From 5d0a9cc39320968da6182bce252fe5bdd03ff985 Mon Sep 17 00:00:00 2001 From: Ian Norden Date: Mon, 3 Feb 2020 13:44:33 -0600 Subject: [PATCH] PR review fixes --- consensus/clique/clique.go | 2 +- consensus/ethash/consensus.go | 2 +- core/types/block_test.go | 6 +----- 3 files changed, 3 insertions(+), 7 deletions(-) diff --git a/consensus/clique/clique.go b/consensus/clique/clique.go index 1f896787b..168d47a2a 100644 --- a/consensus/clique/clique.go +++ b/consensus/clique/clique.go @@ -304,7 +304,7 @@ func (c *Clique) verifyHeader(chain consensus.ChainReader, header *types.Header, return c.verifyCascadingFields(chain, header, parents) } -// VerifyTransactions verifies a the transactions in a block do not exceed the per-transaction gas limit +// VerifyTransactions verifies that the transactions in a block do not exceed the per-transaction gas limit func (*Clique) VerifyTransactions(chain consensus.ChainReader, block *types.Block) error { if chain.Config().IsEIP1559(block.Number()) { for _, tx := range block.Transactions() { diff --git a/consensus/ethash/consensus.go b/consensus/ethash/consensus.go index 690065640..e81488ae8 100644 --- a/consensus/ethash/consensus.go +++ b/consensus/ethash/consensus.go @@ -170,7 +170,7 @@ func (ethash *Ethash) VerifyHeaders(chain consensus.ChainReader, headers []*type return abort, errorsOut } -// VerifyTransactions verifies a the transactions in a block do not exceed the per-transaction gas limit +// VerifyTransactions verifies that the transactions in a block do not exceed the per-transaction gas limit func (*Ethash) VerifyTransactions(chain consensus.ChainReader, block *types.Block) error { if chain.Config().IsEIP1559(block.Number()) { for _, tx := range block.Transactions() { diff --git a/core/types/block_test.go b/core/types/block_test.go index 9436af125..8a35a2a6d 100644 --- a/core/types/block_test.go +++ b/core/types/block_test.go @@ -18,16 +18,12 @@ package types import ( "bytes" - - "github.com/ethereum/go-ethereum/params" - - //"fmt" - //"github.com/ethereum/go-ethereum/params" "math/big" "reflect" "testing" "github.com/ethereum/go-ethereum/common" + "github.com/ethereum/go-ethereum/params" "github.com/ethereum/go-ethereum/rlp" )