cerc-io/go-ethereum
13
0
Fork 0
Code Issues 9 Pull Requests Packages Projects Releases 66 Wiki Activity

signer/fourbytes: fix up error messages (#19877)

Browse Source
This commit is contained in:
Péter Szilágyi 2019-07-23 13:06:31 +03:00 committed by GitHub
parent 78ab411aac
commit 4f56790efc
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
signer/fourbyte/validation.go
View File

@ -53,16 +53,16 @@ func (db *Database) ValidateTransaction(selector *string, tx *core.SendTxArgs) (
if len(data) == 0 { if len(data) == 0 {
// Prevent sending ether into black hole (show stopper) // Prevent sending ether into black hole (show stopper)
if tx.Value.ToInt().Cmp(big.NewInt(0)) > 0 { if tx.Value.ToInt().Cmp(big.NewInt(0)) > 0 {
return nil, errors.New("tx will create contract with value but empty code") return nil, errors.New("transaction will create a contract with value but empty code")
} }
// No value submitted at least, critically Warn, but don't blow up // No value submitted at least, critically Warn, but don't blow up
messages.Crit("Transaction will create contract with empty code") messages.Crit("Transaction will create a contract with empty code")
} else if len(data) < 40 { // arbitrary heuristic limit } else if len(data) < 40 { // arbitrary heuristic limit
messages.Warn(fmt.Sprintf("Transaction will create contract, but payload is suspiciously small (%d bytes)", len(data))) messages.Warn(fmt.Sprintf("Transaction will create a contract, but the payload is suspiciously small (%d bytes)", len(data)))
} }
// Method selector should be nil for contract creation // Method selector should be nil for contract creation
if selector != nil { if selector != nil {
messages.Warn("Transaction will create contract, but method selector supplied, indicating intent to call a method") messages.Warn("Transaction will create a contract, but method selector supplied, indicating an intent to call a method")
} }
return messages, nil return messages, nil
} }