cerc-io/go-ethereum
13
0
Fork 0
Code Issues 9 Pull Requests Packages Projects Releases 66 Wiki Activity

core/types: reject Metro receipts with > 0x01 status bytes

Browse Source
This commit is contained in:
Péter Szilágyi 2017-08-23 10:41:12 +03:00
parent 79bf69b556
commit 4ee92f2d19
No known key found for this signature in database
GPG Key ID: E9AE538CEDF8293D
1 changed files with 11 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
core/types/receipt.go
View File

@ -108,14 +108,21 @@ func (r *Receipt) DecodeRLP(s *rlp.Stream) error {
} }
// Deserialize based on the first component type. // Deserialize based on the first component type.
switch { switch {
case kind == rlp.Byte || kind == rlp.String && len(cnt) == 0: case kind == rlp.Byte || (kind == rlp.String && len(cnt) == 0):
// The first component of metropolis receipts is Byte // The first component of metropolis receipts is Byte (0x01), or the empty
// or empty String(byte with 0x00 value). // string (0x80, decoded as a byte with 0x00 value).
var metro metropolisReceiptRLP var metro metropolisReceiptRLP
if err := rlp.DecodeBytes(raw, &metro); err != nil { if err := rlp.DecodeBytes(raw, &metro); err != nil {
return err return err
} }
r.Failed = metro.Status == receiptStatusFailed switch metro.Status {
case receiptStatusSuccessful:
r.Failed = false
case receiptStatusFailed:
r.Failed = true
default:
return fmt.Errorf("invalid status byte: 0x%x", metro.Status)
}
r.CumulativeGasUsed = metro.CumulativeGasUsed r.CumulativeGasUsed = metro.CumulativeGasUsed
r.Bloom = metro.Bloom r.Bloom = metro.Bloom
r.Logs = metro.Logs r.Logs = metro.Logs