cerc-io/go-ethereum
18
0
Fork 0
Code Issues 9 Pull Requests Packages Projects Releases 66 Wiki Activity

accounts/scwallet: change sc url scheme to keycard (#19632)

Browse Source
This commit is contained in:
Guillaume Ballet 2019-05-28 18:47:53 +02:00 committed by Péter Szilágyi
parent 2388e425f2
commit 048df258dc
2 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
accounts/scwallet/README.md
View File

@ -25,13 +25,13 @@
Start `geth` with the `console` command. You will notice the following warning: Start `geth` with the `console` command. You will notice the following warning:
``` ```
WARN [04-09|16:58:38.898] Failed to open wallet url=pcsc://044def09 err="smartcard: pairing password needed" WARN [04-09|16:58:38.898] Failed to open wallet url=keycard://044def09 err="smartcard: pairing password needed"
``` ```
Write down the URL (`pcsc://044def09` in this example). Then ask `geth` to open the wallet: Write down the URL (`keycard://044def09` in this example). Then ask `geth` to open the wallet:
``` ```
> personal.openWallet("pcsc://044def09") > personal.openWallet("keycard://044def09")
Please enter the pairing password: Please enter the pairing password:
``` ```
@ -42,12 +42,12 @@
``` ```
> personal > personal
WARN [04-09|17:02:07.330] Smartcard wallet account derivation failed url=pcsc://044def09 err="Unexpected response status Cla=0x80, Ins=0xd1, Sw=0x6985" WARN [04-09|17:02:07.330] Smartcard wallet account derivation failed url=keycard://044def09 err="Unexpected response status Cla=0x80, Ins=0xd1, Sw=0x6985"
{ {
listAccounts: [], listAccounts: [],
listWallets: [{ listWallets: [{
status: "Empty, waiting for initialization", status: "Empty, waiting for initialization",
url: "pcsc://044def09" url: "keycard://044def09"
}], }],
... ...
} }
@ -56,7 +56,7 @@
So the communication with the card is working, but there is no key associated with this wallet. Let's create it: So the communication with the card is working, but there is no key associated with this wallet. Let's create it:
``` ```
> personal.initializeWallet("pcsc://044def09") > personal.initializeWallet("keycard://044def09")
"tilt ... impact" "tilt ... impact"
``` ```
@ -67,10 +67,10 @@
[{ [{
accounts: [{ accounts: [{
address: "0x678b7cd55c61917defb23546a41803c5bfefbc7a", address: "0x678b7cd55c61917defb23546a41803c5bfefbc7a",
url: "pcsc://044d/m/44'/60'/0'/0/0" url: "keycard://044d/m/44'/60'/0'/0/0"
}], }],
status: "Online", status: "Online",
url: "pcsc://044def09" url: "keycard://044def09"
}] }]
``` ```
@ -84,14 +84,14 @@
``` ```
listWallets: [{ listWallets: [{
status: "Online, can derive public keys", status: "Online, can derive public keys",
url: "pcsc://a4d73015" url: "keycard://a4d73015"
}] }]
``` ```
3. Open the wallet, you will be prompted for your pairing password, then PIN: 3. Open the wallet, you will be prompted for your pairing password, then PIN:
``` ```
personal.openWallet("pcsc://a4d73015") personal.openWallet("keycard://a4d73015")
``` ```
4. Check that creation was successful by typing e.g. `personal`. Then use it like a regular wallet. 4. Check that creation was successful by typing e.g. `personal`. Then use it like a regular wallet.

2
accounts/scwallet/hub.go
View File

@ -49,7 +49,7 @@ import (
) )
// Scheme is the URI prefix for smartcard wallets. // Scheme is the URI prefix for smartcard wallets.
const Scheme = "pcsc" const Scheme = "keycard"
// refreshCycle is the maximum time between wallet refreshes (if USB hotplug // refreshCycle is the maximum time between wallet refreshes (if USB hotplug
// notifications don't work). // notifications don't work).