Use [chi](https://github.com/go-chi/chi) instead of the forked [macaron](https://gitea.com/macaron/macaron). Since macaron and chi have conflicts with session share, this big PR becomes a have-to thing. According my previous idea, we can replace macaron step by step but I'm wrong. :( Below is a list of big changes on this PR. - [x] Define `context.ResponseWriter` interface with an implementation `context.Response`. - [x] Use chi instead of macaron, and also a customize `Route` to wrap chi so that the router usage is similar as before. - [x] Create different routers for `web`, `api`, `internal` and `install` so that the codes will be more clear and no magic . - [x] Use https://github.com/unrolled/render instead of macaron's internal render - [x] Use https://github.com/NYTimes/gziphandler instead of https://gitea.com/macaron/gzip - [x] Use https://gitea.com/go-chi/session which is a modified version of https://gitea.com/macaron/session and removed `nodb` support since it will not be maintained. **BREAK** - [x] Use https://gitea.com/go-chi/captcha which is a modified version of https://gitea.com/macaron/captcha - [x] Use https://gitea.com/go-chi/cache which is a modified version of https://gitea.com/macaron/cache - [x] Use https://gitea.com/go-chi/binding which is a modified version of https://gitea.com/macaron/binding - [x] Use https://github.com/go-chi/cors instead of https://gitea.com/macaron/cors - [x] Dropped https://gitea.com/macaron/i18n and make a new one in `code.gitea.io/gitea/modules/translation` - [x] Move validation form structs from `code.gitea.io/gitea/modules/auth` to `code.gitea.io/gitea/modules/forms` to avoid dependency cycle. - [x] Removed macaron log service because it's not need any more. **BREAK** - [x] All form structs have to be get by `web.GetForm(ctx)` in the route function but not as a function parameter on routes definition. - [x] Move Git HTTP protocol implementation to use routers directly. - [x] Fix the problem that chi routes don't support trailing slash but macaron did. - [x] `/api/v1/swagger` now will be redirect to `/api/swagger` but not render directly so that `APIContext` will not create a html render. Notices: - Chi router don't support request with trailing slash - Integration test `TestUserHeatmap` maybe mysql version related. It's failed on my macOS(mysql 5.7.29 installed via brew) but succeed on CI. Co-authored-by: 6543 <6543@obermui.de>
		
			
				
	
	
		
			146 lines
		
	
	
		
			3.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			146 lines
		
	
	
		
			3.9 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2014 The Gogs Authors. All rights reserved.
 | |
| // Copyright 2019 The Gitea Authors. All rights reserved.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package middlewares
 | |
| 
 | |
| import (
 | |
| 	"reflect"
 | |
| 	"strings"
 | |
| 
 | |
| 	"code.gitea.io/gitea/modules/translation"
 | |
| 	"code.gitea.io/gitea/modules/validation"
 | |
| 
 | |
| 	"gitea.com/go-chi/binding"
 | |
| 	"github.com/unknwon/com"
 | |
| )
 | |
| 
 | |
| // Form form binding interface
 | |
| type Form interface {
 | |
| 	binding.Validator
 | |
| }
 | |
| 
 | |
| func init() {
 | |
| 	binding.SetNameMapper(com.ToSnakeCase)
 | |
| }
 | |
| 
 | |
| // AssignForm assign form values back to the template data.
 | |
| func AssignForm(form interface{}, data map[string]interface{}) {
 | |
| 	typ := reflect.TypeOf(form)
 | |
| 	val := reflect.ValueOf(form)
 | |
| 
 | |
| 	for typ.Kind() == reflect.Ptr {
 | |
| 		typ = typ.Elem()
 | |
| 		val = val.Elem()
 | |
| 	}
 | |
| 
 | |
| 	for i := 0; i < typ.NumField(); i++ {
 | |
| 		field := typ.Field(i)
 | |
| 
 | |
| 		fieldName := field.Tag.Get("form")
 | |
| 		// Allow ignored fields in the struct
 | |
| 		if fieldName == "-" {
 | |
| 			continue
 | |
| 		} else if len(fieldName) == 0 {
 | |
| 			fieldName = com.ToSnakeCase(field.Name)
 | |
| 		}
 | |
| 
 | |
| 		data[fieldName] = val.Field(i).Interface()
 | |
| 	}
 | |
| }
 | |
| 
 | |
| func getRuleBody(field reflect.StructField, prefix string) string {
 | |
| 	for _, rule := range strings.Split(field.Tag.Get("binding"), ";") {
 | |
| 		if strings.HasPrefix(rule, prefix) {
 | |
| 			return rule[len(prefix) : len(rule)-1]
 | |
| 		}
 | |
| 	}
 | |
| 	return ""
 | |
| }
 | |
| 
 | |
| // GetSize get size int form tag
 | |
| func GetSize(field reflect.StructField) string {
 | |
| 	return getRuleBody(field, "Size(")
 | |
| }
 | |
| 
 | |
| // GetMinSize get minimal size in form tag
 | |
| func GetMinSize(field reflect.StructField) string {
 | |
| 	return getRuleBody(field, "MinSize(")
 | |
| }
 | |
| 
 | |
| // GetMaxSize get max size in form tag
 | |
| func GetMaxSize(field reflect.StructField) string {
 | |
| 	return getRuleBody(field, "MaxSize(")
 | |
| }
 | |
| 
 | |
| // GetInclude get include in form tag
 | |
| func GetInclude(field reflect.StructField) string {
 | |
| 	return getRuleBody(field, "Include(")
 | |
| }
 | |
| 
 | |
| // Validate validate TODO:
 | |
| func Validate(errs binding.Errors, data map[string]interface{}, f Form, l translation.Locale) binding.Errors {
 | |
| 	if errs.Len() == 0 {
 | |
| 		return errs
 | |
| 	}
 | |
| 
 | |
| 	data["HasError"] = true
 | |
| 	// If the field with name errs[0].FieldNames[0] is not found in form
 | |
| 	// somehow, some code later on will panic on Data["ErrorMsg"].(string).
 | |
| 	// So initialize it to some default.
 | |
| 	data["ErrorMsg"] = l.Tr("form.unknown_error")
 | |
| 	AssignForm(f, data)
 | |
| 
 | |
| 	typ := reflect.TypeOf(f)
 | |
| 	val := reflect.ValueOf(f)
 | |
| 
 | |
| 	if typ.Kind() == reflect.Ptr {
 | |
| 		typ = typ.Elem()
 | |
| 		val = val.Elem()
 | |
| 	}
 | |
| 
 | |
| 	if field, ok := typ.FieldByName(errs[0].FieldNames[0]); ok {
 | |
| 		fieldName := field.Tag.Get("form")
 | |
| 		if fieldName != "-" {
 | |
| 			data["Err_"+field.Name] = true
 | |
| 
 | |
| 			trName := field.Tag.Get("locale")
 | |
| 			if len(trName) == 0 {
 | |
| 				trName = l.Tr("form." + field.Name)
 | |
| 			} else {
 | |
| 				trName = l.Tr(trName)
 | |
| 			}
 | |
| 
 | |
| 			switch errs[0].Classification {
 | |
| 			case binding.ERR_REQUIRED:
 | |
| 				data["ErrorMsg"] = trName + l.Tr("form.require_error")
 | |
| 			case binding.ERR_ALPHA_DASH:
 | |
| 				data["ErrorMsg"] = trName + l.Tr("form.alpha_dash_error")
 | |
| 			case binding.ERR_ALPHA_DASH_DOT:
 | |
| 				data["ErrorMsg"] = trName + l.Tr("form.alpha_dash_dot_error")
 | |
| 			case validation.ErrGitRefName:
 | |
| 				data["ErrorMsg"] = trName + l.Tr("form.git_ref_name_error")
 | |
| 			case binding.ERR_SIZE:
 | |
| 				data["ErrorMsg"] = trName + l.Tr("form.size_error", GetSize(field))
 | |
| 			case binding.ERR_MIN_SIZE:
 | |
| 				data["ErrorMsg"] = trName + l.Tr("form.min_size_error", GetMinSize(field))
 | |
| 			case binding.ERR_MAX_SIZE:
 | |
| 				data["ErrorMsg"] = trName + l.Tr("form.max_size_error", GetMaxSize(field))
 | |
| 			case binding.ERR_EMAIL:
 | |
| 				data["ErrorMsg"] = trName + l.Tr("form.email_error")
 | |
| 			case binding.ERR_URL:
 | |
| 				data["ErrorMsg"] = trName + l.Tr("form.url_error")
 | |
| 			case binding.ERR_INCLUDE:
 | |
| 				data["ErrorMsg"] = trName + l.Tr("form.include_error", GetInclude(field))
 | |
| 			case validation.ErrGlobPattern:
 | |
| 				data["ErrorMsg"] = trName + l.Tr("form.glob_pattern_error", errs[0].Message)
 | |
| 			default:
 | |
| 				data["ErrorMsg"] = l.Tr("form.unknown_error") + " " + errs[0].Classification
 | |
| 			}
 | |
| 			return errs
 | |
| 		}
 | |
| 	}
 | |
| 	return errs
 | |
| }
 |