* Remove field from migration to support upgrades from older version That will ensure the field does not get queried in the Select if it does not exist yet: ``` [I] [SQL] SELECT "id", "repo_id", "index", "poster_id", "name", "content", "milestone_id", "priority", "assignee_id", "is_closed", "is_pull", "num_comments", "ref", "deadline_unix", "created_unix", "updated_unix [...itea/routers/init.go:60 GlobalInit()] [E] Failed to initialize ORM engine: migrate: do migrate: pq: column "ref" does not exist ``` see #5318 * Skip remove stale watcher migration if not required Otherwise the migration will fail if executed from a older database version without multiple IssueWatch feature. ``` 2018/11/11 23:51:14 [I] [SQL] SELECT DISTINCT "issue_watch"."user_id", "issue"."repo_id" FROM "issue_watch" INNER JOIN issue ON issue_watch.issue_id = issue.id WHERE (issue_watch.is_watching = $1) LIMIT 50 []int [...itea/routers/init.go:60 GlobalInit()] [E] Failed to initialize ORM engine: migrate: do migrate: pq: relation "issue_watch" does not exist ``` see #5318
		
			
				
	
	
		
			139 lines
		
	
	
		
			3.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			139 lines
		
	
	
		
			3.5 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| // Copyright 2018 The Gitea Authors. All rights reserved.
 | |
| // Use of this source code is governed by a MIT-style
 | |
| // license that can be found in the LICENSE file.
 | |
| 
 | |
| package migrations
 | |
| 
 | |
| import (
 | |
| 	"code.gitea.io/gitea/modules/util"
 | |
| 
 | |
| 	"github.com/go-xorm/xorm"
 | |
| )
 | |
| 
 | |
| func addMultipleAssignees(x *xorm.Engine) error {
 | |
| 
 | |
| 	// Redeclare issue struct
 | |
| 	type Issue struct {
 | |
| 		ID          int64  `xorm:"pk autoincr"`
 | |
| 		RepoID      int64  `xorm:"INDEX UNIQUE(repo_index)"`
 | |
| 		Index       int64  `xorm:"UNIQUE(repo_index)"` // Index in one repository.
 | |
| 		PosterID    int64  `xorm:"INDEX"`
 | |
| 		Title       string `xorm:"name"`
 | |
| 		Content     string `xorm:"TEXT"`
 | |
| 		MilestoneID int64  `xorm:"INDEX"`
 | |
| 		Priority    int
 | |
| 		AssigneeID  int64 `xorm:"INDEX"`
 | |
| 		IsClosed    bool  `xorm:"INDEX"`
 | |
| 		IsPull      bool  `xorm:"INDEX"` // Indicates whether is a pull request or not.
 | |
| 		NumComments int
 | |
| 
 | |
| 		DeadlineUnix util.TimeStamp `xorm:"INDEX"`
 | |
| 		CreatedUnix  util.TimeStamp `xorm:"INDEX created"`
 | |
| 		UpdatedUnix  util.TimeStamp `xorm:"INDEX updated"`
 | |
| 		ClosedUnix   util.TimeStamp `xorm:"INDEX"`
 | |
| 	}
 | |
| 
 | |
| 	// Updated the comment table
 | |
| 	type Comment struct {
 | |
| 		ID              int64 `xorm:"pk autoincr"`
 | |
| 		Type            int
 | |
| 		PosterID        int64 `xorm:"INDEX"`
 | |
| 		IssueID         int64 `xorm:"INDEX"`
 | |
| 		LabelID         int64
 | |
| 		OldMilestoneID  int64
 | |
| 		MilestoneID     int64
 | |
| 		OldAssigneeID   int64
 | |
| 		AssigneeID      int64
 | |
| 		RemovedAssignee bool
 | |
| 		OldTitle        string
 | |
| 		NewTitle        string
 | |
| 
 | |
| 		CommitID        int64
 | |
| 		Line            int64
 | |
| 		Content         string `xorm:"TEXT"`
 | |
| 		RenderedContent string `xorm:"-"`
 | |
| 
 | |
| 		CreatedUnix util.TimeStamp `xorm:"INDEX created"`
 | |
| 		UpdatedUnix util.TimeStamp `xorm:"INDEX updated"`
 | |
| 
 | |
| 		// Reference issue in commit message
 | |
| 		CommitSHA string `xorm:"VARCHAR(40)"`
 | |
| 	}
 | |
| 
 | |
| 	// Create the table
 | |
| 	type IssueAssignees struct {
 | |
| 		ID         int64 `xorm:"pk autoincr"`
 | |
| 		AssigneeID int64 `xorm:"INDEX"`
 | |
| 		IssueID    int64 `xorm:"INDEX"`
 | |
| 	}
 | |
| 
 | |
| 	if err := x.Sync2(IssueAssignees{}); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	if err := x.Sync2(Comment{}); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	// Range over all issues and insert a new entry for each issue/assignee
 | |
| 	sess := x.NewSession()
 | |
| 	defer sess.Close()
 | |
| 
 | |
| 	if err := sess.Begin(); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	allIssues := []Issue{}
 | |
| 	if err := sess.Find(&allIssues); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	for _, issue := range allIssues {
 | |
| 		if issue.AssigneeID != 0 {
 | |
| 			_, err := sess.Insert(IssueAssignees{IssueID: issue.ID, AssigneeID: issue.AssigneeID})
 | |
| 			if err != nil {
 | |
| 				sess.Rollback()
 | |
| 				return err
 | |
| 			}
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// Migrate comments
 | |
| 	// First update everything to not have nulls in db
 | |
| 	if _, err := sess.Where("type = ?", 9).Cols("removed_assignee").Update(Comment{RemovedAssignee: false}); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	allAssignementComments := []Comment{}
 | |
| 	if err := sess.Where("type = ?", 9).Find(&allAssignementComments); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	for _, comment := range allAssignementComments {
 | |
| 		// Everytime where OldAssigneeID is > 0, the assignement was removed.
 | |
| 		if comment.OldAssigneeID > 0 {
 | |
| 			_, err := sess.ID(comment.ID).Update(Comment{RemovedAssignee: true})
 | |
| 			if err != nil {
 | |
| 				return err
 | |
| 			}
 | |
| 		}
 | |
| 	}
 | |
| 
 | |
| 	// Commit and begin new transaction for dropping columns
 | |
| 	if err := sess.Commit(); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	if err := sess.Begin(); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	if err := dropTableColumns(sess, "issue", "assignee_id"); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 
 | |
| 	if err := dropTableColumns(sess, "issue_user", "is_assigned"); err != nil {
 | |
| 		return err
 | |
| 	}
 | |
| 	return sess.Commit()
 | |
| }
 |