* Restricted users (#4334): initial implementation * Add User.IsRestricted & UI to edit it * Pass user object instead of user id to places where IsRestricted flag matters * Restricted users: maintain access rows for all referenced repos (incl public) * Take logged in user & IsRestricted flag into account in org/repo listings, searches and accesses * Add basic repo access tests for restricted users Signed-off-by: Manush Dodunekov <manush@stendahls.se> * Mention restricted users in the faq Signed-off-by: Manush Dodunekov <manush@stendahls.se> * Revert unnecessary change `.isUserPartOfOrg` -> `.IsUserPartOfOrg` Signed-off-by: Manush Dodunekov <manush@stendahls.se> * Remove unnecessary `org.IsOrganization()` call Signed-off-by: Manush Dodunekov <manush@stendahls.se> * Revert to an `int64` keyed `accessMap` * Add type `userAccess` * Add convenience func updateUserAccess() * Turn accessMap into a `map[int64]userAccess` Signed-off-by: Manush Dodunekov <manush@stendahls.se> * or even better: `map[int64]*userAccess` * updateUserAccess(): use tighter syntax as suggested by lafriks * even tighter * Avoid extra loop * Don't disclose limited orgs to unauthenticated users * Don't assume block only applies to orgs * Use an array of `VisibleType` for filtering * fix yet another thinko * Ok - no need for u * Revert "Ok - no need for u" This reverts commit 5c3e886aabd5acd997a3b35687d322439732c200. Co-authored-by: Antoine GIRARD <sapk@users.noreply.github.com> Co-authored-by: Lauris BH <lauris@nix.lv>
		
			
				
	
	
		
			88 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			88 lines
		
	
	
		
			2.3 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
| package models
 | |
| 
 | |
| import (
 | |
| 	"path"
 | |
| 	"testing"
 | |
| 
 | |
| 	"code.gitea.io/gitea/modules/setting"
 | |
| 
 | |
| 	"github.com/stretchr/testify/assert"
 | |
| )
 | |
| 
 | |
| func TestAction_GetRepoPath(t *testing.T) {
 | |
| 	assert.NoError(t, PrepareTestDatabase())
 | |
| 	repo := AssertExistsAndLoadBean(t, &Repository{}).(*Repository)
 | |
| 	owner := AssertExistsAndLoadBean(t, &User{ID: repo.OwnerID}).(*User)
 | |
| 	action := &Action{RepoID: repo.ID}
 | |
| 	assert.Equal(t, path.Join(owner.Name, repo.Name), action.GetRepoPath())
 | |
| }
 | |
| 
 | |
| func TestAction_GetRepoLink(t *testing.T) {
 | |
| 	assert.NoError(t, PrepareTestDatabase())
 | |
| 	repo := AssertExistsAndLoadBean(t, &Repository{}).(*Repository)
 | |
| 	owner := AssertExistsAndLoadBean(t, &User{ID: repo.OwnerID}).(*User)
 | |
| 	action := &Action{RepoID: repo.ID}
 | |
| 	setting.AppSubURL = "/suburl/"
 | |
| 	expected := path.Join(setting.AppSubURL, owner.Name, repo.Name)
 | |
| 	assert.Equal(t, expected, action.GetRepoLink())
 | |
| }
 | |
| 
 | |
| func TestGetFeeds(t *testing.T) {
 | |
| 	// test with an individual user
 | |
| 	assert.NoError(t, PrepareTestDatabase())
 | |
| 	user := AssertExistsAndLoadBean(t, &User{ID: 2}).(*User)
 | |
| 
 | |
| 	actions, err := GetFeeds(GetFeedsOptions{
 | |
| 		RequestedUser:   user,
 | |
| 		Actor:           user,
 | |
| 		IncludePrivate:  true,
 | |
| 		OnlyPerformedBy: false,
 | |
| 		IncludeDeleted:  true,
 | |
| 	})
 | |
| 	assert.NoError(t, err)
 | |
| 	if assert.Len(t, actions, 1) {
 | |
| 		assert.EqualValues(t, 1, actions[0].ID)
 | |
| 		assert.EqualValues(t, user.ID, actions[0].UserID)
 | |
| 	}
 | |
| 
 | |
| 	actions, err = GetFeeds(GetFeedsOptions{
 | |
| 		RequestedUser:   user,
 | |
| 		Actor:           user,
 | |
| 		IncludePrivate:  false,
 | |
| 		OnlyPerformedBy: false,
 | |
| 	})
 | |
| 	assert.NoError(t, err)
 | |
| 	assert.Len(t, actions, 0)
 | |
| }
 | |
| 
 | |
| func TestGetFeeds2(t *testing.T) {
 | |
| 	// test with an organization user
 | |
| 	assert.NoError(t, PrepareTestDatabase())
 | |
| 	org := AssertExistsAndLoadBean(t, &User{ID: 3}).(*User)
 | |
| 	user := AssertExistsAndLoadBean(t, &User{ID: 2}).(*User)
 | |
| 
 | |
| 	actions, err := GetFeeds(GetFeedsOptions{
 | |
| 		RequestedUser:   org,
 | |
| 		Actor:           user,
 | |
| 		IncludePrivate:  true,
 | |
| 		OnlyPerformedBy: false,
 | |
| 		IncludeDeleted:  true,
 | |
| 	})
 | |
| 	assert.NoError(t, err)
 | |
| 	assert.Len(t, actions, 1)
 | |
| 	if assert.Len(t, actions, 1) {
 | |
| 		assert.EqualValues(t, 2, actions[0].ID)
 | |
| 		assert.EqualValues(t, org.ID, actions[0].UserID)
 | |
| 	}
 | |
| 
 | |
| 	actions, err = GetFeeds(GetFeedsOptions{
 | |
| 		RequestedUser:   org,
 | |
| 		Actor:           user,
 | |
| 		IncludePrivate:  false,
 | |
| 		OnlyPerformedBy: false,
 | |
| 		IncludeDeleted:  true,
 | |
| 	})
 | |
| 	assert.NoError(t, err)
 | |
| 	assert.Len(t, actions, 0)
 | |
| }
 |