* Create API endpoints for repo topics.
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Generate swagger
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Add documentation to functions
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Grammar fix
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Fix function comment
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Can't use FindTopics when looking for a single repo topic, as it doesnt use exact match
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Add PUT /repos/{owner}/{repo}/topics and remove GET /repos/{owner}/{repo}/topics
* Ignore if topic is sent twice in same request, refactoring.
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Fix topic dropdown with api changes.
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Style fix
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Update API documentation
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Better way to handle duplicate topics in slice
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Make response element TopicName an array of strings, instead of using an array of TopicName
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Add test cases for API Repo Topics.
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Fix format of tests
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Fix comments
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Fix unit tests after adding some more topics to the test fixture.
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Update models/topic.go
Limit multiple if else if ...
Co-Authored-By: Antoine GIRARD <sapk@users.noreply.github.com>
* Engine as first parameter in function
Co-Authored-By: Antoine GIRARD <sapk@users.noreply.github.com>
* Replace magic numbers with http status code constants.
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Fix variable scope
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Test one read with login and one with token
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Add some more tests
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Apply suggestions from code review
Use empty struct for efficiency
Co-Authored-By: Lauris BH <lauris@nix.lv>
* Add test case to check access for user with write access
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Fix access, repo admin required to change topics
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Correct first test to be without token
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
* Any repo reader should be able to access topics.
* No need for string pointer
Signed-off-by: David Svantesson <davidsvantesson@gmail.com>
		
	
			
		
			
				
	
	
		
			302 lines
		
	
	
		
			7.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
			
		
		
	
	
			302 lines
		
	
	
		
			7.0 KiB
		
	
	
	
		
			Go
		
	
	
	
	
	
// Copyright 2018 The Gitea Authors. All rights reserved.
 | 
						|
// Use of this source code is governed by a MIT-style
 | 
						|
// license that can be found in the LICENSE file.
 | 
						|
 | 
						|
package models
 | 
						|
 | 
						|
import (
 | 
						|
	"fmt"
 | 
						|
	"regexp"
 | 
						|
	"strings"
 | 
						|
 | 
						|
	"code.gitea.io/gitea/modules/timeutil"
 | 
						|
 | 
						|
	"xorm.io/builder"
 | 
						|
)
 | 
						|
 | 
						|
func init() {
 | 
						|
	tables = append(tables,
 | 
						|
		new(Topic),
 | 
						|
		new(RepoTopic),
 | 
						|
	)
 | 
						|
}
 | 
						|
 | 
						|
var topicPattern = regexp.MustCompile(`^[a-z0-9][a-z0-9-]*$`)
 | 
						|
 | 
						|
// Topic represents a topic of repositories
 | 
						|
type Topic struct {
 | 
						|
	ID          int64
 | 
						|
	Name        string `xorm:"UNIQUE VARCHAR(25)"`
 | 
						|
	RepoCount   int
 | 
						|
	CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
 | 
						|
	UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`
 | 
						|
}
 | 
						|
 | 
						|
// RepoTopic represents associated repositories and topics
 | 
						|
type RepoTopic struct {
 | 
						|
	RepoID  int64 `xorm:"UNIQUE(s)"`
 | 
						|
	TopicID int64 `xorm:"UNIQUE(s)"`
 | 
						|
}
 | 
						|
 | 
						|
// ErrTopicNotExist represents an error that a topic is not exist
 | 
						|
type ErrTopicNotExist struct {
 | 
						|
	Name string
 | 
						|
}
 | 
						|
 | 
						|
// IsErrTopicNotExist checks if an error is an ErrTopicNotExist.
 | 
						|
func IsErrTopicNotExist(err error) bool {
 | 
						|
	_, ok := err.(ErrTopicNotExist)
 | 
						|
	return ok
 | 
						|
}
 | 
						|
 | 
						|
// Error implements error interface
 | 
						|
func (err ErrTopicNotExist) Error() string {
 | 
						|
	return fmt.Sprintf("topic is not exist [name: %s]", err.Name)
 | 
						|
}
 | 
						|
 | 
						|
// ValidateTopic checks a topic by length and match pattern rules
 | 
						|
func ValidateTopic(topic string) bool {
 | 
						|
	return len(topic) <= 35 && topicPattern.MatchString(topic)
 | 
						|
}
 | 
						|
 | 
						|
// SanitizeAndValidateTopics sanitizes and checks an array or topics
 | 
						|
func SanitizeAndValidateTopics(topics []string) (validTopics []string, invalidTopics []string) {
 | 
						|
	validTopics = make([]string, 0)
 | 
						|
	mValidTopics := make(map[string]struct{})
 | 
						|
	invalidTopics = make([]string, 0)
 | 
						|
 | 
						|
	for _, topic := range topics {
 | 
						|
		topic = strings.TrimSpace(strings.ToLower(topic))
 | 
						|
		// ignore empty string
 | 
						|
		if len(topic) == 0 {
 | 
						|
			continue
 | 
						|
		}
 | 
						|
		// ignore same topic twice
 | 
						|
		if _, ok := mValidTopics[topic]; ok {
 | 
						|
			continue
 | 
						|
		}
 | 
						|
		if ValidateTopic(topic) {
 | 
						|
			validTopics = append(validTopics, topic)
 | 
						|
			mValidTopics[topic] = struct{}{}
 | 
						|
		} else {
 | 
						|
			invalidTopics = append(invalidTopics, topic)
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	return validTopics, invalidTopics
 | 
						|
}
 | 
						|
 | 
						|
// GetTopicByName retrieves topic by name
 | 
						|
func GetTopicByName(name string) (*Topic, error) {
 | 
						|
	var topic Topic
 | 
						|
	if has, err := x.Where("name = ?", name).Get(&topic); err != nil {
 | 
						|
		return nil, err
 | 
						|
	} else if !has {
 | 
						|
		return nil, ErrTopicNotExist{name}
 | 
						|
	}
 | 
						|
	return &topic, nil
 | 
						|
}
 | 
						|
 | 
						|
// addTopicByNameToRepo adds a topic name to a repo and increments the topic count.
 | 
						|
// Returns topic after the addition
 | 
						|
func addTopicByNameToRepo(e Engine, repoID int64, topicName string) (*Topic, error) {
 | 
						|
	var topic Topic
 | 
						|
	has, err := e.Where("name = ?", topicName).Get(&topic)
 | 
						|
	if err != nil {
 | 
						|
		return nil, err
 | 
						|
	}
 | 
						|
	if !has {
 | 
						|
		topic.Name = topicName
 | 
						|
		topic.RepoCount = 1
 | 
						|
		if _, err := e.Insert(&topic); err != nil {
 | 
						|
			return nil, err
 | 
						|
		}
 | 
						|
	} else {
 | 
						|
		topic.RepoCount++
 | 
						|
		if _, err := e.ID(topic.ID).Cols("repo_count").Update(&topic); err != nil {
 | 
						|
			return nil, err
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	if _, err := e.Insert(&RepoTopic{
 | 
						|
		RepoID:  repoID,
 | 
						|
		TopicID: topic.ID,
 | 
						|
	}); err != nil {
 | 
						|
		return nil, err
 | 
						|
	}
 | 
						|
 | 
						|
	return &topic, nil
 | 
						|
}
 | 
						|
 | 
						|
// removeTopicFromRepo remove a topic from a repo and decrements the topic repo count
 | 
						|
func removeTopicFromRepo(repoID int64, topic *Topic, e Engine) error {
 | 
						|
	topic.RepoCount--
 | 
						|
	if _, err := e.ID(topic.ID).Cols("repo_count").Update(topic); err != nil {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
 | 
						|
	if _, err := e.Delete(&RepoTopic{
 | 
						|
		RepoID:  repoID,
 | 
						|
		TopicID: topic.ID,
 | 
						|
	}); err != nil {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
 | 
						|
	return nil
 | 
						|
}
 | 
						|
 | 
						|
// FindTopicOptions represents the options when fdin topics
 | 
						|
type FindTopicOptions struct {
 | 
						|
	RepoID  int64
 | 
						|
	Keyword string
 | 
						|
	Limit   int
 | 
						|
	Page    int
 | 
						|
}
 | 
						|
 | 
						|
func (opts *FindTopicOptions) toConds() builder.Cond {
 | 
						|
	var cond = builder.NewCond()
 | 
						|
	if opts.RepoID > 0 {
 | 
						|
		cond = cond.And(builder.Eq{"repo_topic.repo_id": opts.RepoID})
 | 
						|
	}
 | 
						|
 | 
						|
	if opts.Keyword != "" {
 | 
						|
		cond = cond.And(builder.Like{"topic.name", opts.Keyword})
 | 
						|
	}
 | 
						|
 | 
						|
	return cond
 | 
						|
}
 | 
						|
 | 
						|
// FindTopics retrieves the topics via FindTopicOptions
 | 
						|
func FindTopics(opts *FindTopicOptions) (topics []*Topic, err error) {
 | 
						|
	sess := x.Select("topic.*").Where(opts.toConds())
 | 
						|
	if opts.RepoID > 0 {
 | 
						|
		sess.Join("INNER", "repo_topic", "repo_topic.topic_id = topic.id")
 | 
						|
	}
 | 
						|
	if opts.Limit > 0 {
 | 
						|
		sess.Limit(opts.Limit, opts.Page*opts.Limit)
 | 
						|
	}
 | 
						|
	return topics, sess.Desc("topic.repo_count").Find(&topics)
 | 
						|
}
 | 
						|
 | 
						|
// GetRepoTopicByName retrives topic from name for a repo if it exist
 | 
						|
func GetRepoTopicByName(repoID int64, topicName string) (*Topic, error) {
 | 
						|
	var cond = builder.NewCond()
 | 
						|
	var topic Topic
 | 
						|
	cond = cond.And(builder.Eq{"repo_topic.repo_id": repoID}).And(builder.Eq{"topic.name": topicName})
 | 
						|
	sess := x.Table("topic").Where(cond)
 | 
						|
	sess.Join("INNER", "repo_topic", "repo_topic.topic_id = topic.id")
 | 
						|
	has, err := sess.Get(&topic)
 | 
						|
	if has {
 | 
						|
		return &topic, err
 | 
						|
	}
 | 
						|
	return nil, err
 | 
						|
}
 | 
						|
 | 
						|
// AddTopic adds a topic name to a repository (if it does not already have it)
 | 
						|
func AddTopic(repoID int64, topicName string) (*Topic, error) {
 | 
						|
	topic, err := GetRepoTopicByName(repoID, topicName)
 | 
						|
	if err != nil {
 | 
						|
		return nil, err
 | 
						|
	}
 | 
						|
	if topic != nil {
 | 
						|
		// Repo already have topic
 | 
						|
		return topic, nil
 | 
						|
	}
 | 
						|
 | 
						|
	return addTopicByNameToRepo(x, repoID, topicName)
 | 
						|
}
 | 
						|
 | 
						|
// DeleteTopic removes a topic name from a repository (if it has it)
 | 
						|
func DeleteTopic(repoID int64, topicName string) (*Topic, error) {
 | 
						|
	topic, err := GetRepoTopicByName(repoID, topicName)
 | 
						|
	if err != nil {
 | 
						|
		return nil, err
 | 
						|
	}
 | 
						|
	if topic == nil {
 | 
						|
		// Repo doesn't have topic, can't be removed
 | 
						|
		return nil, nil
 | 
						|
	}
 | 
						|
 | 
						|
	err = removeTopicFromRepo(repoID, topic, x)
 | 
						|
 | 
						|
	return topic, err
 | 
						|
}
 | 
						|
 | 
						|
// SaveTopics save topics to a repository
 | 
						|
func SaveTopics(repoID int64, topicNames ...string) error {
 | 
						|
	topics, err := FindTopics(&FindTopicOptions{
 | 
						|
		RepoID: repoID,
 | 
						|
	})
 | 
						|
	if err != nil {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
 | 
						|
	sess := x.NewSession()
 | 
						|
	defer sess.Close()
 | 
						|
 | 
						|
	if err := sess.Begin(); err != nil {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
 | 
						|
	var addedTopicNames []string
 | 
						|
	for _, topicName := range topicNames {
 | 
						|
		if strings.TrimSpace(topicName) == "" {
 | 
						|
			continue
 | 
						|
		}
 | 
						|
 | 
						|
		var found bool
 | 
						|
		for _, t := range topics {
 | 
						|
			if strings.EqualFold(topicName, t.Name) {
 | 
						|
				found = true
 | 
						|
				break
 | 
						|
			}
 | 
						|
		}
 | 
						|
		if !found {
 | 
						|
			addedTopicNames = append(addedTopicNames, topicName)
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	var removeTopics []*Topic
 | 
						|
	for _, t := range topics {
 | 
						|
		var found bool
 | 
						|
		for _, topicName := range topicNames {
 | 
						|
			if strings.EqualFold(topicName, t.Name) {
 | 
						|
				found = true
 | 
						|
				break
 | 
						|
			}
 | 
						|
		}
 | 
						|
		if !found {
 | 
						|
			removeTopics = append(removeTopics, t)
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	for _, topicName := range addedTopicNames {
 | 
						|
		_, err := addTopicByNameToRepo(sess, repoID, topicName)
 | 
						|
		if err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	for _, topic := range removeTopics {
 | 
						|
		err := removeTopicFromRepo(repoID, topic, sess)
 | 
						|
		if err != nil {
 | 
						|
			return err
 | 
						|
		}
 | 
						|
	}
 | 
						|
 | 
						|
	topicNames = make([]string, 0, 25)
 | 
						|
	if err := sess.Table("topic").Cols("name").
 | 
						|
		Join("INNER", "repo_topic", "repo_topic.topic_id = topic.id").
 | 
						|
		Where("repo_topic.repo_id = ?", repoID).Desc("topic.repo_count").Find(&topicNames); err != nil {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
 | 
						|
	if _, err := sess.ID(repoID).Cols("topics").Update(&Repository{
 | 
						|
		Topics: topicNames,
 | 
						|
	}); err != nil {
 | 
						|
		return err
 | 
						|
	}
 | 
						|
 | 
						|
	return sess.Commit()
 | 
						|
}
 |