From 6225c1b66fe4b4c5e45b5b6dca5345af3ab818aa Mon Sep 17 00:00:00 2001
From: liangping <18786721@qq.com>
Date: Sat, 8 Oct 2022 09:31:15 +0800
Subject: [PATCH] improve proposal display

---
 src/views/GovernanceProposalView.vue          |  9 +--------
 src/views/components/ObjectFieldComponent.vue | 20 +++++++++----------
 2 files changed, 11 insertions(+), 18 deletions(-)

diff --git a/src/views/GovernanceProposalView.vue b/src/views/GovernanceProposalView.vue
index 46c7d357..bea06b2c 100644
--- a/src/views/GovernanceProposalView.vue
+++ b/src/views/GovernanceProposalView.vue
@@ -49,14 +49,7 @@
         >
           <tbody>
             <b-tr>
-              <b-td
-                style="text-transform: capitalize; vertical-align: top; width:200px"
-              >
-                {{ $t('proposal_id') }}
-              </b-td><b-td>{{ proposal.id }}</b-td>
-            </b-tr>
-            <b-tr>
-              <b-td>
+              <b-td style="text-transform: capitalize; vertical-align: top; width:200px">
                 {{ $t('proposal_proposer') }}
               </b-td><b-td><router-link :to="`../account/${proposer.proposer}`">
                 {{ formatAddress(proposer.proposer) }}
diff --git a/src/views/components/ObjectFieldComponent.vue b/src/views/components/ObjectFieldComponent.vue
index 19d82694..c6972245 100644
--- a/src/views/components/ObjectFieldComponent.vue
+++ b/src/views/components/ObjectFieldComponent.vue
@@ -15,7 +15,7 @@
         <b-td
           style="text-transform: capitalize; vertical-align: top;"
         >
-          {{ name }}
+          {{ formatTitle(name) }}
         </b-td>
         <b-td v-if="isTokenField(value)">
           {{ formatTokens( value ) }}
@@ -37,13 +37,12 @@
           <b-tabs
             v-if="value"
             small
-            class="overflow-hidden"
           >
             <b-tab
               v-for="key in Object.keys(value)"
               :key="key"
-              :title="key"
-              class="p-0 overflow-hidden"
+              :title="formatTitle(key)"
+              class="p-0 text-capitalize"
               title-item-class="bg-light-primary"
             >
               <array-field-component
@@ -60,7 +59,7 @@
               />
               <div
                 v-else
-                style="max-width: 800px; overflow: auto;"
+                style="max-width: 800px; max-height: 300px; overflow: auto;"
               >{{ value[key] }}</div>
             </b-tab>
           </b-tabs>
@@ -71,7 +70,7 @@
           </VueMarkdown>
           <div
             v-else
-            style="max-width: 800px; word-wrap:normal"
+            style="max-width: 800px; max-height: 300px; overflow: auto;"
           >{{ value }}</div>
         </b-td>
       </b-tr>
@@ -135,6 +134,7 @@ export default {
       // }
       return value
     },
+    formatTitle: v => v.replaceAll('_', ' '),
     isObjectText(v) {
       return String(v).startsWith('{') && String(v).endsWith('}')
     },
@@ -146,16 +146,16 @@ export default {
       return Array.from(value)
     },
     isTokenField(value) {
-      return isToken(value)
+      return value ? isToken(value) : false
     },
     isHex(value) {
-      return isHexAddress(value)
+      return value ? isHexAddress(value) : false
     },
     formatHexAddress(v) {
       return getStakingValidatorByHex(this.$http.config.chain_name, v)
     },
     isArrayText(value) {
-      return isStringArray(value)
+      return value ? isStringArray(value) : false
     },
     formatTokens(value) {
       return tokenFormatter(value)
@@ -165,7 +165,7 @@ export default {
       if (percentage.test(value)) {
         return `${percent(value)}%`
       }
-      return value.replace(/(?:\\[rn])+/g, '\n')
+      return value ? value.replace(/(?:\\[rn])+/g, '\n') : '-'
     },
   },
 }