chore: update the PM action secret token

.github/workflows/add_issue_new_projects.yml

@@ -6,7 +6,7 @@ name: 'Add Issues To Project Board'
     types:
       - opened
 env:
-  GH_TOKEN: ${{ secrets.GH_NEW_CARD_TO_PROJECT }}
+  GH_TOKEN: ${{ secrets.PROJECT_MANAGE_ACTION }}
   PROJECT_ID: ${{ secrets.FRONT_END_PROJECT_ID }}
   ISSUE_ID: ${{ github.event.issue.node_id }}
   USER: ${{ github.actor }}

.github/workflows/publish-dist.yml

@@ -28,7 +28,6 @@ jobs:
           echo IS_MAINNET_RELEASE=false >> $GITHUB_ENV
           echo IS_TESTNET_RELEASE=false >> $GITHUB_ENV
           echo IS_IPFS_RELEASE=false >> $GITHUB_ENV
-          echo IS_S3_RELASE=false >> $GITHUB_ENV
 
       - name: Is PR
         if: ${{ github.event_name == 'pull_request' }}
@@ -50,11 +49,6 @@ jobs:
         run: |
           echo IS_IPFS_RELEASE=true >> $GITHUB_ENV
 
-      - name: Is S3 Release
-        if: ${{ env.IS_IPFS_RELASE == 'false' && github.event_name == 'push' }}
-        run: |
-          echo IS_S3_RELASE=true >> $GITHUB_ENV
-
       - name: Set up QEMU
         id: quemu
         uses: docker/setup-qemu-action@v2
@@ -251,7 +245,7 @@ jobs:
       - name: Publish dist to s3
         uses: jakejarvis/s3-sync-action@master
         # s3 releases are not happening for trading on mainnet - it's IPFS
-        if: ${{ env.IS_S3_RELASE == 'true' }}
+        if: ${{ env.IS_IPFS_RELEASE == 'false' }}
         with:
           args: --acl private --follow-symlinks --delete
         env:
@@ -262,11 +256,11 @@ jobs:
           SOURCE_DIR: 'dist-result'
 
       - name: Install aws CLI
-        if: ${{ env.IS_S3_RELASE == 'true' }}
+        if: ${{ env.IS_IPFS_RELEASE == 'false' }}
         uses: unfor19/install-aws-cli-action@master
 
       - name: Perform cache invalidation
-        if: ${{ env.IS_S3_RELASE == 'true' }}
+        if: ${{ env.IS_IPFS_RELEASE == 'false' }}
         env:
           AWS_ACCESS_KEY_ID: ${{ secrets.AWS_ACCESS_KEY_ID }}
           AWS_SECRET_ACCESS_KEY: ${{ secrets.AWS_SECRET_ACCESS_KEY }}

apps/trading-e2e/src/integration/capsule.cy.ts

@@ -120,7 +120,7 @@ describe('capsule - without MultiSign', { tags: '@slow' }, () => {
     cy.get('main[data-testid="/portfolio"]').should('exist');
 
     cy.getByTestId(collateralTab).click();
-    cy.getByTestId('open-transfer').click();
+    cy.getByTestId('open-transfer-dialog').click();
     cy.getByTestId('transfer-form').should('be.visible');
     cy.getByTestId('transfer-form').find('[name="toAddress"]').select(1);
     cy.get('select option')
@@ -187,21 +187,19 @@ describe('capsule', { tags: '@slow', testIsolation: true }, () => {
     // 0006-NETW-010
     const market = this.market;
     cy.visit(`/#/markets/${market.id}`);
-    cy.getByTestId('node-health-trigger').realHover();
     cy.getByTestId('node-health')
       .children()
       .first()
       .should('contain.text', 'Operational')
+      .next()
+      .should('contain.text', new URL(Cypress.env('VEGA_URL')).hostname)
+      .next()
       .then(($el) => {
         const blockHeight = parseInt($el.text());
         // block height will increase over the course of the test run so best
         // we can do here is check that its showing something sensible
         expect(blockHeight).to.be.greaterThan(0);
       });
-    cy.getByTestId('node-health')
-      .children()
-      .eq(1)
-      .should('contain.text', new URL(Cypress.env('VEGA_URL')).hostname);
   });
 
   it('can place and receive an order', function () {

apps/trading-e2e/src/integration/deposit.cy.ts

@@ -20,8 +20,8 @@ describe('deposit form validation', { tags: '@smoke' }, () => {
     cy.get('main[data-testid="/portfolio"]').should('exist');
     cy.getByTestId('Deposits').click();
     cy.getByTestId('deposit-button').click();
-    connectEthereumWallet('MetaMask');
     cy.wait('@Assets');
+    connectEthereumWallet('MetaMask');
   }
 
   before(() => {
@@ -102,6 +102,8 @@ describe('deposit actions', { tags: '@smoke' }, () => {
     cy.mockSubscription();
     cy.setVegaWallet();
     cy.visit('/#/markets/market-1');
+    cy.wait('@MarketsCandles');
+    cy.getByTestId('dialog-close').click();
   });
 
   it('Deposit to trade is visble', () => {

apps/trading-e2e/src/integration/home-node-network.cy.ts

@@ -1,6 +1,5 @@
 const dialogContent = 'dialog-content';
 const nodeHealth = 'node-health';
-const nodeHealthTrigger = 'node-health-trigger';
 
 describe('home', { tags: '@regression' }, () => {
   before(() => {
@@ -9,23 +8,22 @@ describe('home', { tags: '@regression' }, () => {
     cy.visit('/');
   });
 
-  describe('node health', () => {
+  describe('footer', () => {
     it('shows current block height', () => {
       // 0006-NETW-004
       // 0006-NETW-008
       // 0006-NETW-009
-      cy.getByTestId(nodeHealthTrigger).realHover();
+
       cy.getByTestId(nodeHealth)
         .children()
         .first()
         .should('contain.text', 'Operational', {
           timeout: 10000,
         })
+        .next()
+        .should('contain.text', new URL(Cypress.env('VEGA_URL')).hostname)
+        .next()
         .should('contain.text', '100'); // all mocked queries have x-block-height header set to 100
-      cy.getByTestId(nodeHealth)
-        .children()
-        .eq(1)
-        .should('contain.text', new URL(Cypress.env('VEGA_URL')).hostname);
     });
 
     it('shows node switcher details', () => {
@@ -34,7 +32,7 @@ describe('home', { tags: '@regression' }, () => {
       // 0006-NETW-014
       // 0006-NETW-015
       // 0006-NETW-016
-      cy.getByTestId(nodeHealthTrigger).click();
+      cy.getByTestId(nodeHealth).click();
       cy.getByTestId(dialogContent).should('contain.text', 'Connected node');
       cy.getByTestId(dialogContent).should(
         'contain.text',
@@ -58,7 +56,7 @@ describe('home', { tags: '@regression' }, () => {
       // 0006-NETW-018
       // 0006-NETW-019
       // 0006-NETW-020
-      cy.getByTestId(nodeHealthTrigger).click();
+      cy.getByTestId(nodeHealth).click();
       cy.getByTestId('connect').should('be.disabled');
       cy.getByTestId('node-url-custom').click();
       cy.getByTestId('connect').should('be.disabled');

apps/trading-e2e/src/integration/market-liquidity.cy.ts

@@ -132,10 +132,9 @@ describe('liquidity table view', { tags: '@smoke' }, () => {
   it('can see header title', () => {
     // 5002-LIQP-004
     // 5002-LIQP-005
-    cy.getByTestId('header-title').should(
+    cy.getByTestId('header-title')
-      'contain.text',
+      .should('contain.text', 'BTCUSD.MF21 liquidity provision')
-      'BTCUSD.MF21 liquidity provision'
+      .and('contain.text', 'Go to trading');
-    );
   });
 
   it('can see target stake', () => {
@@ -172,7 +171,7 @@ describe('liquidity table view', { tags: '@smoke' }, () => {
       cy.getByTestId('liquidity-supplied').within(() => {
         cy.getByTestId(itemHeader).should('have.text', 'Liquidity supplied');
         cy.getByTestId('indicator').should('be.visible');
-        cy.getByTestId(itemValue).should('have.text', ' 0.10%').realHover();
+        cy.getByTestId(itemValue).should('have.text', '0.10%').realHover();
       });
     });
   });

apps/trading-e2e/src/integration/market-selector.cy.ts

@@ -22,12 +22,15 @@ describe('markets selector', { tags: '@smoke' }, () => {
 
     cy.wait('@Markets');
     cy.wait('@MarketsData');
+    cy.wait('@MarketsCandles');
   });
 
   // 6001-MARK-066
-  it('can open popover to view markets', () => {
+  it('can toggle the sidebar', () => {
+    cy.getByTestId('market-selector').should('be.visible');
+    cy.getByTestId('sidebar-toggle').click();
     cy.getByTestId('market-selector').should('not.exist');
-    cy.getByTestId('header-title').should('be.visible').click();
+    cy.getByTestId('sidebar-toggle').click();
     cy.getByTestId('market-selector').should('be.visible');
   });
 
@@ -37,30 +40,29 @@ describe('markets selector', { tags: '@smoke' }, () => {
     const data = [
       {
         code: 'SOLUSD',
-        markPrice: 'XYZalpha84.41',
+        markPrice: '84.41XYZalpha',
         change: '',
-        vol: '24h vol0.00',
+        vol: '0.0024h vol',
       },
       {
         code: 'ETHBTC.QM21',
-        markPrice: 'tBTC46,126.90058',
+        markPrice: '46,126.90058tBTC',
         change: '',
-        vol: '24h vol0.00',
+        vol: '0.0024h vol',
       },
       {
         code: 'BTCUSD.MF21',
-        markPrice: 'tDAI46,126.90058',
+        markPrice: '46,126.90058tDAI',
         change: '',
-        vol: '24h vol0.00',
+        vol: '0.0024h vol',
       },
       {
         code: 'AAPL.MF21',
-        markPrice: 'tUSDC46,126.90058',
+        markPrice: '46,126.90058tUSDC',
         change: '',
-        vol: '24h vol0.00',
+        vol: '0.0024h vol',
       },
     ];
-    cy.getByTestId('header-title').should('be.visible').click();
     cy.getByTestId(list)
       .find('a')
       .each((item, i) => {
@@ -84,9 +86,18 @@ describe('markets selector', { tags: '@smoke' }, () => {
       });
   });
 
-  it('can use the filter options', () => {
+  it('can see all markets link', () => {
-    cy.getByTestId('header-title').should('be.visible').click();
+    // 6001-MARK-026
+    cy.getByTestId('market-selector').within(() => {
+      cy.getByTestId('all-markets-link')
+        .should('be.visible')
+        .and('have.text', 'All markets')
+        .and('have.attr', 'href')
+        .and('contain', '#/markets/all');
+    });
+  });
 
+  it('can use the filter options', () => {
     // 6001-MARK-027
     // product type
     cy.getByTestId('product-Spot').click();
@@ -107,8 +118,6 @@ describe('markets selector', { tags: '@smoke' }, () => {
   });
 
   it('can sort by by top gaining and top losing market', () => {
-    cy.getByTestId('header-title').should('be.visible').click();
-
     // 6001-MARK-030
     // 6001-MARK-031
     // 6001-MARK-032
@@ -126,8 +135,6 @@ describe('markets selector', { tags: '@smoke' }, () => {
   });
 
   it('can filter by settlement asset', () => {
-    cy.getByTestId('header-title').should('be.visible').click();
-
     // 6001-MARK-028
     cy.getByTestId('asset-trigger').click();
     cy.getByTestId('asset-id-asset-3').contains('tBTC').click();

apps/trading-e2e/src/integration/market-split-bottom-panels.cy.ts

@@ -0,0 +1,71 @@
+describe('market bottom panel', { tags: '@smoke' }, () => {
+  before(() => {
+    cy.clearAllLocalStorage();
+    cy.mockTradingPage();
+    cy.mockSubscription();
+    cy.visit('/#/markets/market-0');
+    cy.wait('@MarketData');
+  });
+
+  it('on xxl screen should be splitted out into two tables', () => {
+    cy.getByTestId('tab-positions').should('have.attr', 'data-state', 'active');
+    cy.getByTestId('tab-open-orders').should(
+      'have.attr',
+      'data-state',
+      'inactive'
+    );
+    cy.getByTestId('tab-closed-orders').should(
+      'have.attr',
+      'data-state',
+      'inactive'
+    );
+    cy.getByTestId('tab-rejected-orders').should(
+      'have.attr',
+      'data-state',
+      'inactive'
+    );
+    cy.getByTestId('tab-orders').should('have.attr', 'data-state', 'inactive');
+    cy.getByTestId('tab-fills').should('have.attr', 'data-state', 'inactive');
+    cy.getByTestId('tab-accounts').should(
+      'have.attr',
+      'data-state',
+      'inactive'
+    );
+
+    cy.viewport(1801, 1000);
+    cy.getByTestId('tab-positions').should('have.attr', 'data-state', 'active');
+    cy.getByTestId('tab-open-orders').should(
+      'have.attr',
+      'data-state',
+      'inactive'
+    );
+    cy.getByTestId('tab-closed-orders').should(
+      'have.attr',
+      'data-state',
+      'inactive'
+    );
+    cy.getByTestId('tab-rejected-orders').should(
+      'have.attr',
+      'data-state',
+      'inactive'
+    );
+    cy.getByTestId('tab-orders').should('have.attr', 'data-state', 'inactive');
+    cy.getByTestId('tab-fills').should('have.attr', 'data-state', 'inactive');
+    cy.getByTestId('tab-accounts').should(
+      'have.attr',
+      'data-state',
+      'inactive'
+    );
+
+    cy.getByTestId('Fills').click();
+    cy.getByTestId('Collateral').click();
+    cy.getByTestId('tab-positions').should(
+      'have.attr',
+      'data-state',
+      'inactive'
+    );
+    cy.getByTestId('tab-orders').should('have.attr', 'data-state', 'inactive');
+    cy.getByTestId('tab-fills').should('have.attr', 'data-state', 'active');
+    cy.getByTestId('tab-accounts').should('have.attr', 'data-state', 'active');
+  });
+});

apps/trading-e2e/src/integration/navbar.cy.ts

@@ -99,6 +99,9 @@ describe('Navbar', { tags: '@smoke' }, () => {
         cy.getByTestId('menu-drawer').should('not.be.visible');
         cy.getByTestId('button-menu-drawer').click();
         cy.getByTestId('menu-drawer').should('be.visible');
+        cy.getByTestId('menu-drawer')
+          .find('[data-testid="Settings"]')
+          .should('be.visible');
         cy.getByTestId('button-menu-drawer').click();
         cy.getByTestId('menu-drawer').should('not.be.visible');
       });

apps/trading-e2e/src/integration/order-book.cy.ts

@@ -1,10 +1,10 @@
 const orderbookTab = 'Orderbook';
 const orderbookTable = 'tab-orderbook';
-const askPrice = 'price-9894185';
+const askPrice = 'price-9894585';
 const bidPrice = 'price-9889001';
-const askVolume = 'ask-vol-9894185';
+const askVolume = 'ask-vol-9894585';
 const bidVolume = 'bid-vol-9889001';
-const askCumulative = 'cumulative-vol-9894185';
+const askCumulative = 'cumulative-vol-9894585';
 const bidCumulative = 'cumulative-vol-9889001';
 const midPrice = 'middle-mark-price-4612690000';
 const priceResolution = 'resolution';
@@ -33,7 +33,7 @@ describe('order book', { tags: '@smoke' }, () => {
 
   it('show orders prices', () => {
     // 6003-ORDB-003
-    cy.getByTestId(askPrice).should('have.text', '98.94185');
+    cy.getByTestId(askPrice).should('have.text', '98.94585');
     cy.getByTestId(bidPrice).should('have.text', '98.89001');
   });
 
@@ -45,7 +45,7 @@ describe('order book', { tags: '@smoke' }, () => {
 
   it('show prices cumulative volumes', () => {
     // 6003-ORDB-005
-    cy.getByTestId(askCumulative).should('have.text', '38');
+    cy.getByTestId(askCumulative).should('have.text', '39');
     cy.getByTestId(bidCumulative).should('have.text', '7');
   });
 
@@ -71,7 +71,7 @@ describe('order book', { tags: '@smoke' }, () => {
   it('copy price to deal ticket form', () => {
     // 6003-ORDB-009
     cy.getByTestId(askPrice).click();
-    cy.getByTestId(dealTicketPrice).should('have.value', '98.94185');
+    cy.getByTestId(dealTicketPrice).should('have.value', '98.94585');
   });
 
   it('change price resolution', () => {

apps/trading-e2e/src/integration/settings.cy.ts

@@ -1,29 +1,42 @@
 describe('Settings page', { tags: '@smoke' }, () => {
   beforeEach(() => {
-    cy.clearLocalStorage();
+    cy.clearLocalStorage().then(() => {
-
+      cy.mockTradingPage();
-    cy.mockTradingPage();
+      cy.mockSubscription();
-    cy.mockSubscription();
+      cy.visit('/');
-    cy.visit('/');
+      cy.get('[aria-label="cog icon"]').click();
-
-    // Only click if not already active otherwise sidebar will close
-    cy.get('[data-testid="sidebar-content"]').then(($sidebarContent) => {
-      if ($sidebarContent.find('h2').text() !== 'Settings') {
-        cy.get('[data-testid="sidebar"] [data-testid="Settings"]').click();
-      }
     });
   });
-
   it('telemetry checkbox should work well', () => {
-    const telemetrySwitch = '#switch-settings-telemetry-switch';
+    cy.location('hash').should('equal', '#/settings');
-    cy.get(telemetrySwitch).should('have.attr', 'data-state', 'unchecked');
+    cy.getByTestId('telemetry-approval').should(
-    cy.get(telemetrySwitch).click();
+      'have.attr',
-    cy.get(telemetrySwitch).should('have.attr', 'data-state', 'checked');
+      'data-state',
+      'unchecked'
+    );
+    cy.get('[for="telemetry-approval"]').click();
+    cy.getByTestId('telemetry-approval').should(
+      'have.attr',
+      'data-state',
+      'checked'
+    );
     cy.reload();
-    cy.get(telemetrySwitch).should('have.attr', 'data-state', 'checked');
+    cy.getByTestId('telemetry-approval').should(
-    cy.get(telemetrySwitch).click();
+      'have.attr',
-    cy.get(telemetrySwitch).should('have.attr', 'data-state', 'unchecked');
+      'data-state',
+      'checked'
+    );
+    cy.get('[for="telemetry-approval"]').click();
+    cy.getByTestId('telemetry-approval').should(
+      'have.attr',
+      'data-state',
+      'unchecked'
+    );
     cy.reload();
-    cy.get(telemetrySwitch).should('have.attr', 'data-state', 'unchecked');
+    cy.getByTestId('telemetry-approval').should(
+      'have.attr',
+      'data-state',
+      'unchecked'
+    );
   });
 });

apps/trading-e2e/src/integration/trading-deal-ticket-submit-account.cy.ts

@@ -12,7 +12,7 @@ describe(
   'account validation',
   { tags: '@regression', testIsolation: true },
   () => {
-    describe.skip('zero balance error', () => {
+    describe('zero balance error', () => {
       beforeEach(() => {
         cy.setVegaWallet();
         cy.mockTradingPage();
@@ -74,8 +74,8 @@ describe(
           'You may not have enough margin available to open this position. 5.00 tDAI is currently required. You have only 0.01001 tDAI available.'
         );
         cy.getByTestId('deal-ticket-deposit-dialog-button').click();
-        cy.getByTestId('sidebar-content')
+        cy.getByTestId('dialog-content')
-          .find('h2')
+          .find('h1')
           .eq(0)
           .should('have.text', 'Deposit');
       });

apps/trading-e2e/src/integration/trading-orders.cy.ts

@@ -431,8 +431,6 @@ describe('amend and cancel order', { tags: '@smoke' }, () => {
   });
 
   const orderId = '1234567890';
-
-  // this test is flakey
   it('must be able to amend the price of an order', () => {
     // 7003-MORD-007
     // 7003-MORD-012

apps/trading-e2e/src/integration/trading-trades.cy.ts

@@ -10,7 +10,6 @@ describe('trades', { tags: '@smoke' }, () => {
     cy.mockTradingPage();
     cy.mockSubscription();
   });
-
   before(() => {
     cy.mockTradingPage();
     cy.mockSubscription();
@@ -28,50 +27,37 @@ describe('trades', { tags: '@smoke' }, () => {
 
   it('show trades prices', () => {
     // 6005-THIS-003
-    cy.getByTestId(tradesTable)
+    cy.get(`${colIdPrice} ${colHeader}`).first().should('have.text', 'Price');
-      .get(`${colIdPrice} ${colHeader}`)
+    cy.get(colIdPrice).each(($tradePrice) => {
-      .first()
+      cy.wrap($tradePrice).invoke('text').should('not.be.empty');
-      .should('have.text', 'Price');
+    });
-    cy.getByTestId(tradesTable)
-      .get(colIdPrice)
-      .each(($tradePrice) => {
-        cy.wrap($tradePrice).invoke('text').should('not.be.empty');
-      });
   });
 
   it('show trades sizes', () => {
     // 6005-THIS-004
-    cy.getByTestId(tradesTable)
+    cy.get(`${colIdSize} ${colHeader}`).first().should('have.text', 'Size');
-      .get(`${colIdSize} ${colHeader}`)
+    cy.get(colIdSize).each(($tradeSize) => {
-      .first()
+      cy.wrap($tradeSize).invoke('text').should('not.be.empty');
-      .should('have.text', 'Size');
+    });
-    cy.getByTestId(tradesTable)
-      .get(colIdSize)
-      .each(($tradeSize) => {
-        cy.wrap($tradeSize).invoke('text').should('not.be.empty');
-      });
   });
 
-  // This won't pass in CI, but does locally
+  it('show trades date and time', () => {
-  it.skip('show trades date and time', () => {
     // 6005-THIS-005
-    cy.getByTestId(tradesTable) // order table shares identical col id
+    cy.get(`${colIdCreatedAt} ${colHeader}`).should('have.text', 'Created at');
-      .find(`${colIdCreatedAt} ${colHeader}`)
-      .should('have.text', 'Created at');
     const dateTimeRegex =
       /(\d{1,2})\/(\d{1,2})\/(\d{4}), (\d{1,2}):(\d{1,2}):(\d{1,2})/gm;
-    cy.getByTestId(tradesTable)
+    cy.get(colIdCreatedAt).each(($tradeDateTime, index) => {
-      .get(`.ag-center-cols-container ${colIdCreatedAt}`)
+      if (index != 0) {
-      .each(($tradeDateTime) => {
+        //ignore header
         cy.wrap($tradeDateTime).invoke('text').should('match', dateTimeRegex);
-      });
+      }
+    });
   });
 
   it('trades are sorted descending by datetime', () => {
     // 6005-THIS-006
     const dateTimes: Date[] = [];
-    cy.getByTestId(tradesTable)
+    cy.get(colIdCreatedAt)
-      .find(colIdCreatedAt)
       .each(($tradeDateTime, index) => {
         if (index != 0) {
           //ignore header
@@ -85,15 +71,9 @@ describe('trades', { tags: '@smoke' }, () => {
       });
   });
 
-  // this passes locally but doesn't in CI
+  it('copy price to deal ticket form', () => {
-  it.skip('copy price to deal ticket form', () => {
-    cy.getByTestId('order-type-TYPE_LIMIT').click(); // make sure on limit
     // 6005-THIS-007
-    cy.getByTestId(tradesTable)
+    cy.get(colIdPrice).last().should('be.visible').click();
-      .find(colIdPrice)
-      .last()
-      .should('be.visible')
-      .click();
     cy.getByTestId('order-price').should('have.value', '171.16898');
   });
 });

apps/trading-e2e/src/integration/withdraw-key-to-key.cy.ts

@@ -5,16 +5,20 @@ const amountShortName = 'input[name="amount"] + div + span.text-xs';
 const assetSelection = 'select-asset';
 const assetBalance = 'asset-balance';
 const assetOption = 'rich-select-option';
-const transferText = 'transfer-intro-text';
+const closeDialog = 'dialog-close';
+const dialogTitle = 'dialog-title';
+const dialogTransferText = 'dialog-transfer-text';
+const dropdownMenu = 'dropdown-menu';
 const errorText = 'input-error-text';
 const formFieldError = 'input-error-text';
 const includeTransferFeeRadioBtn = 'include-transfer-fee';
-const keyID = `[data-testid="${transferText}"] > .rounded-md`;
+const keyID = '[data-testid="dialog-transfer-text"] > .rounded-md';
 const manageVegaWallet = 'manage-vega-wallet';
-const openTransferButton = 'open-transfer';
+const openTransferDialog = 'open-transfer-dialog';
 const submitTransferBtn = '[type="submit"]';
 const toAddressField = '[name="toAddress"]';
 const totalTransferfee = 'total-transfer-fee';
+const transfer = 'transfer';
 const transferAmount = 'transfer-amount';
 const transferForm = 'transfer-form';
 const transferFee = 'transfer-fee';
@@ -35,18 +39,14 @@ describe('transfer fees', { tags: '@regression', testIsolation: true }, () => {
     cy.mockSubscription();
     cy.setVegaWallet();
 
-    cy.visit('/');
+    cy.visit('/#/portfolio');
+    cy.getByTestId('Trading').first().click();
+    cy.getByTestId(collateralTab).click();
+    cy.getByTestId(dropdownMenu).first().click();
+    cy.getByTestId(transfer).click();
 
-    // Only click if not already active otherwise sidebar will close
-    cy.get('[data-testid="sidebar-content"]').then(($sidebarContent) => {
-      if ($sidebarContent.find('h2').text() !== 'Transfer') {
-        cy.get('[data-testid="sidebar"] [data-testid="Transfer"]').click();
-      }
-    });
-
-    cy.wait('@Assets');
     cy.wait('@Accounts');
-
+    cy.wait('@Assets');
     cy.mockVegaWalletTransaction();
   });
 
@@ -72,18 +72,21 @@ describe('transfer fees', { tags: '@regression', testIsolation: true }, () => {
     cy.get('[data-side="bottom"] div')
       .should('be.visible')
       .should('not.be.empty');
+    cy.getByTestId(dialogTitle).click();
 
     //Check Transfer Fee tooltip
     cy.contains('div', 'Transfer fee').realHover();
     cy.get('[data-side="bottom"] div')
       .should('be.visible')
       .should('not.be.empty');
+    cy.getByTestId(dialogTitle).click();
 
     //Check Amount to be transferred tooltip
     cy.contains('div', 'Amount to be transferred').realHover();
     cy.get('[data-side="bottom"] div')
       .should('be.visible')
       .should('not.be.empty');
+    cy.getByTestId(dialogTitle).click();
 
     //Check Total amount (with fee) tooltip
     cy.contains('div', 'Total amount (with fee)').realHover();
@@ -131,7 +134,6 @@ describe('transfer fees', { tags: '@regression', testIsolation: true }, () => {
       .should('contain.text', '1.00');
   });
 });
-
 describe(
   'transfer form validation',
   { tags: '@regression', testIsolation: true },
@@ -152,7 +154,7 @@ describe(
 
     it('transfer Text', () => {
       // 1003-TRAN-003
-      cy.getByTestId(transferText)
+      cy.getByTestId(dialogTransferText)
         .should('exist')
         .get(keyID)
         .invoke('text')
@@ -202,6 +204,7 @@ describe(
         'contain.text',
         'You cannot transfer more than your available collateral'
       );
+      cy.getByTestId(closeDialog).click();
     });
   }
 );
@@ -214,7 +217,7 @@ describe('withdraw actions', { tags: '@smoke', testIsolation: true }, () => {
 
     cy.visit('/#/portfolio');
     cy.getByTestId(collateralTab).click();
-    cy.getByTestId(openTransferButton).click();
+    cy.getByTestId(openTransferDialog).click();
 
     cy.wait('@Accounts');
     cy.wait('@Assets');

apps/trading-e2e/src/integration/withdraw.cy.ts

@@ -21,7 +21,7 @@ describe('withdraw form validation', { tags: '@smoke' }, () => {
     cy.visit('/#/portfolio');
     cy.getByTestId('Withdrawals').click();
 
-    cy.getByTestId('Withdraw').click(); // sidebar item
+    cy.getByTestId('withdraw-dialog-button').click();
 
     // It also requires connection Ethereum wallet
     connectEthereumWallet('MetaMask');
@@ -87,17 +87,15 @@ describe(
       cy.setVegaWallet();
 
       cy.visit('/#/portfolio');
-
-      cy.wait('@Accounts');
-      cy.wait('@Assets');
-
       cy.getByTestId('Withdrawals').click();
 
-      cy.getByTestId('Withdraw').click();
+      cy.getByTestId('withdraw-dialog-button').click();
 
       // It also requires connection Ethereum wallet
       connectEthereumWallet('MetaMask');
 
+      cy.wait('@Accounts');
+      cy.wait('@Assets');
       cy.mockVegaWalletTransaction();
     });
 

apps/trading/client-pages/liquidity/liquidity.tsx

@@ -14,13 +14,20 @@ import {
   useNetworkParams,
 } from '@vegaprotocol/network-parameters';
 import { useDataProvider } from '@vegaprotocol/data-provider';
-import { Tab, Tabs, Indicator, ExternalLink } from '@vegaprotocol/ui-toolkit';
+import {
+  Tab,
+  Tabs,
+  Link as UiToolkitLink,
+  Indicator,
+  ExternalLink,
+} from '@vegaprotocol/ui-toolkit';
 import { useVegaWallet } from '@vegaprotocol/wallet';
 import { memo, useEffect, useState } from 'react';
 
 import { Header, HeaderStat, HeaderTitle } from '../../components/header';
 
-import { useParams } from 'react-router-dom';
+import { Link, useParams } from 'react-router-dom';
+import { Links, Routes } from '../../pages/client-router';
 
 import { useMarket, useStaticMarketData } from '@vegaprotocol/markets';
 import { DocsLinks } from '@vegaprotocol/environment';
@@ -64,15 +71,19 @@ const LiquidityViewHeader = memo(({ marketId }: { marketId?: string }) => {
   return (
     <Header
       title={
+        market?.tradableInstrument.instrument.name &&
         market?.tradableInstrument.instrument.code &&
         marketId && (
-          <HeaderTitle>
+          <HeaderTitle
-            {market.tradableInstrument.instrument.code &&
+            primaryContent={`${market.tradableInstrument.instrument.code} ${t(
-              t(
+              'liquidity provision'
-                '%s liquidity provision',
+            )}`}
-                market.tradableInstrument.instrument.code
+            secondaryContent={
-              )}
+              <Link to={Links[Routes.MARKET](marketId)}>
-          </HeaderTitle>
+                <UiToolkitLink>{t('Go to trading')}</UiToolkitLink>
+              </Link>
+            }
+          />
         )
       }
     >
@@ -105,7 +116,9 @@ const LiquidityViewHeader = memo(({ marketId }: { marketId?: string }) => {
         </div>
       </HeaderStat>
       <HeaderStat heading={t('Liquidity supplied')} testId="liquidity-supplied">
-        <Indicator variant={status} /> {formatNumberPercentage(percentage, 2)}
+        <Indicator variant={status} />
+
+        {formatNumberPercentage(percentage, 2)}
       </HeaderStat>
       <HeaderStat heading={t('Market ID')} testId="liquidity-market-id">
         <div className="break-word">{marketId}</div>
@@ -156,34 +169,24 @@ export const LiquidityViewContainer = ({
   return (
     <div className="h-full grid grid-rows-[min-content_1fr]">
       <LiquidityViewHeader marketId={marketId} />
-      <div className="p-1">
+      <Tabs value={tab || LiquidityTabs.Active} onValueChange={setTab}>
-        <div className="h-full border border-default">
+        <Tab
-          <Tabs value={tab || LiquidityTabs.Active} onValueChange={setTab}>
+          id={LiquidityTabs.MyLiquidityProvision}
-            <Tab
+          name={t('My liquidity provision')}
-              id={LiquidityTabs.MyLiquidityProvision}
+          hidden={!pubKey}
-              name={t('My liquidity provision')}
+        >
-              hidden={!pubKey}
+          <LiquidityContainer
-            >
+            marketId={marketId}
-              <LiquidityContainer
+            filter={{ partyId: pubKey || undefined }}
-                marketId={marketId}
+          />
-                filter={{ partyId: pubKey || undefined }}
+        </Tab>
-              />
+        <Tab id={LiquidityTabs.Active} name={t('Active')}>
-            </Tab>
+          <LiquidityContainer marketId={marketId} filter={{ active: true }} />
-            <Tab id={LiquidityTabs.Active} name={t('Active')}>
+        </Tab>
-              <LiquidityContainer
+        <Tab id={LiquidityTabs.Inactive} name={t('Inactive')}>
-                marketId={marketId}
+          <LiquidityContainer marketId={marketId} filter={{ active: false }} />
-                filter={{ active: true }}
+        </Tab>
-              />
+      </Tabs>
-            </Tab>
-            <Tab id={LiquidityTabs.Inactive} name={t('Inactive')}>
-              <LiquidityContainer
-                marketId={marketId}
-                filter={{ active: false }}
-              />
-            </Tab>
-          </Tabs>
-        </div>
-      </div>
     </div>
   );
 };

apps/trading/client-pages/market/asset-dropdown.tsx

@@ -9,15 +9,13 @@ import {
   DropdownMenuSeparator,
 } from '@vegaprotocol/ui-toolkit';
 
-type Assets = Array<{ id: string; symbol: string }>;
-
 export const AssetDropdown = ({
   assets,
   checkedAssets,
   onSelect,
   onReset,
 }: {
-  assets: Assets | undefined;
+  assets: Array<{ id: string; symbol: string }> | undefined;
   checkedAssets: string[];
   onSelect: (id: string, checked: boolean) => void;
   onReset: () => void;
@@ -30,7 +28,7 @@ export const AssetDropdown = ({
     <DropdownMenu
       trigger={
         <DropdownMenuTrigger data-testid="asset-trigger">
-          <TriggerText assets={assets} checkedAssets={checkedAssets} />
+          <span className="px-1">$</span>
         </DropdownMenuTrigger>
       }
     >
@@ -58,23 +56,3 @@ export const AssetDropdown = ({
     </DropdownMenu>
   );
 };
-
-const TriggerText = ({
-  assets,
-  checkedAssets,
-}: {
-  assets: Assets;
-  checkedAssets: string[];
-}) => {
-  let text = t('Asset');
-
-  if (checkedAssets.length === 1) {
-    const assetId = checkedAssets[0];
-    const asset = assets.find((a) => a.id === assetId);
-    text = asset ? asset.symbol : t('Asset (1)');
-  } else if (checkedAssets.length > 1) {
-    text = t(`Asset (${checkedAssets.length})`);
-  }
-
-  return <span className="px-1">{text}</span>;
-};

apps/trading/client-pages/market/header-stats.tsx

@@ -5,85 +5,92 @@ import { MarketProposalNotification } from '@vegaprotocol/proposals';
 import type { Market } from '@vegaprotocol/markets';
 import { getExpiryDate, getMarketExpiryDate } from '@vegaprotocol/utils';
 import { t } from '@vegaprotocol/i18n';
-import { Last24hPriceChange, Last24hVolume } from '@vegaprotocol/markets';
-import { MarketState as State } from '@vegaprotocol/types';
 import { HeaderStat } from '../../components/header';
 import { MarketMarkPrice } from '../../components/market-mark-price';
-import { HeaderStatMarketTradingMode } from '../../components/market-trading-mode';
+import { Last24hPriceChange, Last24hVolume } from '@vegaprotocol/markets';
 import { MarketState } from '../../components/market-state';
+import { HeaderStatMarketTradingMode } from '../../components/market-trading-mode';
 import { MarketLiquiditySupplied } from '../../components/liquidity-supplied';
+import { MarketState as State } from '@vegaprotocol/types';
 
-interface MarketHeaderStatsProps {
+interface HeaderStatsProps {
   market: Market | null;
 }
 
-export const MarketHeaderStats = ({ market }: MarketHeaderStatsProps) => {
+export const HeaderStats = ({ market }: HeaderStatsProps) => {
   const { VEGA_EXPLORER_URL } = useEnvironment();
   const { open: openAssetDetailsDialog } = useAssetDetailsDialogStore();
 
   const asset = market?.tradableInstrument.instrument.product?.settlementAsset;
 
   return (
-    <>
+    <div className="flex flex-col justify-end lg:pt-4">
-      <HeaderStat
+      <div className="xl:flex xl:gap-4 items-end">
-        heading={t('Expiry')}
+        <div
-        description={
+          data-testid="header-summary"
-          market && (
+          className="flex flex-nowrap items-end xl:flex-1 w-full overflow-x-auto text-xs"
-            <ExpiryTooltipContent
-              market={market}
-              explorerUrl={VEGA_EXPLORER_URL}
-            />
-          )
-        }
-        testId="market-expiry"
-      >
-        <ExpiryLabel market={market} />
-      </HeaderStat>
-      <HeaderStat heading={t('Price')} testId="market-price">
-        <MarketMarkPrice
-          marketId={market?.id}
-          decimalPlaces={market?.decimalPlaces}
-        />
-      </HeaderStat>
-      <HeaderStat heading={t('Change (24h)')} testId="market-change">
-        <Last24hPriceChange
-          marketId={market?.id}
-          decimalPlaces={market?.decimalPlaces}
-        />
-      </HeaderStat>
-      <HeaderStat heading={t('Volume (24h)')} testId="market-volume">
-        <Last24hVolume
-          marketId={market?.id}
-          positionDecimalPlaces={market?.positionDecimalPlaces}
-        />
-      </HeaderStat>
-      <HeaderStatMarketTradingMode
-        marketId={market?.id}
-        initialTradingMode={market?.tradingMode}
-      />
-      <MarketState market={market} />
-      {asset ? (
-        <HeaderStat
-          heading={t('Settlement asset')}
-          testId="market-settlement-asset"
         >
-          <div>
+          <HeaderStat
-            <ButtonLink
+            heading={t('Expiry')}
-              onClick={(e) => {
+            description={
-                openAssetDetailsDialog(asset.id, e.target as HTMLElement);
+              market && (
-              }}
+                <ExpiryTooltipContent
+                  market={market}
+                  explorerUrl={VEGA_EXPLORER_URL}
+                />
+              )
+            }
+            testId="market-expiry"
+          >
+            <ExpiryLabel market={market} />
+          </HeaderStat>
+          <HeaderStat heading={t('Price')} testId="market-price">
+            <MarketMarkPrice
+              marketId={market?.id}
+              decimalPlaces={market?.decimalPlaces}
+            />
+          </HeaderStat>
+          <HeaderStat heading={t('Change (24h)')} testId="market-change">
+            <Last24hPriceChange
+              marketId={market?.id}
+              decimalPlaces={market?.decimalPlaces}
+            />
+          </HeaderStat>
+          <HeaderStat heading={t('Volume (24h)')} testId="market-volume">
+            <Last24hVolume
+              marketId={market?.id}
+              positionDecimalPlaces={market?.positionDecimalPlaces}
+            />
+          </HeaderStat>
+          <HeaderStatMarketTradingMode
+            marketId={market?.id}
+            initialTradingMode={market?.tradingMode}
+          />
+          <MarketState market={market} />
+          {asset ? (
+            <HeaderStat
+              heading={t('Settlement asset')}
+              testId="market-settlement-asset"
             >
-              {asset.symbol}
+              <div>
-            </ButtonLink>
+                <ButtonLink
-          </div>
+                  onClick={(e) => {
-        </HeaderStat>
+                    openAssetDetailsDialog(asset.id, e.target as HTMLElement);
-      ) : null}
+                  }}
-      <MarketLiquiditySupplied
+                >
-        marketId={market?.id}
+                  {asset.symbol}
-        assetDecimals={asset?.decimals || 0}
+                </ButtonLink>
-      />
+              </div>
-      <MarketProposalNotification marketId={market?.id} />
+            </HeaderStat>
-    </>
+          ) : null}
+          <MarketLiquiditySupplied
+            marketId={market?.id}
+            assetDecimals={asset?.decimals || 0}
+          />
+          <MarketProposalNotification marketId={market?.id} />
+        </div>
+      </div>
+    </div>
   );
 };
 

apps/trading/client-pages/market/market-selector-item.spec.tsx

@@ -1,4 +1,5 @@
 import { render, screen, waitFor } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
 import { createMarketFragment } from '@vegaprotocol/mock';
 import { MarketSelectorItem } from './market-selector-item';
 import { MemoryRouter } from 'react-router-dom';
@@ -90,6 +91,8 @@ describe('MarketSelectorItem', () => {
     },
   ];
 
+  const mockOnSelect = jest.fn();
+
   const renderJsx = (mocks: MockedResponse[]) => {
     return render(
       <MemoryRouter>
@@ -98,6 +101,7 @@ describe('MarketSelectorItem', () => {
             market={market}
             currentMarketId={market.id}
             style={{}}
+            onSelect={mockOnSelect}
           />
         </MockedProvider>
       </MemoryRouter>
@@ -169,7 +173,7 @@ describe('MarketSelectorItem', () => {
     // link renders and is styled
     expect(link).toHaveAttribute('href', '/markets/' + market.id);
 
-    expect(link.parentNode).toHaveClass('bg-vega-light-100');
+    expect(link).toHaveClass('ring-1');
 
     expect(screen.getByTitle('24h vol')).toHaveTextContent('0.00');
     expect(screen.getByTitle(symbol)).toHaveTextContent('-');
@@ -179,6 +183,13 @@ describe('MarketSelectorItem', () => {
       expect(screen.getByTitle(symbol)).toHaveTextContent(
         addDecimalsFormatNumber(marketData.markPrice, market.decimalPlaces)
       );
+      expect(screen.getByTestId('market-item-change')).toHaveTextContent(
+        '+100.00%'
+      );
     });
+
+    await userEvent.click(link);
+
+    expect(mockOnSelect).toHaveBeenCalledWith(market.id);
   });
 });

apps/trading/client-pages/market/market-selector-item.tsx

@@ -1,7 +1,11 @@
-import type { CSSProperties } from 'react';
+import type { CSSProperties, ReactNode } from 'react';
 import { Link } from 'react-router-dom';
 import classNames from 'classnames';
-import { addDecimalsFormatNumber } from '@vegaprotocol/utils';
+import {
+  addDecimalsFormatNumber,
+  formatNumber,
+  priceChangePercentage,
+} from '@vegaprotocol/utils';
 import type { MarketMaybeWithDataAndCandles } from '@vegaprotocol/markets';
 import { calcCandleVolume } from '@vegaprotocol/markets';
 import { useCandles } from '@vegaprotocol/markets';
@@ -17,22 +21,29 @@ export const MarketSelectorItem = ({
   market,
   style,
   currentMarketId,
+  onSelect,
 }: {
   market: MarketMaybeWithDataAndCandles;
   style: CSSProperties;
   currentMarketId?: string;
+  onSelect?: (marketId: string) => void;
 }) => {
-  // 'py-1 px-2',
+  const wrapperClasses = classNames(
+    'block bg-vega-light-100 dark:bg-vega-dark-100 rounded-lg p-4',
+    'min-h-[120px]',
+    {
+      'ring-1 ring-vega-light-300 dark:ring-vega-dark-300':
+        currentMarketId === market.id,
+    }
+  );
   return (
-    <div style={style} role="row">
+    <div style={style} className="my-0.5 px-4">
       <Link
         to={`/markets/${market.id}`}
-        className={classNames('h-full flex items-center gap-2 px-4', {
+        className={wrapperClasses}
-          'hover:bg-vega-clight-700 dark:hover:bg-vega-cdark-700':
+        onClick={() => {
-            market.id !== currentMarketId,
+          onSelect && onSelect(market.id);
-          'bg-vega-clight-600 dark:bg-vega-cdark-600':
+        }}
-            market.id === currentMarketId,
-        })}
       >
         <MarketData market={market} />
       </Link>
@@ -80,41 +91,87 @@ const MarketData = ({ market }: { market: MarketMaybeWithDataAndCandles }) => {
 
   return (
     <>
-      <div className="w-1/4" role="gridcell">
+      <div className="flex items-end gap-1 mb-1">
-        <h3 className="text-ellipsis whitespace-nowrap overflow-hidden">
+        <h3
+          className={classNames(
+            'overflow-hidden text-ellipsis whitespace-nowrap',
+            {
+              'w-1/2': mode, // make space for showing the trading mode
+            }
+          )}
+        >
           {market.tradableInstrument.instrument.code}
         </h3>
         {mode && (
-          <p className="text-xs text-vega-orange-500 dark:text-vega-orange-550 whitespace-nowrap">
+          <p className="w-1/2 text-xs text-right text-vega-orange-500 dark:text-vega-orange-550">
             {mode}
           </p>
         )}
       </div>
-      <div
+      <DataRow value={volume} label={t('24h vol')} />
-        className="w-1/4 text-sm"
+      <DataRow
-        title={instrument.product.settlementAsset.symbol}
+        value={price}
-        data-testid="market-selector-data-row"
+        label={instrument.product.settlementAsset.symbol}
-        role="gridcell"
+      />
-      >
+      <div className="relative text-xs p-1">
-        {price} {instrument.product.settlementAsset.symbol}
-      </div>
-      <div
-        className="w-1/4 text-sm text-right"
-        title={t('24h vol')}
-        data-testid="market-selector-data-row"
-        role="gridcell"
-      >
-        {volume}
-      </div>
-      <div className="w-1/4" role="gridcell">
         {oneDayCandles && (
-          <Sparkline
+          <PriceChange candles={oneDayCandles.map((c) => c.close)} />
-            width={70}
-            height={15}
-            data={oneDayCandles.map((c) => Number(c.close))}
-          />
         )}
+
+        <div
+          // absolute so height is not larger than price change value
+          className="absolute right-0 bottom-0 w-[120px]"
+        >
+          {oneDayCandles && (
+            <Sparkline
+              width={120}
+              height={20}
+              data={oneDayCandles.map((c) => Number(c.close))}
+            />
+          )}
+        </div>
       </div>
     </>
   );
 };
+
+const DataRow = ({
+  value,
+  label,
+}: {
+  value: string | ReactNode;
+  label: string;
+}) => {
+  return (
+    <div
+      className="text-ellipsis whitespace-nowrap overflow-hidden leading-tight"
+      data-testid="market-selector-data-row"
+    >
+      <span title={label} className="text-sm mr-1">
+        {value}
+      </span>
+      <span className="text-xs text-vega-light-300 dark:text-vega-light-300">
+        {label}
+      </span>
+    </div>
+  );
+};
+
+const PriceChange = ({ candles }: { candles: string[] }) => {
+  const priceChange = candles ? priceChangePercentage(candles) : undefined;
+  const priceChangeClasses = classNames('text-xs', {
+    'text-market-red': priceChange && priceChange < 0,
+    'text-market-green-600 dark:text-market-green':
+      priceChange && priceChange > 0,
+  });
+  let prefix = '';
+  if (priceChange && priceChange > 0) {
+    prefix = '+';
+  }
+  const formattedChange = formatNumber(Number(priceChange), 2);
+  return (
+    <div className={priceChangeClasses} data-testid="market-item-change">
+      {priceChange ? `${prefix}${formattedChange}%` : '-'}
+    </div>
+  );
+};

apps/trading/client-pages/market/market-selector.spec.tsx

@@ -143,6 +143,7 @@ describe('MarketSelector', () => {
     expect(screen.getAllByTestId(/market-\d/)).toHaveLength(
       activeMarkets.length
     );
+    expect(screen.getByRole('link')).toHaveTextContent('All markets');
   });
 
   it('filters by product type', async () => {

apps/trading/client-pages/market/market-selector.tsx

@@ -9,7 +9,9 @@ import {
 } from '@vegaprotocol/ui-toolkit';
 import type { CSSProperties } from 'react';
 import { useCallback, useState, useMemo } from 'react';
+import { Link } from 'react-router-dom';
 import { FixedSizeList } from 'react-window';
+import AutoSizer from 'react-virtualized-auto-sizer';
 import { useMarketSelectorList } from './use-market-selector-list';
 import type { ProductType } from './product-selector';
 import { Product, ProductSelector } from './product-selector';
@@ -17,7 +19,6 @@ import { AssetDropdown } from './asset-dropdown';
 import type { SortType } from './sort-dropdown';
 import { Sort, SortDropdown } from './sort-dropdown';
 import { MarketSelectorItem } from './market-selector-item';
-import classNames from 'classnames';
 
 export type Filter = {
   searchTerm: string;
@@ -47,15 +48,18 @@ export const MarketSelector = ({
   const { markets, data, loading, error } = useMarketSelectorList(filter);
 
   return (
-    <div data-testid="market-selector">
+    <div
-      <div className="pt-2 px-2 mb-2 w-[320px] lg:w-[584px]">
+      className="grid grid-rows-[min-content_1fr_min-content] h-full"
+      data-testid="market-selector"
+    >
+      <div className="px-4 pt-2 pb-4">
         <ProductSelector
           product={filter.product}
           onSelect={(product) => {
             setFilter((curr) => ({ ...curr, product }));
           }}
         />
-        <div className="text-sm grid grid-cols-[2fr_1fr_1fr] gap-1 ">
+        <div className="text-sm flex gap-1 items-stretch">
           <div className="flex-1">
             <Input
               onChange={(e) =>
@@ -72,7 +76,7 @@ export const MarketSelector = ({
                     onClick={() =>
                       setFilter((curr) => ({ ...curr, searchTerm: '' }))
                     }
-                    className="text-secondary"
+                    className="text-vega-light-200 dark:text-vega-dark-200"
                   >
                     <VegaIcon name={VegaIconNames.CROSS} />
                   </button>
@@ -145,6 +149,18 @@ export const MarketSelector = ({
           }
         />
       </div>
+      <div className="px-4 py-2">
+        <span className="inline-block border-b border-black dark:border-white">
+          <Link
+            to={'/markets/all'}
+            data-testid="all-markets-link"
+            className="flex items-center gap-x-2"
+          >
+            {t('All markets')}
+            <VegaIcon name={VegaIconNames.ARROW_RIGHT} />
+          </Link>
+        </span>
+      </div>
     </div>
   );
 };
@@ -169,34 +185,21 @@ const MarketList = ({
     return <div>{error.message}</div>;
   }
   return (
-    <TinyScroll>
+    <AutoSizer>
-      <div
+      {({ width, height }) => (
-        className={classNames(
+        <TinyScroll>
-          'flex gap-2',
+          <List
-          'bg-vega-clight-700 dark:bg-vega-cdark-700',
+            data={data}
-          'p-2 mx-2 border-b border-default text-xs text-secondary'
+            loading={loading}
-        )}
+            width={width}
-      >
+            height={height}
-        <div className="w-1/4" role="columnheader">
+            currentMarketId={currentMarketId}
-          {t('Name')}
+            onSelect={onSelect}
-        </div>
+            noItems={noItems}
-        <div className="w-1/4" role="columnheader">
+          />
-          {t('Price')}
+        </TinyScroll>
-        </div>
+      )}
-        <div className="w-1/4 text-right" role="columnheader">
+    </AutoSizer>
-          {t('24h volume')}
-        </div>
-        <div className="w-1/4" role="columnheader" />
-      </div>
-      <List
-        data={data}
-        loading={loading}
-        height={400}
-        currentMarketId={currentMarketId}
-        onSelect={onSelect}
-        noItems={noItems}
-      />
-    </TinyScroll>
   );
 };
 
@@ -219,18 +222,21 @@ const ListItem = ({
     market={data.data[index]}
     currentMarketId={data.currentMarketId}
     style={style}
+    onSelect={data.onSelect}
   />
 );
 
 const List = ({
   data,
   loading,
+  width,
   height,
   onSelect,
   noItems,
   currentMarketId,
 }: ListItemData & {
   loading: boolean;
+  width: number;
   height: number;
   noItems: string;
 }) => {
@@ -244,7 +250,7 @@ const List = ({
   );
   if (!data || loading) {
     return (
-      <div style={{ height }}>
+      <div style={{ width, height }}>
         <Skeleton />
         <Skeleton />
       </div>
@@ -253,20 +259,24 @@ const List = ({
 
   if (!data.length) {
     return (
-      <div style={{ height }} data-testid="no-items">
+      <div style={{ width, height }} data-testid="no-items">
-        <div className="mx-4 my-2 text-sm">{noItems}</div>
+        <div className="mb-2 px-4">
+          <div className="text-sm bg-vega-light-100 dark:bg-vega-dark-100 rounded-lg px-4 py-2">
+            {noItems}
+          </div>
+        </div>
       </div>
     );
   }
 
   return (
     <FixedSizeList
-      className="vega-scrollbar"
+      className="virtualized-list"
       itemCount={data.length}
       itemData={itemData}
-      itemSize={45}
+      itemSize={130}
       itemKey={itemKey}
-      width="100%"
+      width={width}
       height={height}
     >
       {ListItem}

apps/trading/client-pages/market/market.tsx

@@ -14,7 +14,6 @@ import { TradePanels } from './trade-panels';
 import { useNavigate, useParams } from 'react-router-dom';
 import { Links, Routes } from '../../pages/client-router';
 import { useMarketClickHandler } from '../../lib/hooks/use-market-click-handler';
-import { ViewType, useSidebar } from '../../components/sidebar';
 
 const calculatePrice = (markPrice?: string, decimalPlaces?: number) => {
   return markPrice && decimalPlaces
@@ -62,7 +61,7 @@ const TitleUpdater = ({
 export const MarketPage = () => {
   const { marketId } = useParams();
   const navigate = useNavigate();
-  const { init, view, setView } = useSidebar();
+
   const { screenSize } = useScreenDimensions();
   const largeScreen = ['lg', 'xl', 'xxl', 'xxxl'].includes(screenSize);
   const update = useGlobalStore((store) => store.update);
@@ -82,13 +81,6 @@ export const MarketPage = () => {
     }
   }, [update, lastMarketId, data?.id]);
 
-  // Make sidebar open on deal ticket by default
-  useEffect(() => {
-    if (init && view === null) {
-      setView({ type: ViewType.Order });
-    }
-  }, [init, view, setView]);
-
   const tradeView = useMemo(() => {
     if (largeScreen) {
       return (

apps/trading/client-pages/market/product-selector.tsx

@@ -1,8 +1,4 @@
 import classNames from 'classnames';
-import { Link } from 'react-router-dom';
-import { Routes } from '../../pages/client-router';
-import { t } from '@vegaprotocol/i18n';
-import { VegaIcon, VegaIconNames } from '@vegaprotocol/ui-toolkit';
 
 // Make sure these match the available __typename properties on product
 export const Product = {
@@ -29,12 +25,12 @@ export const ProductSelector = ({
   onSelect: (product: ProductType) => void;
 }) => {
   return (
-    <div className="flex mb-2">
+    <div className="flex gap-3 mb-3">
       {Object.keys(Product).map((t) => {
-        const classes = classNames('px-3 py-1.5 rounded', {
+        const classes = classNames('py-1 border-b-2', {
-          'bg-vega-clight-500 dark:bg-vega-cdark-500 text-default':
+          'border-vega-yellow text-black dark:text-white': t === product,
-            t === product,
+          'border-transparent text-vega-light-300 dark:text-vega-dark-300':
-          'text-secondary': t !== product,
+            t !== product,
         });
         return (
           <button
@@ -49,10 +45,6 @@ export const ProductSelector = ({
           </button>
         );
       })}
-      <Link to={Routes.MARKETS} className="flex items-center gap-2 ml-auto">
-        <span className="underline underline-offset-4">{t('All markets')}</span>
-        <VegaIcon name={VegaIconNames.ARROW_RIGHT} />
-      </Link>
     </div>
   );
 };

apps/trading/client-pages/market/sort-dropdown.tsx

@@ -8,6 +8,8 @@ import {
   DropdownMenuRadioItem,
   DropdownMenuTrigger,
   DropdownMenuSeparator,
+  VegaIcon,
+  VegaIconNames,
 } from '@vegaprotocol/ui-toolkit';
 
 export const Sort = {
@@ -41,9 +43,7 @@ export const SortDropdown = ({
     <DropdownMenu
       trigger={
         <DropdownMenuTrigger data-testid="sort-trigger">
-          {currentSort === SortTypeMapping.None
+          <VegaIcon name={VegaIconNames.TREND_UP} />
-            ? t('Sort')
-            : SortTypeMapping[currentSort]}
         </DropdownMenuTrigger>
       }
     >

apps/trading/client-pages/market/trade-grid.tsx

@@ -1,5 +1,6 @@
-import { memo } from 'react';
+import { memo, useState } from 'react';
 import type { ReactNode } from 'react';
+import { useNavigate } from 'react-router-dom';
 import { LayoutPriority } from 'allotment';
 import classNames from 'classnames';
 import AutoSizer from 'react-virtualized-auto-sizer';
@@ -8,8 +9,8 @@ import { t } from '@vegaprotocol/i18n';
 import { OracleBanner } from '@vegaprotocol/markets';
 import type { Market } from '@vegaprotocol/markets';
 import { Filter } from '@vegaprotocol/orders';
+import { useScreenDimensions } from '@vegaprotocol/react-helpers';
 import {
-  Popover,
   Tab,
   LocalStoragePersistTabs as Tabs,
   VegaIcon,
@@ -17,22 +18,169 @@ import {
 } from '@vegaprotocol/ui-toolkit';
 import { useMarketClickHandler } from '../../lib/hooks/use-market-click-handler';
 import { VegaWalletContainer } from '../../components/vega-wallet-container';
-import { Header, HeaderTitle } from '../../components/header';
+import { HeaderTitle } from '../../components/header';
 import {
   ResizableGrid,
   ResizableGridPanel,
   usePaneLayout,
 } from '../../components/resizable-grid';
 import { TradingViews } from './trade-views';
-import { MarketSuccessorBanner } from '../../components/market-banner';
 import { MarketSelector } from './market-selector';
-import { MarketHeaderStats } from './market-header-stats';
+import { HeaderStats } from './header-stats';
+import { MarketSuccessorBanner } from '../../components/market-banner';
+
 interface TradeGridProps {
   market: Market | null;
   onSelect: (marketId: string, metaKey?: boolean) => void;
   pinnedAsset?: PinnedAsset;
 }
 
+interface BottomPanelProps {
+  marketId: string;
+  pinnedAsset?: PinnedAsset;
+}
+
+const MarketBottomPanel = memo(
+  ({ marketId, pinnedAsset }: BottomPanelProps) => {
+    const [sizes, handleOnLayoutChange] = usePaneLayout({ id: 'bottom' });
+    const { screenSize } = useScreenDimensions();
+    const onMarketClick = useMarketClickHandler(true);
+
+    return 'xxxl' === screenSize ? (
+      <ResizableGrid
+        proportionalLayout
+        minSize={200}
+        onChange={handleOnLayoutChange}
+      >
+        <ResizableGridPanel
+          priority={LayoutPriority.Low}
+          preferredSize={sizes[0] || '50%'}
+          minSize={50}
+        >
+          <TradeGridChild>
+            <Tabs storageKey="console-trade-grid-bottom-left">
+              <Tab id="open-orders" name={t('Open')}>
+                <VegaWalletContainer>
+                  <TradingViews.orders.component
+                    marketId={marketId}
+                    filter={Filter.Open}
+                  />
+                </VegaWalletContainer>
+              </Tab>
+              <Tab id="closed-orders" name={t('Closed')}>
+                <VegaWalletContainer>
+                  <TradingViews.orders.component
+                    marketId={marketId}
+                    filter={Filter.Closed}
+                  />
+                </VegaWalletContainer>
+              </Tab>
+              <Tab id="rejected-orders" name={t('Rejected')}>
+                <VegaWalletContainer>
+                  <TradingViews.orders.component
+                    marketId={marketId}
+                    filter={Filter.Rejected}
+                  />
+                </VegaWalletContainer>
+              </Tab>
+              <Tab id="orders" name={t('All')}>
+                <VegaWalletContainer>
+                  <TradingViews.orders.component marketId={marketId} />
+                </VegaWalletContainer>
+              </Tab>
+              <Tab id="fills" name={t('Fills')}>
+                <VegaWalletContainer>
+                  <TradingViews.fills.component onMarketClick={onMarketClick} />
+                </VegaWalletContainer>
+              </Tab>
+            </Tabs>
+          </TradeGridChild>
+        </ResizableGridPanel>
+        <ResizableGridPanel
+          priority={LayoutPriority.Low}
+          preferredSize={sizes[1] || '50%'}
+          minSize={50}
+        >
+          <TradeGridChild>
+            <Tabs storageKey="console-trade-grid-bottom-right">
+              <Tab id="positions" name={t('Positions')}>
+                <VegaWalletContainer>
+                  <TradingViews.positions.component
+                    onMarketClick={onMarketClick}
+                  />
+                </VegaWalletContainer>
+              </Tab>
+              <Tab id="accounts" name={t('Collateral')}>
+                <VegaWalletContainer>
+                  <TradingViews.collateral.component
+                    pinnedAsset={pinnedAsset}
+                    onMarketClick={onMarketClick}
+                    hideButtons
+                  />
+                </VegaWalletContainer>
+              </Tab>
+            </Tabs>
+          </TradeGridChild>
+        </ResizableGridPanel>
+      </ResizableGrid>
+    ) : (
+      <TradeGridChild>
+        <Tabs storageKey="console-trade-grid-bottom">
+          <Tab id="positions" name={t('Positions')}>
+            <VegaWalletContainer>
+              <TradingViews.positions.component onMarketClick={onMarketClick} />
+            </VegaWalletContainer>
+          </Tab>
+          <Tab id="open-orders" name={t('Open')}>
+            <VegaWalletContainer>
+              <TradingViews.orders.component
+                marketId={marketId}
+                filter={Filter.Open}
+              />
+            </VegaWalletContainer>
+          </Tab>
+          <Tab id="closed-orders" name={t('Closed')}>
+            <VegaWalletContainer>
+              <TradingViews.orders.component
+                marketId={marketId}
+                filter={Filter.Closed}
+              />
+            </VegaWalletContainer>
+          </Tab>
+          <Tab id="rejected-orders" name={t('Rejected')}>
+            <VegaWalletContainer>
+              <TradingViews.orders.component
+                marketId={marketId}
+                filter={Filter.Rejected}
+              />
+            </VegaWalletContainer>
+          </Tab>
+          <Tab id="orders" name={t('All')}>
+            <VegaWalletContainer>
+              <TradingViews.orders.component marketId={marketId} />
+            </VegaWalletContainer>
+          </Tab>
+          <Tab id="fills" name={t('Fills')}>
+            <VegaWalletContainer>
+              <TradingViews.fills.component onMarketClick={onMarketClick} />
+            </VegaWalletContainer>
+          </Tab>
+          <Tab id="accounts" name={t('Collateral')}>
+            <VegaWalletContainer>
+              <TradingViews.collateral.component
+                pinnedAsset={pinnedAsset}
+                onMarketClick={onMarketClick}
+                hideButtons
+              />
+            </VegaWalletContainer>
+          </Tab>
+        </Tabs>
+      </TradeGridChild>
+    );
+  }
+);
+MarketBottomPanel.displayName = 'MarketBottomPanel';
+
 const MainGrid = memo(
   ({
     marketId,
@@ -41,6 +189,7 @@ const MainGrid = memo(
     marketId: string;
     pinnedAsset?: PinnedAsset;
   }) => {
+    const navigate = useNavigate();
     const [sizes, handleOnLayoutChange] = usePaneLayout({ id: 'top' });
     const [sizesMiddle, handleOnMiddleLayoutChange] = usePaneLayout({
       id: 'middle-1',
@@ -55,6 +204,25 @@ const MainGrid = memo(
             minSize={200}
             onChange={handleOnMiddleLayoutChange}
           >
+            <ResizableGridPanel
+              preferredSize={sizesMiddle[0] || 330}
+              minSize={300}
+            >
+              <TradeGridChild>
+                <Tabs storageKey="console-trade-grid-main-center">
+                  <Tab id="ticket" name={t('Ticket')}>
+                    <TradingViews.ticket.component
+                      marketId={marketId}
+                      onMarketClick={onMarketClick}
+                      onClickCollateral={() => navigate('/portfolio')}
+                    />
+                  </Tab>
+                  <Tab id="info" name={t('Info')}>
+                    <TradingViews.info.component marketId={marketId} />
+                  </Tab>
+                </Tabs>
+              </TradeGridChild>
+            </ResizableGridPanel>
             <ResizableGridPanel
               priority={LayoutPriority.High}
               minSize={200}
@@ -96,63 +264,7 @@ const MainGrid = memo(
           preferredSize={sizes[1] || '25%'}
           minSize={50}
         >
-          <TradeGridChild>
+          <MarketBottomPanel marketId={marketId} pinnedAsset={pinnedAsset} />
-            <Tabs storageKey="console-trade-grid-bottom">
-              <Tab id="positions" name={t('Positions')}>
-                <VegaWalletContainer>
-                  <TradingViews.positions.component
-                    onMarketClick={onMarketClick}
-                  />
-                </VegaWalletContainer>
-              </Tab>
-              <Tab id="open-orders" name={t('Open')}>
-                <VegaWalletContainer>
-                  <TradingViews.orders.component
-                    marketId={marketId}
-                    filter={Filter.Open}
-                  />
-                </VegaWalletContainer>
-              </Tab>
-              <Tab id="closed-orders" name={t('Closed')}>
-                <VegaWalletContainer>
-                  <TradingViews.orders.component
-                    marketId={marketId}
-                    filter={Filter.Closed}
-                  />
-                </VegaWalletContainer>
-              </Tab>
-              <Tab id="rejected-orders" name={t('Rejected')}>
-                <VegaWalletContainer>
-                  <TradingViews.orders.component
-                    marketId={marketId}
-                    filter={Filter.Rejected}
-                  />
-                </VegaWalletContainer>
-              </Tab>
-              <Tab id="orders" name={t('All')}>
-                <VegaWalletContainer>
-                  <TradingViews.orders.component marketId={marketId} />
-                </VegaWalletContainer>
-              </Tab>
-              <Tab id="fills" name={t('Fills')}>
-                <VegaWalletContainer>
-                  <TradingViews.fills.component
-                    marketId={marketId}
-                    onMarketClick={onMarketClick}
-                  />
-                </VegaWalletContainer>
-              </Tab>
-              <Tab id="accounts" name={t('Collateral')}>
-                <VegaWalletContainer>
-                  <TradingViews.collateral.component
-                    pinnedAsset={pinnedAsset}
-                    onMarketClick={onMarketClick}
-                    hideButtons
-                  />
-                </VegaWalletContainer>
-              </Tab>
-            </Tabs>
-          </TradeGridChild>
         </ResizableGridPanel>
       </ResizableGrid>
     );
@@ -161,34 +273,62 @@ const MainGrid = memo(
 MainGrid.displayName = 'MainGrid';
 
 export const TradeGrid = ({ market, pinnedAsset }: TradeGridProps) => {
+  const [sidebarOpen, setSidebarOpen] = useState(true);
   const wrapperClasses = classNames(
     'h-full grid',
-    'grid-rows-[min-content_min-content_1fr]'
+    'grid-rows-[min-content_min-content_1fr]',
+    'grid-cols-[320px_1fr]'
   );
+  const paneWrapperClasses = classNames('min-h-0', {
+    'col-span-2 col-start-1': !sidebarOpen,
+  });
 
   return (
     <div className={wrapperClasses}>
-      <Header
+      <div className="border-b border-r border-default">
-        title={
+        <div className="h-full flex gap-2 justify-between items-end px-4 pt-1 pb-3">
-          <Popover
+          <HeaderTitle
-            trigger={
+            primaryContent={market?.tradableInstrument.instrument.code}
-              <HeaderTitle>
+            secondaryContent={market?.tradableInstrument.instrument.name}
-                {market?.tradableInstrument.instrument.code}
+          />
-                <VegaIcon name={VegaIconNames.CHEVRON_DOWN} size={14} />
+          <button
-              </HeaderTitle>
+            onClick={() => setSidebarOpen((x) => !x)}
-            }
+            className="flex flex-col items-center text-xs w-12"
+            data-testid="sidebar-toggle"
           >
-            <MarketSelector currentMarketId={market?.id} />
+            {sidebarOpen ? (
-          </Popover>
+              <>
-        }
+                <VegaIcon name={VegaIconNames.CHEVRON_UP} />
-      >
+                <span className="text-vega-light-300 dark:text-vega-dark-300">
-        <MarketHeaderStats market={market} />
+                  {t('Close')}
-      </Header>
+                </span>
-      <div className="bg-vega-green">
+              </>
+            ) : (
+              <>
+                <VegaIcon name={VegaIconNames.CHEVRON_DOWN} />
+                <span className="text-vega-light-300 dark:text-vega-dark-300">
+                  {t('Markets')}
+                </span>
+              </>
+            )}
+          </button>
+        </div>
+      </div>
+      <div className="border-b border-default min-w-0">
+        <HeaderStats market={market} />
+      </div>
+      <div className="col-span-2">
         <MarketSuccessorBanner market={market} />
         <OracleBanner marketId={market?.id || ''} />
       </div>
-      <div className="min-h-0 py-0.5">
+      {sidebarOpen && (
+        <div className="border-r border-default min-h-0">
+          <div className="h-full pb-8">
+            <MarketSelector currentMarketId={market?.id} />
+          </div>
+        </div>
+      )}
+      <div className={paneWrapperClasses}>
         <MainGrid marketId={market?.id || ''} pinnedAsset={pinnedAsset} />
       </div>
     </div>
@@ -201,16 +341,9 @@ interface TradeGridChildProps {
 
 const TradeGridChild = ({ children }: TradeGridChildProps) => {
   return (
-    <section className="h-full p-1">
+    <section className="h-full">
       <AutoSizer>
-        {({ width, height }) => (
+        {({ width, height }) => <div style={{ width, height }}>{children}</div>}
-          <div
-            style={{ width, height }}
-            className="border border-default rounded-sm"
-          >
-            {children}
-          </div>
-        )}
       </AutoSizer>
     </section>
   );

apps/trading/client-pages/market/trade-panels.tsx

@@ -9,7 +9,7 @@ import type { TradingView } from './trade-views';
 import { TradingViews } from './trade-views';
 import { memo, useState } from 'react';
 import {
-  Popover,
+  Icon,
   Splash,
   VegaIcon,
   VegaIconNames,
@@ -17,10 +17,11 @@ import {
 import { NO_MARKET } from './constants';
 import AutoSizer from 'react-virtualized-auto-sizer';
 import classNames from 'classnames';
-import { Header, HeaderTitle } from '../../components/header';
+import { HeaderStats } from './header-stats';
+import * as DialogPrimitives from '@radix-ui/react-dialog';
+import { HeaderTitle } from '../../components/header';
 import { MarketSelector } from './market-selector';
 import { MarketSuccessorBanner } from '../../components/market-banner';
-import { MarketHeaderStats } from './market-header-stats';
 
 interface TradePanelsProps {
   market: Market | null;
@@ -37,6 +38,7 @@ export const TradePanels = ({
   onClickCollateral,
   pinnedAsset,
 }: TradePanelsProps) => {
+  const [drawerOpen, setDrawerOpen] = useState(false);
   const onMarketClick = useMarketClickHandler(true);
   const onOrderTypeClick = useMarketLiquidityClickHandler();
 
@@ -71,22 +73,25 @@ export const TradePanels = ({
 
   return (
     <div className="h-full grid grid-rows-[min-content_min-content_1fr_min-content]">
-      <Header
+      <div className="border-b border-default min-w-0">
-        title={
+        <div className="flex gap-4 items-center px-4 py-2">
-          <Popover
+          <HeaderTitle
-            trigger={
+            primaryContent={market?.tradableInstrument.instrument.code}
-              <HeaderTitle>
+            secondaryContent={market?.tradableInstrument.instrument.name}
-                {market?.tradableInstrument.instrument.code}
+          />
-                <VegaIcon name={VegaIconNames.CHEVRON_DOWN} />
+          <button onClick={() => setDrawerOpen((x) => !x)} className="p-2">
-              </HeaderTitle>
+            <span
-            }
+              className={classNames('block', {
-          >
+                'rotate-90 translate-x-1': !drawerOpen,
-            <MarketSelector currentMarketId={market?.id} />
+                '-rotate-90 -translate-x-1': drawerOpen,
-          </Popover>
+              })}
-        }
+            >
-      >
+              <VegaIcon name={VegaIconNames.CHEVRON_UP} />
-        <MarketHeaderStats market={market} />
+            </span>
-      </Header>
+          </button>
+        </div>
+        <HeaderStats market={market} />
+      </div>
       <div>
         <MarketSuccessorBanner market={market} />
         <OracleBanner marketId={market?.id || ''} />
@@ -104,7 +109,8 @@ export const TradePanels = ({
         {Object.keys(TradingViews).map((key) => {
           const isActive = view === key;
           const className = classNames('p-4 min-w-[100px] capitalize', {
-            'bg-vega-clight-500 dark:bg-vega-cdark-500': isActive,
+            'text-black dark:text-vega-yellow': isActive,
+            'bg-neutral-200 dark:bg-neutral-800': isActive,
           });
           return (
             <button
@@ -118,6 +124,25 @@ export const TradePanels = ({
           );
         })}
       </div>
+      <DialogPrimitives.Root open={drawerOpen} onOpenChange={setDrawerOpen}>
+        <DialogPrimitives.Portal>
+          <DialogPrimitives.Overlay />
+          <DialogPrimitives.Content
+            className={classNames(
+              'fixed h-full max-w-[500px] w-[90vw] z-10 top-0 left-0 transition-transform',
+              'bg-white dark:bg-black',
+              'border-r border-default'
+            )}
+          >
+            <DialogPrimitives.Close className="absolute top-0 right-0 p-2">
+              <Icon name="cross" />
+            </DialogPrimitives.Close>
+            {drawerOpen && (
+              <MarketSelector onSelect={() => setDrawerOpen(false)} />
+            )}
+          </DialogPrimitives.Content>
+        </DialogPrimitives.Portal>
+      </DialogPrimitives.Root>
     </div>
   );
 };

apps/trading/client-pages/market/trade-views.tsx

@@ -1,5 +1,7 @@
 import type { ComponentProps } from 'react';
 import { Splash } from '@vegaprotocol/ui-toolkit';
+import { DealTicketContainer } from '@vegaprotocol/deal-ticket';
+import { MarketInfoAccordionContainer } from '@vegaprotocol/markets';
 import { TradesContainer } from '@vegaprotocol/trades';
 import { DepthChartContainer } from '@vegaprotocol/market-depth';
 import { CandlesChartContainer } from '@vegaprotocol/candles-chart';
@@ -16,6 +18,8 @@ import { OrdersContainer } from '../../components/orders-container';
 type MarketDependantView =
   | typeof CandlesChartContainer
   | typeof DepthChartContainer
+  | typeof DealTicketContainer
+  | typeof MarketInfoAccordionContainer
   | typeof OrderbookContainer
   | typeof TradesContainer;
 
@@ -43,6 +47,14 @@ export const TradingViews = {
     label: 'Liquidity',
     component: requiresMarket(LiquidityContainer),
   },
+  ticket: {
+    label: 'Ticket',
+    component: requiresMarket(DealTicketContainer),
+  },
+  info: {
+    label: 'Info',
+    component: requiresMarket(MarketInfoAccordionContainer),
+  },
   orderbook: {
     label: 'Orderbook',
     component: requiresMarket(OrderbookContainer),

apps/trading/client-pages/markets/markets-page.tsx

@@ -15,20 +15,16 @@ export const MarketsPage = () => {
     updateTitle(titlefy(['Markets']));
   }, [updateTitle]);
   return (
-    <div className="h-full pt-0.5 pb-3 px-1">
+    <Tabs storageKey="console-markets">
-      <div className="h-full my-1 border border-default rounded-sm">
+      <Tab id="all-markets" name={t('All markets')}>
-        <Tabs storageKey="console-markets">
+        <Markets />
-          <Tab id="all-markets" name={t('All markets')}>
+      </Tab>
-            <Markets />
+      <Tab id="proposed-markets" name={t('Proposed markets')}>
-          </Tab>
+        <Proposed />
-          <Tab id="proposed-markets" name={t('Proposed markets')}>
+      </Tab>
-            <Proposed />
+      <Tab id="closed-markets" name={t('Closed markets')}>
-          </Tab>
+        <Closed />
-          <Tab id="closed-markets" name={t('Closed markets')}>
+      </Tab>
-            <Closed />
+    </Tabs>
-          </Tab>
-        </Tabs>
-      </div>
-    </div>
   );
 };

apps/trading/client-pages/portfolio/deposits-container.tsx

@@ -1,12 +1,11 @@
 import { Button } from '@vegaprotocol/ui-toolkit';
-import { DepositsTable } from '@vegaprotocol/deposits';
+import { useDepositDialog, DepositsTable } from '@vegaprotocol/deposits';
 import { depositsProvider } from '@vegaprotocol/deposits';
 import { t } from '@vegaprotocol/i18n';
 import { useDataProvider } from '@vegaprotocol/data-provider';
 import { useVegaWallet } from '@vegaprotocol/wallet';
 import { useRef } from 'react';
 import type { AgGridReact } from 'ag-grid-react';
-import { useSidebar, ViewType } from '../../components/sidebar';
 
 export const DepositsContainer = () => {
   const gridRef = useRef<AgGridReact | null>(null);
@@ -16,7 +15,7 @@ export const DepositsContainer = () => {
     variables: { partyId: pubKey || '' },
     skip: !pubKey,
   });
-  const setView = useSidebar((store) => store.setView);
+  const openDepositDialog = useDepositDialog((state) => state.open);
   return (
     <div className="h-full">
       <DepositsTable
@@ -25,11 +24,11 @@ export const DepositsContainer = () => {
         overlayNoRowsTemplate={error ? error.message : t('No deposits')}
       />
       {!isReadOnly && (
-        <div className="h-auto flex justify-end p-2 bottom-0 right-0 absolute dark:bg-black/75 bg-white/75 rounded">
+        <div className="h-auto flex justify-end px-[11px] py-2 bottom-0 right-3 absolute dark:bg-black/75 bg-white/75 rounded">
           <Button
             variant="primary"
             size="sm"
-            onClick={() => setView({ type: ViewType.Deposit })}
+            onClick={() => openDepositDialog()}
             data-testid="deposit-button"
           >
             {t('Deposit')}

apps/trading/client-pages/portfolio/portfolio.tsx

@@ -21,7 +21,6 @@ import {
   ResizableGridPanel,
   usePaneLayout,
 } from '../../components/resizable-grid';
-import { ViewType, useSidebar } from '../../components/sidebar';
 
 const WithdrawalsIndicator = () => {
   const { ready } = useIncompleteWithdrawals();
@@ -29,14 +28,13 @@ const WithdrawalsIndicator = () => {
     return null;
   }
   return (
-    <span className="bg-vega-clight-500 dark:bg-vega-cdark-500 text-default rounded p-1 leading-none">
+    <span className="bg-vega-blue-450 text-white text-[10px] rounded p-[3px] pb-[2px] leading-none">
       {ready.length}
     </span>
   );
 };
 
 export const Portfolio = () => {
-  const { init, view, setView } = useSidebar();
   const { updateTitle } = usePageTitleStore((store) => ({
     updateTitle: store.updateTitle,
   }));
@@ -45,16 +43,9 @@ export const Portfolio = () => {
     updateTitle(titlefy([t('Portfolio')]));
   }, [updateTitle]);
 
-  // Make transfer sidebar open by default
-  useEffect(() => {
-    if (init && view === null) {
-      setView({ type: ViewType.Transfer });
-    }
-  }, [init, view, setView]);
-
   const onMarketClick = useMarketClickHandler(true);
   const [sizes, handleOnLayoutChange] = usePaneLayout({ id: 'portfolio' });
-  const wrapperClasses = 'py-0.5 h-full max-h-full flex flex-col';
+  const wrapperClasses = 'h-full max-h-full flex flex-col';
   return (
     <div className={wrapperClasses}>
       <ResizableGrid vertical onChange={handleOnLayoutChange}>
@@ -127,8 +118,8 @@ interface PortfolioGridChildProps {
 
 const PortfolioGridChild = ({ children }: PortfolioGridChildProps) => {
   return (
-    <section className="h-full p-1">
+    <section className="bg-white dark:bg-black w-full h-full">
-      <div className="border border-default h-full rounded-sm">{children}</div>
+      {children}
     </section>
   );
 };

apps/trading/client-pages/portfolio/withdrawals-container.tsx

@@ -1,6 +1,7 @@
 import { Button } from '@vegaprotocol/ui-toolkit';
 import {
   withdrawalProvider,
+  useWithdrawalDialog,
   WithdrawalsTable,
   useIncompleteWithdrawals,
 } from '@vegaprotocol/withdraws';
@@ -8,7 +9,6 @@ import { useVegaWallet } from '@vegaprotocol/wallet';
 import { t } from '@vegaprotocol/i18n';
 import { useDataProvider } from '@vegaprotocol/data-provider';
 import { VegaWalletContainer } from '../../components/vega-wallet-container';
-import { ViewType, useSidebar } from '../../components/sidebar';
 
 export const WithdrawalsContainer = () => {
   const { pubKey, isReadOnly } = useVegaWallet();
@@ -17,7 +17,7 @@ export const WithdrawalsContainer = () => {
     variables: { partyId: pubKey || '' },
     skip: !pubKey,
   });
-  const setView = useSidebar((store) => store.setView);
+  const openWithdrawDialog = useWithdrawalDialog((state) => state.open);
   const { ready, delayed } = useIncompleteWithdrawals();
 
   return (
@@ -32,11 +32,11 @@ export const WithdrawalsContainer = () => {
         />
       </div>
       {!isReadOnly && (
-        <div className="h-auto flex justify-end p-2 bottom-0 right-0 absolute dark:bg-black/75 bg-white/75 rounded">
+        <div className="h-auto flex justify-end px-[11px] py-2 bottom-0 right-3 absolute dark:bg-black/75 bg-white/75 rounded">
           <Button
             variant="primary"
             size="sm"
-            onClick={() => setView({ type: ViewType.Withdraw })}
+            onClick={() => openWithdrawDialog()}
             data-testid="withdraw-dialog-button"
           >
             {t('Make withdrawal')}

apps/trading/client-pages/settings/index.ts

@@ -0,0 +1,2 @@
+export { Settings as default } from './settings';
+export { SettingsButton } from './settings-button';

apps/trading/client-pages/settings/settings-button.tsx

@@ -0,0 +1,16 @@
+import { Icon, NavigationLink } from '@vegaprotocol/ui-toolkit';
+import { t } from '@vegaprotocol/i18n';
+import { Links, Routes } from '../../pages/client-router';
+import { IconNames } from '@blueprintjs/icons';
+
+export const SettingsButton = ({ withMobile }: { withMobile?: boolean }) => {
+  return (
+    <NavigationLink data-testid="Settings" to={Links[Routes.SETTINGS]()}>
+      {withMobile ? (
+        t('Settings')
+      ) : (
+        <Icon name={IconNames.COG} className="!align-middle" />
+      )}
+    </NavigationLink>
+  );
+};

apps/trading/client-pages/settings/settings.tsx

@@ -0,0 +1,52 @@
+import { t } from '@vegaprotocol/i18n';
+import { TelemetryApproval } from '../../components/welcome-dialog/telemetry-approval';
+import {
+  Divider,
+  RoundedWrapper,
+  Switch,
+  ThemeSwitcher,
+  ToastPositionSetter,
+} from '@vegaprotocol/ui-toolkit';
+import { useThemeSwitcher } from '@vegaprotocol/react-helpers';
+
+export const Settings = () => {
+  const { theme, setTheme } = useThemeSwitcher();
+  const text = t(theme === 'dark' ? 'Light mode' : 'Dark mode');
+  return (
+    <div className="py-16 px-8 flex w-full justify-center">
+      <div className="lg:min-w-[700px] min-w-[300px]">
+        <h1 className="text-4xl xl:text-5xl uppercase font-alpha calt">
+          {t('Settings')}
+        </h1>
+        <div className="mt-8 text-base text-neutral-500 dark:text-neutral-400">
+          {t('Changes are applied automatically.')}
+        </div>
+        <div className="mt-10 w-full">
+          <RoundedWrapper paddingBottom>
+            <div className="flex justify-between py-3">
+              <div className="flex shrink">
+                <ThemeSwitcher />
+                <label htmlFor="theme-switcher" className="self-center text-lg">
+                  {text}
+                </label>
+              </div>
+              <Switch
+                name="settings-theme-switch"
+                onCheckedChange={() => setTheme()}
+                checked={theme === 'dark'}
+              />
+            </div>
+            <Divider />
+            <TelemetryApproval
+              helpText={t(
+                'Help identify bugs and improve the service by sharing anonymous usage data.'
+              )}
+            />
+            <Divider />
+            <ToastPositionSetter />
+          </RoundedWrapper>
+        </div>
+      </div>
+    </div>
+  );
+};

apps/trading/components/accounts-container/accounts-container.tsx

@@ -1,17 +1,18 @@
 import { useCallback } from 'react';
 import { Button } from '@vegaprotocol/ui-toolkit';
 import { t } from '@vegaprotocol/i18n';
+import { useWithdrawalDialog } from '@vegaprotocol/withdraws';
 import { useAssetDetailsDialogStore } from '@vegaprotocol/assets';
 import { Splash } from '@vegaprotocol/ui-toolkit';
 import { useVegaWallet } from '@vegaprotocol/wallet';
 import type { PinnedAsset } from '@vegaprotocol/accounts';
-import { AccountManager } from '@vegaprotocol/accounts';
+import { AccountManager, useTransferDialog } from '@vegaprotocol/accounts';
+import { useDepositDialog } from '@vegaprotocol/deposits';
 import { create } from 'zustand';
 import { persist } from 'zustand/middleware';
 import { useDataGridEvents } from '@vegaprotocol/datagrid';
 import type { DataGridSlice } from '../../stores/datagrid-store-slice';
 import { createDataGridSlice } from '../../stores/datagrid-store-slice';
-import { ViewType, useSidebar } from '../sidebar';
 
 export const AccountsContainer = ({
   pinnedAsset,
@@ -24,7 +25,9 @@ export const AccountsContainer = ({
 }) => {
   const { pubKey, isReadOnly } = useVegaWallet();
   const { open: openAssetDetailsDialog } = useAssetDetailsDialogStore();
-  const setView = useSidebar((store) => store.setView);
+  const openWithdrawalDialog = useWithdrawalDialog((store) => store.open);
+  const openDepositDialog = useDepositDialog((store) => store.open);
+  const openTransferDialog = useTransferDialog((store) => store.open);
 
   const gridStore = useAccountStore((store) => store.gridStore);
   const updateGridStore = useAccountStore((store) => store.updateGridStore);
@@ -52,34 +55,27 @@ export const AccountsContainer = ({
       <AccountManager
         partyId={pubKey}
         onClickAsset={onClickAsset}
-        onClickWithdraw={(assetId) => {
+        onClickWithdraw={openWithdrawalDialog}
-          setView({ type: ViewType.Withdraw, assetId });
+        onClickDeposit={openDepositDialog}
-        }}
-        onClickDeposit={(assetId) => {
-          setView({ type: ViewType.Deposit, assetId });
-        }}
-        onClickTransfer={(assetId) => {
-          setView({ type: ViewType.Transfer, assetId });
-        }}
         onMarketClick={onMarketClick}
         isReadOnly={isReadOnly}
         pinnedAsset={pinnedAsset}
         gridProps={gridStoreCallbacks}
       />
       {!isReadOnly && !hideButtons && (
-        <div className="flex gap-2 justify-end p-2 absolute bottom-0 right-0 dark:bg-black/75 bg-white/75 rounded">
+        <div className="flex gap-2 justify-end p-2 px-[11px] absolute lg:fixed bottom-0 right-3 dark:bg-black/75 bg-white/75 rounded">
           <Button
             variant="primary"
             size="sm"
-            data-testid="open-transfer"
+            data-testid="open-transfer-dialog"
-            onClick={() => setView({ type: ViewType.Transfer })}
+            onClick={() => openTransferDialog()}
           >
             {t('Transfer')}
           </Button>
           <Button
             variant="primary"
             size="sm"
-            onClick={() => setView({ type: ViewType.Deposit })}
+            onClick={() => openDepositDialog()}
           >
             {t('Deposit')}
           </Button>

apps/trading/components/banner/announcement-banner.tsx

@@ -6,7 +6,7 @@ export const AnnouncementBanner = () => {
   // Return an empty div so that the grid layout in _app.page.ts
   // renders correctly
   if (!ANNOUNCEMENTS_CONFIG_URL) {
-    return null;
+    return <div />;
   }
 
   return <Banner app="console" configUrl={ANNOUNCEMENTS_CONFIG_URL} />;

apps/trading/components/footer/footer.spec.tsx

@@ -0,0 +1,70 @@
+import { render, screen, waitFor } from '@testing-library/react';
+import userEvent from '@testing-library/user-event';
+import { NodeHealth, NodeUrl, HealthIndicator } from './footer';
+import { MockedProvider } from '@apollo/client/testing';
+import { Intent } from '@vegaprotocol/ui-toolkit';
+
+const mockSetNodeSwitcher = jest.fn();
+
+jest.mock('@vegaprotocol/environment', () => ({
+  ...jest.requireActual('@vegaprotocol/environment'),
+  useEnvironment: jest.fn().mockImplementation(() => ({
+    VEGA_URL: 'https://vega-url.wtf',
+    VEGA_INCIDENT_URL: 'https://blog.vega.community',
+  })),
+  useNodeSwitcherStore: jest.fn(() => mockSetNodeSwitcher),
+}));
+
+describe('NodeHealth', () => {
+  it('controls the node switcher dialog', async () => {
+    render(<NodeHealth />, { wrapper: MockedProvider });
+    await waitFor(() => {
+      expect(screen.getByRole('button')).toBeInTheDocument();
+    });
+    await userEvent.click(screen.getByRole('button'));
+    expect(mockSetNodeSwitcher).toHaveBeenCalled();
+  });
+
+  it('External link to blog should be present', () => {
+    render(<NodeHealth />, { wrapper: MockedProvider });
+    expect(
+      screen.getByRole('link', { name: /^Mainnet status & incidents/ })
+    ).toBeInTheDocument();
+  });
+});
+
+describe('NodeUrl', () => {
+  it('renders correct part of node url', () => {
+    const node = 'https://api.n99.somenetwork.vega.xyz';
+
+    render(<NodeUrl url={node} />);
+
+    expect(
+      screen.getByText('api.n99.somenetwork.vega.xyz')
+    ).toBeInTheDocument();
+  });
+});
+
+describe('HealthIndicator', () => {
+  const cases = [
+    {
+      intent: Intent.Success,
+      text: 'Operational',
+      classname: 'bg-vega-green-550',
+    },
+    {
+      intent: Intent.Warning,
+      text: '5 Blocks behind',
+      classname: 'bg-warning',
+    },
+    { intent: Intent.Danger, text: 'Non operational', classname: 'bg-danger' },
+  ];
+  it.each(cases)(
+    'renders correct text and indicator color for $diff block difference',
+    (elem) => {
+      render(<HealthIndicator text={elem.text} intent={elem.intent} />);
+      expect(screen.getByTestId('indicator')).toHaveClass(elem.classname);
+      expect(screen.getByText(elem.text)).toBeInTheDocument();
+    }
+  );
+});

apps/trading/components/footer/footer.tsx

@@ -0,0 +1,119 @@
+import { useCallback } from 'react';
+import {
+  useEnvironment,
+  useNodeHealth,
+  useNodeSwitcherStore,
+} from '@vegaprotocol/environment';
+import { t } from '@vegaprotocol/i18n';
+import type { Intent } from '@vegaprotocol/ui-toolkit';
+import { Indicator, ExternalLink } from '@vegaprotocol/ui-toolkit';
+import classNames from 'classnames';
+import type { ButtonHTMLAttributes, ReactNode } from 'react';
+
+export const Footer = () => {
+  return (
+    <footer className="px-4 py-1 text-xs border-t border-default text-vega-light-300 dark:text-vega-dark-300 lg:fixed bottom-0 left-0 border-r bg-white dark:bg-black">
+      {/* Pull left to align with top nav, due to button padding */}
+      <div className="-ml-2">
+        <NodeHealth />
+      </div>
+    </footer>
+  );
+};
+
+export const NodeHealth = () => {
+  const { VEGA_URL, VEGA_INCIDENT_URL } = useEnvironment();
+  const setNodeSwitcher = useNodeSwitcherStore((store) => store.setDialogOpen);
+  const { datanodeBlockHeight, text, intent } = useNodeHealth();
+  const onClick = useCallback(() => {
+    setNodeSwitcher(true);
+  }, [setNodeSwitcher]);
+  const incidentsLink = VEGA_INCIDENT_URL && (
+    <ExternalLink className="ml-1" href={VEGA_INCIDENT_URL}>
+      {t('Mainnet status & incidents')}
+    </ExternalLink>
+  );
+  return (
+    <>
+      {VEGA_URL && (
+        <FooterButton onClick={onClick} data-testid="node-health">
+          <FooterButtonPart>
+            <HealthIndicator text={text} intent={intent} />
+          </FooterButtonPart>
+          <FooterButtonPart>
+            <NodeUrl url={VEGA_URL} />
+          </FooterButtonPart>
+          {/* create a monospace effect - avoiding jumps of width */}
+          <FooterButtonPart
+            width={`${
+              datanodeBlockHeight
+                ? String(datanodeBlockHeight).length + 'ch'
+                : 'auto'
+            }`}
+          >
+            <span title={t('Block height')}>{datanodeBlockHeight}</span>
+          </FooterButtonPart>
+        </FooterButton>
+      )}
+      {incidentsLink}
+    </>
+  );
+};
+
+interface NodeUrlProps {
+  url: string;
+}
+
+export const NodeUrl = ({ url }: NodeUrlProps) => {
+  const urlObj = new URL(url);
+  const nodeUrl = urlObj.hostname;
+  return <span title={t('Connected node')}>{nodeUrl}</span>;
+};
+
+interface HealthIndicatorProps {
+  text: string;
+  intent: Intent;
+}
+
+export const HealthIndicator = ({ text, intent }: HealthIndicatorProps) => {
+  return (
+    <span title={t('Node health')}>
+      <Indicator variant={intent} />
+      {text}
+    </span>
+  );
+};
+
+type FooterButtonProps = ButtonHTMLAttributes<HTMLButtonElement>;
+
+const FooterButton = (props: FooterButtonProps) => {
+  const buttonClasses = classNames(
+    'px-2 py-0.5 rounded-md',
+    'enabled:hover:bg-vega-light-150',
+    'dark:enabled:hover:bg-vega-dark-150'
+  );
+  return <button {...props} className={buttonClasses} />;
+};
+
+const FooterButtonPart = ({
+  width = 'auto',
+  children,
+}: {
+  children: ReactNode;
+  width?: string;
+}) => {
+  return (
+    <span
+      style={{ width }}
+      className={classNames(
+        'relative inline-block mr-2 last:mr-0 pr-2 last:pr-0',
+        'last:after:hidden',
+        'after:content after:absolute after:right-0 after:top-1/2 after:-translate-y-1/2',
+        'after:h-3 after:w-1 after:border-r',
+        'after:border-vega-light-300 dark:after:border-vega-dark-300'
+      )}
+    >
+      {children}
+    </span>
+  );
+};

apps/trading/components/footer/index.ts

@@ -0,0 +1 @@
+export * from './footer';

apps/trading/components/header/header.tsx

@@ -1,30 +1,28 @@
 import { Tooltip } from '@vegaprotocol/ui-toolkit';
-import classNames from 'classnames';
+import type { ReactElement, ReactNode } from 'react';
-import type { ReactNode } from 'react';
+import { Children } from 'react';
+import { cloneElement } from 'react';
 
 interface TradeMarketHeaderProps {
   title: ReactNode;
-  children: ReactNode;
+  children: Array<ReactElement | null>;
 }
 
 export const Header = ({ title, children }: TradeMarketHeaderProps) => {
-  const headerClasses = classNames(
-    'grid',
-    'grid-rows-[min-content_min-content]',
-    'xl:grid-cols-[min-content_1fr]',
-    'lg:border-x border-b border-default',
-    'bg-vega-clight-800 dark:bg-vega-cdark-800'
-  );
   return (
-    <header className="lg:px-1">
+    <header className="w-screen xl:px-4 pt-2 border-b border-default">
-      <div className={headerClasses}>
+      <div className="xl:flex xl:gap-4 items-end">
-        <div className="flex flex-col justify-center items-start pl-3 lg:pl-4 pt-2 xl:pb-2 pb-0">
+        <div className="px-4 xl:px-0 pb-2 xl:pb-3">{title}</div>
-          {title}
+        <div
-        </div>
+          data-testid="header-summary"
-        <div data-testid="header-summary" className="min-w-0">
+          className="flex flex-nowrap items-end xl:flex-1 w-full overflow-x-auto text-xs"
-          <div className="px-3 lg:px-4 py-2 flex flex-nowrap gap-4 items-center text-xs overflow-x-auto">
+        >
-            {children}
+          {Children.map(children, (child, index) => {
-          </div>
+            if (!child) return null;
+            return cloneElement(child, {
+              id: `header-stat-${index}`,
+            });
+          })}
         </div>
       </div>
     </header>
@@ -44,11 +42,9 @@ export const HeaderStat = ({
   description?: string | ReactNode;
   testId?: string;
 }) => {
-  const itemClass = classNames(
+  const itemClass =
-    'text-muted',
+    'min-w-min w-[120px] whitespace-nowrap pb-3 px-4 border-l border-default first:border-none text-neutral-500 dark:text-neutral-400';
-    'min-w-min last:pr-0 whitespace-nowrap'
+  const itemHeading = 'text-black dark:text-white';
-  );
-  const itemValueClasses = 'text-default';
 
   return (
     <div data-testid={testId} className={itemClass}>
@@ -59,7 +55,7 @@ export const HeaderStat = ({
         <div
           data-testid="item-value"
           aria-labelledby={id}
-          className={itemValueClasses}
+          className={itemHeading}
         >
           {children}
         </div>
@@ -68,13 +64,21 @@ export const HeaderStat = ({
   );
 };
 
-export const HeaderTitle = ({ children }: { children: ReactNode }) => {
+export const HeaderTitle = ({
+  primaryContent,
+  secondaryContent,
+}: {
+  primaryContent: ReactNode;
+  secondaryContent: ReactNode;
+}) => {
   return (
-    <h1
+    <div className="text-left" data-testid="header-title">
-      data-testid="header-title"
+      <div className="text-sm md:text-md lg:text-lg whitespace-nowrap !leading-[1]">
-      className="flex gap-4 items-center text-lg whitespace-nowrap xl:pr-4 xl:border-r border-default"
+        {primaryContent}
-    >
+      </div>
-      {children}
+      <div className="text-xs whitespace-nowrap text-vega-light-300 dark:text-vega-dark-300">
-    </h1>
+        {secondaryContent}
+      </div>
+    </div>
   );
 };

apps/trading/components/layouts/index.ts

@@ -1 +0,0 @@
-export * from './layout-with-sidebar';

apps/trading/components/layouts/layout-with-sidebar.tsx

@@ -1,38 +0,0 @@
-import { Outlet } from 'react-router-dom';
-import { Sidebar, SidebarContent, useSidebar } from '../sidebar';
-import classNames from 'classnames';
-
-export const LayoutWithSidebar = () => {
-  const sidebarView = useSidebar((store) => store.view);
-  const sidebarOpen = sidebarView !== null;
-
-  const gridClasses = classNames(
-    'h-full relative z-0 grid',
-    'grid-cols-[1fr_45px]',
-    'lg:grid-cols-[1fr_350px_45px]'
-  );
-
-  return (
-    <div className={gridClasses}>
-      <section
-        className={classNames('col-start-1 col-end-1', {
-          'lg:col-end-3': !sidebarOpen,
-          'hidden lg:block lg:col-end-2': sidebarOpen,
-        })}
-      >
-        <Outlet />
-      </section>
-      <div
-        // min-h-0 is needed as this element is part of a grid, we want the content to be scrollable, without it it will push the grid element taller
-        className={classNames('col-start-1 lg:col-start-2 min-h-0', {
-          hidden: !sidebarOpen,
-        })}
-      >
-        <SidebarContent />
-      </div>
-      <div className="col-start-2 lg:col-start-3 bg-vega-clight-800 dark:bg-vega-cdark-800 border-l border-default">
-        <Sidebar />
-      </div>
-    </div>
-  );
-};

apps/trading/components/liquidity-supplied/liquidity-supplied.tsx

@@ -156,7 +156,8 @@ export const MarketLiquiditySupplied = ({
       description={description}
       testId="liquidity-supplied"
     >
-      <Indicator variant={status} /> {supplied} (
+      <Indicator variant={status} />
+      {supplied} (
       {percentage.gt(100) ? '>100%' : formatNumberPercentage(percentage, 2)})
     </HeaderStat>
   ) : (

apps/trading/components/navbar/navbar.tsx

@@ -24,6 +24,7 @@ import {
 } from '@vegaprotocol/ui-toolkit';
 
 import { Links, Routes } from '../../pages/client-router';
+import { SettingsButton } from '../../client-pages/settings';
 import {
   ProtocolUpgradeCountdown,
   ProtocolUpgradeCountdownMode,
@@ -44,13 +45,14 @@ export const Navbar = ({
 
   return (
     <Navigation
-      appName="console"
+      appName="Console"
       theme={theme}
       actions={
         <>
           <ProtocolUpgradeCountdown
             mode={ProtocolUpgradeCountdownMode.IN_ESTIMATED_TIME_REMAINING}
           />
+          <SettingsButton />
           <VegaWalletConnectButton />
         </>
       }
@@ -118,6 +120,18 @@ export const Navbar = ({
           </NavigationItem>
         )}
       </NavigationList>
+      <NavigationList
+        className="[.drawer-content_&]:border-t [.drawer-content_&]:border-t-vega-light-200 dark:[.drawer-content_&]:border-t-vega-dark-200 [.drawer-content_&]:pt-4 [.drawer-content_&]:mt-4"
+        hide={[
+          NavigationBreakpoint.Small,
+          NavigationBreakpoint.Narrow,
+          NavigationBreakpoint.Full,
+        ]}
+      >
+        <NavigationItem className="[.drawer-content_&]:w-full">
+          <SettingsButton withMobile />
+        </NavigationItem>
+      </NavigationList>
     </Navigation>
   );
 };

apps/trading/components/node-health/index.ts

@@ -1 +0,0 @@
-export * from './node-health';

apps/trading/components/node-health/node-health.spec.tsx

@@ -1,62 +0,0 @@
-import { render, screen, waitFor, within } from '@testing-library/react';
-import userEvent from '@testing-library/user-event';
-import { NodeHealthContainer, NodeUrl } from './node-health';
-import { MockedProvider } from '@apollo/client/testing';
-
-const mockSetNodeSwitcher = jest.fn();
-
-jest.mock('@vegaprotocol/environment', () => ({
-  ...jest.requireActual('@vegaprotocol/environment'),
-  useEnvironment: jest.fn().mockImplementation(() => ({
-    VEGA_URL: 'https://vega-url.wtf',
-    VEGA_INCIDENT_URL: 'https://blog.vega.community',
-  })),
-  useNodeSwitcherStore: jest.fn(() => mockSetNodeSwitcher),
-}));
-
-describe('NodeHealthContainer', () => {
-  it('controls the node switcher dialog', async () => {
-    render(<NodeHealthContainer />, { wrapper: MockedProvider });
-    await waitFor(() => {
-      expect(screen.getByRole('button')).toBeInTheDocument();
-    });
-    await userEvent.click(screen.getByRole('button'));
-    expect(mockSetNodeSwitcher).toHaveBeenCalled();
-  });
-
-  it('Shows node health data on hover', async () => {
-    render(<NodeHealthContainer />, { wrapper: MockedProvider });
-    await waitFor(() => {
-      expect(screen.getByRole('button')).toBeInTheDocument();
-    });
-    await userEvent.hover(screen.getByRole('button'));
-    await waitFor(() => {
-      const portal = within(
-        document.querySelector(
-          '[data-radix-popper-content-wrapper]'
-        ) as HTMLElement
-      );
-      // two tooltips get rendered, I believe for animation purposes
-      const tooltip = within(portal.getAllByTestId('tooltip-content')[0]);
-      expect(
-        tooltip.getByRole('link', { name: /^Mainnet status & incidents/ })
-      ).toBeInTheDocument();
-      expect(tooltip.getByText('Non operational')).toBeInTheDocument();
-      expect(tooltip.getByTitle('Connected node')).toHaveTextContent(
-        'vega-url.wtf'
-      );
-    });
-  });
-});
-
-describe('NodeUrl', () => {
-  it('renders correct part of node url', () => {
-    const node = 'https://api.n99.somenetwork.vega.xyz';
-
-    render(<NodeUrl url={node} />);
-
-    expect(
-      screen.getByText('api.n99.somenetwork.vega.xyz')
-    ).toBeInTheDocument();
-  });
-});

apps/trading/components/node-health/node-health.tsx

@@ -1,62 +0,0 @@
-import {
-  useEnvironment,
-  useNodeHealth,
-  useNodeSwitcherStore,
-} from '@vegaprotocol/environment';
-import { t } from '@vegaprotocol/i18n';
-import { Indicator, ExternalLink } from '@vegaprotocol/ui-toolkit';
-import { Tooltip } from '../../components/tooltip';
-
-export const NodeHealthContainer = () => {
-  const { VEGA_URL, VEGA_INCIDENT_URL } = useEnvironment();
-  const setNodeSwitcher = useNodeSwitcherStore((store) => store.setDialogOpen);
-  const { text, intent, datanodeBlockHeight } = useNodeHealth();
-
-  return (
-    <Tooltip
-      description={
-        <div
-          className="flex flex-col gap-2 p-4 text-sm"
-          data-testid="node-health"
-        >
-          <div className="flex items-center gap-2">
-            <Indicator variant={intent} />
-            <p>{text}</p>
-            <p>{datanodeBlockHeight}</p>
-          </div>
-          {VEGA_URL && (
-            <p>
-              <NodeUrl url={VEGA_URL} />
-            </p>
-          )}
-          {VEGA_INCIDENT_URL && (
-            <ExternalLink href={VEGA_INCIDENT_URL}>
-              {t('Mainnet status & incidents')}
-            </ExternalLink>
-          )}
-        </div>
-      }
-      align="end"
-      side="right"
-      sideOffset={10}
-    >
-      <button
-        className="flex justify-center items-center p-2 rounded hover:bg-vega-light-200 hover:dark:bg-vega-dark-200"
-        onClick={() => setNodeSwitcher(true)}
-        data-testid="node-health-trigger"
-      >
-        <Indicator variant={intent} size="lg" />
-      </button>
-    </Tooltip>
-  );
-};
-
-interface NodeUrlProps {
-  url: string;
-}
-
-export const NodeUrl = ({ url }: NodeUrlProps) => {
-  const urlObj = new URL(url);
-  const nodeUrl = urlObj.hostname;
-  return <span title={t('Connected node')}>{nodeUrl}</span>;
-};

apps/trading/components/settings/index.ts

@@ -1 +0,0 @@
-export * from './settings';

apps/trading/components/settings/settings.tsx

@@ -1,56 +0,0 @@
-import { t } from '@vegaprotocol/i18n';
-import { Switch, ToastPositionSetter } from '@vegaprotocol/ui-toolkit';
-import { useThemeSwitcher } from '@vegaprotocol/react-helpers';
-import { useTelemetryApproval } from '../../lib/hooks/use-telemetry-approval';
-import type { ReactNode } from 'react';
-
-export const Settings = () => {
-  const { theme, setTheme } = useThemeSwitcher();
-  const [isApproved, setIsApproved] = useTelemetryApproval();
-  return (
-    <div>
-      <SettingsGroup label={t('Dark mode')}>
-        <Switch
-          name="settings-theme-switch"
-          onCheckedChange={() => setTheme()}
-          checked={theme === 'dark'}
-        />
-      </SettingsGroup>
-      <SettingsGroup
-        label={t('Share usage data')}
-        helpText={t(
-          'Help identify bugs and improve the service by sharing anonymous usage data.'
-        )}
-      >
-        <Switch
-          name="settings-telemetry-switch"
-          onCheckedChange={(isOn) => setIsApproved(isOn)}
-          checked={isApproved}
-        />
-      </SettingsGroup>
-      <SettingsGroup label={t('Toast location')}>
-        <ToastPositionSetter />
-      </SettingsGroup>
-    </div>
-  );
-};
-
-const SettingsGroup = ({
-  label,
-  helpText,
-  children,
-}: {
-  label: string;
-  helpText?: string;
-  children: ReactNode;
-}) => {
-  return (
-    <div className="flex justify-between items-start mb-4">
-      <div className="w-3/4">
-        <label className="text-sm">{label}</label>
-        {helpText && <p className="text-muted text-xs">{helpText}</p>}
-      </div>
-      {children}
-    </div>
-  );
-};

apps/trading/components/sidebar/index.ts

@@ -1 +0,0 @@
-export * from './sidebar';

apps/trading/components/sidebar/sidebar.spec.tsx

@@ -1,139 +0,0 @@
-import { act, render, screen } from '@testing-library/react';
-import userEvent from '@testing-library/user-event';
-import { Sidebar, SidebarContent, ViewType, useSidebar } from './sidebar';
-import { MemoryRouter, Route, Routes } from 'react-router-dom';
-
-jest.mock('../node-health', () => ({
-  NodeHealthContainer: () => <span data-testid="node-health" />,
-}));
-
-jest.mock('@vegaprotocol/accounts', () => ({
-  TransferContainer: () => <div data-testid="transfer" />,
-}));
-
-jest.mock('@vegaprotocol/deposits', () => ({
-  DepositContainer: () => <div data-testid="deposit" />,
-}));
-
-jest.mock('../settings', () => ({
-  Settings: () => <div data-testid="settings" />,
-}));
-
-describe('Sidebar', () => {
-  it.each(['/markets/all', '/portfolio'])(
-    'does not render ticket and info',
-    (path) => {
-      render(
-        <MemoryRouter initialEntries={[path]}>
-          <Sidebar />
-        </MemoryRouter>
-      );
-
-      expect(screen.getByTestId(ViewType.Settings)).toBeInTheDocument();
-      expect(screen.getByTestId(ViewType.Transfer)).toBeInTheDocument();
-      expect(screen.getByTestId(ViewType.Deposit)).toBeInTheDocument();
-      expect(screen.getByTestId(ViewType.Withdraw)).toBeInTheDocument();
-      expect(screen.getByTestId('node-health')).toBeInTheDocument();
-
-      // no order or info sidebars
-      expect(screen.queryByTestId(ViewType.Order)).not.toBeInTheDocument();
-      expect(screen.queryByTestId(ViewType.Info)).not.toBeInTheDocument();
-    }
-  );
-
-  it('renders ticket and info on market pages', () => {
-    render(
-      <MemoryRouter initialEntries={['/markets/ABC']}>
-        <Sidebar />
-      </MemoryRouter>
-    );
-
-    expect(screen.getByTestId(ViewType.Settings)).toBeInTheDocument();
-    expect(screen.getByTestId(ViewType.Transfer)).toBeInTheDocument();
-    expect(screen.getByTestId(ViewType.Deposit)).toBeInTheDocument();
-    expect(screen.getByTestId(ViewType.Withdraw)).toBeInTheDocument();
-    expect(screen.getByTestId('node-health')).toBeInTheDocument();
-
-    // order and info sidebars are shown
-    expect(screen.getByTestId(ViewType.Order)).toBeInTheDocument();
-    expect(screen.getByTestId(ViewType.Info)).toBeInTheDocument();
-  });
-
-  it('renders selected state', async () => {
-    render(
-      <MemoryRouter initialEntries={['/markets/ABC']}>
-        <Sidebar />
-      </MemoryRouter>
-    );
-
-    const settingsButton = screen.getByTestId(ViewType.Settings);
-    const orderButton = screen.getByTestId(ViewType.Order);
-
-    // select settings first
-    await userEvent.click(settingsButton);
-    expect(settingsButton).toHaveClass('bg-vega-yellow text-black');
-
-    // switch to order
-    await userEvent.click(orderButton);
-    expect(settingsButton).not.toHaveClass('bg-vega-yellow text-black');
-    expect(orderButton).toHaveClass('bg-vega-yellow text-black');
-
-    // close order
-    await userEvent.click(orderButton);
-    expect(orderButton).not.toHaveClass('bg-vega-yellow text-black');
-  });
-});
-
-describe('SidebarContent', () => {
-  it('renders the correct content', () => {
-    const { container } = render(
-      <MemoryRouter initialEntries={['/markets/ABC']}>
-        <Routes>
-          <Route path="/markets/:marketId" element={<SidebarContent />} />
-        </Routes>
-      </MemoryRouter>
-    );
-
-    expect(container).toBeEmptyDOMElement();
-
-    act(() => {
-      useSidebar.setState({ view: { type: ViewType.Transfer } });
-    });
-
-    expect(screen.getByTestId('transfer')).toBeInTheDocument();
-
-    act(() => {
-      useSidebar.setState({ view: { type: ViewType.Deposit } });
-    });
-
-    expect(screen.getByTestId('deposit')).toBeInTheDocument();
-  });
-
-  it('closes sidebar if market id is required but not present', () => {
-    const { container } = render(
-      <MemoryRouter initialEntries={['/portfolio']}>
-        <Routes>
-          <Route path="/portfolio" element={<SidebarContent />} />
-        </Routes>
-      </MemoryRouter>
-    );
-
-    act(() => {
-      useSidebar.setState({ view: { type: ViewType.Order } });
-    });
-
-    expect(container).toBeEmptyDOMElement();
-
-    act(() => {
-      useSidebar.setState({ view: { type: ViewType.Settings } });
-    });
-
-    expect(screen.getByTestId('settings')).toBeInTheDocument();
-
-    act(() => {
-      useSidebar.setState({ view: { type: ViewType.Info } });
-    });
-
-    expect(container).toBeEmptyDOMElement();
-  });
-});

apps/trading/components/sidebar/sidebar.tsx

@@ -1,290 +0,0 @@
-import classNames from 'classnames';
-import type { ReactNode } from 'react';
-import { useEffect } from 'react';
-import { Route, Routes, useParams } from 'react-router-dom';
-import { create } from 'zustand';
-import { TransferContainer } from '@vegaprotocol/accounts';
-import { DealTicketContainer } from '@vegaprotocol/deal-ticket';
-import { DepositContainer } from '@vegaprotocol/deposits';
-import { t } from '@vegaprotocol/i18n';
-import { MarketInfoAccordionContainer } from '@vegaprotocol/markets';
-import { TinyScroll, VegaIcon, VegaIconNames } from '@vegaprotocol/ui-toolkit';
-import { NodeHealthContainer } from '../node-health';
-import { Settings } from '../settings';
-import { Tooltip } from '../../components/tooltip';
-import { WithdrawContainer } from '../withdraw-container';
-import { Routes as AppRoutes } from '../../pages/client-router';
-import { persist } from 'zustand/middleware';
-
-const STORAGE_KEY = 'vega_sidebar_store';
-
-export enum ViewType {
-  Order = 'Order',
-  Info = 'Info',
-  Deposit = 'Deposit',
-  Withdraw = 'Withdraw',
-  Transfer = 'Transfer',
-  Settings = 'Settings',
-}
-
-type SidebarView =
-  | {
-      type: ViewType.Deposit;
-      assetId?: string;
-    }
-  | {
-      type: ViewType.Withdraw;
-      assetId?: string;
-    }
-  | {
-      type: ViewType.Transfer;
-      assetId?: string;
-    }
-  | {
-      type: ViewType.Order;
-    }
-  | {
-      type: ViewType.Info;
-    }
-  | {
-      type: ViewType.Settings;
-    };
-
-export const Sidebar = () => {
-  return (
-    <div className="flex flex-col gap-2 h-full py-1" data-testid="sidebar">
-      <nav className="flex flex-col items-center gap-4 p-1">
-        {/* sidebar options that always show */}
-        <SidebarButton
-          view={ViewType.Deposit}
-          icon={VegaIconNames.DEPOSIT}
-          tooltip={t('Deposit')}
-        />
-        <SidebarButton
-          view={ViewType.Withdraw}
-          icon={VegaIconNames.WITHDRAW}
-          tooltip={t('Withdraw')}
-        />
-        <SidebarButton
-          view={ViewType.Transfer}
-          icon={VegaIconNames.TRANSFER}
-          tooltip={t('Transfer')}
-        />
-        {/* buttons for specific routes */}
-        <Routes>
-          <Route
-            path={AppRoutes.MARKETS}
-            // render nothing for markets/all, otherwise markets/:marketId will match with markets/all
-            element={null}
-          />
-          <Route
-            // render nothing for portfolio
-            path={AppRoutes.PORTFOLIO}
-            element={null}
-          />
-          <Route
-            path={AppRoutes.MARKET}
-            element={
-              <>
-                <SidebarDivider />
-                <SidebarButton
-                  view={ViewType.Order}
-                  icon={VegaIconNames.TICKET}
-                  tooltip={t('Order')}
-                />
-                <SidebarButton
-                  view={ViewType.Info}
-                  icon={VegaIconNames.BREAKDOWN}
-                  tooltip={t('Market specification')}
-                />
-              </>
-            }
-          />
-        </Routes>
-      </nav>
-      <nav className="mt-auto flex flex-col items-center gap-4 p-1">
-        <SidebarButton
-          view={ViewType.Settings}
-          icon={VegaIconNames.COG}
-          tooltip={t('Settings')}
-        />
-        <NodeHealthContainer />
-      </nav>
-    </div>
-  );
-};
-
-const SidebarButton = ({
-  view,
-  icon,
-  tooltip,
-}: {
-  view: ViewType;
-  icon: VegaIconNames;
-  tooltip: string;
-}) => {
-  const { currView, setView } = useSidebar((store) => ({
-    currView: store.view,
-    setView: store.setView,
-  }));
-  const buttonClasses = classNames('flex items-center p-1 rounded', {
-    'text-vega-clight-200 dark:text-vega-cdark-200 hover:bg-vega-clight-500 dark:hover:bg-vega-cdark-500':
-      view !== currView?.type,
-    'bg-vega-yellow hover:bg-vega-yellow-550 text-black':
-      view === currView?.type,
-  });
-  return (
-    <Tooltip
-      description={tooltip}
-      align="center"
-      side="right"
-      sideOffset={10}
-      delayDuration={0}
-    >
-      <button
-        className={buttonClasses}
-        data-testid={view}
-        onClick={() => {
-          if (view === currView?.type) {
-            setView(null);
-          } else {
-            setView({ type: view });
-          }
-        }}
-      >
-        <VegaIcon name={icon} size={20} />
-      </button>
-    </Tooltip>
-  );
-};
-
-const SidebarDivider = () => {
-  return (
-    <div
-      className="bg-vega-clight-600 dark:bg-vega-cdark-600 w-4 h-px"
-      role="separator"
-    />
-  );
-};
-
-export const SidebarContent = () => {
-  const params = useParams();
-  const { view, setView } = useSidebar();
-
-  if (!view) return null;
-
-  if (view.type === ViewType.Order) {
-    if (params.marketId) {
-      return (
-        <ContentWrapper>
-          <DealTicketContainer
-            marketId={params.marketId}
-            onDeposit={(assetId) =>
-              setView({ type: ViewType.Deposit, assetId })
-            }
-          />
-        </ContentWrapper>
-      );
-    } else {
-      return <CloseSidebar />;
-    }
-  }
-
-  if (view.type === ViewType.Info) {
-    if (params.marketId) {
-      return (
-        <ContentWrapper>
-          <MarketInfoAccordionContainer marketId={params.marketId} />
-        </ContentWrapper>
-      );
-    } else {
-      return <CloseSidebar />;
-    }
-  }
-
-  if (view.type === ViewType.Deposit) {
-    return (
-      <ContentWrapper title={t('Deposit')}>
-        <DepositContainer assetId={view.assetId} />
-      </ContentWrapper>
-    );
-  }
-
-  if (view.type === ViewType.Withdraw) {
-    return (
-      <ContentWrapper title={t('Withdraw')}>
-        <WithdrawContainer assetId={view.assetId} />
-      </ContentWrapper>
-    );
-  }
-
-  if (view.type === ViewType.Transfer) {
-    return (
-      <ContentWrapper title={t('Transfer')}>
-        <TransferContainer assetId={view.assetId} />
-      </ContentWrapper>
-    );
-  }
-
-  if (view.type === ViewType.Settings) {
-    return (
-      <ContentWrapper title={t('Settings')}>
-        <Settings />
-      </ContentWrapper>
-    );
-  }
-
-  throw new Error('invalid sidebar');
-};
-
-const ContentWrapper = ({
-  children,
-  title,
-}: {
-  children: ReactNode;
-  title?: string;
-}) => {
-  return (
-    <TinyScroll
-      className="h-full overflow-auto py-4 pl-3 pr-4"
-      // panes have p-1, since sidebar is on the right make pl less to account for additional pane space
-      data-testid="sidebar-content"
-    >
-      {title && <h2 className="mb-4">{title}</h2>}
-      {children}
-    </TinyScroll>
-  );
-};
-
-/** If rendered will close sidebar */
-const CloseSidebar = () => {
-  const setView = useSidebar((store) => store.setView);
-  useEffect(() => {
-    setView(null);
-  }, [setView]);
-  return null;
-};
-
-export const useSidebar = create<{
-  init: boolean;
-  view: SidebarView | null;
-  setView: (view: SidebarView | null) => void;
-}>()(
-  persist(
-    (set) => ({
-      init: true,
-      view: null,
-      setView: (x) =>
-        set(() => {
-          if (x === null) {
-            return { view: null, init: false };
-          }
-
-          return { view: x, init: false };
-        }),
-    }),
-    {
-      name: STORAGE_KEY,
-    }
-  )
-);

apps/trading/components/tooltip/index.ts

@@ -1 +0,0 @@
-export * from './tooltip';

apps/trading/components/tooltip/tooltip.tsx

@@ -1,72 +0,0 @@
-import type { ReactNode } from 'react';
-import React from 'react';
-import {
-  Provider,
-  Root,
-  Trigger,
-  Content,
-  Portal,
-  Arrow,
-} from '@radix-ui/react-tooltip';
-import type { ITooltipParams } from 'ag-grid-community';
-
-const tooltipContentClasses =
-  'max-w-sm bg-vega-clight-500 dark:bg-vega-cdark-500 px-2 py-1 z-20 rounded text-default break-word';
-export interface TooltipProps {
-  children: React.ReactElement;
-  description?: string | ReactNode;
-  open?: boolean;
-  align?: 'start' | 'center' | 'end';
-  side?: 'top' | 'right' | 'bottom' | 'left';
-  sideOffset?: number;
-  delayDuration?: number;
-}
-
-// Conditionally rendered tooltip if description content is provided.
-export const Tooltip = ({
-  children,
-  description,
-  open,
-  sideOffset,
-  align = 'start',
-  side = 'bottom',
-  delayDuration = 200,
-}: TooltipProps) =>
-  description ? (
-    <Provider delayDuration={delayDuration} skipDelayDuration={100}>
-      <Root open={open}>
-        <Trigger
-          asChild
-          className="underline underline-offset-2 decoration-neutral-400 dark:decoration-neutral-400 decoration-dashed"
-        >
-          {children}
-        </Trigger>
-        {description && (
-          <Portal>
-            <Content
-              align={align}
-              side={side}
-              alignOffset={8}
-              className={tooltipContentClasses}
-              sideOffset={sideOffset}
-            >
-              <div className="relative z-0" data-testid="tooltip-content">
-                {description}
-              </div>
-              <Arrow
-                width={16}
-                height={8}
-                className="fill-vega-clight-500 dark:fill-vega-cdark-500"
-              />
-            </Content>
-          </Portal>
-        )}
-      </Root>
-    </Provider>
-  ) : (
-    children
-  );
-
-export const TooltipCellComponent = (props: ITooltipParams) => {
-  return <p className={tooltipContentClasses}>{props.value}</p>;
-};

apps/trading/components/vega-wallet-connect-button/vega-wallet-connect-button.tsx

@@ -21,8 +21,8 @@ import type { PubKey } from '@vegaprotocol/wallet';
 import { useVegaWallet, useVegaWalletDialogStore } from '@vegaprotocol/wallet';
 import { Networks, useEnvironment } from '@vegaprotocol/environment';
 import { WalletIcon } from '../icons/wallet';
+import { useTransferDialog } from '@vegaprotocol/accounts';
 import { useCopyTimeout } from '@vegaprotocol/react-helpers';
-import { ViewType, useSidebar } from '../sidebar';
 
 const MobileWalletButton = ({
   isConnected,
@@ -35,7 +35,7 @@ const MobileWalletButton = ({
   const openVegaWalletDialog = useVegaWalletDialogStore(
     (store) => store.openVegaWalletDialog
   );
-  const setView = useSidebar((store) => store.setView);
+  const openTransferDialog = useTransferDialog((store) => store.open);
   const { VEGA_ENV } = useEnvironment();
   const isYellow = VEGA_ENV === Networks.TESTNET;
   const [drawerOpen, setDrawerOpen] = useState(false);
@@ -128,7 +128,7 @@ const MobileWalletButton = ({
             <Button
               onClick={() => {
                 setDrawerOpen(false);
-                setView({ type: ViewType.Transfer });
+                openTransferDialog(true);
               }}
               fill
             >
@@ -149,7 +149,7 @@ export const VegaWalletConnectButton = () => {
   const openVegaWalletDialog = useVegaWalletDialogStore(
     (store) => store.openVegaWalletDialog
   );
-  const setView = useSidebar((store) => store.setView);
+  const openTransferDialog = useTransferDialog((store) => store.open);
   const {
     pubKey,
     pubKeys,
@@ -190,10 +190,9 @@ export const VegaWalletConnectButton = () => {
           >
             <DropdownMenuContent
               onInteractOutside={() => setDropdownOpen(false)}
-              sideOffset={17}
+              sideOffset={20}
               side="bottom"
               align="end"
-              onEscapeKeyDown={() => setDropdownOpen(false)}
             >
               <div className="min-w-[340px]" data-testid="keypair-list">
                 <DropdownMenuRadioGroup
@@ -210,10 +209,7 @@ export const VegaWalletConnectButton = () => {
                 {!isReadOnly && (
                   <DropdownMenuItem
                     data-testid="wallet-transfer"
-                    onClick={() => {
+                    onClick={() => openTransferDialog(true)}
-                      setView({ type: ViewType.Transfer });
-                      setDropdownOpen(false);
-                    }}
                   >
                     {t('Transfer')}
                   </DropdownMenuItem>
@@ -267,7 +263,9 @@ const KeypairItem = ({ pk }: { pk: PubKey }) => {
               <VegaIcon name={VegaIconNames.COPY} />
             </button>
           </CopyToClipboard>
-          {copied && <span className="text-xs">{t('Copied')}</span>}
+          {copied && (
+            <span className="text-xs text-neutral-500">{t('Copied')}</span>
+          )}
         </span>
       </div>
       <DropdownMenuItemIndicator />
@@ -308,7 +306,9 @@ const KeypairListItem = ({
             <VegaIcon name={VegaIconNames.COPY} />
           </button>
         </CopyToClipboard>
-        {copied && <span className="text-xs">{t('Copied')}</span>}
+        {copied && (
+          <span className="text-xs text-neutral-500">{t('Copied')}</span>
+        )}
       </span>
     </div>
   );

apps/trading/components/welcome-dialog/proposed-markets.tsx

@@ -44,7 +44,7 @@ export const ProposedMarkets = () => {
   const tokenLink = useLinks(DApp.Token);
   return useMemo(
     () => (
-      <div className="mt-7 pt-8 border-t border-default">
+      <div className="mt-7 pt-8 border-t border-neutral-700">
         {newMarkets.length > 0 ? (
           <>
             <h2 className="font-alpha uppercase text-2xl">

apps/trading/components/welcome-dialog/risk-message.tsx

@@ -1,7 +1,10 @@
 import { t } from '@vegaprotocol/i18n';
-import { VegaIcon, VegaIconNames } from '@vegaprotocol/ui-toolkit';
+import {
-import { Routes } from '../../pages/client-router';
+  ExternalLink,
-import { Link } from 'react-router-dom';
+  VegaIcon,
+  VegaIconNames,
+} from '@vegaprotocol/ui-toolkit';
+import { Links, Routes } from '../../pages/client-router';
 
 export const RiskMessage = () => {
   return (
@@ -27,12 +30,15 @@ export const RiskMessage = () => {
         {t(
           'By using the Vega Console, you acknowledge that you have read and understood the'
         )}{' '}
-        <Link className="underline" to={Routes.DISCLAIMER} target="_blank">
+        <ExternalLink
+          href={`/#/${Links[Routes.DISCLAIMER]()}`}
+          className="underline"
+        >
           <span className="flex items-center gap-1">
             <span>{t('Vega Console Disclaimer')}</span>
             <VegaIcon name={VegaIconNames.OPEN_EXTERNAL} />
           </span>
-        </Link>
+        </ExternalLink>
       </p>
     </>
   );

apps/trading/components/withdraw-container/index.ts

@@ -1 +0,0 @@
-export * from './withdraw-container';

apps/trading/components/withdraw-container/withdraw-container.tsx

@@ -1,27 +0,0 @@
-import { useVegaWallet } from '@vegaprotocol/wallet';
-import { WithdrawFormContainer } from '@vegaprotocol/withdraws';
-import { useVegaTransactionStore } from '@vegaprotocol/wallet';
-
-export const WithdrawContainer = ({ assetId }: { assetId?: string }) => {
-  const { pubKey } = useVegaWallet();
-  const createTransaction = useVegaTransactionStore((state) => state.create);
-  return (
-    <WithdrawFormContainer
-      assetId={assetId}
-      partyId={pubKey ? pubKey : undefined}
-      submit={({ amount, asset, receiverAddress }) => {
-        createTransaction({
-          withdrawSubmission: {
-            amount,
-            asset,
-            ext: {
-              erc20: {
-                receiverAddress,
-              },
-            },
-          },
-        });
-      }}
-    />
-  );
-};

apps/trading/lib/hooks/use-market-click-handler.ts

@@ -7,7 +7,6 @@ export const useMarketClickHandler = (replace = false) => {
   const { marketId } = useParams();
   const { pathname } = useLocation();
   const isMarketPage = pathname.match(/^\/markets\/(.+)/);
-
   return useCallback(
     (selectedId: string, metaKey?: boolean) => {
       const link = Links[Routes.MARKET](selectedId);

apps/trading/pages/_app.page.tsx

@@ -1,4 +1,5 @@
 import { useMemo, useState } from 'react';
+import classNames from 'classnames';
 import Head from 'next/head';
 import type { AppProps } from 'next/app';
 import { t } from '@vegaprotocol/i18n';
@@ -16,6 +17,7 @@ import {
 } from '@vegaprotocol/web3';
 import {
   envTriggerMapping,
+  Networks,
   NodeSwitcherDialog,
   useEnvironment,
   useInitializeEnv,
@@ -23,22 +25,22 @@ import {
 } from '@vegaprotocol/environment';
 import './styles.css';
 import { usePageTitleStore } from '../stores';
+import { Footer } from '../components/footer';
 import DialogsContainer from './dialogs-container';
 import ToastsManager from './toasts-manager';
 import { HashRouter, useLocation, useSearchParams } from 'react-router-dom';
 import { Connectors } from '../lib/vega-connectors';
+import { ViewingBanner } from '../components/viewing-banner';
+import { AnnouncementBanner, UpgradeBanner } from '../components/banner';
 import { AppLoader, DynamicLoader } from '../components/app-loader';
+import { Navbar } from '../components/navbar';
 import { useDataProvider } from '@vegaprotocol/data-provider';
 import { activeOrdersProvider } from '@vegaprotocol/orders';
 import { useTelemetryApproval } from '../lib/hooks/use-telemetry-approval';
-import { AnnouncementBanner, UpgradeBanner } from '../components/banner';
-import { Navbar } from '../components/navbar';
-import classNames from 'classnames';
 import {
   ProtocolUpgradeCountdownMode,
   ProtocolUpgradeProposalNotification,
 } from '@vegaprotocol/proposals';
-import { ViewingBanner } from '../components/viewing-banner';
 
 const DEFAULT_TITLE = t('Welcome to Vega trading!');
 
@@ -74,12 +76,15 @@ const InitializeHandlers = () => {
 
 function AppBody({ Component }: AppProps) {
   const location = useLocation();
+  const { VEGA_ENV } = useEnvironment();
+
   const gridClasses = classNames(
     'h-full relative z-0 grid',
     'grid-rows-[repeat(3,min-content),minmax(0,1fr)]'
   );
+
   return (
-    <div className="h-full overflow-hidden">
+    <div className="h-full dark:bg-black dark:text-white">
       <Head>
         {/* Cannot use meta tags in _document.page.tsx see https://nextjs.org/docs/messages/no-document-viewport-meta */}
         <meta name="viewport" content="width=device-width, initial-scale=1" />
@@ -87,7 +92,7 @@ function AppBody({ Component }: AppProps) {
       <Title />
       <div className={gridClasses}>
         <AnnouncementBanner />
-        <Navbar theme="system" />
+        <Navbar theme={VEGA_ENV === Networks.TESTNET ? 'yellow' : 'dark'} />
         <div data-testid="banners">
           <ProtocolUpgradeProposalNotification
             mode={ProtocolUpgradeCountdownMode.IN_ESTIMATED_TIME_REMAINING}
@@ -98,6 +103,7 @@ function AppBody({ Component }: AppProps) {
         <main data-testid={location.pathname}>
           <Component />
         </main>
+        <Footer />
       </div>
       <DialogsContainer />
       <ToastsManager />

apps/trading/pages/_document.page.tsx

@@ -21,7 +21,7 @@ export default function Document() {
         />
         <script src="/theme-setter.js" type="text/javascript" async />
       </Head>
-      <body className="bg-white dark:bg-vega-cdark-900 text-default font-alpha">
+      <body className="font-alpha dark:bg-black dark:text-white">
         <Main />
         <NextScript />
       </body>

apps/trading/pages/client-router.tsx

@@ -1,11 +1,10 @@
 import { Suspense } from 'react';
 import type { RouteObject } from 'react-router-dom';
-import { Outlet, useRoutes } from 'react-router-dom';
+import { useRoutes } from 'react-router-dom';
 import dynamic from 'next/dynamic';
 import { t } from '@vegaprotocol/i18n';
 import { Loader, Splash } from '@vegaprotocol/ui-toolkit';
 import trimEnd from 'lodash/trimEnd';
-import { LayoutWithSidebar } from '../components/layouts';
 
 const LazyHome = dynamic(() => import('../client-pages/home'), {
   ssr: false,
@@ -27,72 +26,83 @@ const LazyPortfolio = dynamic(() => import('../client-pages/portfolio'), {
   ssr: false,
 });
 
+const LazySettings = dynamic(() => import('../client-pages/settings'), {
+  ssr: false,
+});
+
 const LazyDisclaimer = dynamic(() => import('../client-pages/disclaimer'), {
   ssr: false,
 });
 
 export enum Routes {
   HOME = '/',
-  MARKET = '/markets/:marketId',
+  MARKET = '/markets',
   MARKETS = '/markets/all',
   PORTFOLIO = '/portfolio',
-  LIQUIDITY = '/liquidity/:marketId',
+  LIQUIDITY = 'liquidity/:marketId',
-  DISCLAIMER = '/disclaimer',
+  SETTINGS = 'settings',
+  DISCLAIMER = 'disclaimer',
 }
 
 type ConsoleLinks = { [r in Routes]: (...args: string[]) => string };
-
 export const Links: ConsoleLinks = {
   [Routes.HOME]: () => Routes.HOME,
-  [Routes.MARKET]: (marketId: string) =>
+  [Routes.MARKET]: (marketId: string | null | undefined) =>
-    trimEnd(Routes.MARKET.replace(':marketId', marketId)),
+    marketId ? trimEnd(`${Routes.MARKET}/${marketId}`, '/') : Routes.MARKET,
   [Routes.MARKETS]: () => Routes.MARKETS,
   [Routes.PORTFOLIO]: () => Routes.PORTFOLIO,
-  [Routes.LIQUIDITY]: (marketId: string) =>
+  [Routes.LIQUIDITY]: (marketId: string | null | undefined) =>
-    trimEnd(Routes.LIQUIDITY.replace(':marketId', marketId)),
+    marketId
+      ? trimEnd(`${Routes.LIQUIDITY}/${marketId}`, '/')
+      : Routes.LIQUIDITY,
+  [Routes.SETTINGS]: () => Routes.SETTINGS,
   [Routes.DISCLAIMER]: () => Routes.DISCLAIMER,
 };
 
 const routerConfig: RouteObject[] = [
   {
-    path: '/*',
+    index: true,
-    element: <LayoutWithSidebar />,
+    element: <LazyHome />,
+  },
+  {
+    path: Routes.MARKETS,
+    element: <LazyMarkets />,
+  },
+  {
+    path: Routes.MARKET,
     children: [
-      // all pages that require the Layout component (Sidebar)
       {
         index: true,
-        element: <LazyHome />,
+        element: <LazyMarket />,
       },
       {
-        path: 'markets',
+        path: ':marketId',
-        element: <Outlet />,
+        element: <LazyMarket />,
-        children: [
-          {
-            path: 'all',
-            element: <LazyMarkets />,
-          },
-          {
-            path: ':marketId',
-            element: <LazyMarket />,
-          },
-        ],
-      },
-      {
-        path: 'portfolio',
-        element: <LazyPortfolio />,
-      },
-      {
-        path: 'liquidity',
-        element: <Outlet />,
-        children: [
-          {
-            path: ':marketId',
-            element: <LazyLiquidity />,
-          },
-        ],
       },
     ],
   },
+  {
+    path: Routes.LIQUIDITY,
+    element: <LazyLiquidity />,
+    children: [
+      {
+        index: true,
+        element: <LazyLiquidity />,
+      },
+      {
+        path: ':marketId',
+        element: <LazyLiquidity />,
+      },
+    ],
+  },
+  {
+    path: Routes.PORTFOLIO,
+    element: <LazyPortfolio />,
+  },
+  {
+    path: Routes.SETTINGS,
+    element: <LazySettings />,
+  },
   {
     path: Routes.DISCLAIMER,
     element: <LazyDisclaimer />,

apps/trading/pages/dialogs-container.tsx

@@ -4,11 +4,14 @@ import {
 } from '@vegaprotocol/assets';
 import { VegaConnectDialog } from '@vegaprotocol/wallet';
 import { Connectors } from '../lib/vega-connectors';
+import { CreateWithdrawalDialog } from '@vegaprotocol/withdraws';
+import { DepositDialog } from '@vegaprotocol/deposits';
 import {
   Web3ConnectUncontrolledDialog,
   WithdrawalApprovalDialogContainer,
 } from '@vegaprotocol/web3';
 import { WelcomeDialog } from '../components/welcome-dialog';
+import { TransferDialog } from '@vegaprotocol/accounts';
 import { RiskMessage } from '../components/welcome-dialog';
 
 const DialogsContainer = () => {
@@ -26,7 +29,10 @@ const DialogsContainer = () => {
         onChange={setOpen}
       />
       <WelcomeDialog />
+      <DepositDialog />
       <Web3ConnectUncontrolledDialog />
+      <CreateWithdrawalDialog />
+      <TransferDialog />
       <WithdrawalApprovalDialogContainer />
     </>
   );

apps/trading/pages/styles.css

@@ -5,58 +5,29 @@
 @tailwind components;
 @tailwind utilities;
 
-/**
- * TAILWIND HELPERS
- */
-
 html,
 body,
 #__next {
   @apply h-full;
 }
 
-.text-default {
+/* Styles for allotment */
-  @apply text-vega-clight-50 dark:text-vega-cdark-50;
-}
-
-.text-secondary {
-  @apply text-vega-clight-100 dark:text-vega-cdark-100;
-}
-
-.text-muted {
-  @apply text-vega-clight-200 dark:text-vega-cdark-200;
-}
-
-.border-default {
-  @apply border-vega-clight-600 dark:border-vega-cdark-600;
-}
-
-/**
- * ALLOTMENT 
- */
-
 html {
-  --focus-border: theme(colors.vega.pink.500);
+  --focus-border: theme('colors.vega.pink.500');
-  --pennant-color-danger: theme(colors.vega.pink.500);
+  --separator-border: theme('colors.vega.light.200');
+  --pennant-color-danger: theme('colors.vega.pink.500');
 }
 
 html.dark {
-  --focus-border: theme(colors.vega.yellow.500);
+  --focus-border: theme('colors.vega.yellow.500');
+  --separator-border: theme('colors.vega.dark.200');
 }
 
-/* hide pane separation border, we leave it blank so border is applied within a padded area */
+.border-default {
-.split-view-view::before {
+  @apply border-vega-light-200 dark:border-vega-dark-200;
-  display: none;
 }
 
-/* re show separator border within chart */
+/* PENNANT */
-.plot-container__chart .split-view-view::before {
-  display: block;
-}
-
-/**
- * PENNANT
- */
 
 html [data-theme='dark'],
 html [data-theme='light'] {
@@ -76,9 +47,6 @@ html [data-theme='light'] {
 }
 
 html [data-theme='light'] {
-  --separator-border: theme(colors.vega.clight.400);
-  --pennant-background-surface-color: theme(colors.vega.clight.900);
-
   /* candles */
   --pennant-color-buy-fill: theme(colors.market.green.500);
   --pennant-color-buy-stroke: theme(colors.market.green.600);
@@ -97,9 +65,6 @@ html [data-theme='light'] {
 }
 
 html [data-theme='dark'] {
-  --separator-border: theme(colors.vega.cdark.400);
-  --pennant-background-surface-color: theme('colors.vega.cdark.900');
-
   /* candles */
   --pennant-color-buy-fill: theme(colors.market.green.600);
   --pennant-color-buy-stroke: theme(colors.market.green.500);
@@ -117,11 +82,7 @@ html [data-theme='dark'] {
   --pennant-color-volume-sell: theme(colors.market.red.600);
 }
 
-/**
+/* AG GRID - Do not edit without updating other global stylesheets for each app */
- * AG GRID
- *
- * - Do not edit without updating other global stylesheets for each app
- */
 
 .vega-ag-grid .ag-root-wrapper {
   border: solid 0px;
@@ -142,32 +103,26 @@ html [data-theme='dark'] {
   border-width: 0;
 }
 
-.vega-ag-grid .ag-header-row {
-  @apply font-alpha font-normal;
-}
-
 /* Light variables */
 .ag-theme-balham {
   --ag-background-color: theme(colors.white);
-  --ag-border-color: theme(colors.vega.clight.600);
+  --ag-border-color: theme(colors.neutral[300]);
-  --ag-header-background-color: theme(colors.vega.clight.700);
+  --ag-header-background-color: theme(colors.white);
   --ag-odd-row-background-color: theme(colors.white);
-  --ag-header-column-separator-color: theme(colors.vega.clight.500);
+  --ag-header-column-separator-color: theme(colors.neutral[300]);
-  --ag-row-border-color: theme(colors.vega.clight.600);
+  --ag-row-border-color: theme(colors.white);
-  --ag-row-hover-color: theme(colors.vega.clight.800);
+  --ag-row-hover-color: theme(colors.neutral[100]);
-  --ag-modal-overlay-background-color: rgb(244 244 244 / 50%);
 }
 
 /* Dark variables */
 .ag-theme-balham-dark {
-  --ag-background-color: theme(colors.vega.cdark.900);
+  --ag-background-color: theme(colors.black);
-  --ag-border-color: theme(colors.vega.cdark.600);
+  --ag-border-color: theme(colors.neutral[700]);
-  --ag-header-background-color: theme(colors.vega.cdark.700);
+  --ag-header-background-color: theme(colors.black);
-  --ag-odd-row-background-color: theme(colors.vega.cdark.900);
+  --ag-odd-row-background-color: theme(colors.black);
-  --ag-header-column-separator-color: theme(colors.vega.cdark.500);
+  --ag-header-column-separator-color: theme(colors.neutral[600]);
-  --ag-row-border-color: theme(colors.vega.cdark.600);
+  --ag-row-border-color: theme(colors.black);
-  --ag-row-hover-color: theme(colors.vega.cdark.800);
+  --ag-row-hover-color: theme(colors.neutral[800]);
-  --ag-modal-overlay-background-color: rgb(9 11 16 / 50%);
 }
 .ag-theme-balham-dark .ag-row.no-hover,
 .ag-theme-balham-dark .ag-row.no-hover:hover,
@@ -176,26 +131,23 @@ html [data-theme='dark'] {
   background: var(--ag-background-color);
 }
 
-/**
+.virtualized-list {
- * REACT VIRTUALIZED list
- */
-.vega-scrollbar {
   /* Works on Firefox */
   scrollbar-width: thin;
   scrollbar-color: #999 #333;
 }
 
 /* Works on Chrome, Edge, and Safari */
-.vega-scrollbar::-webkit-scrollbar {
+.virtualized-list::-webkit-scrollbar {
   width: 6px;
   background-color: #999;
 }
 
-.vega-scrollbar::-webkit-scrollbar-thumb {
+.virtualized-list::-webkit-scrollbar-thumb {
   width: 6px;
   background-color: #333;
 }
-.vega-scrollbar::-webkit-scrollbar-track {
+.virtualized-list::-webkit-scrollbar-track {
   box-shadow: inset 0 0 6px rgb(0 0 0 / 30%);
   background-color: #999;
 }

libs/accounts/src/lib/accounts-actions-dropdown.tsx

@@ -8,6 +8,7 @@ import {
   VegaIcon,
   VegaIconNames,
 } from '@vegaprotocol/ui-toolkit';
+import { useTransferDialog } from './transfer-dialog';
 import { useAssetDetailsDialogStore } from '@vegaprotocol/assets';
 
 export const AccountsActionsDropdown = ({
@@ -16,16 +17,15 @@ export const AccountsActionsDropdown = ({
   onClickDeposit,
   onClickWithdraw,
   onClickBreakdown,
-  onClickTransfer,
 }: {
   assetId: string;
   assetContractAddress?: string;
   onClickDeposit: () => void;
   onClickWithdraw: () => void;
   onClickBreakdown: () => void;
-  onClickTransfer: () => void;
 }) => {
   const etherscanLink = useEtherscanLink();
+  const openTransferDialog = useTransferDialog((store) => store.open);
   const openAssetDialog = useAssetDetailsDialogStore((store) => store.open);
 
   return (
@@ -49,7 +49,7 @@ export const AccountsActionsDropdown = ({
       <DropdownMenuItem
         key={'transfer'}
         data-testid="transfer"
-        onClick={onClickTransfer}
+        onClick={() => openTransferDialog(true, assetId)}
       >
         <VegaIcon name={VegaIconNames.TRANSFER} size={16} />
         {t('Transfer')}

libs/accounts/src/lib/accounts-manager.tsx

@@ -100,7 +100,6 @@ interface AccountManagerProps {
   onClickAsset: (assetId: string) => void;
   onClickWithdraw?: (assetId?: string) => void;
   onClickDeposit?: (assetId?: string) => void;
-  onClickTransfer?: (assetId?: string) => void;
   onMarketClick?: (marketId: string, metaKey?: boolean) => void;
   isReadOnly: boolean;
   pinnedAsset?: PinnedAsset;
@@ -111,7 +110,6 @@ export const AccountManager = ({
   onClickAsset,
   onClickWithdraw,
   onClickDeposit,
-  onClickTransfer,
   partyId,
   isReadOnly,
   pinnedAsset,
@@ -143,7 +141,6 @@ export const AccountManager = ({
         onClickAsset={onClickAsset}
         onClickDeposit={onClickDeposit}
         onClickWithdraw={onClickWithdraw}
-        onClickTransfer={onClickTransfer}
         onClickBreakdown={setBreakdownAssetId}
         isReadOnly={isReadOnly}
         pinnedAsset={pinnedAsset}

libs/accounts/src/lib/accounts-table.tsx

@@ -31,6 +31,7 @@ import { AccountsActionsDropdown } from './accounts-actions-dropdown';
 
 const colorClass = (percentageUsed: number, neutral = false) => {
   return classNames('text-right', {
+    'text-neutral-500 dark:text-neutral-400': percentageUsed < 75 && !neutral,
     'text-vega-orange': percentageUsed >= 75 && percentageUsed < 90,
     'text-vega-red': percentageUsed >= 90,
   });
@@ -70,7 +71,6 @@ export interface AccountTableProps extends AgGridReactProps {
   onClickWithdraw?: (assetId: string) => void;
   onClickDeposit?: (assetId: string) => void;
   onClickBreakdown?: (assetId: string) => void;
-  onClickTransfer?: (assetId: string) => void;
   isReadOnly: boolean;
   pinnedAsset?: PinnedAsset;
 }
@@ -82,7 +82,6 @@ export const AccountTable = forwardRef<AgGridReact, AccountTableProps>(
       onClickWithdraw,
       onClickDeposit,
       onClickBreakdown,
-      onClickTransfer,
       rowData,
       isReadOnly,
       pinnedAsset,
@@ -184,8 +183,8 @@ export const AccountTable = forwardRef<AgGridReact, AccountTableProps>(
             ) : (
               <>
                 <span className="underline">{valueFormatted}</span>
-                <span className="ml-2 inline-block w-14 text-muted">
+                <span className="ml-2 inline-block w-14 text-vega-light-200 dark:text-vega-dark-200">
-                  {t('0.00%')}
+                  {t('0.00%')}'
                 </span>
               </>
             );
@@ -286,9 +285,6 @@ export const AccountTable = forwardRef<AgGridReact, AccountTableProps>(
                 onClickBreakdown={() => {
                   onClickBreakdown && onClickBreakdown(assetId);
                 }}
-                onClickTransfer={() => {
-                  onClickTransfer && onClickTransfer(assetId);
-                }}
               />
             );
           },
@@ -300,7 +296,6 @@ export const AccountTable = forwardRef<AgGridReact, AccountTableProps>(
       onClickBreakdown,
       onClickDeposit,
       onClickWithdraw,
-      onClickTransfer,
       isReadOnly,
       showDepositButton,
     ]);

libs/accounts/src/lib/index.ts

@@ -7,7 +7,7 @@ export * from './breakdown-table';
 export * from './use-account-balance';
 export * from './get-settlement-account';
 export * from './use-market-account-balance';
+export * from './transfer-dialog';
 export * from './__generated__/Margins';
 export { MarginHealthChart } from './margin-health-chart';
 export * from './margin-data-provider';
-export * from './transfer-container';

libs/accounts/src/lib/transfer-container.tsx

@@ -7,42 +7,31 @@ import {
 } from '@vegaprotocol/network-parameters';
 import { useDataProvider } from '@vegaprotocol/data-provider';
 import type { Transfer } from '@vegaprotocol/wallet';
-import {
+import { useVegaTransactionStore, useVegaWallet } from '@vegaprotocol/wallet';
-  useVegaTransactionStore,
-  useVegaWallet,
-  useVegaWalletDialogStore,
-} from '@vegaprotocol/wallet';
 import { useCallback, useMemo } from 'react';
 import { accountsDataProvider } from './accounts-data-provider';
 import { TransferForm } from './transfer-form';
+import { useTransferDialog } from './transfer-dialog';
+import { Lozenge } from '@vegaprotocol/ui-toolkit';
 import sortBy from 'lodash/sortBy';
-import {
-  ExternalLink,
-  Intent,
-  Lozenge,
-  Notification,
-} from '@vegaprotocol/ui-toolkit';
 
 export const TransferContainer = ({ assetId }: { assetId?: string }) => {
   const { pubKey, pubKeys } = useVegaWallet();
+  const open = useTransferDialog((store) => store.open);
   const { param } = useNetworkParam(NetworkParams.transfer_fee_factor);
   const { data } = useDataProvider({
     dataProvider: accountsDataProvider,
     variables: { partyId: pubKey || '' },
     skip: !pubKey,
   });
-
-  const openVegaWalletDialog = useVegaWalletDialogStore(
-    (store) => store.openVegaWalletDialog
-  );
-
   const create = useVegaTransactionStore((store) => store.create);
 
   const transfer = useCallback(
     (transfer: Transfer) => {
       create({ transfer });
+      open(false);
     },
-    [create]
+    [create, open]
   );
 
   const assets = useMemo(() => {
@@ -62,40 +51,11 @@ export const TransferContainer = ({ assetId }: { assetId?: string }) => {
 
   return (
     <>
-      <p className="text-sm mb-4" data-testid="transfer-intro-text">
+      <p className="text-sm mb-4" data-testid="dialog-transfer-text">
-        {t('Transfer funds to another Vega key')}
+        {t('Transfer funds to another Vega key from')}{' '}
-        {pubKey && (
+        <Lozenge className="font-mono">{truncateByChars(pubKey || '')}</Lozenge>{' '}
-          <>
+        {t('If you are at all unsure, stop and seek advice.')}
-            {t(' from ')}
-            <Lozenge className="font-mono">
-              {truncateByChars(pubKey || '')}
-            </Lozenge>
-          </>
-        )}
-        {t('. If you are at all unsure, stop and seek advice.')}
       </p>
-      {!pubKey && (
-        <div className="mb-4">
-          <Notification
-            intent={Intent.Warning}
-            message={
-              <p className="text-sm pb-2">
-                You need a{' '}
-                <ExternalLink href="https://vega.xyz/wallet">
-                  Vega wallet
-                </ExternalLink>{' '}
-                to make a transfer.
-              </p>
-            }
-            buttonProps={{
-              text: t('Connect wallet'),
-              action: openVegaWalletDialog,
-              dataTestId: 'order-connect-wallet',
-              size: 'sm',
-            }}
-          />
-        </div>
-      )}
       <TransferForm
         pubKey={pubKey}
         pubKeys={pubKeys ? pubKeys?.map((pk) => pk.publicKey) : null}

libs/accounts/src/lib/transfer-dialog.tsx

@@ -0,0 +1,30 @@
+import { t } from '@vegaprotocol/i18n';
+import { Dialog } from '@vegaprotocol/ui-toolkit';
+import { create } from 'zustand';
+import { TransferContainer } from './transfer-container';
+
+interface State {
+  isOpen: boolean;
+  assetId: string | undefined;
+}
+
+interface Actions {
+  open: (open?: boolean, assetId?: string) => void;
+}
+
+export const useTransferDialog = create<State & Actions>()((set) => ({
+  isOpen: false,
+  assetId: undefined,
+  open: (open = true, assetId) => {
+    set(() => ({ isOpen: open, assetId }));
+  },
+}));
+
+export const TransferDialog = () => {
+  const { isOpen, open, assetId } = useTransferDialog();
+  return (
+    <Dialog title={t('Transfer')} open={isOpen} onChange={open} size="small">
+      <TransferContainer assetId={assetId} />
+    </Dialog>
+  );
+};

libs/accounts/src/lib/transfer-form.tsx

@@ -312,7 +312,10 @@ export const TransferFee = ({
           <div>{t('Transfer fee')}</div>
         </Tooltip>
 
-        <div data-testid="transfer-fee" className="text-muted">
+        <div
+          data-testid="transfer-fee"
+          className="text-neutral-500 dark:text-neutral-300"
+        >
           {formatNumber(fee, decimals)}
         </div>
       </div>
@@ -325,7 +328,10 @@ export const TransferFee = ({
           <div>{t('Amount to be transferred')}</div>
         </Tooltip>
 
-        <div data-testid="transfer-amount" className="text-muted">
+        <div
+          data-testid="transfer-amount"
+          className="text-neutral-500 dark:text-neutral-300"
+        >
           {formatNumber(amount, decimals)}
         </div>
       </div>
@@ -338,7 +344,10 @@ export const TransferFee = ({
           <div>{t('Total amount (with fee)')}</div>
         </Tooltip>
 
-        <div data-testid="total-transfer-fee" className="text-muted">
+        <div
+          data-testid="total-transfer-fee"
+          className="text-neutral-500 dark:text-neutral-300"
+        >
           {formatNumber(totalValue, decimals)}
         </div>
       </div>

libs/candles-chart/src/lib/candles-chart.tsx

@@ -131,7 +131,7 @@ export const CandlesChartContainer = ({
 
   return (
     <div className="h-full flex flex-col">
-      <div className="px-3 lg:px-4 py-2 flex flex-row flex-wrap gap-2 bg-vega-clight-700 dark:bg-vega-cdark-700">
+      <div className="px-4 py-2 flex flex-row flex-wrap gap-2">
         <DropdownMenu
           trigger={
             <DropdownMenuTrigger>
@@ -241,7 +241,9 @@ export const CandlesChartContainer = ({
             overlays: overlays,
             studies: studies,
             notEnoughDataText: (
-              <span className="text-xs text-center">{t('No data')}</span>
+              <span className="text-xs text-center text-neutral-800 dark:text-neutral-200">
+                {t('No data')}
+              </span>
             ),
           }}
           interval={interval}

libs/datagrid/src/lib/cells/numeric-cell.tsx

@@ -32,7 +32,7 @@ export const NumericCell = forwardRef<HTMLSpanElement, NumericCellProps>(
       <span
         ref={ref}
         className={classNames(
-          'font-mono relative whitespace-nowrap overflow-hidden text-ellipsis text-right rtl-dir',
+          'font-mono relative text-black dark:text-white whitespace-nowrap overflow-hidden text-ellipsis text-right rtl-dir',
           className
         )}
         data-testid={testId}

libs/datagrid/src/lib/cells/price-cell.tsx

@@ -25,7 +25,7 @@ export const PriceCell = memo(
       return onClick ? (
         <button
           onClick={() => onClick(value)}
-          className="hover:dark:bg-vega-cdark-800 hover:bg-vega-clight-800 text-right"
+          className="hover:dark:bg-neutral-800 hover:bg-neutral-200 text-right"
         >
           <NumericCell
             value={value}

libs/deal-ticket/src/components/deal-ticket-validation/margin-warning.tsx

@@ -1,6 +1,7 @@
 import { addDecimalsFormatNumber } from '@vegaprotocol/utils';
 import { t } from '@vegaprotocol/i18n';
 import { Notification, Intent } from '@vegaprotocol/ui-toolkit';
+import { useDepositDialog } from '@vegaprotocol/deposits';
 
 interface Props {
   margin: string;
@@ -10,10 +11,10 @@ interface Props {
     symbol: string;
     decimals: number;
   };
-  onDeposit: (assetId: string) => void;
 }
 
-export const MarginWarning = ({ margin, balance, asset, onDeposit }: Props) => {
+export const MarginWarning = ({ margin, balance, asset }: Props) => {
+  const openDepositDialog = useDepositDialog((state) => state.open);
   return (
     <Notification
       intent={Intent.Warning}
@@ -28,7 +29,7 @@ export const MarginWarning = ({ margin, balance, asset, onDeposit }: Props) => {
       } ${t('available.')}`}
       buttonProps={{
         text: t(`Deposit ${asset.symbol}`),
-        action: () => onDeposit(asset.id),
+        action: () => openDepositDialog(asset.id),
         dataTestId: 'deal-ticket-deposit-dialog-button',
         size: 'sm',
       }}

libs/deal-ticket/src/components/deal-ticket-validation/zero-balance-error.tsx

@@ -1,4 +1,5 @@
 import { Intent, Notification, Link } from '@vegaprotocol/ui-toolkit';
+import { useDepositDialog } from '@vegaprotocol/deposits';
 import { t } from '@vegaprotocol/i18n';
 
 interface ZeroBalanceErrorProps {
@@ -7,14 +8,13 @@ interface ZeroBalanceErrorProps {
     symbol: string;
   };
   onClickCollateral?: () => void;
-  onDeposit: (assetId: string) => void;
 }
 
 export const ZeroBalanceError = ({
   asset,
   onClickCollateral,
-  onDeposit,
 }: ZeroBalanceErrorProps) => {
+  const openDepositDialog = useDepositDialog((state) => state.open);
   return (
     <Notification
       intent={Intent.Warning}
@@ -35,7 +35,7 @@ export const ZeroBalanceError = ({
       }
       buttonProps={{
         text: t(`Make a deposit`),
-        action: () => onDeposit(asset.id),
+        action: () => openDepositDialog(asset.id),
         dataTestId: 'deal-ticket-deposit-dialog-button',
         size: 'sm',
       }}

libs/deal-ticket/src/components/deal-ticket/deal-ticket-container.tsx

@@ -9,14 +9,12 @@ export interface DealTicketContainerProps {
   marketId: string;
   onMarketClick?: (marketId: string, metaKey?: boolean) => void;
   onClickCollateral?: () => void;
-  onDeposit: (assetId: string) => void;
 }
 
 export const DealTicketContainer = ({
   marketId,
   onMarketClick,
   onClickCollateral,
-  onDeposit,
 }: DealTicketContainerProps) => {
   const {
     data: market,
@@ -52,7 +50,6 @@ export const DealTicketContainer = ({
           submit={(orderSubmission) => create({ orderSubmission })}
           onClickCollateral={onClickCollateral}
           onMarketClick={onMarketClick}
-          onDeposit={onDeposit}
         />
       ) : (
         <Splash>

libs/deal-ticket/src/components/deal-ticket/deal-ticket-fee-details.tsx

@@ -48,11 +48,14 @@ export const DealTicketFeeDetail = ({
 }: DealTicketFeeDetailPros) => {
   const displayValue = `${formattedValue ?? '-'} ${symbol || ''}`;
   const valueElement = onClick ? (
-    <button onClick={onClick} className="text-muted">
+    <button
+      onClick={onClick}
+      className="text-neutral-500 dark:text-neutral-300"
+    >
       {displayValue}
     </button>
   ) : (
-    <div className="text-muted">{displayValue}</div>
+    <div className="text-neutral-500 dark:text-neutral-300">{displayValue}</div>
   );
   return (
     <div

libs/deal-ticket/src/components/deal-ticket/deal-ticket.spec.tsx

@@ -23,12 +23,7 @@ function generateJsx() {
   return (
     <MockedProvider>
       <VegaWalletContext.Provider value={{ pubKey, isReadOnly: false } as any}>
-        <DealTicket
+        <DealTicket market={market} marketData={marketData} submit={submit} />
-          market={market}
-          marketData={marketData}
-          submit={submit}
-          onDeposit={jest.fn()}
-        />
       </VegaWalletContext.Provider>
     </MockedProvider>
   );

libs/deal-ticket/src/components/deal-ticket/deal-ticket.tsx

@@ -22,6 +22,7 @@ import {
   Intent,
   Notification,
   Tooltip,
+  TinyScroll,
 } from '@vegaprotocol/ui-toolkit';
 
 import {
@@ -60,7 +61,6 @@ export interface DealTicketProps {
   onMarketClick?: (marketId: string, metaKey?: boolean) => void;
   submit: (order: OrderSubmission) => void;
   onClickCollateral?: () => void;
-  onDeposit: (assetId: string) => void;
 }
 
 export const DealTicket = ({
@@ -69,7 +69,6 @@ export const DealTicket = ({
   marketData,
   submit,
   onClickCollateral,
-  onDeposit,
 }: DealTicketProps) => {
   const { pubKey, isReadOnly } = useVegaWallet();
   // store last used tif for market so that when changing OrderType the previous TIF
@@ -267,224 +266,229 @@ export const DealTicket = ({
   if (!order || !normalizedOrder) return null;
 
   return (
-    <form onSubmit={isReadOnly ? undefined : handleSubmit(onSubmit)} noValidate>
+    <TinyScroll className="h-full overflow-auto">
-      <Controller
+      <form
-        name="type"
+        onSubmit={isReadOnly ? undefined : handleSubmit(onSubmit)}
-        control={control}
+        className="p-4"
-        rules={{
+        noValidate
-          validate: validateType(
+      >
-            marketData.marketTradingMode,
+        <Controller
-            marketData.trigger
+          name="type"
-          ),
+          control={control}
-        }}
+          rules={{
-        render={() => (
+            validate: validateType(
-          <TypeSelector
+              marketData.marketTradingMode,
-            value={order.type}
+              marketData.trigger
-            onSelect={(type) => {
+            ),
-              if (type === OrderType.TYPE_NETWORK) return;
+          }}
-              update({
+          render={() => (
-                type,
+            <TypeSelector
-                // when changing type also update the TIF to what was last used of new type
+              value={order.type}
-                timeInForce: lastTIF[type] || order.timeInForce,
+              onSelect={(type) => {
-                postOnly:
+                if (type === OrderType.TYPE_NETWORK) return;
-                  type === OrderType.TYPE_MARKET ? false : order.postOnly,
+                update({
-                reduceOnly:
+                  type,
-                  type === OrderType.TYPE_LIMIT &&
+                  // when changing type also update the TIF to what was last used of new type
-                  ![
+                  timeInForce: lastTIF[type] || order.timeInForce,
+                  postOnly:
+                    type === OrderType.TYPE_MARKET ? false : order.postOnly,
+                  reduceOnly:
+                    type === OrderType.TYPE_LIMIT &&
+                    ![
+                      OrderTimeInForce.TIME_IN_FORCE_FOK,
+                      OrderTimeInForce.TIME_IN_FORCE_IOC,
+                    ].includes(lastTIF[type] || order.timeInForce)
+                      ? false
+                      : order.postOnly,
+                  expiresAt: undefined,
+                });
+                clearErrors(['expiresAt', 'price']);
+              }}
+              market={market}
+              marketData={marketData}
+              errorMessage={errors.type?.message}
+            />
+          )}
+        />
+        <Controller
+          name="side"
+          control={control}
+          render={() => (
+            <SideSelector
+              value={order.side}
+              onSelect={(side) => {
+                update({ side });
+              }}
+            />
+          )}
+        />
+        <DealTicketAmount
+          control={control}
+          orderType={order.type}
+          market={market}
+          marketData={marketData}
+          sizeError={errors.size?.message}
+          priceError={errors.price?.message}
+          update={update}
+          size={order.size}
+          price={order.price}
+        />
+        <Controller
+          name="timeInForce"
+          control={control}
+          rules={{
+            validate: validateTimeInForce(
+              marketData.marketTradingMode,
+              marketData.trigger
+            ),
+          }}
+          render={() => (
+            <TimeInForceSelector
+              value={order.timeInForce}
+              orderType={order.type}
+              onSelect={(timeInForce) => {
+                // Reset post only and reduce only when changing TIF
+                update({
+                  timeInForce,
+                  postOnly: [
                     OrderTimeInForce.TIME_IN_FORCE_FOK,
                     OrderTimeInForce.TIME_IN_FORCE_IOC,
-                  ].includes(lastTIF[type] || order.timeInForce)
+                  ].includes(timeInForce)
                     ? false
                     : order.postOnly,
-                expiresAt: undefined,
+                  reduceOnly: ![
-              });
+                    OrderTimeInForce.TIME_IN_FORCE_FOK,
-              clearErrors(['expiresAt', 'price']);
+                    OrderTimeInForce.TIME_IN_FORCE_IOC,
-            }}
+                  ].includes(timeInForce)
-            market={market}
+                    ? false
-            marketData={marketData}
+                    : order.reduceOnly,
-            errorMessage={errors.type?.message}
+                });
-          />
+                // Set TIF value for the given order type, so that when switching
-        )}
+                // types we know the last used TIF for the given order type
-      />
+                setLastTIF((curr) => ({
-      <Controller
+                  ...curr,
-        name="side"
+                  [order.type]: timeInForce,
-        control={control}
+                  expiresAt: undefined,
-        render={() => (
+                }));
-          <SideSelector
+                clearErrors('expiresAt');
-            value={order.side}
+              }}
-            onSelect={(side) => {
+              market={market}
-              update({ side });
+              marketData={marketData}
-            }}
+              errorMessage={errors.timeInForce?.message}
-          />
+            />
-        )}
+          )}
-      />
+        />
-      <DealTicketAmount
+        {order.type === Schema.OrderType.TYPE_LIMIT &&
-        control={control}
+          order.timeInForce === Schema.OrderTimeInForce.TIME_IN_FORCE_GTT && (
-        orderType={order.type}
+            <Controller
-        market={market}
+              name="expiresAt"
-        marketData={marketData}
+              control={control}
-        sizeError={errors.size?.message}
+              rules={{
-        priceError={errors.price?.message}
+                validate: validateExpiration,
-        update={update}
+              }}
-        size={order.size}
+              render={() => (
-        price={order.price}
+                <ExpirySelector
-      />
+                  value={order.expiresAt}
-      <Controller
+                  onSelect={(expiresAt) =>
-        name="timeInForce"
+                    update({
-        control={control}
+                      expiresAt: expiresAt || undefined,
-        rules={{
+                    })
-          validate: validateTimeInForce(
+                  }
-            marketData.marketTradingMode,
+                  errorMessage={errors.expiresAt?.message}
-            marketData.trigger
+                />
-          ),
+              )}
-        }}
+            />
-        render={() => (
+          )}
-          <TimeInForceSelector
+        <div className="flex gap-2 pb-2 justify-between">
-            value={order.timeInForce}
-            orderType={order.type}
-            onSelect={(timeInForce) => {
-              // Reset post only and reduce only when changing TIF
-              update({
-                timeInForce,
-                postOnly: [
-                  OrderTimeInForce.TIME_IN_FORCE_FOK,
-                  OrderTimeInForce.TIME_IN_FORCE_IOC,
-                ].includes(timeInForce)
-                  ? false
-                  : order.postOnly,
-                reduceOnly: ![
-                  OrderTimeInForce.TIME_IN_FORCE_FOK,
-                  OrderTimeInForce.TIME_IN_FORCE_IOC,
-                ].includes(timeInForce)
-                  ? false
-                  : order.reduceOnly,
-              });
-              // Set TIF value for the given order type, so that when switching
-              // types we know the last used TIF for the given order type
-              setLastTIF((curr) => ({
-                ...curr,
-                [order.type]: timeInForce,
-                expiresAt: undefined,
-              }));
-              clearErrors('expiresAt');
-            }}
-            market={market}
-            marketData={marketData}
-            errorMessage={errors.timeInForce?.message}
-          />
-        )}
-      />
-      {order.type === Schema.OrderType.TYPE_LIMIT &&
-        order.timeInForce === Schema.OrderTimeInForce.TIME_IN_FORCE_GTT && (
           <Controller
-            name="expiresAt"
+            name="postOnly"
             control={control}
-            rules={{
-              validate: validateExpiration,
-            }}
             render={() => (
-              <ExpirySelector
+              <Checkbox
-                value={order.expiresAt}
+                name="post-only"
-                onSelect={(expiresAt) =>
+                checked={order.postOnly}
-                  update({
+                disabled={disablePostOnlyCheckbox}
-                    expiresAt: expiresAt || undefined,
+                onCheckedChange={() => {
-                  })
+                  update({ postOnly: !order.postOnly, reduceOnly: false });
+                }}
+                label={
+                  <Tooltip
+                    description={
+                      <span>
+                        {disablePostOnlyCheckbox
+                          ? t(
+                              '"Post only" can not be used on "Fill or Kill" or "Immediate or Cancel" orders.'
+                            )
+                          : t(
+                              '"Post only" will ensure the order is not filled immediately but is placed on the order book as a passive order. When the order is processed it is either stopped (if it would not be filled immediately), or placed in the order book as a passive order until the price taker matches with it.'
+                            )}
+                      </span>
+                    }
+                  >
+                    <span className="text-xs">{t('Post only')}</span>
+                  </Tooltip>
                 }
-                errorMessage={errors.expiresAt?.message}
               />
             )}
           />
-        )}
+          <Controller
-      <div className="flex gap-2 pb-2 justify-between">
+            name="reduceOnly"
-        <Controller
+            control={control}
-          name="postOnly"
+            render={() => (
-          control={control}
+              <Checkbox
-          render={() => (
+                name="reduce-only"
-            <Checkbox
+                checked={order.reduceOnly}
-              name="post-only"
+                disabled={disableReduceOnlyCheckbox}
-              checked={order.postOnly}
+                onCheckedChange={() => {
-              disabled={disablePostOnlyCheckbox}
+                  update({ postOnly: false, reduceOnly: !order.reduceOnly });
-              onCheckedChange={() => {
+                }}
-                update({ postOnly: !order.postOnly, reduceOnly: false });
+                label={
-              }}
+                  <Tooltip
-              label={
+                    description={
-                <Tooltip
+                      <span>
-                  description={
+                        {disableReduceOnlyCheckbox
-                    <span>
+                          ? t(
-                      {disablePostOnlyCheckbox
+                              '"Reduce only" can be used only with non-persistent orders, such as "Fill or Kill" or "Immediate or Cancel".'
-                        ? t(
+                            )
-                            '"Post only" can not be used on "Fill or Kill" or "Immediate or Cancel" orders.'
+                          : t(
-                          )
+                              '"Reduce only" will ensure that this order will not increase the size of an open position. When the order is matched, it will only trade enough volume to bring your open volume towards 0 but never change the direction of your position. If applied to a limit order that is not instantly filled, the order will be stopped.'
-                        : t(
+                            )}
-                            '"Post only" will ensure the order is not filled immediately but is placed on the order book as a passive order. When the order is processed it is either stopped (if it would not be filled immediately), or placed in the order book as a passive order until the price taker matches with it.'
+                      </span>
-                          )}
+                    }
-                    </span>
+                  >
-                  }
+                    <span className="text-xs">{t('Reduce only')}</span>
-                >
+                  </Tooltip>
-                  <span className="text-xs">{t('Post only')}</span>
+                }
-                </Tooltip>
+              />
-              }
+            )}
-            />
+          />
-          )}
+        </div>
+        <SummaryMessage
+          errorMessage={errors.summary?.message}
+          asset={asset}
+          marketTradingMode={marketData.marketTradingMode}
+          balance={balance}
+          margin={
+            positionEstimate?.estimatePosition?.margin.bestCase.initialLevel ||
+            '0'
+          }
+          isReadOnly={isReadOnly}
+          pubKey={pubKey}
+          onClickCollateral={onClickCollateral}
         />
-        <Controller
+        <DealTicketButton side={order.side} />
-          name="reduceOnly"
+        <DealTicketFeeDetails
-          control={control}
+          onMarketClick={onMarketClick}
-          render={() => (
+          feeEstimate={feeEstimate}
-            <Checkbox
+          notionalSize={notionalSize}
-              name="reduce-only"
+          assetSymbol={assetSymbol}
-              checked={order.reduceOnly}
+          marginAccountBalance={marginAccountBalance}
-              disabled={disableReduceOnlyCheckbox}
+          generalAccountBalance={generalAccountBalance}
-              onCheckedChange={() => {
+          positionEstimate={positionEstimate?.estimatePosition}
-                update({ postOnly: false, reduceOnly: !order.reduceOnly });
+          market={market}
-              }}
-              label={
-                <Tooltip
-                  description={
-                    <span>
-                      {disableReduceOnlyCheckbox
-                        ? t(
-                            '"Reduce only" can be used only with non-persistent orders, such as "Fill or Kill" or "Immediate or Cancel".'
-                          )
-                        : t(
-                            '"Reduce only" will ensure that this order will not increase the size of an open position. When the order is matched, it will only trade enough volume to bring your open volume towards 0 but never change the direction of your position. If applied to a limit order that is not instantly filled, the order will be stopped.'
-                          )}
-                    </span>
-                  }
-                >
-                  <span className="text-xs">{t('Reduce only')}</span>
-                </Tooltip>
-              }
-            />
-          )}
         />
-      </div>
+      </form>
-      <SummaryMessage
+    </TinyScroll>
-        errorMessage={errors.summary?.message}
-        asset={asset}
-        marketTradingMode={marketData.marketTradingMode}
-        balance={balance}
-        margin={
-          positionEstimate?.estimatePosition?.margin.bestCase.initialLevel ||
-          '0'
-        }
-        isReadOnly={isReadOnly}
-        pubKey={pubKey}
-        onClickCollateral={onClickCollateral}
-        onDeposit={onDeposit}
-      />
-      <DealTicketButton side={order.side} />
-      <DealTicketFeeDetails
-        onMarketClick={onMarketClick}
-        feeEstimate={feeEstimate}
-        notionalSize={notionalSize}
-        assetSymbol={assetSymbol}
-        marginAccountBalance={marginAccountBalance}
-        generalAccountBalance={generalAccountBalance}
-        positionEstimate={positionEstimate?.estimatePosition}
-        market={market}
-      />
-    </form>
   );
 };
 
@@ -501,7 +505,6 @@ interface SummaryMessageProps {
   isReadOnly: boolean;
   pubKey: string | null;
   onClickCollateral?: () => void;
-  onDeposit: (assetId: string) => void;
 }
 const SummaryMessage = memo(
   ({
@@ -513,7 +516,6 @@ const SummaryMessage = memo(
     isReadOnly,
     pubKey,
     onClickCollateral,
-    onDeposit,
   }: SummaryMessageProps) => {
     // Specific error UI for if balance is so we can
     // render a deposit dialog
@@ -563,7 +565,6 @@ const SummaryMessage = memo(
           <ZeroBalanceError
             asset={asset}
             onClickCollateral={onClickCollateral}
-            onDeposit={onDeposit}
           />
         </div>
       );
@@ -586,12 +587,7 @@ const SummaryMessage = memo(
     if (BigInt(balance) < BigInt(margin) && BigInt(balance) > BigInt(0)) {
       return (
         <div className="mb-2">
-          <MarginWarning
+          <MarginWarning balance={balance} margin={margin} asset={asset} />
-            balance={balance}
-            margin={margin}
-            asset={asset}
-            onDeposit={onDeposit}
-          />
         </div>
       );
     }

libs/deposits/src/lib/deposit-dialog.tsx

@@ -0,0 +1,42 @@
+import { create } from 'zustand';
+import { t } from '@vegaprotocol/i18n';
+import { Dialog } from '@vegaprotocol/ui-toolkit';
+import { DepositContainer } from './deposit-container';
+import { useWeb3ConnectStore } from '@vegaprotocol/web3';
+import { useAssetDetailsDialogStore } from '@vegaprotocol/assets';
+
+interface State {
+  isOpen: boolean;
+  assetId?: string;
+}
+
+interface Actions {
+  open: (assetId?: string) => void;
+  close: () => void;
+}
+
+export const useDepositDialog = create<State & Actions>()((set) => ({
+  isOpen: false,
+  assetId: undefined,
+  open: (assetId) => set(() => ({ assetId, isOpen: true })),
+  close: () => set(() => ({ assetId: undefined, isOpen: false })),
+}));
+
+export const DepositDialog = () => {
+  const { assetId, isOpen, open, close } = useDepositDialog();
+  const assetDetailsDialogOpen = useAssetDetailsDialogStore(
+    (state) => state.isOpen
+  );
+  const connectWalletDialogIsOpen = useWeb3ConnectStore(
+    (state) => state.isOpen
+  );
+  return (
+    <Dialog
+      open={isOpen && !(connectWalletDialogIsOpen || assetDetailsDialogOpen)}
+      onChange={(isOpen) => (isOpen ? open() : close())}
+      title={t('Deposit')}
+    >
+      <DepositContainer assetId={assetId} />
+    </Dialog>
+  );
+};

libs/deposits/src/lib/deposit-form.tsx

@@ -27,7 +27,7 @@ import { useVegaWallet } from '@vegaprotocol/wallet';
 import { useWeb3React } from '@web3-react/core';
 import BigNumber from 'bignumber.js';
 import type { ButtonHTMLAttributes, ChangeEvent, ReactNode } from 'react';
-import { useEffect, useMemo, useState } from 'react';
+import { useMemo, useState } from 'react';
 import { useWatch, Controller, useForm } from 'react-hook-form';
 import { DepositLimits } from './deposit-limits';
 import { useAssetDetailsDialogStore } from '@vegaprotocol/assets';
@@ -90,18 +90,16 @@ export const DepositForm = ({
   const [approveNotificationIntent, setApproveNotificationIntent] =
     useState<Intent>(Intent.Warning);
   const [persistedDeposit] = usePersistentDeposit(selectedAsset?.id);
-  console.log('deposit-form', account);
+
   const {
     register,
     handleSubmit,
     setValue,
     clearErrors,
-    trigger,
     control,
     formState: { errors },
   } = useForm<FormFields>({
     defaultValues: {
-      from: account || '',
       to: pubKey ? pubKey : undefined,
       asset: selectedAsset?.id,
       amount: persistedDeposit?.amount,
@@ -138,11 +136,6 @@ export const DepositForm = ({
     return _pubKeys ? _pubKeys.map((pk) => pk.publicKey) : [];
   }, [_pubKeys]);
 
-  useEffect(() => {
-    setValue('from', account || '');
-    trigger('from');
-  }, [account, setValue, trigger]);
-
   const approved =
     balances && balances.allowance.isGreaterThan(0) ? true : false;
 
@@ -173,7 +166,7 @@ export const DepositForm = ({
             if (isActive && account) {
               return (
                 <div className="text-sm" aria-describedby="ethereum-address">
-                  <p className="mb-1 break-all" data-testid="ethereum-address">
+                  <p className="mb-1" data-testid="ethereum-address">
                     {account}
                   </p>
                   <DisconnectEthereumButton

libs/deposits/src/lib/deposit-manager.tsx

@@ -7,6 +7,7 @@ import { useSubmitApproval } from './use-submit-approval';
 import { useSubmitFaucet } from './use-submit-faucet';
 import { useCallback, useState } from 'react';
 import { useDepositBalances } from './use-deposit-balances';
+import { useDepositDialog } from './deposit-dialog';
 import type { Asset } from '@vegaprotocol/assets';
 import {
   useEthTransactionStore,
@@ -33,6 +34,7 @@ export const DepositManager = ({
   const [assetId, setAssetId] = useState(persistentDeposit?.assetId);
   const asset = assets.find((a) => a.id === assetId);
   const bridgeContract = useBridgeContract();
+  const closeDepositDialog = useDepositDialog((state) => state.close);
 
   const { getBalances, reset, balances } = useDepositBalances(asset);
 
@@ -60,6 +62,7 @@ export const DepositManager = ({
       config?.confirmations ?? 1,
       true
     );
+    closeDepositDialog();
   };
 
   const onAmountChange = useCallback(

libs/deposits/src/lib/index.ts

@@ -1,6 +1,7 @@
 export * from './__generated__/Deposit';
 export * from './asset-balance';
 export * from './deposit-container';
+export * from './deposit-dialog';
 export * from './deposit-form';
 export * from './deposit-limits';
 export * from './deposit-manager';

libs/environment/src/components/network-switcher/network-switcher.tsx

@@ -120,7 +120,7 @@ export const NetworkSwitcher = ({
         </DropdownMenuTrigger>
       }
     >
-      <DropdownMenuContent align="start" sideOffset={17}>
+      <DropdownMenuContent align="start">
         {!isAdvancedView && (
           <>
             {standardNetworkKeys.map((key) => (
@@ -183,7 +183,7 @@ export const NetworkSwitcher = ({
           </>
         )}
         <div
-          className="relative flex items-center justify-between mx-2 py-2 border-t border-default pt-2 text-sm"
+          className="relative flex items-center justify-between mx-2 py-2 border-t border-neutral-400 pt-2 text-sm"
           key="propose-network-param"
         >
           <ExternalLink href={tokenLink(TOKEN_NEW_NETWORK_PARAM_PROPOSAL)}>

libs/environment/src/components/node-switcher/layout-cell.tsx

@@ -29,7 +29,7 @@ export const LayoutCell = ({
         data-testid={dataTestId}
         className={classnames('font-mono', {
           'text-danger': !isLoading && hasError,
-          'text-muted': isLoading,
+          'text-neutral-800 dark:text-neutral-200': isLoading,
         })}
       >
         {isLoading ? t('Checking') : children || '-'}

libs/fills/src/lib/fills-table.tsx

@@ -302,7 +302,7 @@ const FeesBreakdownTooltip = ({
   return (
     <div
       data-testid="fee-breakdown-tooltip"
-      className="max-w-sm bg-vega-light-100 dark:bg-vega-dark-100 border border-vega-light-200 dark:border-vega-dark-200 px-4 py-2 z-20 rounded text-sm break-word text-black dark:text-white"
+      className="max-w-sm border border-neutral-600 bg-neutral-100 dark:bg-neutral-800 px-4 py-2 z-20 rounded text-sm break-word text-black dark:text-white"
     >
       {role === MAKER && (
         <>

libs/ledger/src/lib/ledger-table.tsx

@@ -32,7 +32,7 @@ export const TransferTooltipCellComponent = ({
   value: Types.TransferType;
 }) => {
   return (
-    <p className="max-w-sm px-4 py-2 z-20 rounded text-sm break-word">
+    <p className="max-w-sm bg-neutral-200 px-4 py-2 z-20 rounded text-sm break-word text-black">
       {value ? DescriptionTransferTypeMapping[value] : ''}
     </p>
   );

libs/market-depth/src/lib/depth-chart.tsx

@@ -238,7 +238,9 @@ export const DepthChartContainer = ({ marketId }: DepthChartManagerProps) => {
           volumeFormat={volumeFormat}
           priceFormat={priceFormat}
           notEnoughDataText={
-            <span className="text-xs text-center">{t('No data')}</span>
+            <span className="text-xs text-center text-neutral-800 dark:text-neutral-200">
+              {t('No data')}
+            </span>
           }
         />
       )}

libs/market-depth/src/lib/orderbook.tsx

@@ -101,7 +101,7 @@ export const Orderbook = ({
   }, [bids, resolution]);
 
   return (
-    <div className="h-full text-xs grid grid-rows-[1fr_min-content]">
+    <div className="h-full pl-1 text-xs grid grid-rows-[1fr_min-content]">
       <div>
         <ReactVirtualizedAutoSizer disableWidth>
           {({ height }) => {
@@ -162,13 +162,13 @@ export const Orderbook = ({
           }}
         </ReactVirtualizedAutoSizer>
       </div>
-      <div className="border-t border-default bg-vega-clight-700 dark:bg-vega-cdark-700">
+      <div className="border-t border-default">
         <select
           onChange={(e) => {
             setResolution(Number(e.currentTarget.value));
           }}
           value={resolution}
-          className="block bg-transparent font-mono text-right"
+          className="block bg-neutral-100 dark:bg-neutral-700 font-mono text-right"
           data-testid="resolution"
         >
           {resolutions.map((r) => (

libs/markets/src/lib/components/market-info/market-info-accordion.tsx

@@ -9,6 +9,7 @@ import {
   ExternalLink,
   Link as UILink,
   Splash,
+  TinyScroll,
   AccordionItem,
 } from '@vegaprotocol/ui-toolkit';
 import { generatePath, Link } from 'react-router-dom';
@@ -60,7 +61,9 @@ export const MarketInfoAccordionContainer = ({
   return (
     <AsyncRenderer data={data} loading={loading} error={error} reload={reload}>
       {data ? (
-        <MarketInfoAccordion market={data} onSelect={onSelect} />
+        <TinyScroll className="h-full overflow-auto">
+          <MarketInfoAccordion market={data} onSelect={onSelect} />
+        </TinyScroll>
       ) : (
         <Splash>
           <p>{t('Could not load market')}</p>
@@ -103,7 +106,7 @@ export const MarketInfoAccordion = ({
   };
 
   return (
-    <div>
+    <div className="p-4">
       <div className="mb-8">
         <h3 className={headerClassName}>{t('Market data')}</h3>
         <Accordion>
@@ -124,19 +127,13 @@ export const MarketInfoAccordion = ({
           />
           {marketAccounts
             .filter((a) => a.type === Schema.AccountType.ACCOUNT_TYPE_INSURANCE)
-            .map((a) => {
+            .map((a) => (
-              const id = `${a.type}:${a.asset.id}`;
+              <AccordionItem
-              return (
+                itemId={`${a.type}:${a.asset.id}`}
-                <AccordionItem
+                title={t('Insurance pool')}
-                  key={id}
+                content={<InsurancePoolInfoPanel market={market} account={a} />}
-                  itemId={id}
+              />
-                  title={t('Insurance pool')}
+            ))}
-                  content={
-                    <InsurancePoolInfoPanel market={market} account={a} />
-                  }
-                />
-              );
-            })}
         </Accordion>
       </div>
       <div className="mb-8">
@@ -204,22 +201,18 @@ export const MarketInfoAccordion = ({
             content={<RiskFactorsInfoPanel market={market} />}
           />
           {(market.priceMonitoringSettings?.parameters?.triggers || []).map(
-            (_, triggerIndex) => {
+            (_, triggerIndex) => (
-              const id = `trigger-${triggerIndex}`;
+              <AccordionItem
-              return (
+                itemId={`trigger-${triggerIndex}`}
-                <AccordionItem
+                title={t(`Price monitoring bounds ${triggerIndex + 1}`)}
-                  key={id}
+                content={
-                  itemId={id}
+                  <PriceMonitoringBoundsInfoPanel
-                  title={t(`Price monitoring bounds ${triggerIndex + 1}`)}
+                    market={market}
-                  content={
+                    triggerIndex={triggerIndex}
-                    <PriceMonitoringBoundsInfoPanel
+                  />
-                      market={market}
+                }
-                      triggerIndex={triggerIndex}
+              />
-                    />
+            )
-                  }
-                />
-              );
-            }
           )}
           <AccordionItem
             itemId="liqudity-monitoring-parameters"

libs/orders/src/lib/components/order-list-manager/order-list-manager.tsx

@@ -139,7 +139,7 @@ export const OrderListManager = ({
 };
 
 const CancelAllOrdersButton = ({ onClick }: { onClick: () => void }) => (
-  <div className="dark:bg-black/75 bg-white/75 h-auto flex justify-end p-2 absolute bottom-0 right-0 rounded">
+  <div className="dark:bg-black/75 bg-white/75 h-auto flex justify-end px-[11px] py-2 absolute bottom-0 right-3 rounded">
     <Button
       variant="primary"
       size="sm"

libs/tailwindcss-config/src/theme.js

@@ -16,16 +16,22 @@ module.exports = {
     market: {
       red: {
         // same as vega-red
-        650: '#550016',
+        700: '#2F000C',
+        600: '#7B001F',
+        550: '#B3002E',
         DEFAULT: '#EC003C',
+        500: '#EC003C',
+        400: '#F57382',
         300: '#FDD9DC',
       },
       green: {
         // same as vega-green
-        650: '#015D30',
+        700: '#012915',
         600: '#01914B',
         550: '#01C566',
         DEFAULT: '#00F780',
+        500: '#00F780',
+        400: '#74BE8E',
         300: '#DDFEE8',
       },
     },
@@ -145,32 +151,6 @@ module.exports = {
         300: '#939393',
         400: '#626262',
       },
-
-      cdark: {
-        50: '#DCDEE3', // text-primary-light
-        100: '#94969B', // text-secondary
-        200: '#7C7E83',
-        300: '#626469',
-        400: '#44464B',
-        500: '#323339', // surface-container-highest
-        600: '#292B30',
-        700: '#202227',
-        800: '#17191E', // surface-container
-        900: '#05060C',
-      },
-
-      clight: {
-        50: '#040405',
-        100: '#4C4E51',
-        200: '#65676B',
-        300: '#818388',
-        400: '#AAABAE',
-        500: '#D1D2D3',
-        600: '#E9E9EA',
-        700: '#EEEEEF',
-        800: '#F4F4F4',
-        900: '#F9FAFA',
-      },
     },
     danger: '#FF077F',
     warning: '#FF8700',

libs/trades/src/lib/trades-table.tsx

@@ -80,7 +80,7 @@ export const TradesTable = forwardRef<AgGridReact, Props>(
                   onClick &&
                   onClick(addDecimal(value, data.market?.decimalPlaces || 0))
                 }
-                className="hover:dark:bg-vega-cdark-800 hover:bg-vega-clight-800"
+                className="hover:dark:bg-neutral-800 hover:bg-neutral-200"
               >
                 {addDecimalsFormatNumber(value, data.market.decimalPlaces)}
               </button>

libs/ui-toolkit/src/components/dropdown-menu/dropdown-menu.tsx

@@ -72,12 +72,12 @@ export const DropdownMenuRadioGroup = DropdownMenuPrimitive.RadioGroup;
 export const DropdownMenuContent = forwardRef<
   React.ElementRef<typeof DropdownMenuPrimitive.Content>,
   React.ComponentProps<typeof DropdownMenuPrimitive.Content>
->(({ className, sideOffset = 10, ...contentProps }, forwardedRef) => (
+>(({ className, ...contentProps }, forwardedRef) => (
   <DropdownMenuPrimitive.Content
     ref={forwardedRef}
+    sideOffset={10}
     className="min-w-[290px] bg-vega-light-100 dark:bg-vega-dark-100 p-2 rounded z-20 text-black dark:text-white border border-vega-light-200 dark:border-vega-dark-200"
     align="start"
-    sideOffset={sideOffset}
     {...contentProps}
   />
 ));

libs/ui-toolkit/src/components/icon/vega-icons/svg-icons/icon-cog.tsx

@@ -1,8 +0,0 @@
-export const IconCog = ({ size = 16 }: { size: number }) => {
-  return (
-    <svg width={size} height={size} viewBox="0 0 16 16">
-      <path d="M11.2 6.15051L8 4.30032L4.8 6.15051V9.84975L8 11.6999L11.2 9.84975V6.15051ZM5.7 9.33051V6.66975L8 5.33993L10.3 6.66975V9.33051L8 10.6603L5.7 9.33051Z" />
-      <path d="M9.905 1.01514H6.125V2.67221L4.34419 3.70148L2.89648 2.85979L1.00056 6.13342L2.435 6.96739V9.02288L1.00154 9.85629L2.88434 13.1291L4.31971 12.3057L6.115 13.3386V14.9951H9.895V13.3386L11.6903 12.3057L13.1257 13.1291L15.0085 9.85629L13.575 9.02288V6.96739L15.0085 6.13399L13.1245 2.85921L11.6894 3.69357L9.905 2.66221V1.01514ZM6.915 3.12807V1.80514H9.115V3.11807L11.6906 4.60671L12.8355 3.94106L13.9315 5.84629L12.785 6.51288V9.47739L13.9315 10.144L12.8343 12.0512L11.6897 11.3946L9.105 12.8817V14.2051H6.905V12.8817L4.32029 11.3946L3.17566 12.0512L2.07846 10.144L3.225 9.47739V6.51288L2.07944 5.84686L3.18352 3.94049L4.08704 4.46579L4.27512 4.65387L6.915 3.12807Z" />
-    </svg>
-  );
-};

libs/ui-toolkit/src/components/icon/vega-icons/svg-icons/icon-ticket.tsx

@@ -1,20 +0,0 @@
-export const IconTicket = ({ size = 16 }: { size: number }) => {
-  return (
-    <svg width={size} height={size} viewBox="0 0 16 16">
-      <rect x="9" y="10" width="3" height="2" />
-      <rect x="9" y="7" width="3" height="1" />
-      <rect x="4" y="7" width="4" height="1" />
-      <rect x="6" y="4" width="6" height="1" />
-      <rect x="5" y="5" width="1" height="1" />
-      <rect x="4" y="4" width="1" height="1" />
-      <rect
-        x="2.5"
-        y="2.5"
-        width="11"
-        height="11"
-        fill="transparent"
-        stroke="currentColor"
-      />
-    </svg>
-  );
-};