From f7beb48ded2bbbf6a31c02edc740deb0cf4c759c Mon Sep 17 00:00:00 2001
From: maciek <maciek@vegaprotocol.io>
Date: Mon, 13 Mar 2023 15:25:30 +0100
Subject: [PATCH] chore: display latency in block height progressing as warn or
 error

---
 apps/trading/components/footer/footer.tsx   | 33 +++++++++++++++++++--
 libs/apollo-client/src/lib/apollo-client.ts | 20 ++++++++-----
 2 files changed, 43 insertions(+), 10 deletions(-)

diff --git a/apps/trading/components/footer/footer.tsx b/apps/trading/components/footer/footer.tsx
index 62ab51491..e1b8546f0 100644
--- a/apps/trading/components/footer/footer.tsx
+++ b/apps/trading/components/footer/footer.tsx
@@ -11,7 +11,10 @@ export const Footer = () => {
   const setNodeSwitcher = useGlobalStore(
     (store) => (open: boolean) => store.update({ nodeSwitcherDialog: open })
   );
-  const { blockDiff, datanodeBlockHeight } = useNodeHealth();
+  const { blockDiff, datanodeBlockHeight, datanodeVegaTime } = useNodeHealth();
+  const blockUpdateMsLatency = datanodeVegaTime
+    ? Date.now() - datanodeVegaTime.valueOf()
+    : 0;
 
   return (
     <footer className="px-4 py-1 text-xs border-t border-default text-vega-light-300 dark:text-vega-dark-300 lg:fixed bottom-0 left-0 border-r bg-white dark:bg-black">
@@ -22,6 +25,7 @@ export const Footer = () => {
             url={VEGA_URL}
             blockHeight={datanodeBlockHeight}
             blockDiff={blockDiff}
+            blockUpdateMsLatency={blockUpdateMsLatency}
             onClick={() => setNodeSwitcher(true)}
           />
         )}
@@ -34,6 +38,7 @@ interface NodeHealthProps {
   blockHeight: number | undefined;
   blockDiff: number | null;
   onClick: () => void;
+  blockUpdateMsLatency: number;
 }
 
 export const NodeHealth = ({
@@ -41,11 +46,15 @@ export const NodeHealth = ({
   blockHeight,
   blockDiff,
   onClick,
+  blockUpdateMsLatency,
 }: NodeHealthProps) => {
   return (
     <FooterButton onClick={onClick} data-testid="node-health">
       <FooterButtonPart>
-        <HealthIndicator blockDiff={blockDiff} />
+        <HealthIndicator
+          blockDiff={blockDiff}
+          blockUpdateMsLatency={blockUpdateMsLatency}
+        />
       </FooterButtonPart>
       <FooterButtonPart>
         <NodeUrl url={url} />
@@ -70,13 +79,19 @@ export const NodeUrl = ({ url }: NodeUrlProps) => {
 
 interface HealthIndicatorProps {
   blockDiff: number | null;
+  blockUpdateMsLatency: number;
 }
 
 // How many blocks behind the most advanced block that is
 // deemed acceptable for "Good" status
 const BLOCK_THRESHOLD = 3;
+const ERROR_LATENCY = 20000;
+const WARNING_LATENCY = 10000;
 
-export const HealthIndicator = ({ blockDiff }: HealthIndicatorProps) => {
+export const HealthIndicator = ({
+  blockDiff,
+  blockUpdateMsLatency,
+}: HealthIndicatorProps) => {
   const online = useNavigatorOnline();
 
   let intent = Intent.Success;
@@ -89,9 +104,21 @@ export const HealthIndicator = ({ blockDiff }: HealthIndicatorProps) => {
     // Block height query failed and null was returned
     text = t('Non operational');
     intent = Intent.Danger;
+  } else if (blockUpdateMsLatency > ERROR_LATENCY) {
+    text = t('Erroneous latency ( >%s sec): %s sec', [
+      (ERROR_LATENCY / 1000).toFixed(2),
+      (blockUpdateMsLatency / 1000).toFixed(2),
+    ]);
+    intent = Intent.Danger;
   } else if (blockDiff >= BLOCK_THRESHOLD) {
     text = t(`${blockDiff} Blocks behind`);
     intent = Intent.Warning;
+  } else if (blockUpdateMsLatency > WARNING_LATENCY) {
+    text = t('Warning delay ( >%s sec): %s sec', [
+      (WARNING_LATENCY / 1000).toFixed(2),
+      (blockUpdateMsLatency / 1000).toFixed(2),
+    ]);
+    intent = Intent.Warning;
   }
 
   return (
diff --git a/libs/apollo-client/src/lib/apollo-client.ts b/libs/apollo-client/src/lib/apollo-client.ts
index 94b74aaa8..77d0d023c 100644
--- a/libs/apollo-client/src/lib/apollo-client.ts
+++ b/libs/apollo-client/src/lib/apollo-client.ts
@@ -59,13 +59,19 @@ export function createClient({
           const timestamp = r?.headers.get('x-block-timestamp');
           if (blockHeight && timestamp) {
             const state = useHeaderStore.getState();
-            useHeaderStore.setState({
-              ...state,
-              [r.url]: {
-                blockHeight: Number(blockHeight),
-                timestamp: new Date(Number(timestamp.slice(0, -6))),
-              },
-            });
+            const urlState = state[r.url];
+            if (
+              !urlState?.blockHeight ||
+              urlState.blockHeight !== blockHeight
+            ) {
+              useHeaderStore.setState({
+                ...state,
+                [r.url]: {
+                  blockHeight: Number(blockHeight),
+                  timestamp: new Date(Number(timestamp.slice(0, -6))),
+                },
+              });
+            }
           }
           return response;
         });