LaconicNetwork/vega-frontend-monorepo
3
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

fix(deposits): deposit dialog doesn't respect given assetId (#3414)

Browse Source
This commit is contained in:
Maciek 2023-04-11 16:41:20 +02:00 committed by GitHub
parent 03f5ca3096
commit f3fe43724e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 10 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/deposits/src/lib/deposit-form.tsx
View File

@ -100,7 +100,7 @@ export const DepositForm = ({
defaultValues: { defaultValues: {
to: pubKey ? pubKey : undefined, to: pubKey ? pubKey : undefined,
asset: selectedAsset?.id, asset: selectedAsset?.id,
amount: persistedDeposit.amount, amount: persistedDeposit?.amount,
}, },
}); });

3
libs/deposits/src/lib/deposit-manager.tsx
View File

@ -70,7 +70,8 @@ export const DepositManager = ({
const onAmountChange = useCallback( const onAmountChange = useCallback(
(amount: string) => { (amount: string) => {
savePersistentDeposit({ ...persistentDeposit, amount }); persistentDeposit &&
savePersistentDeposit({ ...persistentDeposit, amount });
}, },
[savePersistentDeposit, persistentDeposit] [savePersistentDeposit, persistentDeposit]
); );

2
libs/deposits/src/lib/use-persistent-deposit.spec.ts
View File

@ -4,7 +4,7 @@ import { usePersistentDeposit } from './use-persistent-deposit';
describe('usePersistenDeposit', () => { describe('usePersistenDeposit', () => {
it('should return empty data', () => { it('should return empty data', () => {
const { result } = renderHook(() => usePersistentDeposit()); const { result } = renderHook(() => usePersistentDeposit());
expect(result.current).toEqual([{ assetId: '' }, expect.any(Function)]); expect(result.current).toEqual([undefined, expect.any(Function)]);
}); });
it('should return empty and properly saved data', async () => { it('should return empty and properly saved data', async () => {
const aId = 'test'; const aId = 'test';

8
libs/deposits/src/lib/use-persistent-deposit.ts
View File

@ -32,10 +32,14 @@ const usePersistentDepositStore = create<{
export const usePersistentDeposit = ( export const usePersistentDeposit = (
assetId?: string assetId?: string
): [PersistedDeposit, (entry: PersistedDeposit) => void] => { ): [PersistedDeposit | undefined, (entry: PersistedDeposit) => void] => {
const { deposits, lastVisited, saveValue } = usePersistentDepositStore(); const { deposits, lastVisited, saveValue } = usePersistentDepositStore();
const discoveredData = useMemo(() => { const discoveredData = useMemo(() => {
return deposits[assetId || ''] || lastVisited || { assetId: assetId || '' }; return assetId
? deposits[assetId]
? deposits[assetId]
: { assetId }
: lastVisited;
}, [deposits, lastVisited, assetId]); }, [deposits, lastVisited, assetId]);
return [discoveredData, saveValue]; return [discoveredData, saveValue];