chore(trading): cherry pick position pnl formatting fix (#4347)

libs/positions/src/lib/positions-table.spec.tsx

@@ -6,6 +6,7 @@ import type { Position } from './positions-data-providers';
 import * as Schema from '@vegaprotocol/types';
 import { PositionStatus, PositionStatusMapping } from '@vegaprotocol/types';
 import type { ICellRendererParams } from 'ag-grid-community';
+import { addDecimalsFormatNumber } from '@vegaprotocol/utils';
 
 jest.mock('./liquidation-price', () => ({
   LiquidationPrice: () => (
@@ -19,7 +20,7 @@ const singleRow: Position = {
   assetSymbol: 'BTC',
   averageEntryPrice: '133',
   currentLeverage: 1.1,
-  decimals: 2,
+  decimals: 2, // this is settlementAsset.decimals
   quantum: '0.1',
   lossSocializationAmount: '0',
   marginAccountBalance: '12345600',
@@ -177,12 +178,23 @@ it('displays allocated margin', async () => {
 });
 
 it('displays realised and unrealised PNL', async () => {
+  // pnl cells should be rendered with asset dps
+  const expectedRealised = addDecimalsFormatNumber(
+    singleRow.realisedPNL,
+    singleRow.decimals
+  );
+  const expectedUnrealised = addDecimalsFormatNumber(
+    singleRow.unrealisedPNL,
+    singleRow.decimals
+  );
+
   await act(async () => {
     render(<PositionsTable rowData={singleRowData} isReadOnly={false} />);
   });
+
   const cells = screen.getAllByRole('gridcell');
-  expect(cells[9].textContent).toEqual('12.3');
+  expect(cells[9].textContent).toEqual(expectedRealised);
-  expect(cells[10].textContent).toEqual('45.6');
+  expect(cells[10].textContent).toEqual(expectedUnrealised);
 });
 
 it('displays close button', async () => {

libs/positions/src/lib/positions-table.tsx

@@ -375,10 +375,7 @@ export const PositionsTable = forwardRef<AgGridReact, Props>(
               }: VegaValueFormatterParams<Position, 'realisedPNL'>) => {
                 return !data
                   ? ''
-                  : addDecimalsFormatNumber(
+                  : addDecimalsFormatNumber(data.realisedPNL, data.decimals);
-                      data.realisedPNL,
-                      data.marketDecimalPlaces
-                    );
               },
               headerTooltip: t(
                 'Profit or loss is realised whenever your position is reduced to zero and the margin is released back to your collateral balance. P&L excludes any fees paid.'
@@ -396,20 +393,14 @@ export const PositionsTable = forwardRef<AgGridReact, Props>(
               valueGetter: ({ data }: VegaValueGetterParams<Position>) => {
                 return !data
                   ? undefined
-                  : toBigNum(
+                  : toBigNum(data.unrealisedPNL, data.decimals).toNumber();
-                      data.unrealisedPNL,
-                      data.marketDecimalPlaces
-                    ).toNumber();
               },
               valueFormatter: ({
                 data,
               }: VegaValueFormatterParams<Position, 'unrealisedPNL'>) =>
                 !data
                   ? ''
-                  : addDecimalsFormatNumber(
+                  : addDecimalsFormatNumber(data.unrealisedPNL, data.decimals),
-                      data.unrealisedPNL,
-                      data.marketDecimalPlaces
-                    ),
               headerTooltip: t(
                 'Unrealised profit is the current profit on your open position. Margin is still allocated to your position.'
               ),