From e274b7a873850f2ebee0fff6627e4353cf7dbfd6 Mon Sep 17 00:00:00 2001
From: Matthew Russell <mattrussell36@gmail.com>
Date: Fri, 30 Jun 2023 17:07:12 -0700
Subject: [PATCH] test: fix market selector tests

---
 .../market/market-selector-item.spec.tsx           | 14 ++++++--------
 .../client-pages/market/market-selector-item.tsx   |  5 ++++-
 .../client-pages/market/market-selector.spec.tsx   |  1 -
 .../client-pages/market/market-selector.tsx        |  2 --
 4 files changed, 10 insertions(+), 12 deletions(-)

diff --git a/apps/trading/client-pages/market/market-selector-item.spec.tsx b/apps/trading/client-pages/market/market-selector-item.spec.tsx
index f55b5540d..8b434e211 100644
--- a/apps/trading/client-pages/market/market-selector-item.spec.tsx
+++ b/apps/trading/client-pages/market/market-selector-item.spec.tsx
@@ -173,7 +173,7 @@ describe('MarketSelectorItem', () => {
     // link renders and is styled
     expect(link).toHaveAttribute('href', '/markets/' + market.id);
 
-    expect(link).toHaveClass('ring-1');
+    expect(link.parentNode).toHaveClass('bg-vega-light-100');
 
     expect(screen.getByTitle('24h vol')).toHaveTextContent('0.00');
     expect(screen.getByTitle(symbol)).toHaveTextContent('-');
@@ -183,13 +183,11 @@ describe('MarketSelectorItem', () => {
       expect(screen.getByTitle(symbol)).toHaveTextContent(
         addDecimalsFormatNumber(marketData.markPrice, market.decimalPlaces)
       );
-      expect(screen.getByTestId('market-item-change')).toHaveTextContent(
-        '+100.00%'
-      );
+      // TODO: re add if we use price change value
+
+      // expect(screen.getByTestId('market-item-change')).toHaveTextContent(
+      //   '+100.00%'
+      // );
     });
-
-    await userEvent.click(link);
-
-    expect(mockOnSelect).toHaveBeenCalledWith(market.id);
   });
 });
diff --git a/apps/trading/client-pages/market/market-selector-item.tsx b/apps/trading/client-pages/market/market-selector-item.tsx
index 019c07aba..6a2071a27 100644
--- a/apps/trading/client-pages/market/market-selector-item.tsx
+++ b/apps/trading/client-pages/market/market-selector-item.tsx
@@ -26,8 +26,11 @@ export const MarketSelectorItem = ({
   style: CSSProperties;
   currentMarketId?: string;
 }) => {
+  const wrapperClasses = classNames('py-1 px-4', {
+    'bg-vega-light-100 dark:bg-vega-dark-100': market.id === currentMarketId,
+  });
   return (
-    <div style={style} className="my-0.5 px-4">
+    <div style={style} className={wrapperClasses}>
       <Link to={`/markets/${market.id}`} className="block">
         <MarketData market={market} />
       </Link>
diff --git a/apps/trading/client-pages/market/market-selector.spec.tsx b/apps/trading/client-pages/market/market-selector.spec.tsx
index e6894ac5d..86d938dae 100644
--- a/apps/trading/client-pages/market/market-selector.spec.tsx
+++ b/apps/trading/client-pages/market/market-selector.spec.tsx
@@ -143,7 +143,6 @@ describe('MarketSelector', () => {
     expect(screen.getAllByTestId(/market-\d/)).toHaveLength(
       activeMarkets.length
     );
-    expect(screen.getByRole('link')).toHaveTextContent('All markets');
   });
 
   it('filters by product type', async () => {
diff --git a/apps/trading/client-pages/market/market-selector.tsx b/apps/trading/client-pages/market/market-selector.tsx
index 9795b5a50..ce8892471 100644
--- a/apps/trading/client-pages/market/market-selector.tsx
+++ b/apps/trading/client-pages/market/market-selector.tsx
@@ -9,7 +9,6 @@ import {
 } from '@vegaprotocol/ui-toolkit';
 import type { CSSProperties } from 'react';
 import { useCallback, useState, useMemo } from 'react';
-import { Link } from 'react-router-dom';
 import { FixedSizeList } from 'react-window';
 import { useMarketSelectorList } from './use-market-selector-list';
 import type { ProductType } from './product-selector';
@@ -202,7 +201,6 @@ const ListItem = ({
     market={data.data[index]}
     currentMarketId={data.currentMarketId}
     style={style}
-    onSelect={data.onSelect}
   />
 );