LaconicNetwork/vega-frontend-monorepo
4
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

chore: add regression tagged tests to PR runs (#2242)

Browse Source 
* chore: fix trading-portfolio test

* chore: fix wallet connect

* chore: fix failing deal ticket validation test

* chore: add regression tagged tests to be run during pr checks

* chore: skip parties tests in explorer-e2e

Co-authored-by: maciek <maciek@vegaprotocol.io>
This commit is contained in:
Radosław Szpiech 2022-11-28 15:13:57 +01:00 committed by GitHub
parent 96e082cb5d
commit c60e5841f7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
5 changed files with 12 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.github/workflows/capsule-cypress.yml vendored
View File

@ -67,4 +67,4 @@ jobs:
project: ${{ needs.pr.outputs.projects }} project: ${{ needs.pr.outputs.projects }}
vega-version: ${{needs.pr.outputs.vega-version}} vega-version: ${{needs.pr.outputs.vega-version}}
gobin: ${{needs.pr.outputs.gobin}} gobin: ${{needs.pr.outputs.gobin}}
tags: "--env.grepTags='@smoke'" tags: "--env.grepTags='[@smoke, @regression]'"

4
apps/explorer-e2e/src/integration/parties.cy.js
View File

@ -14,7 +14,9 @@ let assetData = {
const assetsInTest = Object.keys(assetData); const assetsInTest = Object.keys(assetData);
context('Parties page', { tags: '@regression' }, function () { // skipped due to existing issue
// https://github.com/vegaprotocol/frontend-monorepo/issues/2243
context.skip('Parties page', { tags: '@regression' }, function () {
before('send-faucet assets to connected vega wallet', function () { before('send-faucet assets to connected vega wallet', function () {
assetsInTest.forEach((asset) => { assetsInTest.forEach((asset) => {
cy.vega_wallet_receive_fauceted_asset( cy.vega_wallet_receive_fauceted_asset(

2
apps/trading-e2e/src/integration/trading-deal-ticket.cy.ts
View File

@ -718,7 +718,7 @@ describe('account validation', { tags: '@regression' }, () => {
); );
cy.getByTestId('dealticket-warning-margin').should( cy.getByTestId('dealticket-warning-margin').should(
'contain.text', 'contain.text',
'10,000 tBTC currently required, 1,000 tBTC available' '10,000.00 tBTC currently required, 1,000.00 tBTC available'
); );
cy.getByTestId('deal-ticket-deposit-dialog-button').click(); cy.getByTestId('deal-ticket-deposit-dialog-button').click();
cy.getByTestId('dialog-content') cy.getByTestId('dialog-content')

6
apps/trading-e2e/src/integration/trading-portfolio.cy.ts
View File

@ -4,7 +4,7 @@ import { connectVegaWallet } from '../support/vega-wallet';
import { generateAssets } from '../support/mocks/generate-assets'; import { generateAssets } from '../support/mocks/generate-assets';
import { generateMarkets } from '../support/mocks/generate-markets'; import { generateMarkets } from '../support/mocks/generate-markets';
describe('Portfolio page', { tags: '@regression' }, () => { describe('Portfolio page', { tags: '@smoke' }, () => {
beforeEach(() => { beforeEach(() => {
cy.mockGQL((req) => { cy.mockGQL((req) => {
aliasQuery(req, 'LedgerEntries', generateLedgerEntries()); aliasQuery(req, 'LedgerEntries', generateLedgerEntries());
@ -17,7 +17,7 @@ describe('Portfolio page', { tags: '@regression' }, () => {
it('List should be properly rendered', () => { it('List should be properly rendered', () => {
cy.visit('/#/portfolio'); cy.visit('/#/portfolio');
connectVegaWallet(); connectVegaWallet();
cy.get('[data-testid="Ledger entries"]').click(); cy.getByTestId('"Ledger entries"').click();
const headers = [ const headers = [
'Sender', 'Sender',
'Receiver', 'Receiver',
@ -26,7 +26,7 @@ describe('Portfolio page', { tags: '@regression' }, () => {
'Asset', 'Asset',
'Vega Time', 'Vega Time',
]; ];
cy.get('.ag-header-row.ag-header-row-column').within(($headers) => { cy.getByTestId('tab-ledger-entries').within(($headers) => {
cy.wrap($headers) cy.wrap($headers)
.get('.ag-header-cell-text') .get('.ag-header-cell-text')
.each(($header, i) => { .each(($header, i) => {

6
libs/deal-ticket/src/hooks/use-order-margin.ts
View File

@ -5,6 +5,7 @@ import { useMarketPositions } from './use-market-positions';
import type { EstimateOrderQuery } from './__generated__/EstimateOrder'; import type { EstimateOrderQuery } from './__generated__/EstimateOrder';
import { useEstimateOrderQuery } from './__generated__/EstimateOrder'; import { useEstimateOrderQuery } from './__generated__/EstimateOrder';
import type { MarketDealTicket } from '@vegaprotocol/market-list'; import type { MarketDealTicket } from '@vegaprotocol/market-list';
import { getDerivedPrice } from '../utils/get-price';
export interface Props { export interface Props {
order: OrderSubmissionBody['orderSubmission']; order: OrderSubmissionBody['orderSubmission'];
@ -36,18 +37,19 @@ export const useOrderMargin = ({
derivedPrice, derivedPrice,
}: Props): OrderMargin | null => { }: Props): OrderMargin | null => {
const marketPositions = useMarketPositions({ marketId: market.id, partyId }); const marketPositions = useMarketPositions({ marketId: market.id, partyId });
const priceForEstimate = derivedPrice || getDerivedPrice(order, market);
const { data } = useEstimateOrderQuery({ const { data } = useEstimateOrderQuery({
variables: { variables: {
marketId: market.id, marketId: market.id,
partyId, partyId,
price: derivedPrice, price: priceForEstimate,
size: removeDecimal(order.size, market.positionDecimalPlaces), size: removeDecimal(order.size, market.positionDecimalPlaces),
side: order.side, side: order.side,
timeInForce: order.timeInForce, timeInForce: order.timeInForce,
type: order.type, type: order.type,
}, },
skip: !partyId || !market.id || !order.size || !derivedPrice, skip: !partyId || !market.id || !order.size || !priceForEstimate,
}); });
if (data?.estimateOrder.marginLevels.initialLevel) { if (data?.estimateOrder.marginLevels.initialLevel) {