LaconicNetwork/vega-frontend-monorepo
4
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

fix(trading): deal ticket limit price input and margin warning (#3050)

Browse Source
This commit is contained in:
m.ray 2023-03-01 09:23:21 -05:00 committed by GitHub
parent 6799a06acd
commit 886b0cb6d3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
libs/deal-ticket/src/components/deal-ticket/deal-ticket-fee-details.tsx
View File

@ -1,5 +1,6 @@
import { Tooltip } from '@vegaprotocol/ui-toolkit'; import { Tooltip } from '@vegaprotocol/ui-toolkit';
import type { ReactNode } from 'react'; import type { ReactNode } from 'react';
import { useMemo } from 'react';
import type { OrderSubmissionBody } from '@vegaprotocol/wallet'; import type { OrderSubmissionBody } from '@vegaprotocol/wallet';
import type { Market, MarketData } from '@vegaprotocol/market-list'; import type { Market, MarketData } from '@vegaprotocol/market-list';
import { import {
@ -26,7 +27,7 @@ export const DealTicketFeeDetails = ({
marketData, marketData,
}: DealTicketFeeDetailsProps) => { }: DealTicketFeeDetailsProps) => {
const feeDetails = useFeeDealTicketDetails(order, market, marketData); const feeDetails = useFeeDealTicketDetails(order, market, marketData);
const details = getFeeDetailsValues(feeDetails); const details = useMemo(() => getFeeDetailsValues(feeDetails), [feeDetails]);
return ( return (
<div> <div>
{details.map(({ label, value, labelDescription, symbol }) => ( {details.map(({ label, value, labelDescription, symbol }) => (

7
libs/deal-ticket/src/components/deal-ticket/deal-ticket.tsx
View File

@ -36,6 +36,7 @@ import {
usePersistedOrderStore, usePersistedOrderStore,
usePersistedOrderStoreSubscription, usePersistedOrderStoreSubscription,
} from '@vegaprotocol/orders'; } from '@vegaprotocol/orders';
import { OrderType } from '@vegaprotocol/types';
export type TransactionStatus = 'default' | 'pending'; export type TransactionStatus = 'default' | 'pending';
@ -82,7 +83,9 @@ export const DealTicket = ({
const order = watch(); const order = watch();
watch((orderData) => { watch((orderData) => {
setPersistedOrder(orderData as DealTicketFormFields); if (orderData.type === OrderType.TYPE_LIMIT && orderData.price === '') {
setPersistedOrder(orderData as DealTicketFormFields);
}
}); });
usePersistedOrderStoreSubscription(market.id, (storedOrder) => { usePersistedOrderStoreSubscription(market.id, (storedOrder) => {
@ -369,7 +372,7 @@ const SummaryMessage = memo(
if (balanceError) { if (balanceError) {
return ( return (
<div className="mb-2"> <div className="mb-2">
<MarginWarning balance={balance} margin={margin} asset={asset} />; <MarginWarning balance={balance} margin={margin} asset={asset} />
</div> </div>
); );
} }

2
libs/ui-toolkit/src/components/notification/notification.tsx
View File

@ -82,7 +82,7 @@ export const Notification = ({
{title} {title}
</div> </div>
)} )}
<div className="text-sm">{message}</div> <div className="text-sm [word-break:break-word]">{message}</div>
{buttonProps && ( {buttonProps && (
<Button <Button
size={buttonProps.size || 'sm'} size={buttonProps.size || 'sm'}