LaconicNetwork/vega-frontend-monorepo
3
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

fix(trading): remove price flash cell from PNL (#2829)

Browse Source
This commit is contained in:
m.ray 2023-02-03 09:59:24 -05:00 committed by GitHub
parent 0eddfa4073
commit 7f1e47d7fd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
libs/positions/src/lib/positions-table.tsx
View File

@ -19,6 +19,7 @@ import {
signedNumberCssClassRules, signedNumberCssClassRules,
DateRangeFilter, DateRangeFilter,
addDecimalsFormatNumber, addDecimalsFormatNumber,
PriceCell,
} from '@vegaprotocol/react-helpers'; } from '@vegaprotocol/react-helpers';
import { AgGridDynamic as AgGrid, Link } from '@vegaprotocol/ui-toolkit'; import { AgGridDynamic as AgGrid, Link } from '@vegaprotocol/ui-toolkit';
import { AgGridColumn } from 'ag-grid-react'; import { AgGridColumn } from 'ag-grid-react';
@ -84,7 +85,7 @@ export const PositionsTable = forwardRef<AgGridReact, Props>(
filterParams: { buttons: ['reset'] }, filterParams: { buttons: ['reset'] },
tooltipComponent: TooltipCellComponent, tooltipComponent: TooltipCellComponent,
}} }}
components={{ AmountCell, PriceFlashCell, ProgressBarCell }} components={{ AmountCell, PriceFlashCell, PriceCell, ProgressBarCell }}
{...props} {...props}
> >
<AgGridColumn <AgGridColumn
@ -335,7 +336,7 @@ export const PositionsTable = forwardRef<AgGridReact, Props>(
? undefined ? undefined
: addDecimalsFormatNumber(data.realisedPNL, data.decimals); : addDecimalsFormatNumber(data.realisedPNL, data.decimals);
}} }}
cellRenderer="PriceFlashCell" cellRenderer="PriceCell"
headerTooltip={t( headerTooltip={t(
'Profit or loss is realised whenever your position is reduced to zero and the margin is released back to your collateral balance. P&L excludes any fees paid.' 'Profit or loss is realised whenever your position is reduced to zero and the margin is released back to your collateral balance. P&L excludes any fees paid.'
)} )}
@ -360,7 +361,7 @@ export const PositionsTable = forwardRef<AgGridReact, Props>(
? undefined ? undefined
: addDecimalsFormatNumber(data.unrealisedPNL, data.decimals) : addDecimalsFormatNumber(data.unrealisedPNL, data.decimals)
} }
cellRenderer="PriceFlashCell" cellRenderer="PriceCell"
headerTooltip={t( headerTooltip={t(
'Unrealised profit is the current profit on your open position. Margin is still allocated to your position.' 'Unrealised profit is the current profit on your open position. Margin is still allocated to your position.'
)} )}