LaconicNetwork/vega-frontend-monorepo
4
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

chore: change name of the column (#2420)

Browse Source
This commit is contained in:
macqbat 2022-12-15 13:38:55 +01:00 committed by GitHub
parent dce802d153
commit 7d5cc9b080
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
apps/trading-e2e/src/integration/trading-positions.cy.ts
View File

@ -57,6 +57,11 @@ describe('positions', { tags: '@smoke' }, () => {
cy.get('[col-id="notional"]').should('contain.text', '276,761.40348'); // Total tDAI position cy.get('[col-id="notional"]').should('contain.text', '276,761.40348'); // Total tDAI position
cy.get('[col-id="realisedPNL"]').should('contain.text', '0.001'); // Total Realised PNL cy.get('[col-id="realisedPNL"]').should('contain.text', '0.001'); // Total Realised PNL
cy.get('[col-id="unrealisedPNL"]').should('contain.text', '8.95'); // Total Unrealised PNL cy.get('[col-id="unrealisedPNL"]').should('contain.text', '8.95'); // Total Unrealised PNL
cy.get('.ag-header-row [col-id="notional"]')
.should('contain.text', 'Notional')
.realHover();
cy.get('.ag-popup').should('contain.text', 'Mark price x open volume');
}); });
cy.getByTestId('close-position').should('be.visible').and('have.length', 3); cy.getByTestId('close-position').should('be.visible').and('have.length', 3);

2
libs/positions/src/lib/positions-table.spec.tsx
View File

@ -48,7 +48,7 @@ it('Render correct columns', async () => {
headers.map((h) => h.querySelector('[ref="eText"]')?.textContent?.trim()) headers.map((h) => h.querySelector('[ref="eText"]')?.textContent?.trim())
).toEqual([ ).toEqual([
'Market', 'Market',
'Notional size', 'Notional',
'Open volume', 'Open volume',
'Mark price', 'Mark price',
'Settlement asset', 'Settlement asset',

3
libs/positions/src/lib/positions-table.tsx
View File

@ -138,7 +138,8 @@ export const PositionsTable = forwardRef<AgGridReact, Props>(
}} }}
/> />
<AgGridColumn <AgGridColumn
headerName={t('Notional size')} headerName={t('Notional')}
headerTooltip={t('Mark price x open volume.')}
field="notional" field="notional"
type="rightAligned" type="rightAligned"
cellClass="font-mono text-right" cellClass="font-mono text-right"