feat(trading): show inactive rewards (#6031)

apps/trading/components/rewards-container/reward-card.tsx

@@ -188,7 +188,7 @@ const RewardCard = ({
                 <span className="text-muted text-xs">{t('Starts in')} </span>
                 <span data-testid="starts-in" data-startsin={startsIn}>
                   {t('numberEpochs', '{{count}} epochs', {
-                    count: endsIn,
+                    count: startsIn,
                   })}
                 </span>
               </span>

apps/trading/lib/hooks/use-rewards.spec.ts

@@ -138,7 +138,7 @@ describe('isActiveReward', () => {
         makeDispatchStrategy(EntityScope.ENTITY_SCOPE_TEAMS),
         'RecurringTransfer'
       ),
-      false,
+      true,
     ],
     [
       makeReward(

apps/trading/lib/hooks/use-rewards.ts

@@ -56,17 +56,16 @@ export const isReward = (node: TransferNode): node is RewardTransfer => {
 };
 
 /**
- * Checks if given reward (transfer) is active.
+ * Checks if given reward (transfer) is has not ended. If it is active or due to start in the future.
  */
 export const isActiveReward = (node: RewardTransfer, currentEpoch: number) => {
   const { transfer } = node;
 
   const pending = transfer.status === TransferStatus.STATUS_PENDING;
   const withinEpochs =
-    transfer.kind.startEpoch <= currentEpoch &&
-    (transfer.kind.endEpoch != null
+    transfer.kind.endEpoch != null
       ? transfer.kind.endEpoch >= currentEpoch
-      : true);
+      : true;
 
   if (pending && withinEpochs) return true;
   return false;