LaconicNetwork/vega-frontend-monorepo
3
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

test: reintroduce tests that were failing (#1505)

Browse Source
This commit is contained in:
Dexter Edwards 2022-10-11 14:36:16 +01:00 committed by GitHub
parent a7d100bce8
commit 6ec6c6b8b7
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
apps/token/.env
View File

@ -13,3 +13,4 @@ NX_HOSTED_WALLET_URL=https://wallet.testnet.vega.xyz
#Test configuration variables #Test configuration variables
CYPRESS_FAIRGROUND=false CYPRESS_FAIRGROUND=false
LC_ALL="en_US.UTF-8"

12
apps/token/src/routes/governance/components/propose/proposal-form-vote-and-enactment-deadline.spec.tsx
View File

@ -127,8 +127,7 @@ describe('Proposal form vote, validation and enactment deadline', () => {
expect(screen.getByTestId('validation-2-mins-extra')).toBeTruthy(); expect(screen.getByTestId('validation-2-mins-extra')).toBeTruthy();
}); });
// eslint-disable-next-line jest/no-disabled-tests it('should show the correct datetimes', () => {
it.skip('should show the correct datetimes', () => {
renderComponent(); renderComponent();
// Should be adding 2 mins to the vote deadline as the minimum is set by // Should be adding 2 mins to the vote deadline as the minimum is set by
// default, and we add 2 mins for wallet confirmation // default, and we add 2 mins for wallet confirmation
@ -143,8 +142,7 @@ describe('Proposal form vote, validation and enactment deadline', () => {
); );
}); });
// eslint-disable-next-line jest/no-disabled-tests it('should be updating every second, so show the correct datetimes when 30 seconds have passed', () => {
it.skip('should be updating every second, so show the correct datetimes when 30 seconds have passed', () => {
renderComponent(); renderComponent();
act(() => { act(() => {
jest.advanceTimersByTime(30000); jest.advanceTimersByTime(30000);
@ -161,8 +159,7 @@ describe('Proposal form vote, validation and enactment deadline', () => {
); );
}); });
// eslint-disable-next-line jest/no-disabled-tests it('update the vote deadline date and the enactment deadline date when the vote deadline is changed', () => {
it.skip('update the vote deadline date and the enactment deadline date when the vote deadline is changed', () => {
renderComponent(); renderComponent();
const voteDeadlineInput = screen.getByTestId('proposal-vote-deadline'); const voteDeadlineInput = screen.getByTestId('proposal-vote-deadline');
fireEvent.change(voteDeadlineInput, { target: { value: 2 } }); fireEvent.change(voteDeadlineInput, { target: { value: 2 } });
@ -174,8 +171,7 @@ describe('Proposal form vote, validation and enactment deadline', () => {
); );
}); });
// eslint-disable-next-line jest/no-disabled-tests it('updates the validation deadline max and date when the vote deadline max is changed', () => {
it.skip('updates the validation deadline max and date when the vote deadline max is changed', () => {
renderComponent(); renderComponent();
const voteDeadlineMinButton = screen.getByTestId('min-vote'); const voteDeadlineMinButton = screen.getByTestId('min-vote');
const voteDeadlineMaxButton = screen.getByTestId('max-vote'); const voteDeadlineMaxButton = screen.getByTestId('max-vote');

6
apps/token/src/routes/governance/components/propose/proposal-form-vote-and-enactment-deadline.tsx
View File

@ -91,7 +91,7 @@ const ValidationForm = ({
{t('ThisWillSetValidationDeadlineTo')} {t('ThisWillSetValidationDeadlineTo')}
</span> </span>
<span data-testid="validation-date" className="pl-2"> <span data-testid="validation-date" className="pl-2">
{deadlineDates.validation?.toLocaleString()} {deadlineDates.validation.toLocaleString()}
</span> </span>
{deadlines.validation === 0 && ( {deadlines.validation === 0 && (
<span <span
@ -179,7 +179,7 @@ const EnactmentForm = ({
{t('ThisWillSetEnactmentDeadlineTo')} {t('ThisWillSetEnactmentDeadlineTo')}
</span> </span>
<span data-testid="enactment-date" className="pl-2"> <span data-testid="enactment-date" className="pl-2">
{deadlineDates.enactment?.toLocaleString()} {deadlineDates.enactment.toLocaleString()}
</span> </span>
</p> </p>
)} )}
@ -406,7 +406,7 @@ export const ProposalFormVoteAndEnactmentDeadline = ({
{t('ThisWillSetVotingDeadlineTo')} {t('ThisWillSetVotingDeadlineTo')}
</span> </span>
<span data-testid="voting-date" className="pl-2"> <span data-testid="voting-date" className="pl-2">
{deadlineDates.vote?.toLocaleString()} {deadlineDates.vote.toLocaleString()}
</span> </span>
{deadlines.vote === minVoteHours && ( {deadlines.vote === minVoteHours && (
<span <span