LaconicNetwork/vega-frontend-monorepo
3
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

fix(trading): deal ticket validation on zero account balance and margin warnings (#3177)

Browse Source
This commit is contained in:
m.ray 2023-03-13 13:58:51 -04:00 committed by GitHub
parent 52ee998bf0
commit 676aeb07a4
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
libs/deal-ticket/src/components/deal-ticket/deal-ticket.tsx
View File

@ -116,7 +116,7 @@ export const DealTicket = ({
return; return;
} }
const hasNoBalance = generalAccountBalance === '0'; const hasNoBalance = !BigInt(generalAccountBalance);
if (hasNoBalance) { if (hasNoBalance) {
setError('summary', { setError('summary', {
message: SummaryValidationType.NoCollateral, message: SummaryValidationType.NoCollateral,
@ -141,7 +141,6 @@ export const DealTicket = ({
pubKey, pubKey,
setError, setError,
clearErrors, clearErrors,
errors.summary,
]); ]);
const onSubmit = useCallback( const onSubmit = useCallback(
@ -386,8 +385,12 @@ const SummaryMessage = memo(
// If there is no blocking error but user doesn't have enough // If there is no blocking error but user doesn't have enough
// balance render the margin warning, but still allow submission // balance render the margin warning, but still allow submission
if (BigInt(balance) < BigInt(margin)) { if (BigInt(balance) < BigInt(margin) && BigInt(balance) > BigInt(0)) {
return <MarginWarning balance={balance} margin={margin} asset={asset} />; return (
<div className="mb-2">
<MarginWarning balance={balance} margin={margin} asset={asset} />
</div>
);
} }
// Show auction mode warning // Show auction mode warning
if ( if (