From 67186bf4c0d09a0f8059dfe17ccf86b72533e17e Mon Sep 17 00:00:00 2001 From: daro-maj <119658839+daro-maj@users.noreply.github.com> Date: Tue, 21 Feb 2023 18:46:00 +0100 Subject: [PATCH] test(trading): node version update for live workflow (#2954) --- .github/workflows/cypress-live-test.yml | 4 ++++ apps/trading-e2e/src/integration/navbar.cy.ts | 5 ++--- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/.github/workflows/cypress-live-test.yml b/.github/workflows/cypress-live-test.yml index bad7b384e..68d9bc457 100644 --- a/.github/workflows/cypress-live-test.yml +++ b/.github/workflows/cypress-live-test.yml @@ -18,6 +18,10 @@ jobs: - name: Checkout uses: actions/checkout@v2 + - uses: actions/setup-node@v3 + with: + node-version: 16 + - name: Run Cypress tests uses: cypress-io/github-action@v4 with: diff --git a/apps/trading-e2e/src/integration/navbar.cy.ts b/apps/trading-e2e/src/integration/navbar.cy.ts index 25a740628..1b389e535 100644 --- a/apps/trading-e2e/src/integration/navbar.cy.ts +++ b/apps/trading-e2e/src/integration/navbar.cy.ts @@ -1,6 +1,6 @@ import { mockConnectWallet } from '@vegaprotocol/cypress'; -before(() => { +beforeEach(() => { cy.mockTradingPage(); cy.mockSubscription(); cy.visit('/'); @@ -19,11 +19,11 @@ describe('Desktop view', { tags: '@smoke' }, () => { cy.getByTestId('navbar') .find(`[data-testid="navbar-links"] a[data-testid=${link}]`) .then((element) => { + cy.contains('Loading...').should('not.exist'); cy.wrap(element).click(); cy.wrap(element) .get('span.absolute.md\\:h-1.w-full') .should('exist'); - cy.contains('No market').should('not.exist'); cy.location('hash').should('equal', hashes[index]); }); }); @@ -69,7 +69,6 @@ describe('Mobile view', { tags: '@smoke' }, () => { cy.getByTestId('button-menu-drawer').click(); cy.getByTestId('menu-drawer').within((el) => { cy.wrap(el).getByTestId('Trading').click(); - cy.contains('No market').should('not.exist'); cy.location('hash').should('equal', '#/markets/market-1'); }); });