LaconicNetwork/vega-frontend-monorepo
3
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

fix(trading): do not show alias edit on read only (#6111)

Browse Source
This commit is contained in:
m.ray 2024-03-27 10:11:37 +00:00 committed by GitHub
parent bfa6be4c1c
commit 64fc075f7a
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 18 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

28
apps/trading/components/vega-wallet-connect-button/vega-wallet-connect-button.tsx
View File

@ -96,6 +96,7 @@ export const VegaWalletConnectButton = ({
pubKeys={pubKeys} pubKeys={pubKeys}
activeKey={activeKey?.publicKey} activeKey={activeKey?.publicKey}
onSelect={selectPubKey} onSelect={selectPubKey}
isReadOnly={isReadOnly}
/> />
<TradingDropdownSeparator /> <TradingDropdownSeparator />
{!isReadOnly && ( {!isReadOnly && (
@ -141,11 +142,13 @@ const KeypairRadioGroup = ({
pubKeys, pubKeys,
activeKey, activeKey,
onSelect, onSelect,
isReadOnly,
}: { }: {
pubKey: string | undefined; pubKey: string | undefined;
pubKeys: Key[]; pubKeys: Key[];
activeKey: string | undefined; activeKey: string | undefined;
onSelect: (pubKey: string) => void; onSelect: (pubKey: string) => void;
isReadOnly: boolean;
}) => { }) => {
const { data } = usePartyProfilesQuery({ const { data } = usePartyProfilesQuery({
variables: { partyIds: pubKeys.map((pk) => pk.publicKey) }, variables: { partyIds: pubKeys.map((pk) => pk.publicKey) },
@ -165,6 +168,7 @@ const KeypairRadioGroup = ({
pk={pk} pk={pk}
isActive={activeKey === pk.publicKey} isActive={activeKey === pk.publicKey}
alias={profile?.node.alias} alias={profile?.node.alias}
isReadOnly={isReadOnly}
/> />
); );
})} })}
@ -176,10 +180,12 @@ const KeypairItem = ({
pk, pk,
isActive, isActive,
alias, alias,
isReadOnly,
}: { }: {
pk: Key; pk: Key;
alias: string | undefined; alias: string | undefined;
isActive: boolean; isActive: boolean;
isReadOnly: boolean;
}) => { }) => {
const t = useT(); const t = useT();
const [copied, setCopied] = useCopyTimeout(); const [copied, setCopied] = useCopyTimeout();
@ -210,16 +216,18 @@ const KeypairItem = ({
className={classNames('flex-1 mr-2 text-secondary text-sm')} className={classNames('flex-1 mr-2 text-secondary text-sm')}
data-testid={`key-${pk.publicKey}`} data-testid={`key-${pk.publicKey}`}
> >
<Tooltip description={t('Public facing key alias. Click to edit')}> {!isReadOnly && (
<button <Tooltip description={t('Public facing key alias. Click to edit')}>
data-testid="alias" <button
onClick={() => setOpen(pk.publicKey)} data-testid="alias"
className="flex items-center gap-1" onClick={() => setOpen(pk.publicKey)}
> className="flex items-center gap-1"
{alias ? alias : t('No alias')} >
{isActive && <VegaIcon name={VegaIconNames.EDIT} />} {alias ? alias : t('No alias')}
</button> {isActive && <VegaIcon name={VegaIconNames.EDIT} />}
</Tooltip> </button>
</Tooltip>
)}
</div> </div>
</div> </div>
<TradingDropdownItemIndicator /> <TradingDropdownItemIndicator />