feat(trading): show fills for all markets (#4951)

This commit is contained in:
Bartłomiej Głownia 2023-10-03 12:00:26 +02:00 committed by GitHub
parent eeff4ffcd4
commit 60ca6c2eb6
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 2 additions and 8 deletions

View File

@ -128,7 +128,7 @@ const MainGrid = memo(
</Tab> </Tab>
) : null} ) : null}
<Tab id="fills" name={t('Fills')}> <Tab id="fills" name={t('Fills')}>
<TradingViews.fills.component marketId={marketId} /> <TradingViews.fills.component />
</Tab> </Tab>
<Tab <Tab
id="accounts" id="accounts"

View File

@ -9,7 +9,7 @@ import type { DataGridSlice } from '../../stores/datagrid-store-slice';
import { createDataGridSlice } from '../../stores/datagrid-store-slice'; import { createDataGridSlice } from '../../stores/datagrid-store-slice';
import { useMarketClickHandler } from '../../lib/hooks/use-market-click-handler'; import { useMarketClickHandler } from '../../lib/hooks/use-market-click-handler';
export const FillsContainer = ({ marketId }: { marketId?: string }) => { export const FillsContainer = () => {
const onMarketClick = useMarketClickHandler(true); const onMarketClick = useMarketClickHandler(true);
const { pubKey } = useVegaWallet(); const { pubKey } = useVegaWallet();
@ -31,7 +31,6 @@ export const FillsContainer = ({ marketId }: { marketId?: string }) => {
return ( return (
<FillsManager <FillsManager
partyId={pubKey} partyId={pubKey}
marketId={marketId}
onMarketClick={onMarketClick} onMarketClick={onMarketClick}
gridProps={gridStoreCallbacks} gridProps={gridStoreCallbacks}
/> />

View File

@ -9,14 +9,12 @@ import { fillsWithMarketProvider } from './fills-data-provider';
interface FillsManagerProps { interface FillsManagerProps {
partyId: string; partyId: string;
marketId?: string;
onMarketClick?: (marketId: string, metaKey?: boolean) => void; onMarketClick?: (marketId: string, metaKey?: boolean) => void;
gridProps: ReturnType<typeof useDataGridEvents>; gridProps: ReturnType<typeof useDataGridEvents>;
} }
export const FillsManager = ({ export const FillsManager = ({
partyId, partyId,
marketId,
onMarketClick, onMarketClick,
gridProps, gridProps,
}: FillsManagerProps) => { }: FillsManagerProps) => {
@ -24,9 +22,6 @@ export const FillsManager = ({
const filter: Schema.TradesFilter | Schema.TradesSubscriptionFilter = { const filter: Schema.TradesFilter | Schema.TradesSubscriptionFilter = {
partyIds: [partyId], partyIds: [partyId],
}; };
if (marketId) {
filter.marketIds = [marketId];
}
const { data, error } = useDataProvider({ const { data, error } = useDataProvider({
dataProvider: fillsWithMarketProvider, dataProvider: fillsWithMarketProvider,
update: ({ data }) => { update: ({ data }) => {