LaconicNetwork/vega-frontend-monorepo
4
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

Fix: data test ids for price change and visual regression fixes (#511)

Browse Source 
* fix: add data test ids for price change percentage

* fix: add data test id for dialog overlay
This commit is contained in:
m.ray 2022-06-13 13:40:28 +01:00 committed by GitHub
parent 554097e391
commit 5f8061d5ce
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
4 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/market-list/src/lib/components/landing/landing-dialog.tsx
View File

@ -26,7 +26,7 @@ export const LandingDialog = ({ open, setOpen }: LandingDialogProps) => {
<AsyncRenderer loading={loading} error={error} data={data}> <AsyncRenderer loading={loading} error={error} data={data}>
<Dialog <Dialog
title={t('Select a market to get started')} title={t('Select a market to get started')}
intent={Intent.Warning} intent={Intent.Primary}
open={open} open={open}
onChange={setClose} onChange={setClose}
titleClassNames="font-bold font-sans text-3xl tracking-tight mb-0 pl-8" titleClassNames="font-bold font-sans text-3xl tracking-tight mb-0 pl-8"

2
libs/market-list/src/lib/components/landing/select-market-dialog.tsx
View File

@ -14,7 +14,7 @@ export const SelectMarketDialog = ({
return ( return (
<Dialog <Dialog
title={t('Select a market')} title={t('Select a market')}
intent={Intent.Warning} intent={Intent.Primary}
open={dialogOpen} open={dialogOpen}
onChange={() => setDialogOpen(false)} onChange={() => setDialogOpen(false)}
titleClassNames="font-bold font-sans text-3xl tracking-tight mb-0 pl-8" titleClassNames="font-bold font-sans text-3xl tracking-tight mb-0 pl-8"

5
libs/ui-toolkit/src/components/dialog/dialog.tsx
View File

@ -35,7 +35,10 @@ export function Dialog({
return ( return (
<DialogPrimitives.Root open={open} onOpenChange={(x) => onChange(x)}> <DialogPrimitives.Root open={open} onOpenChange={(x) => onChange(x)}>
<DialogPrimitives.Portal> <DialogPrimitives.Portal>
<DialogPrimitives.Overlay className="fixed inset-0 bg-black/50 z-10" /> <DialogPrimitives.Overlay
className="fixed inset-0 bg-black/50 z-10"
data-testid="dialog-overlay"
/>
<DialogPrimitives.Content className={contentClasses}> <DialogPrimitives.Content className={contentClasses}>
<DialogPrimitives.Close <DialogPrimitives.Close
className="p-12 absolute top-0 right-0" className="p-12 absolute top-0 right-0"

6
libs/ui-toolkit/src/components/price-change/price-change-cell.tsx
View File

@ -54,15 +54,15 @@ export const PriceCellChange = React.memo(
)} flex items-center gap-4 justify-end`} )} flex items-center gap-4 justify-end`}
> >
<Arrow value={change} /> <Arrow value={change} />
<span className="flex items-center gap-6 font-mono"> <span className="flex items-center gap-6 font-mono text-ui-small">
<span> <span data-testid="price-change-percentage">
{formatNumberPercentage( {formatNumberPercentage(
new BigNumber(changePercentage.toString()), new BigNumber(changePercentage.toString()),
2 2
)} )}
&nbsp; &nbsp;
</span> </span>
<span> <span data-testid="price-change">
{addDecimalsFormatNumber(change.toString(), decimalPlaces ?? 0, 3)} {addDecimalsFormatNumber(change.toString(), decimalPlaces ?? 0, 3)}
</span> </span>
</span> </span>