LaconicNetwork/vega-frontend-monorepo
3
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

fix(trading): ag-grid styling updates and filter fixes (#5368)

Browse Source
This commit is contained in:
m.ray 2023-11-29 00:13:12 +02:00 committed by GitHub
parent 73a118978f
commit 5ee1748495
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 8 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
apps/trading/client-pages/market/market.tsx
View File

@ -2,7 +2,7 @@ import React, { useEffect, useMemo } from 'react';
import { addDecimalsFormatNumber, titlefy } from '@vegaprotocol/utils'; import { addDecimalsFormatNumber, titlefy } from '@vegaprotocol/utils';
import { useScreenDimensions } from '@vegaprotocol/react-helpers'; import { useScreenDimensions } from '@vegaprotocol/react-helpers';
import { useThrottledDataProvider } from '@vegaprotocol/data-provider'; import { useThrottledDataProvider } from '@vegaprotocol/data-provider';
import { ExternalLink, Loader, Splash } from '@vegaprotocol/ui-toolkit'; import { Link, Loader, Splash } from '@vegaprotocol/ui-toolkit';
import { getAsset, marketDataProvider, useMarket } from '@vegaprotocol/markets'; import { getAsset, marketDataProvider, useMarket } from '@vegaprotocol/markets';
import { useGlobalStore, usePageTitleStore } from '../../stores'; import { useGlobalStore, usePageTitleStore } from '../../stores';
import { TradeGrid } from './trade-grid'; import { TradeGrid } from './trade-grid';
@ -117,12 +117,13 @@ export const MarketPage = () => {
defaults="Please choose another market from the <0>market list</0>" defaults="Please choose another market from the <0>market list</0>"
ns={ns} ns={ns}
components={[ components={[
<ExternalLink <Link
className="underline underline-offset-4 "
onClick={() => navigate(Links.MARKETS())} onClick={() => navigate(Links.MARKETS())}
key="link" key="link"
> >
market list market list
</ExternalLink>, </Link>,
]} ]}
/> />
</p> </p>

2
apps/trading/client-pages/markets/open-markets.tsx
View File

@ -43,7 +43,7 @@ export const OpenMarkets = () => {
if (!data) return; if (!data) return;
// prevent navigating to the market page if any of the below cells are clicked // prevent navigating to the market page if any of the below cells are clicked
// event.preventDefault or event.stopPropagation dont seem to apply for aggird // event.preventDefault or event.stopPropagation do not seem to apply for ag-grid
const colId = column.getColId(); const colId = column.getColId();
if ( if (

6
apps/trading/pages/styles.css
View File

@ -170,7 +170,7 @@ html [data-theme='dark'] {
.ag-theme-balham, .ag-theme-balham,
.ag-theme-balham-dark { .ag-theme-balham-dark {
--ag-grid-size: 2px; /* Used for compactness */ --ag-grid-size: 5px; /* Used for compactness */
--ag-row-height: 36px; --ag-row-height: 36px;
--ag-header-height: 28px; --ag-header-height: 28px;
} }
@ -184,7 +184,7 @@ html [data-theme='dark'] {
/* Light variables */ /* Light variables */
.ag-theme-balham { .ag-theme-balham {
--ag-background-color: transparent; --ag-background-color: theme(colors.vega.clight.900);
--ag-border-color: theme(colors.vega.clight.600); --ag-border-color: theme(colors.vega.clight.600);
--ag-header-background-color: theme(colors.vega.clight.700); --ag-header-background-color: theme(colors.vega.clight.700);
--ag-odd-row-background-color: transparent; --ag-odd-row-background-color: transparent;
@ -196,7 +196,7 @@ html [data-theme='dark'] {
/* Dark variables */ /* Dark variables */
.ag-theme-balham-dark { .ag-theme-balham-dark {
--ag-background-color: transparent; --ag-background-color: theme(colors.vega.cdark.900);
--ag-border-color: theme(colors.vega.cdark.600); --ag-border-color: theme(colors.vega.cdark.600);
--ag-header-background-color: theme(colors.vega.cdark.700); --ag-header-background-color: theme(colors.vega.cdark.700);
--ag-odd-row-background-color: transparent; --ag-odd-row-background-color: transparent;