From 4c20bb1e9ffa245fb7ee032cd5a03c5977559b16 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bart=C5=82omiej=20G=C5=82ownia?= <bglownia@gmail.com>
Date: Wed, 3 May 2023 20:34:52 +0200
Subject: [PATCH] chore: remove initializer from orders filter enum

---
 .../components/order-list-manager/order-list-manager.tsx | 9 ++++-----
 1 file changed, 4 insertions(+), 5 deletions(-)

diff --git a/libs/orders/src/lib/components/order-list-manager/order-list-manager.tsx b/libs/orders/src/lib/components/order-list-manager/order-list-manager.tsx
index 7623ae1b5..97822089b 100644
--- a/libs/orders/src/lib/components/order-list-manager/order-list-manager.tsx
+++ b/libs/orders/src/lib/components/order-list-manager/order-list-manager.tsx
@@ -20,8 +20,7 @@ import type { Order } from '../order-data-provider';
 import { OrderStatus } from '@vegaprotocol/types';
 
 export enum Filter {
-  // make filter value always truthy
-  'Open' = 1,
+  'Open',
   'Closed',
   'Rejected',
 }
@@ -78,7 +77,7 @@ export const OrderListManager = ({
   const { data, error, loading, reload } = useDataProvider({
     dataProvider: ordersWithMarketProvider,
     variables:
-      filter && filter === Filter.Open
+      filter === Filter.Open
         ? { partyId, filter: { liveOnly: true } }
         : { partyId },
   });
@@ -106,7 +105,7 @@ export const OrderListManager = ({
 
   const onGridReady = useCallback(
     ({ api }: GridReadyEvent) => {
-      if (filter) {
+      if (filter !== undefined) {
         api.setFilterModel({
           status: {
             value: FilterStatusValue[filter],
@@ -144,7 +143,7 @@ export const OrderListManager = ({
         <OrderListTable
           rowData={data as Order[]}
           ref={gridRef}
-          readonlyStatusFilter={Boolean(filter)}
+          readonlyStatusFilter={filter !== undefined}
           onGridReady={onGridReady}
           cancel={cancel}
           setEditOrder={setEditOrder}