LaconicNetwork/vega-frontend-monorepo
3
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

fix: governance links to proposals (#2478) (#2480)

Browse Source 
* fix: governance links to proposals

* fix:  fix proposals link in governance.cy.js

* fix: fix link for https://vega.xyz/governance
This commit is contained in:
m.ray 2022-12-27 10:18:42 -05:00 committed by GitHub
parent 61457bc24d
commit 485c609791
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 12 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
apps/trading-e2e/src/integration/market-info.cy.ts
View File

@ -183,12 +183,12 @@ describe('market info is displayed', { tags: '@smoke' }, () => {
.first() .first()
.should('have.text', 'View governance proposal') .should('have.text', 'View governance proposal')
.and('have.attr', 'href') .and('have.attr', 'href')
.and('contain', '/governance/market-0'); .and('contain', '/proposals/market-0');
cy.getByTestId(externalLink) cy.getByTestId(externalLink)
.eq(1) .eq(1)
.should('have.text', 'Propose a change to market') .should('have.text', 'Propose a change to market')
.and('have.attr', 'href') .and('have.attr', 'href')
.and('contain', '/governance/propose/update-market'); .and('contain', '/proposals/propose/update-market');
}); });
afterEach('close toggle', () => { afterEach('close toggle', () => {

2
apps/trading-e2e/src/integration/market-summary.cy.ts
View File

@ -49,7 +49,7 @@ describe('Market proposal notification', { tags: '@smoke' }, () => {
cy.getByTestId('external-link').should( cy.getByTestId('external-link').should(
'have.attr', 'have.attr',
'href', 'href',
'https://stagnet3.token.vega.xyz/governance/123' 'https://stagnet3.token.vega.xyz/proposals/123'
); );
}); });
}); });

2
apps/trading-e2e/src/integration/markets.cy.ts
View File

@ -106,7 +106,7 @@ describe('markets table', { tags: '@smoke' }, () => {
.and( .and(
'have.attr', 'have.attr',
'href', 'href',
'https://stagnet3.token.vega.xyz/governance/propose/new-market' 'https://stagnet3.token.vega.xyz/proposals/propose/new-market'
); );
}); });
}); });

10
libs/environment/src/hooks/use-links.ts
View File

@ -88,12 +88,12 @@ export const useEtherscanLink = () => {
export const BLOG = 'https://blog.vega.xyz/'; export const BLOG = 'https://blog.vega.xyz/';
// Token pages // Token pages
export const TOKEN_NEW_MARKET_PROPOSAL = '/governance/propose/new-market'; export const TOKEN_NEW_MARKET_PROPOSAL = '/proposals/propose/new-market';
export const TOKEN_NEW_NETWORK_PARAM_PROPOSAL = export const TOKEN_NEW_NETWORK_PARAM_PROPOSAL =
'/governance/propose/network-parameter'; '/proposals/propose/network-parameter';
export const TOKEN_GOVERNANCE = '/governance'; export const TOKEN_GOVERNANCE = '/proposals';
export const TOKEN_PROPOSALS = '/governance'; export const TOKEN_PROPOSALS = '/proposals';
export const TOKEN_PROPOSAL = '/governance/:id'; export const TOKEN_PROPOSAL = '/proposals/:id';
// Explorer pages // Explorer pages
export const EXPLORER_TX = '/txs/:hash'; export const EXPLORER_TX = '/txs/:hash';

2
libs/governance/src/lib/proposals-list/use-column-defs.tsx
View File

@ -55,7 +55,7 @@ export const useColumnDefs = () => {
const { change } = data?.terms || {}; const { change } = data?.terms || {};
if (instrumentGuard(change) && VEGA_TOKEN_URL) { if (instrumentGuard(change) && VEGA_TOKEN_URL) {
if (data?.id) { if (data?.id) {
const link = `${VEGA_TOKEN_URL}/governance/${data.id}`; const link = `${VEGA_TOKEN_URL}/proposals/${data.id}`;
return ( return (
<ExternalLink href={link}> <ExternalLink href={link}>
{change.instrument.code} {change.instrument.code}

4
libs/react-helpers/src/lib/links/links.ts
View File

@ -26,6 +26,6 @@ export const ExternalLinks = {
}; };
export const TokenLinks = { export const TokenLinks = {
PROPOSAL_PAGE: ':tokenUrl/governance/:proposalId', PROPOSAL_PAGE: ':tokenUrl/proposals/:proposalId',
UPDATE_PROPOSAL_PAGE: ':tokenUrl/governance/propose/update-market', UPDATE_PROPOSAL_PAGE: ':tokenUrl/proposals/propose/update-market',
}; };