From 45623f33c583d5425a537ae7dd534b56509102a0 Mon Sep 17 00:00:00 2001 From: Sam Keen Date: Fri, 8 Sep 2023 10:19:59 +0100 Subject: [PATCH] fix(governance): corrected sorting of upgrade proposals by blockheight (#4729) --- .../proposals/components/proposals-list/proposals-list.tsx | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/apps/governance/src/routes/proposals/components/proposals-list/proposals-list.tsx b/apps/governance/src/routes/proposals/components/proposals-list/proposals-list.tsx index 4cfac6cc3..e4fe5ec55 100644 --- a/apps/governance/src/routes/proposals/components/proposals-list/proposals-list.tsx +++ b/apps/governance/src/routes/proposals/components/proposals-list/proposals-list.tsx @@ -55,7 +55,10 @@ export const orderByUpgradeBlockHeight = ( ) => orderBy( arr, - [(p) => p?.upgradeBlockHeight, (p) => p.vegaReleaseTag], + [ + (p) => (p?.upgradeBlockHeight ? parseInt(p.upgradeBlockHeight, 10) : 0), + (p) => p.vegaReleaseTag, + ], ['desc', 'desc'] );