LaconicNetwork/vega-frontend-monorepo
4
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

fix(trading): market info number formatting (#4163)

Browse Source
This commit is contained in:
m.ray 2023-06-23 14:44:18 +03:00 committed by GitHub
parent bb1b236cdf
commit 445a085190
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apps/trading-e2e/src/integration/market-info.cy.ts
View File

@ -182,7 +182,7 @@ describe('market info is displayed', { tags: '@smoke' }, () => {
.contains('Liquidity monitoring parameters') .contains('Liquidity monitoring parameters')
.click(); .click();
validateMarketDataRow(0, 'Triggering Ratio', '0'); validateMarketDataRow(0, 'Triggering Ratio', '0.7');
validateMarketDataRow(1, 'Time Window', '3,600'); validateMarketDataRow(1, 'Time Window', '3,600');
validateMarketDataRow(2, 'Scaling Factor', '10'); validateMarketDataRow(2, 'Scaling Factor', '10');
}); });

6
libs/markets/src/lib/components/market-info/info-key-value-table.tsx
View File

@ -1,6 +1,5 @@
import { import {
addDecimalsFormatNumber, addDecimalsFormatNumber,
formatNumber,
formatNumberPercentage, formatNumberPercentage,
} from '@vegaprotocol/utils'; } from '@vegaprotocol/utils';
import { t } from '@vegaprotocol/i18n'; import { t } from '@vegaprotocol/i18n';
@ -47,7 +46,10 @@ const Row = ({
if (asPercentage) { if (asPercentage) {
return formatNumberPercentage(new BigNumber(value).times(100)); return formatNumberPercentage(new BigNumber(value).times(100));
} }
return `${formatNumber(Number(value))} ${assetSymbol}`; if (assetSymbol) {
return `${Number(value).toLocaleString()} ${assetSymbol}`;
}
return Number(value).toLocaleString();
}; };
const formattedValue = getFormattedValue(value); const formattedValue = getFormattedValue(value);

2
libs/markets/src/lib/components/market-info/market-info.mock.ts
View File

@ -94,7 +94,7 @@ export const marketInfoQuery = (
}, },
lpPriceRange: '0.02', lpPriceRange: '0.02',
liquidityMonitoringParameters: { liquidityMonitoringParameters: {
triggeringRatio: '0', triggeringRatio: '0.7',
targetStakeParameters: { targetStakeParameters: {
timeWindow: 3600, timeWindow: 3600,
scalingFactor: 10, scalingFactor: 10,