chore(trading): add close position button back to console (#5407)

apps/trading/.env.mainnet

@@ -28,3 +28,4 @@ NX_REFERRALS=false
 
 NX_TENDERMINT_URL=https://be.vega.community
 NX_TENDERMINT_WEBSOCKET_URL=wss://be.vega.community/websocket
+NX_DISABLE_CLOSE_POSITION=true

libs/environment/src/hooks/use-environment.ts

@@ -150,7 +150,7 @@ export const useEnvironment = create<EnvStore>()((set, get) => ({
  * Initialize Vega app to dynamically select a node from the
  * VEGA_CONFIG_URL
  *
- * This can be ommitted if you intend to only use a single node,
+ * This can be omitted if you intend to only use a single node,
  * in those cases be sure to set NX_VEGA_URL
  */
 export const useInitializeEnv = () => {
@@ -415,6 +415,12 @@ function compileFeatureFlags(): FeatureFlags {
     REFERRALS: TRUTHY.includes(
       windowOrDefault('NX_REFERRALS', process.env['NX_REFERRALS']) as string
     ),
+    DISABLE_CLOSE_POSITION: TRUTHY.includes(
+      windowOrDefault(
+        'NX_DISABLE_CLOSE_POSITION',
+        process.env['NX_DISABLE_CLOSE_POSITION']
+      ) as string
+    ),
     UPDATE_MARKET_STATE: TRUTHY.includes(
       windowOrDefault(
         'NX_UPDATE_MARKET_STATE',

libs/environment/src/types.ts

@@ -27,6 +27,7 @@ export type CosmicElevatorFlags = Pick<
   | 'UPDATE_MARKET_STATE'
   | 'GOVERNANCE_TRANSFERS'
   | 'VOLUME_DISCOUNTS'
+  | 'DISABLE_CLOSE_POSITION'
 >;
 export type Configuration = z.infer<typeof tomlConfigSchema>;
 export const CUSTOM_NODE_KEY = 'custom' as const;

libs/environment/src/utils/validate-environment.ts

@@ -81,6 +81,7 @@ const COSMIC_ELEVATOR_FLAGS = {
   UPDATE_MARKET_STATE: z.optional(z.boolean()),
   GOVERNANCE_TRANSFERS: z.optional(z.boolean()),
   VOLUME_DISCOUNTS: z.optional(z.boolean()),
+  DISABLE_CLOSE_POSITION: z.optional(z.boolean()),
 };
 
 const EXPLORER_FLAGS = {

libs/orders/src/lib/components/order-list/order-list.tsx

@@ -1,6 +1,6 @@
 import { memo, forwardRef, useMemo, type ForwardedRef } from 'react';
 import {
-  MAXGOINT64,
+  HALFMAXGOINT64,
   addDecimalsFormatNumber,
   getDateTimeFormat,
   isNumeric,
@@ -151,7 +151,7 @@ export const OrderListTable = memo<
                 : '';
 
               if (
-                data.size === MAXGOINT64 &&
+                data.size >= HALFMAXGOINT64 &&
                 data.timeInForce ===
                   Schema.OrderTimeInForce.TIME_IN_FORCE_IOC &&
                 data.reduceOnly

libs/positions/src/lib/positions-manager.spec.tsx

@@ -3,7 +3,7 @@ import { PositionsManager } from './positions-manager';
 import { positionsMarketsProvider } from './positions-data-providers';
 import { singleRow } from './positions.mock';
 import { MockedProvider } from '@apollo/client/testing';
-import { MAXGOINT64 } from '@vegaprotocol/utils';
+import { HALFMAXGOINT64 } from '@vegaprotocol/utils';
 
 const mockCreate = jest.fn();
 
@@ -31,9 +31,7 @@ jest.mock('@vegaprotocol/data-provider', () => ({
 }));
 
 describe('PositionsManager', () => {
-  // TODO: Close position temporarily disabled in https://github.com/vegaprotocol/frontend-monorepo/pull/5350
+  it('should close position with half of max uint64', async () => {
-  // eslint-disable-next-line jest/no-disabled-tests
-  it.skip('should close position with max uint64', async () => {
     render(<PositionsManager partyIds={['partyId']} isReadOnly={false} />, {
       wrapper: MockedProvider,
     });
@@ -43,6 +41,6 @@ describe('PositionsManager', () => {
 
     expect(
       mockCreate.mock.lastCall[0].batchMarketInstructions.submissions[0].size
-    ).toEqual(MAXGOINT64);
+    ).toEqual(HALFMAXGOINT64);
   });
 });

libs/positions/src/lib/positions-manager.tsx

@@ -7,13 +7,11 @@ import {
 } from './positions-data-providers';
 import type { useDataGridEvents } from '@vegaprotocol/datagrid';
 import { useT } from '../use-t';
-
+import { useCallback } from 'react';
-// TODO: Close position temporarily disabled in https://github.com/vegaprotocol/frontend-monorepo/pull/5350
+import * as Schema from '@vegaprotocol/types';
-//
+import { useVegaTransactionStore } from '@vegaprotocol/web3';
-// import { useCallback } from 'react';
+import { HALFMAXGOINT64 } from '@vegaprotocol/utils';
-// import * as Schema from '@vegaprotocol/types';
+import { FLAGS } from '@vegaprotocol/environment';
-// import { useVegaTransactionStore } from '@vegaprotocol/web3';
-// import { MAXGOINT64 } from '@vegaprotocol/utils';
 
 interface PositionsManagerProps {
   partyIds: string[];
@@ -32,37 +30,35 @@ export const PositionsManager = ({
 }: PositionsManagerProps) => {
   const t = useT();
   const { pubKeys, pubKey } = useVegaWallet();
+  const create = useVegaTransactionStore((store) => store.create);
+  const disableClosePositionsButton = FLAGS.DISABLE_CLOSE_POSITION;
 
-  // TODO: Close position temporarily disabled in https://github.com/vegaprotocol/frontend-monorepo/pull/5350
+  const onClose = useCallback(
-  //
+    ({ marketId, openVolume }: { marketId: string; openVolume: string }) =>
-  // const create = useVegaTransactionStore((store) => store.create);
+      create({
-  //
+        batchMarketInstructions: {
-  // const onClose = useCallback(
+          cancellations: [
-  //   ({ marketId, openVolume }: { marketId: string; openVolume: string }) =>
+            {
-  //     create({
+              marketId,
-  //       batchMarketInstructions: {
+              orderId: '', // omit order id to cancel all active orders
-  //         cancellations: [
+            },
-  //           {
+          ],
-  //             marketId,
+          submissions: [
-  //             orderId: '', // omit order id to cancel all active orders
+            {
-  //           },
+              marketId: marketId,
-  //         ],
+              type: Schema.OrderType.TYPE_MARKET as const,
-  //         submissions: [
+              timeInForce: Schema.OrderTimeInForce.TIME_IN_FORCE_IOC as const,
-  //           {
+              side: openVolume.startsWith('-')
-  //             marketId: marketId,
+                ? Schema.Side.SIDE_BUY
-  //             type: Schema.OrderType.TYPE_MARKET as const,
+                : Schema.Side.SIDE_SELL,
-  //             timeInForce: Schema.OrderTimeInForce.TIME_IN_FORCE_IOC as const,
+              size: HALFMAXGOINT64, // improvement for avoiding leftovers filled in the meantime when close request has been sent
-  //             side: openVolume.startsWith('-')
+              reduceOnly: true,
-  //               ? Schema.Side.SIDE_BUY
+            },
-  //               : Schema.Side.SIDE_SELL,
+          ],
-  //             size: MAXGOINT64, // improvement for avoiding leftovers filled in the meantime when close request has been sent
+        },
-  //             reduceOnly: true,
+      }),
-  //           },
+    [create]
-  //         ],
+  );
-  //       },
-  //     }),
-  //   [create]
-  // );
 
   const { data: marketIds } = useDataProvider({
     dataProvider: positionsMarketsProvider,
@@ -81,8 +77,7 @@ export const PositionsManager = ({
       pubKeys={pubKeys}
       rowData={data}
       onMarketClick={onMarketClick}
-      // TODO: temporarily disable close position
+      onClose={disableClosePositionsButton ? undefined : onClose}
-      // onClose={onClose}
       isReadOnly={isReadOnly}
       multipleKeys={partyIds.length > 1}
       overlayNoRowsTemplate={error ? error.message : t('No positions')}

libs/utils/src/lib/constants.ts

@@ -1 +1,5 @@
 export const MAXGOINT64 = '9223372036854775807';
+// The fix for the close position functionality needs MaxInt64/2 for the size
+// Issue: https://github.com/vegaprotocol/vega/issues/10177
+// Core PR: https://github.com/vegaprotocol/vega/pull/10178
+export const HALFMAXGOINT64 = '4611686018427387903';

libs/web3/src/lib/use-vega-transaction-toasts.tsx

@@ -41,7 +41,7 @@ import {
   toBigNum,
   truncateByChars,
   useFormatTrigger,
-  MAXGOINT64,
+  HALFMAXGOINT64,
 } from '@vegaprotocol/utils';
 import { useAssetsMapProvider } from '@vegaprotocol/assets';
 import { useEthWithdrawApprovalsStore } from './use-ethereum-withdraw-approvals-store';
@@ -1014,7 +1014,7 @@ export const getVegaTransactionContentIntent = (tx: VegaStoredTxState) => {
     tx.order &&
     tx.order.status === Schema.OrderStatus.STATUS_STOPPED &&
     tx.order.timeInForce === Schema.OrderTimeInForce.TIME_IN_FORCE_IOC &&
-    tx.order.size === MAXGOINT64 &&
+    tx.order.size >= HALFMAXGOINT64 &&
     // isClosePositionTransaction(tx) &&
     Intent.Success;