From 359247ce7df54291d3ce174fa5c856e468a5078f Mon Sep 17 00:00:00 2001 From: asiaznik Date: Thu, 8 Feb 2024 15:10:33 +0100 Subject: [PATCH] chore(explorer): remove voting column from proposal table --- .../src/integration/proposal.cy.js | 8 ------ .../components/proposals/proposals-table.tsx | 28 ------------------- 2 files changed, 36 deletions(-) diff --git a/apps/explorer-e2e/src/integration/proposal.cy.js b/apps/explorer-e2e/src/integration/proposal.cy.js index ef03e28b3..3d1568141 100644 --- a/apps/explorer-e2e/src/integration/proposal.cy.js +++ b/apps/explorer-e2e/src/integration/proposal.cy.js @@ -24,10 +24,6 @@ context('Proposal page', { tags: '@smoke' }, function () { cy.get_element_by_col_id('title').should('have.text', proposalTitle); cy.get_element_by_col_id('type').should('have.text', 'NewMarket'); cy.get_element_by_col_id('state').should('have.text', 'Enacted'); - cy.getByTestId('vote-progress').should('be.visible'); - cy.getByTestId('vote-progress-bar-for') - .invoke('attr', 'style') - .should('eq', 'width: 100%;'); cy.get('[col-id="cDate"]') .invoke('text') .should('match', dateTimeRegex); @@ -73,10 +69,6 @@ context('Proposal page', { tags: '@smoke' }, function () { 'have.text', 'Waiting for Node Vote' ); - cy.getByTestId('vote-progress').should('be.visible'); - cy.getByTestId('vote-progress-bar-against') - .invoke('attr', 'style') - .should('eq', 'width: 100%;'); cy.get('[col-id="cDate"]') .invoke('text') .should('match', dateTimeRegex); diff --git a/apps/explorer/src/app/components/proposals/proposals-table.tsx b/apps/explorer/src/app/components/proposals/proposals-table.tsx index 88d31a697..02a92ab3c 100644 --- a/apps/explorer/src/app/components/proposals/proposals-table.tsx +++ b/apps/explorer/src/app/components/proposals/proposals-table.tsx @@ -1,5 +1,4 @@ import { type ProposalListFieldsFragment } from '@vegaprotocol/proposals'; -import { VoteProgress } from '@vegaprotocol/proposals'; import { type AgGridReact } from 'ag-grid-react'; import { ExternalLink } from '@vegaprotocol/ui-toolkit'; import { AgGrid } from '@vegaprotocol/datagrid'; @@ -90,33 +89,6 @@ export const ProposalsTable = ({ data }: ProposalsTableProps) => { return value ? ProposalStateMapping[value] : '-'; }, }, - { - colId: 'voting', - maxWidth: 100, - hide: window.innerWidth <= BREAKPOINT_MD, - headerName: t('Voting'), - cellRenderer: ({ - data, - }: VegaICellRendererParams) => { - if (data) { - const yesTokens = new BigNumber(data.votes.yes.totalTokens); - const noTokens = new BigNumber(data.votes.no.totalTokens); - const totalTokensVoted = yesTokens.plus(noTokens); - const yesPercentage = totalTokensVoted.isZero() - ? new BigNumber(0) - : yesTokens.multipliedBy(100).dividedBy(totalTokensVoted); - return ( -
- -
- ); - } - return '-'; - }, - }, { colId: 'cDate', maxWidth: 150,