From 293a3544e2a764d0bf3d653065d7923968c85817 Mon Sep 17 00:00:00 2001 From: maciek Date: Tue, 16 May 2023 15:54:05 +0200 Subject: [PATCH] chore: refactor createDocsUrl for fully static use across all apps --- .../vega-wallet/download-wallet-prompt.tsx | 2 +- apps/governance/src/routes/home/index.tsx | 3 +- .../proposals-list/proposals-list.tsx | 8 ++-- .../propose/proposal-form-terms.tsx | 12 ++---- .../propose/freeform/propose-freeform.tsx | 15 +++---- .../propose-network-parameter.tsx | 19 +++------ .../propose/new-asset/propose-new-asset.tsx | 16 +++----- .../propose/new-market/propose-new-market.tsx | 16 +++----- .../src/routes/proposals/propose/propose.tsx | 14 +++---- .../proposals/propose/raw/propose-raw.tsx | 15 +++---- .../update-asset/propose-update-asset.tsx | 16 +++----- .../update-market/propose-update-market.tsx | 16 +++----- .../src/routes/rewards/home/rewards-page.tsx | 8 ++-- .../src/routes/staking/home/staking.tsx | 8 ++-- .../validator-tables/validator-tables.tsx | 13 ++----- .../routes/staking/node/validator-table.tsx | 14 ++++--- apps/governance/src/routes/token/index.tsx | 3 +- .../client-pages/liquidity/liquidity.tsx | 7 ++-- .../liquidity-supplied/liquidity-supplied.tsx | 12 ++---- apps/trading/components/navbar/navbar.tsx | 8 ++-- .../welcome-dialog/risk-notice-dialog.tsx | 17 ++++---- .../welcome-dialog/welcome-notice-dialog.tsx | 2 +- .../trading-mode-tooltip.tsx | 30 +++++--------- libs/environment/src/hooks/use-links.ts | 39 +++++++++++++++++++ .../market-info/market-info-accordion.tsx | 8 ++-- .../market-info/tooltip-mapping.tsx | 2 +- libs/positions/src/lib/positions-table.tsx | 16 +++----- libs/utils/src/index.ts | 1 - libs/utils/src/lib/links.ts | 38 ------------------ .../connect-dialog-elements.tsx | 10 ++--- .../src/connect-dialog/connect-dialog.tsx | 7 +++- .../json-rpc-connector-form.tsx | 10 ++--- 32 files changed, 166 insertions(+), 239 deletions(-) delete mode 100644 libs/utils/src/lib/links.ts diff --git a/apps/governance/src/components/vega-wallet/download-wallet-prompt.tsx b/apps/governance/src/components/vega-wallet/download-wallet-prompt.tsx index 6dd9f567e..8f6cb5c47 100644 --- a/apps/governance/src/components/vega-wallet/download-wallet-prompt.tsx +++ b/apps/governance/src/components/vega-wallet/download-wallet-prompt.tsx @@ -1,6 +1,6 @@ import { Link } from '@vegaprotocol/ui-toolkit'; import { useTranslation } from 'react-i18next'; -import { ExternalLinks } from '@vegaprotocol/utils'; +import { ExternalLinks } from '@vegaprotocol/environment'; export const DownloadWalletPrompt = () => { const { t } = useTranslation(); diff --git a/apps/governance/src/routes/home/index.tsx b/apps/governance/src/routes/home/index.tsx index 00ffd171c..b5b2a485c 100644 --- a/apps/governance/src/routes/home/index.tsx +++ b/apps/governance/src/routes/home/index.tsx @@ -12,7 +12,8 @@ import { useRefreshAfterEpoch } from '../../hooks/use-refresh-after-epoch'; import { ProposalsListItem } from '../proposals/components/proposals-list-item'; import { ProtocolUpgradeProposalsListItem } from '../proposals/components/protocol-upgrade-proposals-list-item/protocol-upgrade-proposals-list-item'; import Routes from '../routes'; -import { ExternalLinks, removePaginationWrapper } from '@vegaprotocol/utils'; +import { ExternalLinks } from '@vegaprotocol/environment'; +import { removePaginationWrapper } from '@vegaprotocol/utils'; import { useNodesQuery } from '../staking/home/__generated__/Nodes'; import { useProposalsQuery } from '../proposals/proposals/__generated__/Proposals'; import { diff --git a/apps/governance/src/routes/proposals/components/proposals-list/proposals-list.tsx b/apps/governance/src/routes/proposals/components/proposals-list/proposals-list.tsx index d96fccc7f..db1490391 100644 --- a/apps/governance/src/routes/proposals/components/proposals-list/proposals-list.tsx +++ b/apps/governance/src/routes/proposals/components/proposals-list/proposals-list.tsx @@ -8,12 +8,11 @@ import { ProposalsListFilter } from '../proposals-list-filter'; import Routes from '../../../routes'; import { Button, VegaIcon, VegaIconNames } from '@vegaprotocol/ui-toolkit'; import { Link } from 'react-router-dom'; -import { createDocsLinks, ExternalLinks } from '@vegaprotocol/utils'; import { ExternalLink } from '@vegaprotocol/ui-toolkit'; import type { ProposalQuery } from '../../proposal/__generated__/Proposal'; import type { ProposalFieldsFragment } from '../../proposals/__generated__/Proposals'; import type { ProtocolUpgradeProposalFieldsFragment } from '@vegaprotocol/proposals'; -import { useEnvironment } from '@vegaprotocol/environment'; +import { DocsLinks, ExternalLinks } from '@vegaprotocol/environment'; interface ProposalsListProps { proposals: Array; @@ -36,7 +35,6 @@ export const ProposalsList = ({ protocolUpgradeProposals, lastBlockHeight, }: ProposalsListProps) => { - const { VEGA_DOCS_URL } = useEnvironment(); const { t } = useTranslation(); const [filterString, setFilterString] = useState(''); const sortedProposals = proposals.reduce( @@ -83,9 +81,9 @@ export const ProposalsList = ({ marginBottom={false} title={t('pageTitleProposals')} /> - {VEGA_DOCS_URL && ( + {DocsLinks && (
- +