From 2123afc4b09b47306fa42114b401db943101a954 Mon Sep 17 00:00:00 2001 From: Sam Keen Date: Fri, 17 Feb 2023 16:42:22 +0000 Subject: [PATCH] fix(governance): overstaked penalty shown as NaN (#2932) --- apps/token/src/routes/staking/shared.ts | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/apps/token/src/routes/staking/shared.ts b/apps/token/src/routes/staking/shared.ts index 0c6fe1438..149ee3956 100644 --- a/apps/token/src/routes/staking/shared.ts +++ b/apps/token/src/routes/staking/shared.ts @@ -59,11 +59,17 @@ export const getOverstakedAmount = ( export const getOverstakingPenalty = ( overstakedAmount: BigNumber, stakedOnNode: string -) => - formatNumberPercentage( +) => { + // avoid division by zero + if (new BigNumber(stakedOnNode).isZero() || overstakedAmount.isZero()) { + return '0'; + } + + return formatNumberPercentage( overstakedAmount.dividedBy(new BigNumber(stakedOnNode)).times(100), 2 ); +}; export const getTotalPenalties = ( rawValidatorScore: string | null | undefined,