From 17ff01466619fb97bb62192fd6a4be503eec27a0 Mon Sep 17 00:00:00 2001
From: Matthew Russell <mattrussell36@gmail.com>
Date: Thu, 23 Feb 2023 16:25:40 -0800
Subject: [PATCH] chore: add missing values to mocks, wrap return value with
 fragment

---
 libs/positions/src/lib/positions-table.tsx | 17 ++++++++++++-----
 libs/positions/src/lib/positions.mock.ts   |  9 ++++++++-
 2 files changed, 20 insertions(+), 6 deletions(-)

diff --git a/libs/positions/src/lib/positions-table.tsx b/libs/positions/src/lib/positions-table.tsx
index 92f953891..104d8d07a 100644
--- a/libs/positions/src/lib/positions-table.tsx
+++ b/libs/positions/src/lib/positions-table.tsx
@@ -424,12 +424,13 @@ export const PNLCell = ({
   const { VEGA_DOCS_URL } = useEnvironment();
 
   if (!data) {
-    return '-';
+    return <>-</>;
   }
 
   const losses = parseInt(data?.lossSocializationAmount ?? '0');
   if (losses <= 0) {
-    return valueFormatted;
+    // eslint-disable-next-line react/jsx-no-useless-fragment
+    return <>{valueFormatted}</>;
   }
 
   const lossesFormatted = addDecimalsFormatNumber(
@@ -464,11 +465,12 @@ export const OpenVolumeCell = ({
   const { VEGA_DOCS_URL } = useEnvironment();
 
   if (!data) {
-    return '-';
+    return <>-</>;
   }
 
   if (data.status === PositionStatus.POSITION_STATUS_UNSPECIFIED) {
-    return valueFormatted;
+    // eslint-disable-next-line react/jsx-no-useless-fragment
+    return <>{valueFormatted}</>;
   }
 
   return (
@@ -479,7 +481,12 @@ export const OpenVolumeCell = ({
             {t('Your positions was affected by market conditions')}
           </p>
           <p className="mb-2">
-            {t('Status: %s', PositionStatusMapping[data.status])}
+            {t(
+              'Status: %s',
+              PositionStatusMapping[
+                PositionStatus.POSITION_STATUS_ORDERS_CLOSED
+              ]
+            )}
           </p>
           {VEGA_DOCS_URL && (
             <ExternalLink href={VEGA_DOCS_URL}>
diff --git a/libs/positions/src/lib/positions.mock.ts b/libs/positions/src/lib/positions.mock.ts
index 87735f88b..95c24bdfa 100644
--- a/libs/positions/src/lib/positions.mock.ts
+++ b/libs/positions/src/lib/positions.mock.ts
@@ -1,3 +1,4 @@
+import { PositionStatus } from '@vegaprotocol/types';
 import merge from 'lodash/merge';
 import type { PartialDeep } from 'type-fest';
 import type {
@@ -58,6 +59,8 @@ const positionFields: PositionFieldsFragment[] = [
       id: 'market-0',
       __typename: 'Market',
     },
+    lossSocializationAmount: '0',
+    positionStatus: PositionStatus.POSITION_STATUS_UNSPECIFIED,
   },
   {
     __typename: 'Position',
@@ -70,8 +73,11 @@ const positionFields: PositionFieldsFragment[] = [
       id: 'market-1',
       __typename: 'Market',
     },
+    lossSocializationAmount: '0',
+    positionStatus: PositionStatus.POSITION_STATUS_UNSPECIFIED,
   },
   {
+    __typename: 'Position',
     realisedPNL: '230000',
     openVolume: '1',
     unrealisedPNL: '-22519',
@@ -81,7 +87,8 @@ const positionFields: PositionFieldsFragment[] = [
       id: 'market-2',
       __typename: 'Market',
     },
-    __typename: 'Position',
+    lossSocializationAmount: '0',
+    positionStatus: PositionStatus.POSITION_STATUS_UNSPECIFIED,
   },
 ];