From 105a758e8d31705125146a13159a9de7b2ac53c7 Mon Sep 17 00:00:00 2001
From: daro-maj <119658839+daro-maj@users.noreply.github.com>
Date: Fri, 1 Sep 2023 10:48:38 +0200
Subject: [PATCH] test(trading): add stop order oco spec (#4669)
---
specs/0002-WCON-connect_vega_wallet.md | 2 ++
specs/7002-SORD-submit_orders.md | 23 +++++++++++++++++++++++
2 files changed, 25 insertions(+)
diff --git a/specs/0002-WCON-connect_vega_wallet.md b/specs/0002-WCON-connect_vega_wallet.md
index d430e34bd..68e110541 100644
--- a/specs/0002-WCON-connect_vega_wallet.md
+++ b/specs/0002-WCON-connect_vega_wallet.md
@@ -13,6 +13,8 @@ When looking to use Vega via a user interface e.g. Dapp (Decentralized web App),
- If there is not running desktop wallet or CLI detected, I can see that I need to open my wallet. (0002-WCON-0013)
- I can find out more about supported browsers i.e. there is a link (Issue "List compatible browsers" vegawallet-browser#360 has to be implemented). (0002-WCON-0013)
- I can find out more about the Vega Wallet and see what "other" versions there are i.e. there is a link to the page on the website (currently - https://vega.xyz/wallet#overview). (0002-WCON-0014)
+- I can install and connect vega metamask snap wallet (0002-WCON-0015)
+
- Browser wallet:
- The browser extension you need is automatically detected if you are using Chrome or Firefox, presenting the specific call to action to install that browser extension in a visible way e.g. with a Chrome or Firefox icon. (0002-WCON-041)
diff --git a/specs/7002-SORD-submit_orders.md b/specs/7002-SORD-submit_orders.md
index c5e41c202..733388f67 100644
--- a/specs/7002-SORD-submit_orders.md
+++ b/specs/7002-SORD-submit_orders.md
@@ -174,11 +174,34 @@ When populating a deal ticket I...
- **must** see that selecting "Post only" or "reduce only" de-select the other (if selected). As is it not possibly to apply them both to an order (7003-SORD-059)
- **must** see an option to select expire for stop order limit and market (7002-SORD-071)
+
- **must** select strategy for stop order limit and market (7002-SORD-072)
- **must** see strategy submit (7002-SORD-073)
+ if it is oco then submit strategy is not available (7002-SORD-081)
- **must** see strategy cancel (7002-SORD-074)
- **must** see expiry time/date (7002-SORD-075)
+- **must** see an option to select oco for stop order limit and market (7002-SORD-082)
+ - **must** see a type to select market or limit (7002-SORD-083)
+ - **must** see for market type
+ - **must** see rises above (7002-SORD-084)
+ - **must** see falls below (7002-SORD-085)
+ - **must** enter a trigger value (7002-SORD-086)
+ - **must** select a trigger price (7002-SORD-087)
+ - **must** select a trigger trailing percent offset (7002-SORD-088)
+ - **must** see for limit type
+ - **must** enter a price (7002-SORD-089)
+ - **must** select a trigger direction (7002-SORD-090)
+ - **must** see rises above (7002-SORD-099)
+ - **must** see falls below (7002-SORD-091)
+ - if the user has not set a preference: trigger direction **must** default to `opposite to the one selected in the stop order` (7002-SORD-092)
+ - **must** enter a trigger value (7002-SORD-093)
+ - **must** select a trigger type (7002-SORD-094)
+ - **must** see a trigger price (7002-SORD-095)
+ - **must** see a trigger trailing percent offset (7002-SORD-096)
+ - if the user has not set a preference: trigger type **must** default to `price` (7002-SORD-097)
+ - if the trigger price is already met on submission, **must** warn the user that the stop order will be triggered immediately (7002-SORD-098)
+
... so I can control in more detail how my order is executed
## Auto Populating a deal ticket non-manual methods