LaconicNetwork/vega-frontend-monorepo
3
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

fix(trading): remove invalid candles from price change calc (#5983) (#5984)

Browse Source
This commit is contained in:
Matthew Russell 2024-03-13 13:34:22 +00:00 committed by GitHub
parent 424061d64c
commit 0f5b712034
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
2 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
libs/datagrid/src/lib/cells/price-change-cell.tsx
View File

@ -18,8 +18,9 @@ export interface PriceChangeCellProps {
export const PriceChangeCell = memo( export const PriceChangeCell = memo(
forwardRef<HTMLSpanElement, PriceChangeCellProps>( forwardRef<HTMLSpanElement, PriceChangeCellProps>(
({ candles, decimalPlaces }: PriceChangeCellProps, ref) => { ({ candles, decimalPlaces }: PriceChangeCellProps, ref) => {
const change = priceChange(candles); const validCandles = candles.filter((c) => c !== '');
const changePercentage = priceChangePercentage(candles); const change = priceChange(validCandles);
const changePercentage = priceChangePercentage(validCandles);
return ( return (
<span <span
ref={ref} ref={ref}

3
libs/markets/src/lib/components/last-24h-price-change/last-24h-price-change.tsx
View File

@ -32,7 +32,8 @@ export const Last24hPriceChange = ({
return nonIdeal; return nonIdeal;
} }
const candles = oneDayCandles?.map((c) => c.close) || []; const candles =
oneDayCandles.map((c) => c.close).filter((c) => c !== '') || [];
const change = priceChange(candles); const change = priceChange(candles);
const changePercentage = priceChangePercentage(candles); const changePercentage = priceChangePercentage(candles);