LaconicNetwork/vega-frontend-monorepo
3
0
Fork 0
Code Issues Pull Requests 1 Packages Projects Releases Wiki Activity

fix(ui-toolkit): sparkline appearing to go up when the price moved down (#5137)

Browse Source
This commit is contained in:
Matthew Russell 2023-10-31 04:20:48 -07:00 committed by GitHub
parent 142f08343b
commit 0ebfab64ff
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
libs/ui-toolkit/src/components/sparkline/sparkline.stories.tsx
View File

@ -72,7 +72,7 @@ LessThan24HoursIncrease.args = {
export const LessThan24HoursDecrease = Template.bind({}); export const LessThan24HoursDecrease = Template.bind({});
LessThan24HoursDecrease.args = { LessThan24HoursDecrease.args = {
data: [20, 21, 22, 23, 24, 6, 7, 9, 11, 13, 11, 9], data: [20990000, 20939973, 20980130],
width: 110, width: 110,
height: 30, height: 30,
}; };

6
libs/ui-toolkit/src/components/sparkline/sparkline.tsx
View File

@ -44,14 +44,12 @@ export const SparklineView = ({
return null; return null;
} }
const midValue = (min + max) / 2;
// Market may be less than 24hr old so padd the data array // Market may be less than 24hr old so padd the data array
// with values that is the mid value (avg of min and max). // with values that is the mid value (avg of min and max).
// This will rendera horizontal line until the real data shifts the line // This will rendera horizontal line until the real data shifts the line
const padCount = data.length < points ? points - data.length : 0;
const padArr = new Array(padCount).fill(midValue);
const trimmedData = data.slice(-points); const trimmedData = data.slice(-points);
const padCount = data.length < points ? points - data.length : 0;
const padArr = new Array(padCount).fill(trimmedData[0]);
// Get the last 24 values if data has more than needed // Get the last 24 values if data has more than needed
const lineData: [number, number][] = [...padArr, ...trimmedData].map( const lineData: [number, number][] = [...padArr, ...trimmedData].map(