From 081c9f44aef4ee97fa6038d2ca50cff977ddced2 Mon Sep 17 00:00:00 2001
From: "m.ray" <16125548+MadalinaRaicu@users.noreply.github.com>
Date: Mon, 28 Nov 2022 10:15:18 -0500
Subject: [PATCH] fix: orderbook decimal places issue  (#2235) (#2237)

* fix: positions table fixes notional dp (#2144)

* fix: update decimals on position notional size

* fix: normalize values

* fix: fix positions unit tests

* fix: remove liquidation price

* fix: positions linting issue

* fix: remove liquidation price test

* fix: remove total summary row

* fix: remove comments

* fix: cypress test to not show trailing 0s

* fix: add back liq. price est as cell only

* fix: remove not used params

* chore: merge with release/testnet

* fix: orderbook dp

* Update libs/positions/src/lib/positions-table.spec.tsx
---
 libs/market-depth/src/lib/orderbook.tsx      |  4 ++--
 libs/positions/src/lib/positions-table.tsx   |  2 +-
 libs/react-helpers/src/lib/format/number.tsx | 22 ++++++++++++++++++++
 3 files changed, 25 insertions(+), 3 deletions(-)

diff --git a/libs/market-depth/src/lib/orderbook.tsx b/libs/market-depth/src/lib/orderbook.tsx
index e5a932bfe..74b39773e 100644
--- a/libs/market-depth/src/lib/orderbook.tsx
+++ b/libs/market-depth/src/lib/orderbook.tsx
@@ -14,11 +14,11 @@ import {
 import classNames from 'classnames';
 
 import {
-  formatNumber,
   addDecimalsFormatNumber,
   t,
   ThemeContext,
   useResizeObserver,
+  formatNumberFixed,
 } from '@vegaprotocol/react-helpers';
 import { Schema } from '@vegaprotocol/types';
 import { OrderbookRow } from './orderbook-row';
@@ -659,7 +659,7 @@ export const Orderbook = ({
           >
             {resolutions.map((r) => (
               <option key={r} value={r}>
-                {formatNumber(0, decimalPlaces - Math.log10(r))}
+                {formatNumberFixed(0, decimalPlaces - Math.log10(r))}
               </option>
             ))}
           </select>
diff --git a/libs/positions/src/lib/positions-table.tsx b/libs/positions/src/lib/positions-table.tsx
index 3e8b4fc86..86083c141 100644
--- a/libs/positions/src/lib/positions-table.tsx
+++ b/libs/positions/src/lib/positions-table.tsx
@@ -10,7 +10,6 @@ import type {
 import { ProgressBarCell } from '@vegaprotocol/ui-toolkit';
 import {
   PriceFlashCell,
-  addDecimalsFormatNumber,
   volumePrefix,
   t,
   toBigNum,
@@ -19,6 +18,7 @@ import {
   signedNumberCssClass,
   signedNumberCssClassRules,
   DateRangeFilter,
+  addDecimalsFormatNumber,
 } from '@vegaprotocol/react-helpers';
 import { AgGridDynamic as AgGrid } from '@vegaprotocol/ui-toolkit';
 import { AgGridColumn } from 'ag-grid-react';
diff --git a/libs/react-helpers/src/lib/format/number.tsx b/libs/react-helpers/src/lib/format/number.tsx
index 839bdacf4..8a2a46eef 100644
--- a/libs/react-helpers/src/lib/format/number.tsx
+++ b/libs/react-helpers/src/lib/format/number.tsx
@@ -50,6 +50,17 @@ export const getNumberFormat = memoize((digits: number) => {
   });
 });
 
+// https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Intl/NumberFormat/NumberFormat
+export const getFixedNumberFormat = memoize((digits: number) => {
+  if (isNil(digits) || digits < 0) {
+    return new Intl.NumberFormat(getUserLocale());
+  }
+  return new Intl.NumberFormat(getUserLocale(), {
+    minimumFractionDigits: Math.min(Math.max(0, digits), MAX_FRACTION_DIGITS),
+    maximumFractionDigits: Math.min(Math.max(0, digits), MAX_FRACTION_DIGITS),
+  });
+});
+
 export const getDecimalSeparator = memoize(
   () =>
     getNumberFormat(1)
@@ -68,6 +79,17 @@ export const formatNumber = (
   return getNumberFormat(formatDecimals).format(Number(rawValue));
 };
 
+/** formatNumberFixed will format the number with fixed decimals
+ * @param rawValue - should be a number that is not outside the safe range fail as in https://mikemcl.github.io/bignumber.js/#toN
+ * @param formatDecimals - number of decimals to use
+ */
+export const formatNumberFixed = (
+  rawValue: string | number | BigNumber,
+  formatDecimals = 0
+) => {
+  return getFixedNumberFormat(formatDecimals).format(Number(rawValue));
+};
+
 export const addDecimalsFormatNumber = (
   rawValue: string | number,
   decimalPlaces: number,