From bb6a9b99e344b8648b4c3963930fd2acfe2eaa8c Mon Sep 17 00:00:00 2001
From: Yusuf Seyrek <yusufseyrek@users.noreply.github.com>
Date: Wed, 26 Jul 2023 14:55:30 +0300
Subject: [PATCH] feat: swap form fixes & improvements (#322)

---
 src/components/RangeInput/index.tsx           | 12 +++--
 .../TradeModule/SwapForm/AssetAmountInput.tsx | 13 +++--
 .../Trade/TradeModule/SwapForm/index.tsx      | 51 +++++++++++--------
 3 files changed, 44 insertions(+), 32 deletions(-)

diff --git a/src/components/RangeInput/index.tsx b/src/components/RangeInput/index.tsx
index ad478761..410dd87f 100644
--- a/src/components/RangeInput/index.tsx
+++ b/src/components/RangeInput/index.tsx
@@ -4,16 +4,17 @@ import classNames from 'classnames'
 import InputOverlay from 'components/RangeInput/InputOverlay'
 
 type Props = {
-  value: number
-  onChange: (value: number) => void
-  wrapperClassName?: string
-  disabled?: boolean
   max: number
+  value: number
+  disabled?: boolean
   marginThreshold?: number
+  wrapperClassName?: string
+  onChange: (value: number) => void
+  onBlur?: () => void
 }
 
 function RangeInput(props: Props) {
-  const { value, max, onChange, wrapperClassName, disabled, marginThreshold } = props
+  const { value, max, onChange, wrapperClassName, disabled, marginThreshold, onBlur } = props
 
   const handleOnChange = useCallback(
     (event: ChangeEvent<HTMLInputElement>) => {
@@ -36,6 +37,7 @@ function RangeInput(props: Props) {
           step={max / 100}
           max={max}
           onChange={handleOnChange}
+          onBlur={onBlur}
         />
         <InputOverlay
           max={max}
diff --git a/src/components/Trade/TradeModule/SwapForm/AssetAmountInput.tsx b/src/components/Trade/TradeModule/SwapForm/AssetAmountInput.tsx
index 13ffe300..5bb23ecf 100644
--- a/src/components/Trade/TradeModule/SwapForm/AssetAmountInput.tsx
+++ b/src/components/Trade/TradeModule/SwapForm/AssetAmountInput.tsx
@@ -15,19 +15,21 @@ interface Props {
   containerClassName?: string
   setAmount: (amount: BigNumber) => void
   onFocus?: () => void
+  onBlur?: () => void
 }
 
 export default function AssetAmountInput(props: Props) {
   const {
+    max,
     label,
     amount,
-    setAmount,
     asset,
-    containerClassName,
-    max,
-    maxButtonLabel,
-    onFocus,
+    setAmount,
     assetUSDValue,
+    maxButtonLabel,
+    containerClassName,
+    onFocus,
+    onBlur,
   } = props
 
   const handleMaxClick = useCallback(() => {
@@ -52,6 +54,7 @@ export default function AssetAmountInput(props: Props) {
             max={max}
             onChange={setAmount}
             onFocus={onFocus}
+            onBlur={onBlur}
           />
           <span>{asset.symbol}</span>
         </div>
diff --git a/src/components/Trade/TradeModule/SwapForm/index.tsx b/src/components/Trade/TradeModule/SwapForm/index.tsx
index a35436fa..b4be46ee 100644
--- a/src/components/Trade/TradeModule/SwapForm/index.tsx
+++ b/src/components/Trade/TradeModule/SwapForm/index.tsx
@@ -30,10 +30,11 @@ export default function SwapForm(props: Props) {
   const account = useCurrentAccount()
   const { data: prices } = usePrices()
   const swap = useStore((s) => s.swap)
+  const [slippage] = useLocalStorage(SLIPPAGE_KEY, DEFAULT_SETTINGS.slippage)
+
   const [isMarginChecked, setMarginChecked] = useState(false)
   const [buyAssetAmount, setBuyAssetAmount] = useState(BN_ZERO)
   const [sellAssetAmount, setSellAssetAmount] = useState(BN_ZERO)
-  const [slippage] = useLocalStorage(SLIPPAGE_KEY, DEFAULT_SETTINGS.slippage)
   const [focusedInput, setFocusedInput] = useState<'buy' | 'sell' | null>(null)
   const [maxBuyableAmountEstimation, setMaxBuyableAmountEstimation] = useState(BN_ZERO)
   const [selectedOrderType, setSelectedOrderType] = useState<AvailableOrderType>('Market')
@@ -43,13 +44,6 @@ export default function SwapForm(props: Props) {
     [account, sellAsset.denom],
   )
 
-  useEffect(() => {
-    estimateExactIn(
-      { denom: sellAsset.denom, amount: accountSellAssetDeposit },
-      buyAsset.denom,
-    ).then(setMaxBuyableAmountEstimation)
-  }, [accountSellAssetDeposit, buyAsset.denom, sellAsset.denom])
-
   const [buyAssetValue, sellAssetValue] = useMemo(() => {
     const buyAssetPrice = prices.find(byDenom(buyAsset.denom))?.amount ?? BN_ZERO
     const sellAssetPrice = prices.find(byDenom(sellAsset.denom))?.amount ?? BN_ZERO
@@ -68,6 +62,19 @@ export default function SwapForm(props: Props) {
     sellAssetAmount,
   ])
 
+  useEffect(() => {
+    setFocusedInput(null)
+    setBuyAssetAmount(BN_ZERO)
+    setSellAssetAmount(BN_ZERO)
+  }, [buyAsset.denom, sellAsset.denom])
+
+  useEffect(() => {
+    estimateExactIn(
+      { denom: sellAsset.denom, amount: accountSellAssetDeposit },
+      buyAsset.denom,
+    ).then(setMaxBuyableAmountEstimation)
+  }, [accountSellAssetDeposit, buyAsset.denom, sellAsset.denom])
+
   useEffect(() => {
     if (focusedInput === 'sell') {
       estimateExactIn(
@@ -89,16 +96,6 @@ export default function SwapForm(props: Props) {
     }
   }, [buyAsset.denom, buyAssetAmount, focusedInput, sellAsset.denom])
 
-  useEffect(() => {
-    setFocusedInput(null)
-    setBuyAssetAmount(BN_ZERO)
-    setSellAssetAmount(BN_ZERO)
-  }, [sellAsset.denom])
-
-  useEffect(() => {
-    setFocusedInput(null)
-  }, [buyAsset.denom])
-
   const handleBuyClick = useCallback(async () => {
     if (account?.id) {
       const isSucceeded = await swap({
@@ -110,10 +107,20 @@ export default function SwapForm(props: Props) {
       })
       if (isSucceeded) {
         setSellAssetAmount(BN_ZERO)
+        setBuyAssetAmount(BN_ZERO)
       }
     }
   }, [account?.id, buyAsset.denom, sellAsset.denom, sellAssetAmount, slippage, swap])
 
+  const dismissInputFocus = useCallback(() => setFocusedInput(null), [])
+  const handleRangeInputChange = useCallback(
+    (value: number) => {
+      setFocusedInput('sell')
+      setSellAssetAmount(BN(value).shiftedBy(sellAsset.decimals).integerValue())
+    },
+    [sellAsset.decimals],
+  )
+
   return (
     <>
       <Divider />
@@ -131,16 +138,15 @@ export default function SwapForm(props: Props) {
         assetUSDValue={buyAssetValue}
         maxButtonLabel='Max Amount:'
         containerClassName='mx-3 my-6'
+        onBlur={dismissInputFocus}
         onFocus={() => setFocusedInput('buy')}
       />
 
       <RangeInput
         max={accountSellAssetDeposit.shiftedBy(-sellAsset.decimals).toNumber()}
         value={sellAssetAmount.shiftedBy(-sellAsset.decimals).toNumber()}
-        onChange={(value) => {
-          setFocusedInput('sell')
-          setSellAssetAmount(BN(value).shiftedBy(sellAsset.decimals).integerValue())
-        }}
+        onChange={handleRangeInputChange}
+        onBlur={dismissInputFocus}
         wrapperClassName='p-4'
       />
 
@@ -153,6 +159,7 @@ export default function SwapForm(props: Props) {
         asset={sellAsset}
         maxButtonLabel='Balance:'
         containerClassName='mx-3'
+        onBlur={dismissInputFocus}
         onFocus={() => setFocusedInput('sell')}
       />