Old code passes -1 to os.Exit and the value is directly passed to syscall.
The behavior with -1 depends on environments (most cases should convert
into 255 though)
This commit is to remove unnecessary the ambiguity and change it to use 1 instead of 255.
* Use go mod instead of glide
* Add `--with-kompose-annotation` flag to allow us to switch it off for tests
* Remove hostpid support (since the newest sdk does not support it)
* Create new test script and fixtures
* Remove replicationcontroller support
The PR https://github.com/kubernetes/kompose/pull/1147 introduced a
push-image parameter for the 'up' command that allows to disable
pushing the image to the registry. The PR changed the behavior of the
'convert' command that now no longer pushes the image.
This commit introduces the same parameter for the 'convert' command
and reintroduces the original behavior of pushing the image.
To make `kompose up` & `kompose convert` equal in feature, This PR will
add `--controller` flag for `kompose up` as well as `kompose down`
so that user experience will be the same for `up` & `convert`
Resolves#798
since we are adding `--controller` to `up` and `down`, So respective code to deploy and undeploy also being added for `daemonset` and `replicationcontroller`
Added tests for `--controller`
Updated `sirupsen`, `docker/cli`, `docker/libcompose` in `glide`,
Also changed `Sirupsen` with `sirupsen` in all kompose packages as well as in
`docker/distribution` packages
Moves the version information to a seperate file. This is mostly due to
import cycle errors occuring when using "import
github.com/kubernetes/kompose/cmd" in order to get the global variable
of VERSION and GITCOMMIT.
Update's the Makefile and other files accordingly.
If the version and commmit is unretriveable due to not being able to
find the kompose binary, the one from pkg/version/version.go will be
used.
This PR will add customhelp section in `kompose up --help` section,
which will show consistency in help section.
Issue reference: #842
for example,
```
$ kompose up --help
Deploy your Dockerized application to a container orchestrator. (default "kubernetes")
Usage:
kompose up [flags]
OpenShift Flags:
--build-branch Specify repository branch to use for buildconfig (default is current branch name)
--build-repo Specify source repository for buildconfig (default is current branch's remote url
--insecure-repository Specify to use insecure docker repository while generating Openshift image stream object
Flags:
--build string Set the type of build ("local"|"build-config" (OpenShift only)|"none") (default "local")
-h, --help help for up
--namespace string Specify Namespace to deploy your application (default "default")
--replicas int Specify the number of replicas generated (default 1)
--volumes string Volumes to be generated ("persistentVolumeClaim"|"emptyDir") (default "persistentVolumeClaim")
Global Flags:
--error-on-warning Treat any warning as an error
-f, --file stringArray Specify an alternative compose file
--provider string Specify a provider. Kubernetes or OpenShift. (default "kubernetes")
--suppress-warnings Suppress all warnings
-v, --verbose verbose output
```
Previously we used to mention controller type as `--deployment`,
`--replication-controller` or `--daemonset` as argument.
But now,
it will be like,
ex.
```
kompose convert --controller=daemonset
```
This adds the --volumes paramater with a "generate" and "empty"
By default, "generate" will be used as a place-holder for "true".
Although not used in the code, we will eventually add "none"
This uses CLI paramater naming processes (no emptyVols as that is Go /
Kubernetes specific) and thus we use dashes.
In pkg/app/app.go, the function ValidateComposeFile() has an
unused parameter "cmd *cobra.Command".
This commit removes that parameter from the function and the
callers of the function.
namusyaka
Hang Yan
Christian Fetzer
Kubernetes Prow Robot
Chiang Fong Lee
Rui Cao
xianlubird
Pascal Borreli
Charlie Drage
adolphlwq
Suraj Narwade
Rajadeepan D Ramesh
Shubham Minglani