Merge pull request #946 from hangyan/fix-build-path

Fix image build path error
This commit is contained in:
Charlie Drage
2018-02-27 10:09:45 -05:00
committed by GitHub
7 changed files with 43 additions and 9 deletions
+2 -2
View File
@@ -660,13 +660,13 @@ func (k *Kubernetes) Transform(komposeObject kobject.KomposeObject, opt kobject.
return nil, err
}
// Build the container!
// Build the image!
err = transformer.BuildDockerImage(service, name, composeFileDir)
if err != nil {
return nil, errors.Wrapf(err, "Unable to build Docker image for service %v", name)
}
// Push the built container to the repo!
// Push the built image to the repo!
err = transformer.PushDockerImage(service, name)
if err != nil {
return nil, errors.Wrapf(err, "Unable to push Docker image for service %v", name)
+6 -7
View File
@@ -209,16 +209,15 @@ func GetComposeFileDir(inputFiles []string) (string, error) {
//BuildDockerImage builds docker image
func BuildDockerImage(service kobject.ServiceConfig, name string, relativePath string) error {
// First, let's figure out the relative path of the Dockerfile!
// else, we error out.
if _, err := os.Stat(service.Build); err != nil {
// Get the appropriate image source and name
imagePath := path.Join(relativePath, path.Base(service.Build))
if !path.IsAbs(service.Build) {
imagePath = path.Join(relativePath, service.Build)
}
if _, err := os.Stat(imagePath); err != nil {
return errors.Wrapf(err, "%s is not a valid path for building image %s. Check if this dir exists.", service.Build, name)
}
// Get the appropriate image source and name
// use path.Base to get the last element of the relative build path
imagePath := path.Join(relativePath, path.Base(service.Build))
imageName := name
if service.Image != "" {
imageName = service.Image