From c292c84c2c85ea39a2dc66a2fc44f660361837d7 Mon Sep 17 00:00:00 2001
From: Bill <bill@dydx.exchange>
Date: Mon, 6 Nov 2023 17:48:19 -0800
Subject: [PATCH] Fix decimal overflow bug (#127)

* Fix decimal overflow bug

* use decimals:
---
 src/hooks/useSubaccount.tsx  | 145 ++++++++++++++++++++++-------------
 src/hooks/useTokenConfigs.ts |   4 +
 2 files changed, 95 insertions(+), 54 deletions(-)

diff --git a/src/hooks/useSubaccount.tsx b/src/hooks/useSubaccount.tsx
index 955572c..28ea2d4 100644
--- a/src/hooks/useSubaccount.tsx
+++ b/src/hooks/useSubaccount.tsx
@@ -48,7 +48,7 @@ export const useSubaccount = () => useContext(SubaccountContext);
 
 export const useSubaccountContext = ({ localDydxWallet }: { localDydxWallet?: LocalWallet }) => {
   const dispatch = useDispatch();
-  const { usdcDenom } = useTokenConfigs();
+  const { usdcDenom, usdcDecimals } = useTokenConfigs();
   const { compositeClient, faucetClient } = useDydxClient();
 
   const { getFaucetFunds } = useMemo(
@@ -79,16 +79,34 @@ export const useSubaccountContext = ({ localDydxWallet }: { localDydxWallet?: Lo
         subaccountClient: SubaccountClient;
         assetId?: number;
         amount: number;
-      }) => await compositeClient?.depositToSubaccount(subaccountClient, amount.toString()),
-
+      }) => {
+        try {
+          return await compositeClient?.depositToSubaccount(
+            subaccountClient,
+            amount.toFixed(usdcDecimals)
+          );
+        } catch (error) {
+          log('useSubaccount/depositToSubaccount', error);
+          throw error;
+        }
+      },
       withdrawFromSubaccount: async ({
         subaccountClient,
         amount,
       }: {
         subaccountClient: SubaccountClient;
         amount: number;
-      }) => await compositeClient?.withdrawFromSubaccount(subaccountClient, amount.toString()),
-
+      }) => {
+        try {
+          return await compositeClient?.withdrawFromSubaccount(
+            subaccountClient,
+            amount.toFixed(usdcDecimals)
+          );
+        } catch (error) {
+          log('useSubaccount/withdrawFromSubaccount', error);
+          throw error;
+        }
+      },
       transferFromSubaccountToAddress: async ({
         subaccountClient,
         assetId = 0,
@@ -99,27 +117,33 @@ export const useSubaccountContext = ({ localDydxWallet }: { localDydxWallet?: Lo
         assetId?: number;
         amount: number;
         recipient: string;
-      }) =>
-        await compositeClient?.validatorClient.post.send(
-          subaccountClient?.wallet,
-          () =>
-            new Promise((resolve) => {
-              const msg =
-                compositeClient?.validatorClient.post.composer.composeMsgWithdrawFromSubaccount(
-                  subaccountClient.address,
-                  subaccountClient.subaccountNumber,
-                  assetId,
-                  Long.fromNumber(amount * QUANTUM_MULTIPLIER),
-                  recipient
-                );
+      }) => {
+        try {
+          return await compositeClient?.validatorClient.post.send(
+            subaccountClient?.wallet,
+            () =>
+              new Promise((resolve) => {
+                const msg =
+                  compositeClient?.validatorClient.post.composer.composeMsgWithdrawFromSubaccount(
+                    subaccountClient.address,
+                    subaccountClient.subaccountNumber,
+                    assetId,
+                    Long.fromNumber(amount * QUANTUM_MULTIPLIER),
+                    recipient
+                  );
 
-              resolve([msg]);
-            }),
-          false,
-          undefined,
-          undefined,
-          Method.BroadcastTxCommit
-        ),
+                resolve([msg]);
+              }),
+            false,
+            undefined,
+            undefined,
+            Method.BroadcastTxCommit
+          );
+        } catch (error) {
+          log('useSubaccount/transferFromSubaccountToAddress', error);
+          throw error;
+        }
+      },
 
       transferNativeToken: async ({
         subaccountClient,
@@ -129,24 +153,30 @@ export const useSubaccountContext = ({ localDydxWallet }: { localDydxWallet?: Lo
         subaccountClient: SubaccountClient;
         amount: number;
         recipient: string;
-      }) =>
-        await compositeClient?.validatorClient.post.send(
-          subaccountClient.wallet,
-          () =>
-            new Promise((resolve) => {
-              const msg = compositeClient?.sendTokenMessage(
-                subaccountClient.wallet,
-                amount.toString(),
-                recipient,
-              );
+      }) => {
+        try {
+          return await compositeClient?.validatorClient.post.send(
+            subaccountClient.wallet,
+            () =>
+              new Promise((resolve) => {
+                const msg = compositeClient?.sendTokenMessage(
+                  subaccountClient.wallet,
+                  amount.toString(),
+                  recipient
+                );
 
-              resolve([msg]);
-            }),
-          false,
-          compositeClient?.validatorClient?.post.defaultDydxGasPrice,
-          undefined,
-          Method.BroadcastTxCommit
-        ),
+                resolve([msg]);
+              }),
+            false,
+            compositeClient?.validatorClient?.post.defaultDydxGasPrice,
+            undefined,
+            Method.BroadcastTxCommit
+          );
+        } catch (error) {
+          log('useSubaccount/transferNativeToken', error);
+          throw error;
+        }
+      },
 
       sendSquidWithdrawFromSubaccount: async ({
         subaccountClient,
@@ -158,20 +188,27 @@ export const useSubaccountContext = ({ localDydxWallet }: { localDydxWallet?: Lo
         payload: string;
       }) => {
         if (!compositeClient) throw new Error('client not initialized');
+        try {
+          const transaction = JSON.parse(payload);
 
-        const transaction = JSON.parse(payload);
+          const msg = compositeClient.withdrawFromSubaccountMessage(
+            subaccountClient,
+            amount.toFixed(usdcDecimals)
+          );
+          const ibcMsg: EncodeObject = {
+            typeUrl: transaction.msgTypeUrl,
+            value: transaction.msg,
+          };
 
-        const msg = compositeClient.withdrawFromSubaccountMessage(subaccountClient, amount.toString());
-        const ibcMsg: EncodeObject = {
-          typeUrl: transaction.msgTypeUrl,
-          value: transaction.msg,
-        };
-
-        return await compositeClient.send(
-          subaccountClient.wallet,
-          () => Promise.resolve([msg, ibcMsg]),
-          false
-        );
+          return await compositeClient.send(
+            subaccountClient.wallet,
+            () => Promise.resolve([msg, ibcMsg]),
+            false
+          );
+        } catch (error) {
+          log('useSubaccount/sendSquidWithdrawFromSubaccount', error);
+          throw error;
+        }
       },
     }),
     [compositeClient]
diff --git a/src/hooks/useTokenConfigs.ts b/src/hooks/useTokenConfigs.ts
index 2a2b728..2bbe155 100644
--- a/src/hooks/useTokenConfigs.ts
+++ b/src/hooks/useTokenConfigs.ts
@@ -19,8 +19,10 @@ export const useTokenConfigs = (): {
     },
   };
   usdcDenom: string;
+  usdcDecimals: number;
   usdcLabel: string;
   chainTokenDenom: string;
+  chainTokenDecimals: number;
   chainTokenLabel: string;
 } => {
   const { selectedNetwork } = useSelectedNetwork();
@@ -29,8 +31,10 @@ export const useTokenConfigs = (): {
   return { 
     tokensConfigs,
     usdcDenom: tokensConfigs[DydxChainAsset.USDC].denom, 
+    usdcDecimals: tokensConfigs[DydxChainAsset.USDC].decimals, 
     usdcLabel: tokensConfigs[DydxChainAsset.USDC].name,
     chainTokenDenom: tokensConfigs[DydxChainAsset.CHAINTOKEN].denom,
+    chainTokenDecimals: tokensConfigs[DydxChainAsset.CHAINTOKEN].decimals, 
     chainTokenLabel: tokensConfigs[DydxChainAsset.CHAINTOKEN].name,
   };
 };