From 575856b77b5006febf39055a69a380e401bfa81f Mon Sep 17 00:00:00 2001 From: aleka Date: Mon, 23 Oct 2023 17:51:13 -0400 Subject: [PATCH] remove asset symbol for account balance logic (#95) --- src/hooks/useAccountBalance.ts | 5 +---- src/pages/rewards/DYDXBalancePanel.tsx | 6 ++---- src/views/forms/AccountManagementForms/DepositForm.tsx | 1 - 3 files changed, 3 insertions(+), 9 deletions(-) diff --git a/src/hooks/useAccountBalance.ts b/src/hooks/useAccountBalance.ts index c4a84b5..89cdf55 100644 --- a/src/hooks/useAccountBalance.ts +++ b/src/hooks/useAccountBalance.ts @@ -6,7 +6,6 @@ import { useQuery } from 'react-query'; import { formatUnits } from 'viem'; import { ENVIRONMENT_CONFIG_MAP } from '@/constants/networks'; -import { QUANTUM_MULTIPLIER } from '@/constants/numbers'; import { EvmAddress } from '@/constants/wallets'; import { convertBech32Address } from '@/lib/addressUtils'; @@ -21,7 +20,6 @@ import { useTokenConfigs } from './useTokenConfigs'; type UseAccountBalanceProps = { // Token Items addressOrDenom?: string; - assetSymbol?: string; decimals?: number; // Chain Items @@ -40,7 +38,6 @@ export const CHAIN_DEFAULT_TOKEN_ADDRESS = '0xEeeeeEeeeEeEeeEeEeEeeEEEeeeeEeeeee export const useAccountBalance = ({ addressOrDenom, - assetSymbol, bech32AddrPrefix, chainId, decimals = 0, @@ -91,7 +88,7 @@ export const useAccountBalance = ({ }); const { formatted: evmBalance } = evmQuery.data || {}; - const balance = !assetSymbol ? '0' : isCosmosChain ? cosmosQuery.data : evmBalance; + const balance = isCosmosChain ? cosmosQuery.data : evmBalance; const nativeTokenCoinBalance = balances?.[chainTokenDenom]; const nativeTokenBalance = MustBigNumber(nativeTokenCoinBalance?.amount); diff --git a/src/pages/rewards/DYDXBalancePanel.tsx b/src/pages/rewards/DYDXBalancePanel.tsx index f2c055e..7d4fd9e 100644 --- a/src/pages/rewards/DYDXBalancePanel.tsx +++ b/src/pages/rewards/DYDXBalancePanel.tsx @@ -22,7 +22,6 @@ import { OnboardingTriggerButton } from '@/views/dialogs/OnboardingTriggerButton import { openDialog } from '@/state/dialogs'; import { calculateCanAccountTrade } from '@/state/accountCalculators'; -// TODO(@aforaleka): replace with real data export const DYDXBalancePanel = () => { const dispatch = useDispatch(); const stringGetter = useStringGetter(); @@ -110,7 +109,7 @@ export const DYDXBalancePanel = () => { value: ( ), @@ -126,7 +125,7 @@ const Styled: Record = {}; Styled.Header = styled.div` ${layoutMixins.spacedRow} - padding: 1.25rem 1.5rem 0.5rem; + padding: 1rem 1.5rem 0; `; Styled.Title = styled.h3` @@ -155,7 +154,6 @@ Styled.ReceiveButton = styled(Button)` Styled.Content = styled.div` ${layoutMixins.flexColumn} gap: 0.75rem; - padding: 0 0.5rem 0.5rem; `; Styled.IconContainer = styled.div` diff --git a/src/views/forms/AccountManagementForms/DepositForm.tsx b/src/views/forms/AccountManagementForms/DepositForm.tsx index e44e81e..426be1c 100644 --- a/src/views/forms/AccountManagementForms/DepositForm.tsx +++ b/src/views/forms/AccountManagementForms/DepositForm.tsx @@ -87,7 +87,6 @@ export const DepositForm = ({ onDeposit, onError }: DepositFormProps) => { // Async Data const { balance, queryStatus, isQueryFetching } = useAccountBalance({ addressOrDenom: sourceToken?.address || CHAIN_DEFAULT_TOKEN_ADDRESS, - assetSymbol: sourceToken?.symbol || undefined, chainId: chainId, decimals: sourceToken?.decimals || undefined, isCosmosChain: false,