cosmos-sdk/x/auth/client/cli
Zaki Manian f65b6c9363
feat: Error on blank chain-id in multisign command (#9593)
Error on `tx multisign` command if chain-id is blank. This is a common cause of signature verification failures when combining signatures and the error message doesn't provide any clues to this common cause.

I have...

- [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [x] added `!` to the type prefix if API or client breaking change
- [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting))
- [] provided a link to the relevant issue or specification
- [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules)
- [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing)
- [ ] added a changelog entry to `CHANGELOG.md`
- [ ] included comments for [documenting Go code](https://blog.golang.org/godoc)
- [ ] updated the relevant documentation or specification
- [ ] reviewed "Files changed" and left comments if necessary
- [ ] confirmed all CI checks have passed

### Reviewers Checklist

*All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.*

I have...

- [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title
- [ ] confirmed `!` in the type prefix if API or client breaking change
- [ ] confirmed all author checklist items have been addressed 
- [ ] reviewed state machine logic
- [ ] reviewed API design and naming
- [ ] reviewed documentation is accurate
- [ ] reviewed tests and test coverage
- [ ] manually tested (if applicable)
2021-06-29 08:10:04 +00:00
..
broadcast.go Combine client.ReadTxCommandFlags with GetClientContextFromCmd (#8155) 2020-12-14 22:09:51 +00:00
decode.go fix: duplicate vesting and format (#9535) 2021-06-18 01:50:37 +00:00
encode_test.go refactor(client): add client/Context.Codec and deprecate JSONCodec (#9498) 2021-06-11 11:49:39 +00:00
encode.go fix: Signature only flag bug on tx sign command 7632 (#8106) 2020-12-14 21:44:15 +00:00
query.go fix: query txs command adds output flag (#9540) 2021-06-21 10:40:56 +00:00
tx_multisign.go feat: Error on blank chain-id in multisign command (#9593) 2021-06-29 08:10:04 +00:00
tx_sign.go feat: multisig should accept name, not just address (#9553) 2021-06-23 16:21:59 +00:00
validate_sigs.go Set proper default command output (#8628) 2021-04-17 00:21:32 +00:00