fc2897d3a9
## Description Deprecate the usage of the now legacy x/params module within x/staking. Closes: #12285 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
113 lines
3.3 KiB
Go
113 lines
3.3 KiB
Go
package params_test
|
|
|
|
import (
|
|
stakingtypes "github.com/cosmos/cosmos-sdk/x/staking/types"
|
|
"testing"
|
|
|
|
"github.com/golang/mock/gomock"
|
|
"github.com/stretchr/testify/suite"
|
|
|
|
"github.com/cosmos/cosmos-sdk/testutil"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
moduletestutil "github.com/cosmos/cosmos-sdk/types/module/testutil"
|
|
govv1beta1 "github.com/cosmos/cosmos-sdk/x/gov/types/v1beta1"
|
|
"github.com/cosmos/cosmos-sdk/x/params"
|
|
"github.com/cosmos/cosmos-sdk/x/params/keeper"
|
|
paramstestutil "github.com/cosmos/cosmos-sdk/x/params/testutil"
|
|
paramtypes "github.com/cosmos/cosmos-sdk/x/params/types"
|
|
"github.com/cosmos/cosmos-sdk/x/params/types/proposal"
|
|
)
|
|
|
|
// StakingKeeper defines the expected staking keeper
|
|
type StakingKeeper interface {
|
|
MaxValidators(ctx sdk.Context) (res uint32)
|
|
}
|
|
|
|
type HandlerTestSuite struct {
|
|
suite.Suite
|
|
|
|
ctx sdk.Context
|
|
govHandler govv1beta1.Handler
|
|
stakingKeeper StakingKeeper
|
|
}
|
|
|
|
func (suite *HandlerTestSuite) SetupTest() {
|
|
encodingCfg := moduletestutil.MakeTestEncodingConfig(params.AppModuleBasic{})
|
|
key := sdk.NewKVStoreKey(paramtypes.StoreKey)
|
|
tkey := sdk.NewTransientStoreKey("params_transient_test")
|
|
|
|
ctx := testutil.DefaultContext(key, tkey)
|
|
paramsKeeper := keeper.NewKeeper(encodingCfg.Codec, encodingCfg.Amino, key, tkey)
|
|
paramsKeeper.Subspace("staking").WithKeyTable(stakingtypes.ParamKeyTable())
|
|
ctrl := gomock.NewController(suite.T())
|
|
stakingKeeper := paramstestutil.NewMockStakingKeeper(ctrl)
|
|
stakingKeeper.EXPECT().MaxValidators(ctx).Return(uint32(1))
|
|
|
|
suite.govHandler = params.NewParamChangeProposalHandler(paramsKeeper)
|
|
suite.stakingKeeper = stakingKeeper
|
|
suite.ctx = ctx
|
|
}
|
|
|
|
func TestHandlerTestSuite(t *testing.T) {
|
|
suite.Run(t, new(HandlerTestSuite))
|
|
}
|
|
|
|
func testProposal(changes ...proposal.ParamChange) *proposal.ParameterChangeProposal {
|
|
return proposal.NewParameterChangeProposal("title", "description", changes)
|
|
}
|
|
|
|
func (suite *HandlerTestSuite) TestProposalHandler() {
|
|
testCases := []struct {
|
|
name string
|
|
proposal *proposal.ParameterChangeProposal
|
|
onHandle func()
|
|
expErr bool
|
|
}{
|
|
{
|
|
"all fields",
|
|
testProposal(proposal.NewParamChange(stakingtypes.ModuleName, string(stakingtypes.KeyMaxValidators), "1")),
|
|
func() {
|
|
maxVals := suite.stakingKeeper.MaxValidators(suite.ctx)
|
|
suite.Require().Equal(uint32(1), maxVals)
|
|
},
|
|
false,
|
|
},
|
|
{
|
|
"invalid type",
|
|
testProposal(proposal.NewParamChange(stakingtypes.ModuleName, string(stakingtypes.KeyMaxValidators), "-")),
|
|
func() {},
|
|
true,
|
|
},
|
|
//{
|
|
// "omit empty fields",
|
|
// testProposal(proposal.ParamChange{
|
|
// Subspace: govtypes.ModuleName,
|
|
// Key: string(govv1.ParamStoreKeyDepositParams),
|
|
// Value: `{"min_deposit": [{"denom": "uatom","amount": "64000000"}], "max_deposit_period": "172800000000000"}`,
|
|
// }),
|
|
// func() {
|
|
// depositParams := suite.app.GovKeeper.GetDepositParams(suite.ctx)
|
|
// defaultPeriod := govv1.DefaultPeriod
|
|
// suite.Require().Equal(govv1.DepositParams{
|
|
// MinDeposit: sdk.NewCoins(sdk.NewCoin("uatom", sdk.NewInt(64000000))),
|
|
// MaxDepositPeriod: &defaultPeriod,
|
|
// }, depositParams)
|
|
// },
|
|
// false,
|
|
//},
|
|
}
|
|
|
|
for _, tc := range testCases {
|
|
tc := tc
|
|
suite.Run(tc.name, func() {
|
|
err := suite.govHandler(suite.ctx, tc.proposal)
|
|
if tc.expErr {
|
|
suite.Require().Error(err)
|
|
} else {
|
|
suite.Require().NoError(err)
|
|
tc.onHandle()
|
|
}
|
|
})
|
|
}
|
|
}
|