9094794478
<!-- The default pull request template is for types feat, fix, or refactor. For other templates, add one of the following parameters to the url: - template=docs.md - template=other.md --> ## Description Closes: #8961 SDK allows InitGenesis to return with an empty validator set. In practice, the error for an empty validator set gets thrown in tendermint. To fix this, * Add non-empty validator set check to the `mm.InitGenesis` function. This will break `simapp.Setup` because it relies on an empty validator set [#comment](https://github.com/cosmos/cosmos-sdk/pull/8909#issuecomment-804850834). * Update `simapp.Setup` to use a single validator. * Fix failing tests (Most of them are keeper tests). <!-- Add a description of the changes that this PR introduces and the files that are the most critical to review. --> --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [x] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [x] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [x] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
132 lines
4.5 KiB
Go
132 lines
4.5 KiB
Go
package keeper_test
|
|
|
|
import (
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/assert"
|
|
"github.com/stretchr/testify/require"
|
|
tmproto "github.com/tendermint/tendermint/proto/tendermint/types"
|
|
|
|
"github.com/cosmos/cosmos-sdk/simapp"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
"github.com/cosmos/cosmos-sdk/x/bank/testutil"
|
|
"github.com/cosmos/cosmos-sdk/x/distribution/types"
|
|
)
|
|
|
|
func TestSetWithdrawAddr(t *testing.T) {
|
|
app := simapp.Setup(t, false)
|
|
ctx := app.BaseApp.NewContext(false, tmproto.Header{})
|
|
|
|
addr := simapp.AddTestAddrs(app, ctx, 2, sdk.NewInt(1000000000))
|
|
|
|
params := app.DistrKeeper.GetParams(ctx)
|
|
params.WithdrawAddrEnabled = false
|
|
app.DistrKeeper.SetParams(ctx, params)
|
|
|
|
err := app.DistrKeeper.SetWithdrawAddr(ctx, addr[0], addr[1])
|
|
require.NotNil(t, err)
|
|
|
|
params.WithdrawAddrEnabled = true
|
|
app.DistrKeeper.SetParams(ctx, params)
|
|
|
|
err = app.DistrKeeper.SetWithdrawAddr(ctx, addr[0], addr[1])
|
|
require.Nil(t, err)
|
|
|
|
require.Error(t, app.DistrKeeper.SetWithdrawAddr(ctx, addr[0], distrAcc.GetAddress()))
|
|
}
|
|
|
|
func TestWithdrawValidatorCommission(t *testing.T) {
|
|
app := simapp.Setup(t, false)
|
|
ctx := app.BaseApp.NewContext(false, tmproto.Header{})
|
|
|
|
valCommission := sdk.DecCoins{
|
|
sdk.NewDecCoinFromDec("mytoken", sdk.NewDec(5).Quo(sdk.NewDec(4))),
|
|
sdk.NewDecCoinFromDec("stake", sdk.NewDec(3).Quo(sdk.NewDec(2))),
|
|
}
|
|
|
|
addr := simapp.AddTestAddrs(app, ctx, 1, sdk.NewInt(1000000000))
|
|
valAddrs := simapp.ConvertAddrsToValAddrs(addr)
|
|
|
|
// set module account coins
|
|
distrAcc := app.DistrKeeper.GetDistributionAccount(ctx)
|
|
coins := sdk.NewCoins(sdk.NewCoin("mytoken", sdk.NewInt(2)), sdk.NewCoin("stake", sdk.NewInt(2)))
|
|
require.NoError(t, testutil.FundModuleAccount(app.BankKeeper, ctx, distrAcc.GetName(), coins))
|
|
|
|
app.AccountKeeper.SetModuleAccount(ctx, distrAcc)
|
|
|
|
// check initial balance
|
|
balance := app.BankKeeper.GetAllBalances(ctx, sdk.AccAddress(valAddrs[0]))
|
|
expTokens := app.StakingKeeper.TokensFromConsensusPower(ctx, 1000)
|
|
expCoins := sdk.NewCoins(sdk.NewCoin("stake", expTokens))
|
|
require.Equal(t, expCoins, balance)
|
|
|
|
// set outstanding rewards
|
|
app.DistrKeeper.SetValidatorOutstandingRewards(ctx, valAddrs[0], types.ValidatorOutstandingRewards{Rewards: valCommission})
|
|
|
|
// set commission
|
|
app.DistrKeeper.SetValidatorAccumulatedCommission(ctx, valAddrs[0], types.ValidatorAccumulatedCommission{Commission: valCommission})
|
|
|
|
// withdraw commission
|
|
_, err := app.DistrKeeper.WithdrawValidatorCommission(ctx, valAddrs[0])
|
|
require.NoError(t, err)
|
|
|
|
// check balance increase
|
|
balance = app.BankKeeper.GetAllBalances(ctx, sdk.AccAddress(valAddrs[0]))
|
|
require.Equal(t, sdk.NewCoins(
|
|
sdk.NewCoin("mytoken", sdk.NewInt(1)),
|
|
sdk.NewCoin("stake", expTokens.AddRaw(1)),
|
|
), balance)
|
|
|
|
// check remainder
|
|
remainder := app.DistrKeeper.GetValidatorAccumulatedCommission(ctx, valAddrs[0]).Commission
|
|
require.Equal(t, sdk.DecCoins{
|
|
sdk.NewDecCoinFromDec("mytoken", sdk.NewDec(1).Quo(sdk.NewDec(4))),
|
|
sdk.NewDecCoinFromDec("stake", sdk.NewDec(1).Quo(sdk.NewDec(2))),
|
|
}, remainder)
|
|
|
|
require.True(t, true)
|
|
}
|
|
|
|
func TestGetTotalRewards(t *testing.T) {
|
|
app := simapp.Setup(t, false)
|
|
ctx := app.BaseApp.NewContext(false, tmproto.Header{})
|
|
|
|
valCommission := sdk.DecCoins{
|
|
sdk.NewDecCoinFromDec("mytoken", sdk.NewDec(5).Quo(sdk.NewDec(4))),
|
|
sdk.NewDecCoinFromDec("stake", sdk.NewDec(3).Quo(sdk.NewDec(2))),
|
|
}
|
|
|
|
addr := simapp.AddTestAddrs(app, ctx, 2, sdk.NewInt(1000000000))
|
|
valAddrs := simapp.ConvertAddrsToValAddrs(addr)
|
|
|
|
app.DistrKeeper.SetValidatorOutstandingRewards(ctx, valAddrs[0], types.ValidatorOutstandingRewards{Rewards: valCommission})
|
|
app.DistrKeeper.SetValidatorOutstandingRewards(ctx, valAddrs[1], types.ValidatorOutstandingRewards{Rewards: valCommission})
|
|
|
|
expectedRewards := valCommission.MulDec(sdk.NewDec(2))
|
|
totalRewards := app.DistrKeeper.GetTotalRewards(ctx)
|
|
|
|
require.Equal(t, expectedRewards, totalRewards)
|
|
}
|
|
|
|
func TestFundCommunityPool(t *testing.T) {
|
|
app := simapp.Setup(t, false)
|
|
ctx := app.BaseApp.NewContext(false, tmproto.Header{})
|
|
|
|
// reset fee pool
|
|
app.DistrKeeper.SetFeePool(ctx, types.InitialFeePool())
|
|
|
|
addr := simapp.AddTestAddrs(app, ctx, 2, sdk.ZeroInt())
|
|
|
|
amount := sdk.NewCoins(sdk.NewInt64Coin("stake", 100))
|
|
require.NoError(t, testutil.FundAccount(app.BankKeeper, ctx, addr[0], amount))
|
|
|
|
initPool := app.DistrKeeper.GetFeePool(ctx)
|
|
assert.Empty(t, initPool.CommunityPool)
|
|
|
|
err := app.DistrKeeper.FundCommunityPool(ctx, amount, addr[0])
|
|
assert.Nil(t, err)
|
|
|
|
assert.Equal(t, initPool.CommunityPool.Add(sdk.NewDecCoinsFromCoins(amount...)...), app.DistrKeeper.GetFeePool(ctx).CommunityPool)
|
|
assert.Empty(t, app.BankKeeper.GetAllBalances(ctx, addr[0]))
|
|
}
|