## Description We decided to remove middlewares, and revert to antehandlers (exactly like in v045) for this release. A better middleware solution will be implemented after v046. ref: https://github.com/cosmos/cosmos-sdk/issues/11955 This PR is part 2 of 2: - part 1: Revert baseapp and middlewares to v0.45.4 - part 2: Add posthandler, tips, priority Depends on: - [x] #11979 --- Suggestion for reviewers: - Apart from correctness, I would also like someone to review **exhaustiveness**. I.e. all changes we made in v046 into the [middleware folder](https://github.com/cosmos/cosmos-sdk/tree/v0.46.0-beta2/x/auth/middleware) are reflected in this PR, and that I didn't forget anything. I found the following ones: - add a TxFeeChecker in DeductFee - add a ExtensionChecker in ExtCheckerDecorator - add a TipDecorator --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/main/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/main/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
66 lines
2.1 KiB
Go
66 lines
2.1 KiB
Go
package ante
|
|
|
|
import (
|
|
codectypes "github.com/cosmos/cosmos-sdk/codec/types"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
sdkerrors "github.com/cosmos/cosmos-sdk/types/errors"
|
|
)
|
|
|
|
type HasExtensionOptionsTx interface {
|
|
GetExtensionOptions() []*codectypes.Any
|
|
GetNonCriticalExtensionOptions() []*codectypes.Any
|
|
}
|
|
|
|
// ExtensionOptionChecker is a function that returns true if the extension option is accepted.
|
|
type ExtensionOptionChecker func(*codectypes.Any) bool
|
|
|
|
// rejectExtensionOption is the default extension check that reject all tx
|
|
// extensions.
|
|
func rejectExtensionOption(*codectypes.Any) bool {
|
|
return false
|
|
}
|
|
|
|
// RejectExtensionOptionsDecorator is an AnteDecorator that rejects all extension
|
|
// options which can optionally be included in protobuf transactions. Users that
|
|
// need extension options should create a custom AnteHandler chain that handles
|
|
// needed extension options properly and rejects unknown ones.
|
|
type RejectExtensionOptionsDecorator struct {
|
|
checker ExtensionOptionChecker
|
|
}
|
|
|
|
// NewExtensionOptionsDecorator creates a new antehandler that rejects all extension
|
|
// options which can optionally be included in protobuf transactions that don't pass the checker.
|
|
// Users that need extension options should pass a custom checker that returns true for the
|
|
// needed extension options.
|
|
func NewExtensionOptionsDecorator(checker ExtensionOptionChecker) sdk.AnteDecorator {
|
|
if checker == nil {
|
|
checker = rejectExtensionOption
|
|
}
|
|
|
|
return RejectExtensionOptionsDecorator{checker: checker}
|
|
}
|
|
|
|
var _ sdk.AnteDecorator = RejectExtensionOptionsDecorator{}
|
|
|
|
// AnteHandle implements the AnteDecorator.AnteHandle method
|
|
func (r RejectExtensionOptionsDecorator) AnteHandle(ctx sdk.Context, tx sdk.Tx, simulate bool, next sdk.AnteHandler) (newCtx sdk.Context, err error) {
|
|
err = checkExtOpts(tx, r.checker)
|
|
if err != nil {
|
|
return ctx, err
|
|
}
|
|
|
|
return next(ctx, tx, simulate)
|
|
}
|
|
|
|
func checkExtOpts(tx sdk.Tx, checker ExtensionOptionChecker) error {
|
|
if hasExtOptsTx, ok := tx.(HasExtensionOptionsTx); ok {
|
|
for _, opt := range hasExtOptsTx.GetExtensionOptions() {
|
|
if !checker(opt) {
|
|
return sdkerrors.ErrUnknownExtensionOptions
|
|
}
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|