## Description + fixing `x/bank/migrations/v44.migrateDenomMetadata` - we could potentially put a wrong data in a new key if the old keys have variable length. + linting the code Putting in the same PR because i found the issue when running a linter. Depends on: #10112 --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [x] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [x] added `!` to the type prefix if API or client breaking change - [x] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [x] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
186 lines
6.2 KiB
Go
186 lines
6.2 KiB
Go
package cmd
|
|
|
|
import (
|
|
"bufio"
|
|
"encoding/json"
|
|
"errors"
|
|
"fmt"
|
|
|
|
"github.com/spf13/cobra"
|
|
|
|
"github.com/cosmos/cosmos-sdk/client"
|
|
"github.com/cosmos/cosmos-sdk/client/flags"
|
|
"github.com/cosmos/cosmos-sdk/crypto/keyring"
|
|
"github.com/cosmos/cosmos-sdk/server"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
authtypes "github.com/cosmos/cosmos-sdk/x/auth/types"
|
|
authvesting "github.com/cosmos/cosmos-sdk/x/auth/vesting/types"
|
|
banktypes "github.com/cosmos/cosmos-sdk/x/bank/types"
|
|
"github.com/cosmos/cosmos-sdk/x/genutil"
|
|
genutiltypes "github.com/cosmos/cosmos-sdk/x/genutil/types"
|
|
)
|
|
|
|
const (
|
|
flagVestingStart = "vesting-start-time"
|
|
flagVestingEnd = "vesting-end-time"
|
|
flagVestingAmt = "vesting-amount"
|
|
)
|
|
|
|
// AddGenesisAccountCmd returns add-genesis-account cobra Command.
|
|
func AddGenesisAccountCmd(defaultNodeHome string) *cobra.Command {
|
|
cmd := &cobra.Command{
|
|
Use: "add-genesis-account [address_or_key_name] [coin][,[coin]]",
|
|
Short: "Add a genesis account to genesis.json",
|
|
Long: `Add a genesis account to genesis.json. The provided account must specify
|
|
the account address or key name and a list of initial coins. If a key name is given,
|
|
the address will be looked up in the local Keybase. The list of initial tokens must
|
|
contain valid denominations. Accounts may optionally be supplied with vesting parameters.
|
|
`,
|
|
Args: cobra.ExactArgs(2),
|
|
RunE: func(cmd *cobra.Command, args []string) error {
|
|
clientCtx := client.GetClientContextFromCmd(cmd)
|
|
serverCtx := server.GetServerContextFromCmd(cmd)
|
|
config := serverCtx.Config
|
|
|
|
config.SetRoot(clientCtx.HomeDir)
|
|
|
|
var kr keyring.Keyring
|
|
addr, err := sdk.AccAddressFromBech32(args[0])
|
|
if err != nil {
|
|
inBuf := bufio.NewReader(cmd.InOrStdin())
|
|
keyringBackend, _ := cmd.Flags().GetString(flags.FlagKeyringBackend)
|
|
|
|
if keyringBackend != "" && clientCtx.Keyring == nil {
|
|
var err error
|
|
kr, err = keyring.New(sdk.KeyringServiceName(), keyringBackend, clientCtx.HomeDir, inBuf, clientCtx.Codec)
|
|
if err != nil {
|
|
return err
|
|
}
|
|
} else {
|
|
kr = clientCtx.Keyring
|
|
}
|
|
|
|
k, err := kr.Key(args[0])
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get address from Keyring: %w", err)
|
|
}
|
|
|
|
addr, err = k.GetAddress()
|
|
if err != nil {
|
|
return err
|
|
}
|
|
}
|
|
|
|
coins, err := sdk.ParseCoinsNormalized(args[1])
|
|
if err != nil {
|
|
return fmt.Errorf("failed to parse coins: %w", err)
|
|
}
|
|
|
|
vestingStart, _ := cmd.Flags().GetInt64(flagVestingStart)
|
|
vestingEnd, _ := cmd.Flags().GetInt64(flagVestingEnd)
|
|
vestingAmtStr, _ := cmd.Flags().GetString(flagVestingAmt)
|
|
|
|
vestingAmt, err := sdk.ParseCoinsNormalized(vestingAmtStr)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to parse vesting amount: %w", err)
|
|
}
|
|
|
|
// create concrete account type based on input parameters
|
|
var genAccount authtypes.GenesisAccount
|
|
|
|
balances := banktypes.Balance{Address: addr.String(), Coins: coins.Sort()}
|
|
baseAccount := authtypes.NewBaseAccount(addr, nil, 0, 0)
|
|
|
|
if !vestingAmt.IsZero() {
|
|
baseVestingAccount := authvesting.NewBaseVestingAccount(baseAccount, vestingAmt.Sort(), vestingEnd)
|
|
|
|
if (balances.Coins.IsZero() && !baseVestingAccount.OriginalVesting.IsZero()) ||
|
|
baseVestingAccount.OriginalVesting.IsAnyGT(balances.Coins) {
|
|
return errors.New("vesting amount cannot be greater than total amount")
|
|
}
|
|
|
|
switch {
|
|
case vestingStart != 0 && vestingEnd != 0:
|
|
genAccount = authvesting.NewContinuousVestingAccountRaw(baseVestingAccount, vestingStart)
|
|
|
|
case vestingEnd != 0:
|
|
genAccount = authvesting.NewDelayedVestingAccountRaw(baseVestingAccount)
|
|
|
|
default:
|
|
return errors.New("invalid vesting parameters; must supply start and end time or end time")
|
|
}
|
|
} else {
|
|
genAccount = baseAccount
|
|
}
|
|
|
|
if err := genAccount.Validate(); err != nil {
|
|
return fmt.Errorf("failed to validate new genesis account: %w", err)
|
|
}
|
|
|
|
genFile := config.GenesisFile()
|
|
appState, genDoc, err := genutiltypes.GenesisStateFromGenFile(genFile)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to unmarshal genesis state: %w", err)
|
|
}
|
|
|
|
authGenState := authtypes.GetGenesisStateFromAppState(clientCtx.Codec, appState)
|
|
|
|
accs, err := authtypes.UnpackAccounts(authGenState.Accounts)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to get accounts from any: %w", err)
|
|
}
|
|
|
|
if accs.Contains(addr) {
|
|
return fmt.Errorf("cannot add account at existing address %s", addr)
|
|
}
|
|
|
|
// Add the new account to the set of genesis accounts and sanitize the
|
|
// accounts afterwards.
|
|
accs = append(accs, genAccount)
|
|
accs = authtypes.SanitizeGenesisAccounts(accs)
|
|
|
|
genAccs, err := authtypes.PackAccounts(accs)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to convert accounts into any's: %w", err)
|
|
}
|
|
authGenState.Accounts = genAccs
|
|
|
|
authGenStateBz, err := clientCtx.Codec.MarshalJSON(&authGenState)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to marshal auth genesis state: %w", err)
|
|
}
|
|
|
|
appState[authtypes.ModuleName] = authGenStateBz
|
|
|
|
bankGenState := banktypes.GetGenesisStateFromAppState(clientCtx.Codec, appState)
|
|
bankGenState.Balances = append(bankGenState.Balances, balances)
|
|
bankGenState.Balances = banktypes.SanitizeGenesisBalances(bankGenState.Balances)
|
|
bankGenState.Supply = bankGenState.Supply.Add(balances.Coins...)
|
|
|
|
bankGenStateBz, err := clientCtx.Codec.MarshalJSON(bankGenState)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to marshal bank genesis state: %w", err)
|
|
}
|
|
|
|
appState[banktypes.ModuleName] = bankGenStateBz
|
|
|
|
appStateJSON, err := json.Marshal(appState)
|
|
if err != nil {
|
|
return fmt.Errorf("failed to marshal application genesis state: %w", err)
|
|
}
|
|
|
|
genDoc.AppState = appStateJSON
|
|
return genutil.ExportGenesisFile(genDoc, genFile)
|
|
},
|
|
}
|
|
|
|
cmd.Flags().String(flags.FlagHome, defaultNodeHome, "The application home directory")
|
|
cmd.Flags().String(flags.FlagKeyringBackend, flags.DefaultKeyringBackend, "Select keyring's backend (os|file|kwallet|pass|test)")
|
|
cmd.Flags().String(flagVestingAmt, "", "amount of coins for vesting accounts")
|
|
cmd.Flags().Int64(flagVestingStart, 0, "schedule start time (unix epoch) for vesting accounts")
|
|
cmd.Flags().Int64(flagVestingEnd, 0, "schedule end time (unix epoch) for vesting accounts")
|
|
flags.AddQueryFlagsToCmd(cmd)
|
|
|
|
return cmd
|
|
}
|