## Description Implements part of #7258 Check some of currently unchecked errors. - [x] baseapp - [x] client - [x] codec - [x] crypto - [x] server - [x] simapp - [ ] snapshots - [ ] store - [x] testutil - [ ] types - [ ] modules --- ### Author Checklist *All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues.* I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] targeted the correct branch (see [PR Targeting](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] followed the guidelines for [building modules](https://github.com/cosmos/cosmos-sdk/blob/master/docs/building-modules) - [ ] included the necessary unit and integration [tests](https://github.com/cosmos/cosmos-sdk/blob/master/CONTRIBUTING.md#testing) - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist *All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items.* I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed `!` in the type prefix if API or client breaking change - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
227 lines
7.2 KiB
Go
227 lines
7.2 KiB
Go
package keys
|
|
|
|
import (
|
|
"context"
|
|
"fmt"
|
|
"testing"
|
|
|
|
"github.com/stretchr/testify/require"
|
|
|
|
"github.com/cosmos/cosmos-sdk/client"
|
|
"github.com/cosmos/cosmos-sdk/client/flags"
|
|
"github.com/cosmos/cosmos-sdk/crypto/hd"
|
|
"github.com/cosmos/cosmos-sdk/crypto/keyring"
|
|
"github.com/cosmos/cosmos-sdk/crypto/keys/multisig"
|
|
"github.com/cosmos/cosmos-sdk/crypto/keys/secp256k1"
|
|
cryptotypes "github.com/cosmos/cosmos-sdk/crypto/types"
|
|
"github.com/cosmos/cosmos-sdk/simapp"
|
|
"github.com/cosmos/cosmos-sdk/testutil"
|
|
"github.com/cosmos/cosmos-sdk/testutil/testdata"
|
|
sdk "github.com/cosmos/cosmos-sdk/types"
|
|
)
|
|
|
|
func Test_multiSigKey_Properties(t *testing.T) {
|
|
tmpKey1 := secp256k1.GenPrivKeyFromSecret([]byte("mySecret"))
|
|
pk := multisig.NewLegacyAminoPubKey(
|
|
1,
|
|
[]cryptotypes.PubKey{tmpKey1.PubKey()},
|
|
)
|
|
k, err := keyring.NewMultiRecord("myMultisig", pk)
|
|
require.NoError(t, err)
|
|
require.Equal(t, "myMultisig", k.Name)
|
|
require.Equal(t, keyring.TypeMulti, k.GetType())
|
|
|
|
pub, err := k.GetPubKey()
|
|
require.NoError(t, err)
|
|
require.Equal(t, "D3923267FA8A3DD367BB768FA8BDC8FF7F89DA3F", pub.Address().String())
|
|
|
|
addr, err := k.GetAddress()
|
|
require.NoError(t, err)
|
|
require.Equal(t, "cosmos16wfryel63g7axeamw68630wglalcnk3l0zuadc", sdk.MustBech32ifyAddressBytes("cosmos", addr))
|
|
}
|
|
|
|
func Test_showKeysCmd(t *testing.T) {
|
|
cmd := ShowKeysCmd()
|
|
require.NotNil(t, cmd)
|
|
require.Equal(t, "false", cmd.Flag(FlagAddress).DefValue)
|
|
require.Equal(t, "false", cmd.Flag(FlagPublicKey).DefValue)
|
|
}
|
|
|
|
func Test_runShowCmd(t *testing.T) {
|
|
cmd := ShowKeysCmd()
|
|
cmd.Flags().AddFlagSet(Commands("home").PersistentFlags())
|
|
mockIn := testutil.ApplyMockIODiscardOutErr(cmd)
|
|
|
|
kbHome := t.TempDir()
|
|
cdc := simapp.MakeTestEncodingConfig().Codec
|
|
kb, err := keyring.New(sdk.KeyringServiceName(), keyring.BackendTest, kbHome, mockIn, cdc)
|
|
require.NoError(t, err)
|
|
|
|
clientCtx := client.Context{}.
|
|
WithKeyringDir(kbHome).
|
|
WithCodec(cdc)
|
|
ctx := context.WithValue(context.Background(), client.ClientContextKey, &clientCtx)
|
|
|
|
cmd.SetArgs([]string{"invalid"})
|
|
require.EqualError(t, cmd.ExecuteContext(ctx), "invalid is not a valid name or address: decoding bech32 failed: invalid bech32 string length 7")
|
|
|
|
cmd.SetArgs([]string{"invalid1", "invalid2"})
|
|
require.EqualError(t, cmd.ExecuteContext(ctx), "invalid1 is not a valid name or address: decoding bech32 failed: invalid separator index 7")
|
|
|
|
fakeKeyName1 := "runShowCmd_Key1"
|
|
fakeKeyName2 := "runShowCmd_Key2"
|
|
|
|
t.Cleanup(func() {
|
|
cleanupKeys(t, kb, "runShowCmd_Key1")
|
|
cleanupKeys(t, kb, "runShowCmd_Key2")
|
|
})
|
|
|
|
path := hd.NewFundraiserParams(1, sdk.CoinType, 0).String()
|
|
_, err = kb.NewAccount(fakeKeyName1, testdata.TestMnemonic, "", path, hd.Secp256k1)
|
|
require.NoError(t, err)
|
|
|
|
path2 := hd.NewFundraiserParams(1, sdk.CoinType, 1).String()
|
|
_, err = kb.NewAccount(fakeKeyName2, testdata.TestMnemonic, "", path2, hd.Secp256k1)
|
|
require.NoError(t, err)
|
|
|
|
// Now try single key
|
|
cmd.SetArgs([]string{
|
|
fakeKeyName1,
|
|
fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome),
|
|
fmt.Sprintf("--%s=", FlagBechPrefix),
|
|
fmt.Sprintf("--%s=%s", flags.FlagKeyringBackend, keyring.BackendTest),
|
|
})
|
|
require.EqualError(t, cmd.ExecuteContext(ctx), "invalid Bech32 prefix encoding provided: ")
|
|
|
|
cmd.SetArgs([]string{
|
|
fakeKeyName1,
|
|
fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome),
|
|
fmt.Sprintf("--%s=%s", FlagBechPrefix, sdk.PrefixAccount),
|
|
fmt.Sprintf("--%s=%s", flags.FlagKeyringBackend, keyring.BackendTest),
|
|
})
|
|
|
|
// try fetch by name
|
|
require.NoError(t, cmd.ExecuteContext(ctx))
|
|
|
|
// try fetch by addr
|
|
k, err := kb.Key(fakeKeyName1)
|
|
require.NoError(t, err)
|
|
addr, err := k.GetAddress()
|
|
require.NoError(t, err)
|
|
cmd.SetArgs([]string{
|
|
addr.String(),
|
|
fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome),
|
|
fmt.Sprintf("--%s=%s", FlagBechPrefix, sdk.PrefixAccount),
|
|
fmt.Sprintf("--%s=%s", flags.FlagKeyringBackend, keyring.BackendTest),
|
|
})
|
|
|
|
require.NoError(t, cmd.ExecuteContext(ctx))
|
|
|
|
// Now try multisig key - set bech to acc
|
|
cmd.SetArgs([]string{
|
|
fakeKeyName1, fakeKeyName2,
|
|
fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome),
|
|
fmt.Sprintf("--%s=%s", FlagBechPrefix, sdk.PrefixAccount),
|
|
fmt.Sprintf("--%s=0", flagMultiSigThreshold),
|
|
fmt.Sprintf("--%s=%s", flags.FlagKeyringBackend, keyring.BackendTest),
|
|
})
|
|
require.EqualError(t, cmd.ExecuteContext(ctx), "threshold must be a positive integer")
|
|
|
|
cmd.SetArgs([]string{
|
|
fakeKeyName1, fakeKeyName2,
|
|
fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome),
|
|
fmt.Sprintf("--%s=%s", FlagBechPrefix, sdk.PrefixAccount),
|
|
fmt.Sprintf("--%s=2", flagMultiSigThreshold),
|
|
fmt.Sprintf("--%s=%s", flags.FlagKeyringBackend, keyring.BackendTest),
|
|
})
|
|
require.NoError(t, cmd.ExecuteContext(ctx))
|
|
|
|
// Now try multisig key - set bech to acc + threshold=2
|
|
cmd.SetArgs([]string{
|
|
fakeKeyName1, fakeKeyName2,
|
|
fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome),
|
|
fmt.Sprintf("--%s=acc", FlagBechPrefix),
|
|
fmt.Sprintf("--%s=true", FlagDevice),
|
|
fmt.Sprintf("--%s=2", flagMultiSigThreshold),
|
|
fmt.Sprintf("--%s=%s", flags.FlagKeyringBackend, keyring.BackendTest),
|
|
})
|
|
require.EqualError(t, cmd.ExecuteContext(ctx), "the device flag (-d) can only be used for accounts stored in devices")
|
|
|
|
cmd.SetArgs([]string{
|
|
fakeKeyName1, fakeKeyName2,
|
|
fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome),
|
|
fmt.Sprintf("--%s=val", FlagBechPrefix),
|
|
fmt.Sprintf("--%s=true", FlagDevice),
|
|
fmt.Sprintf("--%s=2", flagMultiSigThreshold),
|
|
fmt.Sprintf("--%s=%s", flags.FlagKeyringBackend, keyring.BackendTest),
|
|
})
|
|
require.EqualError(t, cmd.ExecuteContext(ctx), "the device flag (-d) can only be used for accounts")
|
|
|
|
cmd.SetArgs([]string{
|
|
fakeKeyName1, fakeKeyName2,
|
|
fmt.Sprintf("--%s=%s", flags.FlagHome, kbHome),
|
|
fmt.Sprintf("--%s=val", FlagBechPrefix),
|
|
fmt.Sprintf("--%s=true", FlagDevice),
|
|
fmt.Sprintf("--%s=2", flagMultiSigThreshold),
|
|
fmt.Sprintf("--%s=true", FlagPublicKey),
|
|
fmt.Sprintf("--%s=%s", flags.FlagKeyringBackend, keyring.BackendTest),
|
|
})
|
|
require.EqualError(t, cmd.ExecuteContext(ctx), "the device flag (-d) can only be used for addresses not pubkeys")
|
|
}
|
|
|
|
func Test_validateMultisigThreshold(t *testing.T) {
|
|
type args struct {
|
|
k int
|
|
nKeys int
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
wantErr bool
|
|
}{
|
|
{"zeros", args{0, 0}, true},
|
|
{"1-0", args{1, 0}, true},
|
|
{"1-1", args{1, 1}, false},
|
|
{"1-2", args{1, 1}, false},
|
|
{"1-2", args{2, 1}, true},
|
|
}
|
|
for _, tt := range tests {
|
|
tt := tt
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
if err := validateMultisigThreshold(tt.args.k, tt.args.nKeys); (err != nil) != tt.wantErr {
|
|
t.Errorf("validateMultisigThreshold() error = %v, wantErr %v", err, tt.wantErr)
|
|
}
|
|
})
|
|
}
|
|
}
|
|
|
|
func Test_getBechKeyOut(t *testing.T) {
|
|
type args struct {
|
|
bechPrefix string
|
|
}
|
|
tests := []struct {
|
|
name string
|
|
args args
|
|
want bechKeyOutFn
|
|
wantErr bool
|
|
}{
|
|
{"empty", args{""}, nil, true},
|
|
{"wrong", args{"???"}, nil, true},
|
|
{"acc", args{sdk.PrefixAccount}, keyring.MkAccKeyOutput, false},
|
|
{"val", args{sdk.PrefixValidator}, keyring.MkValKeyOutput, false},
|
|
{"cons", args{sdk.PrefixConsensus}, keyring.MkConsKeyOutput, false},
|
|
}
|
|
for _, tt := range tests {
|
|
tt := tt
|
|
t.Run(tt.name, func(t *testing.T) {
|
|
got, err := getBechKeyOut(tt.args.bechPrefix)
|
|
if tt.wantErr {
|
|
require.Error(t, err)
|
|
} else {
|
|
require.NoError(t, err)
|
|
require.NotNil(t, got)
|
|
}
|
|
})
|
|
}
|
|
}
|